Re: [PATCH 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E

[Andreas Kemnade <andreas@kemnade.info>]

Am Tue, 22 Oct 2024 17:59:10 +0100
schrieb Conor Dooley <conor@kernel.org>:

> On Mon, Oct 21, 2024 at 07:36:30PM +0200, Andreas Kemnade wrote:
> > Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based
> > on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is
> > equipped with an i.MX6SLL SoC.
> > 
> > Expected to work:
> >   - Buttons
> >   - Wifi
> >   - Bluetooth
> >     (if Wifi is initialized first, driver does not handle regulators
> >      yet)
> >   - LED
> >   - uSD
> >   - USB
> >   - RTC

and also touchscreen.
> > 



> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> >  arch/arm/boot/dts/nxp/imx/Makefile            |   2 +
> >  .../dts/nxp/imx/imx6sll-kobo-clara2e-a.dts    |  23 +
> >  .../dts/nxp/imx/imx6sll-kobo-clara2e-b.dts    |  23 +
> >  .../nxp/imx/imx6sll-kobo-clara2e-common.dtsi  | 514
> > ++++++++++++++++++ 4 files changed, 562 insertions(+)
> >  create mode 100644
> > arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts create mode
> > 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dts create
> > mode 100644
> > arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/Makefile
> > b/arch/arm/boot/dts/nxp/imx/Makefile index
> > 92e291603ea13..58db45352b666 100644 ---
> > a/arch/arm/boot/dts/nxp/imx/Makefile +++
> > b/arch/arm/boot/dts/nxp/imx/Makefile @@ -290,6 +290,8 @@
> > dtb-$(CONFIG_SOC_IMX6SL) += \ dtb-$(CONFIG_SOC_IMX6SLL) += \
> >  	imx6sll-evk.dtb \
> >  	imx6sll-kobo-clarahd.dtb \
> > +	imx6sll-kobo-clara2e-a.dtb \
> > +	imx6sll-kobo-clara2e-b.dtb \
> >  	imx6sll-kobo-librah2o.dtb
> >  dtb-$(CONFIG_SOC_IMX6SX) += \
> >  	imx6sx-nitrogen6sx.dtb \
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts
> > b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts new file
> > mode 100644 index 0000000000000..33756d6de7aa0
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts
> > @@ -0,0 +1,23 @@
> > +// SPDX-License-Identifier: (GPL-2.0)
> > +/*
> > + * Device tree for the Kobo Clara 2E rev A ebook reader
> > + *
> > + * Name on mainboard is: 37NB-E60K2M+4A2
> > + * Serials start with: E60K2M (a number also seen in
> > + * vendor kernel sources)
> > + *
> > + * Copyright 2024 Andreas Kemnade
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "imx6sll-kobo-clara2e-common.dtsi"
> > +
> > +/ {
> > +	model = "Kobo Clara 2E";
> > +	compatible = "kobo,clara2e-b", "kobo,clara2e",
> > "fsl,imx6sll"; +};
> > +
> > +&i2c2 {
> > +	/* EPD PMIC SY7636 at 0x62 */  
> 
> Could you explain what you're doing here, please?
>
I am not sure what you are really after with this question...
So I am guessing a bit.
I describe the hardware as good as possible. The sy7636a (apparently
=sy7636) driver could probably be used here but the driver and its
bindings needs to be extended to specify an input supply and some gpios.
So at the moment I could not use a machine-readable way of fully
describe the stuff here. But I want to put a human-readable mark here
so if someone extends the driver, he/she might be aware that there are
some possible users and candidates for a Tested-by here.
For the JD9930 it is even worse. No driver in kernel. I have a pretty
dirty one requiring some rounds with the brush before sending it.
So the mark is good for information what is missing and for teaming up.

Regards,
Andreas