Re: [PATCH 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2448 bytes --]

On Mon, Oct 21, 2024 at 07:36:30PM +0200, Andreas Kemnade wrote:
> Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based
> on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is
> equipped with an i.MX6SLL SoC.
> 
> Expected to work:
>   - Buttons
>   - Wifi
>   - Bluetooth
>     (if Wifi is initialized first, driver does not handle regulators
>      yet)
>   - LED
>   - uSD
>   - USB
>   - RTC
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/nxp/imx/Makefile            |   2 +
>  .../dts/nxp/imx/imx6sll-kobo-clara2e-a.dts    |  23 +
>  .../dts/nxp/imx/imx6sll-kobo-clara2e-b.dts    |  23 +
>  .../nxp/imx/imx6sll-kobo-clara2e-common.dtsi  | 514 ++++++++++++++++++
>  4 files changed, 562 insertions(+)
>  create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts
>  create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dts
>  create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> index 92e291603ea13..58db45352b666 100644
> --- a/arch/arm/boot/dts/nxp/imx/Makefile
> +++ b/arch/arm/boot/dts/nxp/imx/Makefile
> @@ -290,6 +290,8 @@ dtb-$(CONFIG_SOC_IMX6SL) += \
>  dtb-$(CONFIG_SOC_IMX6SLL) += \
>  	imx6sll-evk.dtb \
>  	imx6sll-kobo-clarahd.dtb \
> +	imx6sll-kobo-clara2e-a.dtb \
> +	imx6sll-kobo-clara2e-b.dtb \
>  	imx6sll-kobo-librah2o.dtb
>  dtb-$(CONFIG_SOC_IMX6SX) += \
>  	imx6sx-nitrogen6sx.dtb \
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts
> new file mode 100644
> index 0000000000000..33756d6de7aa0
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: (GPL-2.0)
> +/*
> + * Device tree for the Kobo Clara 2E rev A ebook reader
> + *
> + * Name on mainboard is: 37NB-E60K2M+4A2
> + * Serials start with: E60K2M (a number also seen in
> + * vendor kernel sources)
> + *
> + * Copyright 2024 Andreas Kemnade
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6sll-kobo-clara2e-common.dtsi"
> +
> +/ {
> +	model = "Kobo Clara 2E";
> +	compatible = "kobo,clara2e-b", "kobo,clara2e", "fsl,imx6sll";
> +};
> +
> +&i2c2 {
> +	/* EPD PMIC SY7636 at 0x62 */

Could you explain what you're doing here, please?

> +};

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]