From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
manivannan.sadhasivam@linaro.org, kishon@kernel.org,
u.kleine-koenig@pengutronix.de, cassel@kernel.org,
dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH v2 1/2] PCI: keystone: Set mode as RootComplex for "ti,keystone-pcie" compatible
Date: Thu, 7 Nov 2024 01:05:20 +0900 [thread overview]
Message-ID: <20241106160520.GD2745640@rocinante> (raw)
In-Reply-To: <20241106154945.GA1526156@bhelgaas>
Hello,
[...]
> > I suppose that "data->mode" will default to zero for v3.65a prior to
> > this commit, corresponding to "DW_PCIE_UNKNOWN_TYPE" rather than the
> > correct value of "DW_PCIE_RC_TYPE". Since I don't have an SoC with the
> > v3.65a version of the controller, I cannot test it out, but I presume
> > that the "INVALID device type 0" error will be displayed. Though the probe
> > will not fail since the "default" case doesn't return an error code, the
> > controller probably will not be functional as the configuration associated
> > with the "DW_PCIE_RC_TYPE" case has been skipped. Hence, I believe that
> > this fix should be backported.
>
> I guess nobody really cares too much since it's been broken for almost
> four years.
>
> But indeed, sounds like it should have a stable tag and maybe a commit
> log hint about what the failure looks like.
Added Cc for stable releases. Siddharth, let me know how to update the
commit log per Bjorn feedback, so I can do it directly on the branch.
Thank you!
Krzysztof
next prev parent reply other threads:[~2024-11-06 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 10:57 [PATCH v2 0/2] Fixes for PCI Keystone driver Siddharth Vadapalli
2024-05-24 10:57 ` [PATCH v2 1/2] PCI: keystone: Set mode as RootComplex for "ti,keystone-pcie" compatible Siddharth Vadapalli
2024-11-06 0:57 ` Bjorn Helgaas
2024-11-06 6:06 ` Siddharth Vadapalli
2024-11-06 15:49 ` Bjorn Helgaas
2024-11-06 16:05 ` Krzysztof Wilczyński [this message]
2024-11-07 4:39 ` Siddharth Vadapalli
2024-11-07 15:51 ` Krzysztof Wilczyński
2024-11-08 5:05 ` Siddharth Vadapalli
2024-05-24 10:57 ` [PATCH v2 2/2] PCI: keystone: Add link up check in ks_child_pcie_ops.map_bus() Siddharth Vadapalli
2024-11-03 21:05 ` [PATCH v2 0/2] Fixes for PCI Keystone driver Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106160520.GD2745640@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=helgaas@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox