From: "Krzysztof Wilczyński" <kw@linux.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
manivannan.sadhasivam@linaro.org, kishon@kernel.org,
u.kleine-koenig@pengutronix.de, cassel@kernel.org,
dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH v2 1/2] PCI: keystone: Set mode as RootComplex for "ti,keystone-pcie" compatible
Date: Fri, 8 Nov 2024 00:51:44 +0900 [thread overview]
Message-ID: <20241107155144.GB1297107@rocinante> (raw)
In-Reply-To: <4fc87e39-ae2f-4ac9-ace3-26b2b79e2297@ti.com>
Hello,
> > Added Cc for stable releases. Siddharth, let me know how to update the
> > commit log per Bjorn feedback, so I can do it directly on the branch.
>
> The existing commit message could be replaced by the following:
>
> ------------------------------------------------------------------------
> commit 23284ad677a9 ("PCI: keystone: Add support for PCIe EP in AM654x
> Platforms") introduced configuring "enum dw_pcie_device_mode" as part of
> device data ("struct ks_pcie_of_data"). However it failed to set the mode
> for "ti,keystone-pcie" compatible.
>
> Since the mode defaults to "DW_PCIE_UNKNOWN_TYPE", the following error
> message is displayed:
> "INVALID device type 0"
> for the v3.65a controller. Despite the driver probing successfully, the
> controller may not be functional in the Root Complex mode of operation.
>
> So, set the mode as Root Complex for "ti,keystone-pcie" compatible to fix
> this.
> ------------------------------------------------------------------------
Done. See the following:
- https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/keystone&id=5a938ed9481b0c06cb97aec45e722a80568256fd
Thank you!
Krzysztof
next prev parent reply other threads:[~2024-11-07 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240524105714.191642-2-s-vadapalli@ti.com>
2024-11-06 0:57 ` [PATCH v2 1/2] PCI: keystone: Set mode as RootComplex for "ti,keystone-pcie" compatible Bjorn Helgaas
2024-11-06 6:06 ` Siddharth Vadapalli
2024-11-06 15:49 ` Bjorn Helgaas
2024-11-06 16:05 ` Krzysztof Wilczyński
2024-11-07 4:39 ` Siddharth Vadapalli
2024-11-07 15:51 ` Krzysztof Wilczyński [this message]
2024-11-08 5:05 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107155144.GB1297107@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=helgaas@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox