[PATCH 0/3] sysfs: treewide: Remove spurious NULL in attribute_group definition

[PATCH 0/3] sysfs: treewide: Remove spurious NULL in attribute_group definition

[Thomas Weißschuh]

Generated with the following coccinelle script:

virtual patch

	@@
	identifier ag, pattrs;
	@@

	  struct attribute_group ag = {
	    .attrs = pattrs,
	-   NULL
	  };

This series is meant to be applied through the driver-core tree.

See also:
https://lore.kernel.org/lkml/71fe4030-d6a1-47da-b8a7-28b899187168@t-8ch.de/

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (3):
      perf: arm-ni: Remove spurious NULL in attribute_group definition
      s390/con3215: Remove spurious NULL in attribute_group definition
      cpu: Remove spurious NULL in attribute_group definition

 drivers/perf/arm-ni.c       | 1 -
 drivers/s390/char/con3215.c | 1 -
 kernel/cpu.c                | 3 ---
 3 files changed, 5 deletions(-)
---
base-commit: 5943c0dc7912210be1ab2732e0b663c1082ab543
change-id: 20241118-sysfs-const-attribute_group-fixes-6e7a77c40535

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

[PATCH 1/3] perf: arm-ni: Remove spurious NULL in attribute_group definition

[Thomas Weißschuh]

This NULL value is most-likely a copy-paste error from an array
definition. So far the NULL didn't have any effect.
As there will be a union in struct attribute_group at this location,
it will trigger a compiler warning.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/perf/arm-ni.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
index 90fcfe693439ef3e18e23c6351433ac3c5ea78b5..fd7a5e60e96302fada29cd44e7bf9c582e93e4ce 100644
--- a/drivers/perf/arm-ni.c
+++ b/drivers/perf/arm-ni.c
@@ -247,7 +247,6 @@ static struct attribute *arm_ni_other_attrs[] = {
 
 static const struct attribute_group arm_ni_other_attr_group = {
 	.attrs = arm_ni_other_attrs,
-	NULL
 };
 
 static const struct attribute_group *arm_ni_attr_groups[] = {

-- 
2.47.0

Re: [PATCH 1/3] perf: arm-ni: Remove spurious NULL in attribute_group definition

[Robin Murphy]

On 2024-11-18 3:02 pm, Thomas Weißschuh wrote:
> This NULL value is most-likely a copy-paste error from an array
> definition. So far the NULL didn't have any effect.
> As there will be a union in struct attribute_group at this location,
> it will trigger a compiler warning.

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>   drivers/perf/arm-ni.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
> index 90fcfe693439ef3e18e23c6351433ac3c5ea78b5..fd7a5e60e96302fada29cd44e7bf9c582e93e4ce 100644
> --- a/drivers/perf/arm-ni.c
> +++ b/drivers/perf/arm-ni.c
> @@ -247,7 +247,6 @@ static struct attribute *arm_ni_other_attrs[] = {
>   
>   static const struct attribute_group arm_ni_other_attr_group = {
>   	.attrs = arm_ni_other_attrs,
> -	NULL
>   };
>   
>   static const struct attribute_group *arm_ni_attr_groups[] = {
> 

[PATCH 2/3] s390/con3215: Remove spurious NULL in attribute_group definition

[Thomas Weißschuh]

This NULL value is most-likely a copy-paste error from an array
definition. So far the NULL didn't have any effect.
As there will be a union in struct attribute_group at this location,
it will trigger a compiler warning.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/s390/char/con3215.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index dcb3c32f027af6748448600bad51864f6ba5d9a1..c763c50d1454676f223e8b29a92f5fb45ddd7932 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -803,7 +803,6 @@ static struct attribute *con3215_drv_attrs[] = {
 
 static struct attribute_group con3215_drv_attr_group = {
 	.attrs = con3215_drv_attrs,
-	NULL,
 };
 
 static const struct attribute_group *con3215_drv_attr_groups[] = {

-- 
2.47.0

[PATCH 3/3] cpu: Remove spurious NULL in attribute_group definition

[Thomas Weißschuh]

This NULL value is most-likely a copy-paste error from an array
definition. The NULL doesn't have any effect.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 kernel/cpu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index d293d52a3e00e1e8d7c82bdf2f1365bb459f8bb6..f3ee615d2274f161857ef0180454f30b54477cc1 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -2866,7 +2866,6 @@ static struct attribute *cpuhp_cpu_attrs[] = {
 static const struct attribute_group cpuhp_cpu_attr_group = {
 	.attrs = cpuhp_cpu_attrs,
 	.name = "hotplug",
-	NULL
 };
 
 static ssize_t states_show(struct device *dev,
@@ -2898,7 +2897,6 @@ static struct attribute *cpuhp_cpu_root_attrs[] = {
 static const struct attribute_group cpuhp_cpu_root_attr_group = {
 	.attrs = cpuhp_cpu_root_attrs,
 	.name = "hotplug",
-	NULL
 };
 
 #ifdef CONFIG_HOTPLUG_SMT
@@ -3020,7 +3018,6 @@ static struct attribute *cpuhp_smt_attrs[] = {
 static const struct attribute_group cpuhp_smt_attr_group = {
 	.attrs = cpuhp_smt_attrs,
 	.name = "smt",
-	NULL
 };
 
 static int __init cpu_smt_sysfs_init(void)

-- 
2.47.0

Re: [PATCH 0/3] sysfs: treewide: Remove spurious NULL in attribute_group definition

[Greg Kroah-Hartman]

On Mon, Nov 18, 2024 at 04:02:46PM +0100, Thomas Weißschuh wrote:
> Generated with the following coccinelle script:
> 
> virtual patch
> 
> 	@@
> 	identifier ag, pattrs;
> 	@@
> 
> 	  struct attribute_group ag = {
> 	    .attrs = pattrs,
> 	-   NULL
> 	  };
> 
> This series is meant to be applied through the driver-core tree.
> 
> See also:
> https://lore.kernel.org/lkml/71fe4030-d6a1-47da-b8a7-28b899187168@t-8ch.de/
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

All now applied, thanks!

greg k-h