From: Leo Yan <leo.yan@arm.com>
To: Yabin Cui <yabinc@google.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] coresight: catu: Introduce refcount and spinlock for enabling/disabling
Date: Wed, 2 Apr 2025 14:01:45 +0100 [thread overview]
Message-ID: <20250402130145.GI115840@e132581.arm.com> (raw)
In-Reply-To: <CALJ9ZPNBGBd9OTBgedoQStXh3d2oGDGi6fUF7PXbU5qTEBRHew@mail.gmail.com>
Hi Yabin,
On Tue, Apr 01, 2025 at 06:21:59PM -0700, Yabin Cui wrote:
[...]
> > @@ -486,12 +491,17 @@ static int catu_disable_hw(struct catu_drvdata *drvdata)
> >
> > static int catu_disable(struct coresight_device *csdev, void *__unused)
> > {
> > - int rc;
> > + int rc = 0;
> > struct catu_drvdata *catu_drvdata = csdev_to_catu_drvdata(csdev);
> > + guard(raw_spinlock_irqsave)(&catu_drvdata->spinlock);
> >
> > - CS_UNLOCK(catu_drvdata->base);
> > - rc = catu_disable_hw(catu_drvdata);
> > - CS_LOCK(catu_drvdata->base);
> > + if (--csdev->refcnt == 0) {
> > + CS_UNLOCK(catu_drvdata->base);
> > + rc = catu_disable_hw(catu_drvdata);
> > + CS_LOCK(catu_drvdata->base);
> > + } else {
> > + rc = -EBUSY;
This is not an error if the decremented reference counter is not zero.
It should return 0. Otherwise, the change looks good to me.
Thanks,
Leo
next prev parent reply other threads:[~2025-04-02 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 1:18 [PATCH v2 0/3] coresight: catu: Introduce refcount and spinlock for enabling/disabling Yabin Cui
2025-04-02 1:18 ` [PATCH v2 1/3] " Yabin Cui
2025-04-02 1:21 ` Yabin Cui
2025-04-02 13:01 ` Leo Yan [this message]
2025-04-03 17:53 ` Yabin Cui
2025-04-04 9:46 ` Suzuki K Poulose
2025-04-02 1:18 ` [PATCH v2 2/3] coresight: catu: Prevent concurrent PERF and SYSFS mode enablement Yabin Cui
2025-04-02 13:47 ` Leo Yan
2025-04-03 17:58 ` Yabin Cui
2025-04-02 1:18 ` [PATCH v2 3/3] coresight: core: Disable helpers for devices that fail to enable Yabin Cui
2025-04-02 1:22 ` Yabin Cui
2025-04-02 13:32 ` Leo Yan
2025-04-02 13:50 ` Mike Leach
2025-04-02 14:12 ` Leo Yan
2025-04-03 0:53 ` Jie Gan
2025-04-03 18:28 ` Yabin Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402130145.GI115840@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=yabinc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).