* [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() [not found] <20250319092951.37667-1-jirislaby@kernel.org> @ 2025-03-19 9:28 ` Jiri Slaby (SUSE) 2025-03-19 10:29 ` [Linux-stm32] " Antonio Borneo ` (2 more replies) 2025-03-19 9:29 ` [PATCH v2 07/57] irqdomain: pci: " Jiri Slaby (SUSE) ` (3 subsequent siblings) 4 siblings, 3 replies; 12+ messages in thread From: Jiri Slaby (SUSE) @ 2025-03-19 9:28 UTC (permalink / raw) To: tglx Cc: maz, linux-kernel, Jiri Slaby (SUSE), Antoine Tenart, Sven Peter, Janne Grunau, Alyssa Rosenzweig, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Linus Walleij, Imre Kaloz, Herve Codina, Huacai Chen, WANG Xuerui, Jiaxun Yang, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Anup Patel, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Maxime Coquelin, Alexandre Torgue, Nishanth Menon, Tero Kristo, Santosh Shilimkar, Kunihiko Hayashi, Masami Hiramatsu, linux-arm-kernel, asahi, loongarch, linux-mips, linux-amlogic, linux-riscv, linux-stm32 of_node_to_fwnode() is irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Antoine Tenart <atenart@kernel.org> Cc: Sven Peter <sven@svenpeter.dev> Cc: Janne Grunau <j@jannau.net> Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@bootlin.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Marc Zyngier <maz@kernel.org> Cc: Linus Walleij <linusw@kernel.org> Cc: Imre Kaloz <kaloz@openwrt.org> Cc: Herve Codina <herve.codina@bootlin.com> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: WANG Xuerui <kernel@xen0n.name> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Kevin Hilman <khilman@baylibre.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Anup Patel <anup@brainfault.org> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: Alexandre Ghiti <alex@ghiti.fr> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Nishanth Menon <nm@ti.com> Cc: Tero Kristo <kristo@kernel.org> Cc: Santosh Shilimkar <ssantosh@kernel.org> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: asahi@lists.linux.dev Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linux-amlogic@lists.infradead.org Cc: linux-riscv@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com --- drivers/irqchip/irq-alpine-msi.c | 2 +- drivers/irqchip/irq-apple-aic.c | 4 ++-- drivers/irqchip/irq-armada-370-xp.c | 4 ++-- drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 2 +- drivers/irqchip/irq-gic-v3.c | 4 ++-- drivers/irqchip/irq-ixp4xx.c | 2 +- drivers/irqchip/irq-lan966x-oic.c | 2 +- drivers/irqchip/irq-loongarch-cpu.c | 2 +- drivers/irqchip/irq-loongson-eiointc.c | 2 +- drivers/irqchip/irq-loongson-htvec.c | 2 +- drivers/irqchip/irq-loongson-liointc.c | 2 +- drivers/irqchip/irq-loongson-pch-msi.c | 2 +- drivers/irqchip/irq-loongson-pch-pic.c | 2 +- drivers/irqchip/irq-ls-scfg-msi.c | 2 +- drivers/irqchip/irq-meson-gpio.c | 2 +- drivers/irqchip/irq-mvebu-gicp.c | 2 +- drivers/irqchip/irq-mvebu-odmi.c | 2 +- drivers/irqchip/irq-mvebu-sei.c | 6 +++--- drivers/irqchip/irq-qcom-mpm.c | 2 +- drivers/irqchip/irq-riscv-intc.c | 2 +- drivers/irqchip/irq-sni-exiu.c | 2 +- drivers/irqchip/irq-stm32mp-exti.c | 2 +- drivers/irqchip/irq-ti-sci-inta.c | 4 ++-- drivers/irqchip/irq-ti-sci-intr.c | 2 +- drivers/irqchip/irq-uniphier-aidet.c | 2 +- 25 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index a1430ab60a8a..0207d35135da 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -213,7 +213,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, return -ENOMEM; } - msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), + msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(node), &alpine_msix_domain_info, middle_domain); if (!msi_domain) { diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 974dc088c853..032d66dceb8e 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1014,7 +1014,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p irqc->info.die_stride = off - start_off; - irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node), + irqc->hw_domain = irq_domain_create_tree(of_fwnode_handle(node), &aic_irq_domain_ops, irqc); if (WARN_ON(!irqc->hw_domain)) goto err_unmap; @@ -1067,7 +1067,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p if (is_kernel_in_hyp_mode()) { struct irq_fwspec mi = { - .fwnode = of_node_to_fwnode(node), + .fwnode = of_fwnode_handle(node), .param_count = 3, .param = { [0] = AIC_FIQ, /* This is a lie */ diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index 2aa6a51e05d0..de98d16c1718 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -353,7 +353,7 @@ static int __init mpic_msi_init(struct mpic *mpic, struct device_node *node, if (!mpic->msi_inner_domain) return -ENOMEM; - mpic->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), &mpic_msi_domain_info, + mpic->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(node), &mpic_msi_domain_info, mpic->msi_inner_domain); if (!mpic->msi_domain) { irq_domain_remove(mpic->msi_inner_domain); @@ -492,7 +492,7 @@ static int __init mpic_ipi_init(struct mpic *mpic, struct device_node *node) { int base_ipi; - mpic->ipi_domain = irq_domain_create_linear(of_node_to_fwnode(node), IPI_DOORBELL_NR, + mpic->ipi_domain = irq_domain_create_linear(of_fwnode_handle(node), IPI_DOORBELL_NR, &mpic_ipi_domain_ops, mpic); if (WARN_ON(!mpic->ipi_domain)) return -ENOMEM; diff --git a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c index 8e87fc35f8aa..11549d85f23b 100644 --- a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c +++ b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c @@ -152,7 +152,7 @@ static void __init its_fsl_mc_of_msi_init(void) if (!of_property_read_bool(np, "msi-controller")) continue; - its_fsl_mc_msi_init_one(of_node_to_fwnode(np), + its_fsl_mc_msi_init_one(of_fwnode_handle(np), np->full_name); } } diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 270d7a4d85a6..efc791c43d44 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1826,7 +1826,7 @@ static int partition_domain_translate(struct irq_domain *d, ppi_idx = __gic_get_ppi_index(ppi_intid); ret = partition_translate_id(gic_data.ppi_descs[ppi_idx], - of_node_to_fwnode(np)); + of_fwnode_handle(np)); if (ret < 0) return ret; @@ -2192,7 +2192,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) part = &parts[part_idx]; - part->partition_id = of_node_to_fwnode(child_part); + part->partition_id = of_fwnode_handle(child_part); pr_info("GIC: PPI partition %pOFn[%d] { ", child_part, part_idx); diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c index f23b02f62a5c..a9a5a52b818a 100644 --- a/drivers/irqchip/irq-ixp4xx.c +++ b/drivers/irqchip/irq-ixp4xx.c @@ -261,7 +261,7 @@ static int __init ixp4xx_of_init_irq(struct device_node *np, pr_crit("IXP4XX: could not ioremap interrupt controller\n"); return -ENODEV; } - fwnode = of_node_to_fwnode(np); + fwnode = of_fwnode_handle(np); /* These chip variants have 64 interrupts */ is_356 = of_device_is_compatible(np, "intel,ixp43x-interrupt") || diff --git a/drivers/irqchip/irq-lan966x-oic.c b/drivers/irqchip/irq-lan966x-oic.c index 41ac880e3b87..9445c3a6b1b0 100644 --- a/drivers/irqchip/irq-lan966x-oic.c +++ b/drivers/irqchip/irq-lan966x-oic.c @@ -224,7 +224,7 @@ static int lan966x_oic_probe(struct platform_device *pdev) .exit = lan966x_oic_chip_exit, }; struct irq_domain_info d_info = { - .fwnode = of_node_to_fwnode(pdev->dev.of_node), + .fwnode = of_fwnode_handle(pdev->dev.of_node), .domain_flags = IRQ_DOMAIN_FLAG_DESTROY_GC, .size = LAN966X_OIC_NR_IRQ, .hwirq_max = LAN966X_OIC_NR_IRQ, diff --git a/drivers/irqchip/irq-loongarch-cpu.c b/drivers/irqchip/irq-loongarch-cpu.c index e62dab4c97fc..950bc087e388 100644 --- a/drivers/irqchip/irq-loongarch-cpu.c +++ b/drivers/irqchip/irq-loongarch-cpu.c @@ -100,7 +100,7 @@ static const struct irq_domain_ops loongarch_cpu_intc_irq_domain_ops = { static int __init cpuintc_of_init(struct device_node *of_node, struct device_node *parent) { - cpuintc_handle = of_node_to_fwnode(of_node); + cpuintc_handle = of_fwnode_handle(of_node); irq_domain = irq_domain_create_linear(cpuintc_handle, EXCCODE_INT_NUM, &loongarch_cpu_intc_irq_domain_ops, NULL); diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c index bb79e19dfb59..b2860eb2d32c 100644 --- a/drivers/irqchip/irq-loongson-eiointc.c +++ b/drivers/irqchip/irq-loongson-eiointc.c @@ -554,7 +554,7 @@ static int __init eiointc_of_init(struct device_node *of_node, priv->vec_count = VEC_COUNT; priv->node = 0; - priv->domain_handle = of_node_to_fwnode(of_node); + priv->domain_handle = of_fwnode_handle(of_node); ret = eiointc_init(priv, parent_irq, 0); if (ret < 0) diff --git a/drivers/irqchip/irq-loongson-htvec.c b/drivers/irqchip/irq-loongson-htvec.c index 5da02c7ad0b3..d8558eb35044 100644 --- a/drivers/irqchip/irq-loongson-htvec.c +++ b/drivers/irqchip/irq-loongson-htvec.c @@ -248,7 +248,7 @@ static int htvec_of_init(struct device_node *node, } err = htvec_init(res.start, resource_size(&res), - num_parents, parent_irq, of_node_to_fwnode(node)); + num_parents, parent_irq, of_fwnode_handle(node)); if (err < 0) return err; diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c index 2b1bd4a96665..95cade56e0be 100644 --- a/drivers/irqchip/irq-loongson-liointc.c +++ b/drivers/irqchip/irq-loongson-liointc.c @@ -363,7 +363,7 @@ static int __init liointc_of_init(struct device_node *node, } err = liointc_init(res.start, resource_size(&res), - revision, of_node_to_fwnode(node), node); + revision, of_fwnode_handle(node), node); if (err < 0) return err; diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c index 9c62108b3ad5..c07876ae7b49 100644 --- a/drivers/irqchip/irq-loongson-pch-msi.c +++ b/drivers/irqchip/irq-loongson-pch-msi.c @@ -243,7 +243,7 @@ static int pch_msi_of_init(struct device_node *node, struct device_node *parent) return -EINVAL; } - err = pch_msi_init(res.start, irq_base, irq_count, parent_domain, of_node_to_fwnode(node)); + err = pch_msi_init(res.start, irq_base, irq_count, parent_domain, of_fwnode_handle(node)); if (err < 0) return err; diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c index 69efda35a8e7..62e6bf3a0611 100644 --- a/drivers/irqchip/irq-loongson-pch-pic.c +++ b/drivers/irqchip/irq-loongson-pch-pic.c @@ -392,7 +392,7 @@ static int pch_pic_of_init(struct device_node *node, } err = pch_pic_init(res.start, resource_size(&res), vec_base, - parent_domain, of_node_to_fwnode(node), 0); + parent_domain, of_fwnode_handle(node), 0); if (err < 0) return err; diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c index 3cb80796cc7c..cbe11a8afe4f 100644 --- a/drivers/irqchip/irq-ls-scfg-msi.c +++ b/drivers/irqchip/irq-ls-scfg-msi.c @@ -225,7 +225,7 @@ static int ls_scfg_msi_domains_init(struct ls_scfg_msi *msi_data) } msi_data->msi_domain = pci_msi_create_irq_domain( - of_node_to_fwnode(msi_data->pdev->dev.of_node), + of_fwnode_handle(msi_data->pdev->dev.of_node), &ls_scfg_msi_domain_info, msi_data->parent); if (!msi_data->msi_domain) { diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c index 0a25536a5d07..7d177626d64b 100644 --- a/drivers/irqchip/irq-meson-gpio.c +++ b/drivers/irqchip/irq-meson-gpio.c @@ -607,7 +607,7 @@ static int meson_gpio_irq_of_init(struct device_node *node, struct device_node * domain = irq_domain_create_hierarchy(parent_domain, 0, ctl->params->nr_hwirq, - of_node_to_fwnode(node), + of_fwnode_handle(node), &meson_gpio_irq_domain_ops, ctl); if (!domain) { diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c index d67f93f6d750..521cc265c05e 100644 --- a/drivers/irqchip/irq-mvebu-gicp.c +++ b/drivers/irqchip/irq-mvebu-gicp.c @@ -232,7 +232,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev) inner_domain = irq_domain_create_hierarchy(parent_domain, 0, gicp->spi_cnt, - of_node_to_fwnode(node), + of_fwnode_handle(node), &gicp_domain_ops, gicp); if (!inner_domain) return -ENOMEM; diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c index 28f7e81df94f..c1fcd4525e3b 100644 --- a/drivers/irqchip/irq-mvebu-odmi.c +++ b/drivers/irqchip/irq-mvebu-odmi.c @@ -207,7 +207,7 @@ static int __init mvebu_odmi_init(struct device_node *node, inner_domain = irq_domain_create_hierarchy(parent_domain, 0, odmis_count * NODMIS_PER_FRAME, - of_node_to_fwnode(node), + of_fwnode_handle(node), &odmi_domain_ops, NULL); if (!inner_domain) { ret = -ENOMEM; diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-sei.c index ebd4a9014e8d..5030fcecdcc3 100644 --- a/drivers/irqchip/irq-mvebu-sei.c +++ b/drivers/irqchip/irq-mvebu-sei.c @@ -402,7 +402,7 @@ static int mvebu_sei_probe(struct platform_device *pdev) } /* Create the root SEI domain */ - sei->sei_domain = irq_domain_create_linear(of_node_to_fwnode(node), + sei->sei_domain = irq_domain_create_linear(of_fwnode_handle(node), (sei->caps->ap_range.size + sei->caps->cp_range.size), &mvebu_sei_domain_ops, @@ -418,7 +418,7 @@ static int mvebu_sei_probe(struct platform_device *pdev) /* Create the 'wired' domain */ sei->ap_domain = irq_domain_create_hierarchy(sei->sei_domain, 0, sei->caps->ap_range.size, - of_node_to_fwnode(node), + of_fwnode_handle(node), &mvebu_sei_ap_domain_ops, sei); if (!sei->ap_domain) { @@ -432,7 +432,7 @@ static int mvebu_sei_probe(struct platform_device *pdev) /* Create the 'MSI' domain */ sei->cp_domain = irq_domain_create_hierarchy(sei->sei_domain, 0, sei->caps->cp_range.size, - of_node_to_fwnode(node), + of_fwnode_handle(node), &mvebu_sei_cp_domain_ops, sei); if (!sei->cp_domain) { diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c index 7942d8eb3d00..00c770e367d0 100644 --- a/drivers/irqchip/irq-qcom-mpm.c +++ b/drivers/irqchip/irq-qcom-mpm.c @@ -447,7 +447,7 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent) priv->domain = irq_domain_create_hierarchy(parent_domain, IRQ_DOMAIN_FLAG_QCOM_MPM_WAKEUP, pin_cnt, - of_node_to_fwnode(np), &qcom_mpm_ops, priv); + of_fwnode_handle(np), &qcom_mpm_ops, priv); if (!priv->domain) { dev_err(dev, "failed to create MPM domain\n"); ret = -ENOMEM; diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c index f653c13de62b..e5805885394e 100644 --- a/drivers/irqchip/irq-riscv-intc.c +++ b/drivers/irqchip/irq-riscv-intc.c @@ -242,7 +242,7 @@ static int __init riscv_intc_init(struct device_node *node, chip = &andes_intc_chip; } - return riscv_intc_init_common(of_node_to_fwnode(node), chip); + return riscv_intc_init_common(of_fwnode_handle(node), chip); } IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c index c7db617e1a2f..7d10bf6e5824 100644 --- a/drivers/irqchip/irq-sni-exiu.c +++ b/drivers/irqchip/irq-sni-exiu.c @@ -249,7 +249,7 @@ static int __init exiu_dt_init(struct device_node *node, return -ENXIO; } - data = exiu_init(of_node_to_fwnode(node), &res); + data = exiu_init(of_fwnode_handle(node), &res); if (IS_ERR(data)) return PTR_ERR(data); diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c index cb83d6cc6113..649b84f12efc 100644 --- a/drivers/irqchip/irq-stm32mp-exti.c +++ b/drivers/irqchip/irq-stm32mp-exti.c @@ -531,7 +531,7 @@ static int stm32mp_exti_domain_alloc(struct irq_domain *dm, if (ret) return ret; /* we only support one parent, so far */ - if (of_node_to_fwnode(out_irq.np) != dm->parent->fwnode) + if (of_fwnode_handle(out_irq.np) != dm->parent->fwnode) return -EINVAL; of_phandle_args_to_fwspec(out_irq.np, out_irq.args, diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index a887efba262c..38dfc1f9a56b 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -233,7 +233,7 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom INIT_LIST_HEAD(&vint_desc->list); parent_node = of_irq_find_parent(dev_of_node(&inta->pdev->dev)); - parent_fwspec.fwnode = of_node_to_fwnode(parent_node); + parent_fwspec.fwnode = of_fwnode_handle(parent_node); if (of_device_is_compatible(parent_node, "arm,gic-v3")) { /* Parent is GIC */ @@ -709,7 +709,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev) return -ENOMEM; } - msi_domain = ti_sci_inta_msi_create_irq_domain(of_node_to_fwnode(node), + msi_domain = ti_sci_inta_msi_create_irq_domain(of_fwnode_handle(node), &ti_sci_inta_msi_domain_info, domain); if (!msi_domain) { diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c index b49a73106c69..686a8f69fd9c 100644 --- a/drivers/irqchip/irq-ti-sci-intr.c +++ b/drivers/irqchip/irq-ti-sci-intr.c @@ -149,7 +149,7 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain, goto err_irqs; parent_node = of_irq_find_parent(dev_of_node(intr->dev)); - fwspec.fwnode = of_node_to_fwnode(parent_node); + fwspec.fwnode = of_fwnode_handle(parent_node); if (of_device_is_compatible(parent_node, "arm,gic-v3")) { /* Parent is GIC */ diff --git a/drivers/irqchip/irq-uniphier-aidet.c b/drivers/irqchip/irq-uniphier-aidet.c index 601f9343d5b3..6005c2d28dd9 100644 --- a/drivers/irqchip/irq-uniphier-aidet.c +++ b/drivers/irqchip/irq-uniphier-aidet.c @@ -188,7 +188,7 @@ static int uniphier_aidet_probe(struct platform_device *pdev) priv->domain = irq_domain_create_hierarchy( parent_domain, 0, UNIPHIER_AIDET_NR_IRQS, - of_node_to_fwnode(dev->of_node), + of_fwnode_handle(dev->of_node), &uniphier_aidet_domain_ops, priv); if (!priv->domain) return -ENOMEM; -- 2.49.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Linux-stm32] [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() 2025-03-19 9:28 ` [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() Jiri Slaby (SUSE) @ 2025-03-19 10:29 ` Antonio Borneo 2025-03-20 5:26 ` Anup Patel 2025-03-20 17:15 ` Herve Codina 2 siblings, 0 replies; 12+ messages in thread From: Antonio Borneo @ 2025-03-19 10:29 UTC (permalink / raw) To: Jiri Slaby (SUSE), tglx Cc: Nishanth Menon, Andrew Lunn, Herve Codina, Kunihiko Hayashi, Santosh Shilimkar, Jiaxun Yang, linux-mips, WANG Xuerui, linux-riscv, Alyssa Rosenzweig, Jerome Brunet, Alexandre Ghiti, asahi, maz, Gregory Clement, Huacai Chen, linux-stm32, Janne Grunau, Kevin Hilman, Sebastian Hesselbarth, Albert Ou, Sven Peter, Martin Blumenstingl, loongarch, Paul Walmsley, linux-amlogic, linux-arm-kernel, Neil Armstrong, Tero Kristo, Linus Walleij, linux-kernel, Palmer Dabbelt, Masami Hiramatsu, Maxime Coquelin, Anup Patel, Imre Kaloz, Antoine Tenart On Wed, 2025-03-19 at 10:28 +0100, Jiri Slaby (SUSE) wrote: > of_node_to_fwnode() is irqdomain's reimplementation of the "officially" > defined of_fwnode_handle(). The former is in the process of being > removed, so use the latter instead. > ... snip ... > diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c > index cb83d6cc6113..649b84f12efc 100644 > --- a/drivers/irqchip/irq-stm32mp-exti.c > +++ b/drivers/irqchip/irq-stm32mp-exti.c > @@ -531,7 +531,7 @@ static int stm32mp_exti_domain_alloc(struct irq_domain *dm, > if (ret) > return ret; > /* we only support one parent, so far */ > - if (of_node_to_fwnode(out_irq.np) != dm->parent->fwnode) > + if (of_fwnode_handle(out_irq.np) != dm->parent->fwnode) > For drivers/irqchip/irq-stm32mp-exti.c Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() 2025-03-19 9:28 ` [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() Jiri Slaby (SUSE) 2025-03-19 10:29 ` [Linux-stm32] " Antonio Borneo @ 2025-03-20 5:26 ` Anup Patel 2025-03-20 17:15 ` Herve Codina 2 siblings, 0 replies; 12+ messages in thread From: Anup Patel @ 2025-03-20 5:26 UTC (permalink / raw) To: Jiri Slaby (SUSE) Cc: tglx, maz, linux-kernel, Antoine Tenart, Sven Peter, Janne Grunau, Alyssa Rosenzweig, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Linus Walleij, Imre Kaloz, Herve Codina, Huacai Chen, WANG Xuerui, Jiaxun Yang, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Maxime Coquelin, Alexandre Torgue, Nishanth Menon, Tero Kristo, Santosh Shilimkar, Kunihiko Hayashi, Masami Hiramatsu, linux-arm-kernel, asahi, loongarch, linux-mips, linux-amlogic, linux-riscv, linux-stm32 On Wed, Mar 19, 2025 at 3:01 PM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote: > > of_node_to_fwnode() is irqdomain's reimplementation of the "officially" > defined of_fwnode_handle(). The former is in the process of being > removed, so use the latter instead. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Antoine Tenart <atenart@kernel.org> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Janne Grunau <j@jannau.net> > Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@bootlin.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Linus Walleij <linusw@kernel.org> > Cc: Imre Kaloz <kaloz@openwrt.org> > Cc: Herve Codina <herve.codina@bootlin.com> > Cc: Huacai Chen <chenhuacai@kernel.org> > Cc: WANG Xuerui <kernel@xen0n.name> > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Anup Patel <anup@brainfault.org> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: Alexandre Ghiti <alex@ghiti.fr> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Nishanth Menon <nm@ti.com> > Cc: Tero Kristo <kristo@kernel.org> > Cc: Santosh Shilimkar <ssantosh@kernel.org> > Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: asahi@lists.linux.dev > Cc: loongarch@lists.linux.dev > Cc: linux-mips@vger.kernel.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com LGTM for irq-riscv-intc driver Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup > --- > drivers/irqchip/irq-alpine-msi.c | 2 +- > drivers/irqchip/irq-apple-aic.c | 4 ++-- > drivers/irqchip/irq-armada-370-xp.c | 4 ++-- > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 2 +- > drivers/irqchip/irq-gic-v3.c | 4 ++-- > drivers/irqchip/irq-ixp4xx.c | 2 +- > drivers/irqchip/irq-lan966x-oic.c | 2 +- > drivers/irqchip/irq-loongarch-cpu.c | 2 +- > drivers/irqchip/irq-loongson-eiointc.c | 2 +- > drivers/irqchip/irq-loongson-htvec.c | 2 +- > drivers/irqchip/irq-loongson-liointc.c | 2 +- > drivers/irqchip/irq-loongson-pch-msi.c | 2 +- > drivers/irqchip/irq-loongson-pch-pic.c | 2 +- > drivers/irqchip/irq-ls-scfg-msi.c | 2 +- > drivers/irqchip/irq-meson-gpio.c | 2 +- > drivers/irqchip/irq-mvebu-gicp.c | 2 +- > drivers/irqchip/irq-mvebu-odmi.c | 2 +- > drivers/irqchip/irq-mvebu-sei.c | 6 +++--- > drivers/irqchip/irq-qcom-mpm.c | 2 +- > drivers/irqchip/irq-riscv-intc.c | 2 +- > drivers/irqchip/irq-sni-exiu.c | 2 +- > drivers/irqchip/irq-stm32mp-exti.c | 2 +- > drivers/irqchip/irq-ti-sci-inta.c | 4 ++-- > drivers/irqchip/irq-ti-sci-intr.c | 2 +- > drivers/irqchip/irq-uniphier-aidet.c | 2 +- > 25 files changed, 31 insertions(+), 31 deletions(-) > > diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c > index a1430ab60a8a..0207d35135da 100644 > --- a/drivers/irqchip/irq-alpine-msi.c > +++ b/drivers/irqchip/irq-alpine-msi.c > @@ -213,7 +213,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, > return -ENOMEM; > } > > - msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), > + msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(node), > &alpine_msix_domain_info, > middle_domain); > if (!msi_domain) { > diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c > index 974dc088c853..032d66dceb8e 100644 > --- a/drivers/irqchip/irq-apple-aic.c > +++ b/drivers/irqchip/irq-apple-aic.c > @@ -1014,7 +1014,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p > > irqc->info.die_stride = off - start_off; > > - irqc->hw_domain = irq_domain_create_tree(of_node_to_fwnode(node), > + irqc->hw_domain = irq_domain_create_tree(of_fwnode_handle(node), > &aic_irq_domain_ops, irqc); > if (WARN_ON(!irqc->hw_domain)) > goto err_unmap; > @@ -1067,7 +1067,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p > > if (is_kernel_in_hyp_mode()) { > struct irq_fwspec mi = { > - .fwnode = of_node_to_fwnode(node), > + .fwnode = of_fwnode_handle(node), > .param_count = 3, > .param = { > [0] = AIC_FIQ, /* This is a lie */ > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c > index 2aa6a51e05d0..de98d16c1718 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -353,7 +353,7 @@ static int __init mpic_msi_init(struct mpic *mpic, struct device_node *node, > if (!mpic->msi_inner_domain) > return -ENOMEM; > > - mpic->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), &mpic_msi_domain_info, > + mpic->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(node), &mpic_msi_domain_info, > mpic->msi_inner_domain); > if (!mpic->msi_domain) { > irq_domain_remove(mpic->msi_inner_domain); > @@ -492,7 +492,7 @@ static int __init mpic_ipi_init(struct mpic *mpic, struct device_node *node) > { > int base_ipi; > > - mpic->ipi_domain = irq_domain_create_linear(of_node_to_fwnode(node), IPI_DOORBELL_NR, > + mpic->ipi_domain = irq_domain_create_linear(of_fwnode_handle(node), IPI_DOORBELL_NR, > &mpic_ipi_domain_ops, mpic); > if (WARN_ON(!mpic->ipi_domain)) > return -ENOMEM; > diff --git a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c > index 8e87fc35f8aa..11549d85f23b 100644 > --- a/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c > @@ -152,7 +152,7 @@ static void __init its_fsl_mc_of_msi_init(void) > if (!of_property_read_bool(np, "msi-controller")) > continue; > > - its_fsl_mc_msi_init_one(of_node_to_fwnode(np), > + its_fsl_mc_msi_init_one(of_fwnode_handle(np), > np->full_name); > } > } > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 270d7a4d85a6..efc791c43d44 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -1826,7 +1826,7 @@ static int partition_domain_translate(struct irq_domain *d, > > ppi_idx = __gic_get_ppi_index(ppi_intid); > ret = partition_translate_id(gic_data.ppi_descs[ppi_idx], > - of_node_to_fwnode(np)); > + of_fwnode_handle(np)); > if (ret < 0) > return ret; > > @@ -2192,7 +2192,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) > > part = &parts[part_idx]; > > - part->partition_id = of_node_to_fwnode(child_part); > + part->partition_id = of_fwnode_handle(child_part); > > pr_info("GIC: PPI partition %pOFn[%d] { ", > child_part, part_idx); > diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c > index f23b02f62a5c..a9a5a52b818a 100644 > --- a/drivers/irqchip/irq-ixp4xx.c > +++ b/drivers/irqchip/irq-ixp4xx.c > @@ -261,7 +261,7 @@ static int __init ixp4xx_of_init_irq(struct device_node *np, > pr_crit("IXP4XX: could not ioremap interrupt controller\n"); > return -ENODEV; > } > - fwnode = of_node_to_fwnode(np); > + fwnode = of_fwnode_handle(np); > > /* These chip variants have 64 interrupts */ > is_356 = of_device_is_compatible(np, "intel,ixp43x-interrupt") || > diff --git a/drivers/irqchip/irq-lan966x-oic.c b/drivers/irqchip/irq-lan966x-oic.c > index 41ac880e3b87..9445c3a6b1b0 100644 > --- a/drivers/irqchip/irq-lan966x-oic.c > +++ b/drivers/irqchip/irq-lan966x-oic.c > @@ -224,7 +224,7 @@ static int lan966x_oic_probe(struct platform_device *pdev) > .exit = lan966x_oic_chip_exit, > }; > struct irq_domain_info d_info = { > - .fwnode = of_node_to_fwnode(pdev->dev.of_node), > + .fwnode = of_fwnode_handle(pdev->dev.of_node), > .domain_flags = IRQ_DOMAIN_FLAG_DESTROY_GC, > .size = LAN966X_OIC_NR_IRQ, > .hwirq_max = LAN966X_OIC_NR_IRQ, > diff --git a/drivers/irqchip/irq-loongarch-cpu.c b/drivers/irqchip/irq-loongarch-cpu.c > index e62dab4c97fc..950bc087e388 100644 > --- a/drivers/irqchip/irq-loongarch-cpu.c > +++ b/drivers/irqchip/irq-loongarch-cpu.c > @@ -100,7 +100,7 @@ static const struct irq_domain_ops loongarch_cpu_intc_irq_domain_ops = { > static int __init cpuintc_of_init(struct device_node *of_node, > struct device_node *parent) > { > - cpuintc_handle = of_node_to_fwnode(of_node); > + cpuintc_handle = of_fwnode_handle(of_node); > > irq_domain = irq_domain_create_linear(cpuintc_handle, EXCCODE_INT_NUM, > &loongarch_cpu_intc_irq_domain_ops, NULL); > diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c > index bb79e19dfb59..b2860eb2d32c 100644 > --- a/drivers/irqchip/irq-loongson-eiointc.c > +++ b/drivers/irqchip/irq-loongson-eiointc.c > @@ -554,7 +554,7 @@ static int __init eiointc_of_init(struct device_node *of_node, > priv->vec_count = VEC_COUNT; > > priv->node = 0; > - priv->domain_handle = of_node_to_fwnode(of_node); > + priv->domain_handle = of_fwnode_handle(of_node); > > ret = eiointc_init(priv, parent_irq, 0); > if (ret < 0) > diff --git a/drivers/irqchip/irq-loongson-htvec.c b/drivers/irqchip/irq-loongson-htvec.c > index 5da02c7ad0b3..d8558eb35044 100644 > --- a/drivers/irqchip/irq-loongson-htvec.c > +++ b/drivers/irqchip/irq-loongson-htvec.c > @@ -248,7 +248,7 @@ static int htvec_of_init(struct device_node *node, > } > > err = htvec_init(res.start, resource_size(&res), > - num_parents, parent_irq, of_node_to_fwnode(node)); > + num_parents, parent_irq, of_fwnode_handle(node)); > if (err < 0) > return err; > > diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c > index 2b1bd4a96665..95cade56e0be 100644 > --- a/drivers/irqchip/irq-loongson-liointc.c > +++ b/drivers/irqchip/irq-loongson-liointc.c > @@ -363,7 +363,7 @@ static int __init liointc_of_init(struct device_node *node, > } > > err = liointc_init(res.start, resource_size(&res), > - revision, of_node_to_fwnode(node), node); > + revision, of_fwnode_handle(node), node); > if (err < 0) > return err; > > diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c > index 9c62108b3ad5..c07876ae7b49 100644 > --- a/drivers/irqchip/irq-loongson-pch-msi.c > +++ b/drivers/irqchip/irq-loongson-pch-msi.c > @@ -243,7 +243,7 @@ static int pch_msi_of_init(struct device_node *node, struct device_node *parent) > return -EINVAL; > } > > - err = pch_msi_init(res.start, irq_base, irq_count, parent_domain, of_node_to_fwnode(node)); > + err = pch_msi_init(res.start, irq_base, irq_count, parent_domain, of_fwnode_handle(node)); > if (err < 0) > return err; > > diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c > index 69efda35a8e7..62e6bf3a0611 100644 > --- a/drivers/irqchip/irq-loongson-pch-pic.c > +++ b/drivers/irqchip/irq-loongson-pch-pic.c > @@ -392,7 +392,7 @@ static int pch_pic_of_init(struct device_node *node, > } > > err = pch_pic_init(res.start, resource_size(&res), vec_base, > - parent_domain, of_node_to_fwnode(node), 0); > + parent_domain, of_fwnode_handle(node), 0); > if (err < 0) > return err; > > diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c > index 3cb80796cc7c..cbe11a8afe4f 100644 > --- a/drivers/irqchip/irq-ls-scfg-msi.c > +++ b/drivers/irqchip/irq-ls-scfg-msi.c > @@ -225,7 +225,7 @@ static int ls_scfg_msi_domains_init(struct ls_scfg_msi *msi_data) > } > > msi_data->msi_domain = pci_msi_create_irq_domain( > - of_node_to_fwnode(msi_data->pdev->dev.of_node), > + of_fwnode_handle(msi_data->pdev->dev.of_node), > &ls_scfg_msi_domain_info, > msi_data->parent); > if (!msi_data->msi_domain) { > diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c > index 0a25536a5d07..7d177626d64b 100644 > --- a/drivers/irqchip/irq-meson-gpio.c > +++ b/drivers/irqchip/irq-meson-gpio.c > @@ -607,7 +607,7 @@ static int meson_gpio_irq_of_init(struct device_node *node, struct device_node * > > domain = irq_domain_create_hierarchy(parent_domain, 0, > ctl->params->nr_hwirq, > - of_node_to_fwnode(node), > + of_fwnode_handle(node), > &meson_gpio_irq_domain_ops, > ctl); > if (!domain) { > diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c > index d67f93f6d750..521cc265c05e 100644 > --- a/drivers/irqchip/irq-mvebu-gicp.c > +++ b/drivers/irqchip/irq-mvebu-gicp.c > @@ -232,7 +232,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev) > > inner_domain = irq_domain_create_hierarchy(parent_domain, 0, > gicp->spi_cnt, > - of_node_to_fwnode(node), > + of_fwnode_handle(node), > &gicp_domain_ops, gicp); > if (!inner_domain) > return -ENOMEM; > diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c > index 28f7e81df94f..c1fcd4525e3b 100644 > --- a/drivers/irqchip/irq-mvebu-odmi.c > +++ b/drivers/irqchip/irq-mvebu-odmi.c > @@ -207,7 +207,7 @@ static int __init mvebu_odmi_init(struct device_node *node, > > inner_domain = irq_domain_create_hierarchy(parent_domain, 0, > odmis_count * NODMIS_PER_FRAME, > - of_node_to_fwnode(node), > + of_fwnode_handle(node), > &odmi_domain_ops, NULL); > if (!inner_domain) { > ret = -ENOMEM; > diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-sei.c > index ebd4a9014e8d..5030fcecdcc3 100644 > --- a/drivers/irqchip/irq-mvebu-sei.c > +++ b/drivers/irqchip/irq-mvebu-sei.c > @@ -402,7 +402,7 @@ static int mvebu_sei_probe(struct platform_device *pdev) > } > > /* Create the root SEI domain */ > - sei->sei_domain = irq_domain_create_linear(of_node_to_fwnode(node), > + sei->sei_domain = irq_domain_create_linear(of_fwnode_handle(node), > (sei->caps->ap_range.size + > sei->caps->cp_range.size), > &mvebu_sei_domain_ops, > @@ -418,7 +418,7 @@ static int mvebu_sei_probe(struct platform_device *pdev) > /* Create the 'wired' domain */ > sei->ap_domain = irq_domain_create_hierarchy(sei->sei_domain, 0, > sei->caps->ap_range.size, > - of_node_to_fwnode(node), > + of_fwnode_handle(node), > &mvebu_sei_ap_domain_ops, > sei); > if (!sei->ap_domain) { > @@ -432,7 +432,7 @@ static int mvebu_sei_probe(struct platform_device *pdev) > /* Create the 'MSI' domain */ > sei->cp_domain = irq_domain_create_hierarchy(sei->sei_domain, 0, > sei->caps->cp_range.size, > - of_node_to_fwnode(node), > + of_fwnode_handle(node), > &mvebu_sei_cp_domain_ops, > sei); > if (!sei->cp_domain) { > diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c > index 7942d8eb3d00..00c770e367d0 100644 > --- a/drivers/irqchip/irq-qcom-mpm.c > +++ b/drivers/irqchip/irq-qcom-mpm.c > @@ -447,7 +447,7 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent) > > priv->domain = irq_domain_create_hierarchy(parent_domain, > IRQ_DOMAIN_FLAG_QCOM_MPM_WAKEUP, pin_cnt, > - of_node_to_fwnode(np), &qcom_mpm_ops, priv); > + of_fwnode_handle(np), &qcom_mpm_ops, priv); > if (!priv->domain) { > dev_err(dev, "failed to create MPM domain\n"); > ret = -ENOMEM; > diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c > index f653c13de62b..e5805885394e 100644 > --- a/drivers/irqchip/irq-riscv-intc.c > +++ b/drivers/irqchip/irq-riscv-intc.c > @@ -242,7 +242,7 @@ static int __init riscv_intc_init(struct device_node *node, > chip = &andes_intc_chip; > } > > - return riscv_intc_init_common(of_node_to_fwnode(node), chip); > + return riscv_intc_init_common(of_fwnode_handle(node), chip); > } > > IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); > diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c > index c7db617e1a2f..7d10bf6e5824 100644 > --- a/drivers/irqchip/irq-sni-exiu.c > +++ b/drivers/irqchip/irq-sni-exiu.c > @@ -249,7 +249,7 @@ static int __init exiu_dt_init(struct device_node *node, > return -ENXIO; > } > > - data = exiu_init(of_node_to_fwnode(node), &res); > + data = exiu_init(of_fwnode_handle(node), &res); > if (IS_ERR(data)) > return PTR_ERR(data); > > diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c > index cb83d6cc6113..649b84f12efc 100644 > --- a/drivers/irqchip/irq-stm32mp-exti.c > +++ b/drivers/irqchip/irq-stm32mp-exti.c > @@ -531,7 +531,7 @@ static int stm32mp_exti_domain_alloc(struct irq_domain *dm, > if (ret) > return ret; > /* we only support one parent, so far */ > - if (of_node_to_fwnode(out_irq.np) != dm->parent->fwnode) > + if (of_fwnode_handle(out_irq.np) != dm->parent->fwnode) > return -EINVAL; > > of_phandle_args_to_fwspec(out_irq.np, out_irq.args, > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index a887efba262c..38dfc1f9a56b 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -233,7 +233,7 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom > INIT_LIST_HEAD(&vint_desc->list); > > parent_node = of_irq_find_parent(dev_of_node(&inta->pdev->dev)); > - parent_fwspec.fwnode = of_node_to_fwnode(parent_node); > + parent_fwspec.fwnode = of_fwnode_handle(parent_node); > > if (of_device_is_compatible(parent_node, "arm,gic-v3")) { > /* Parent is GIC */ > @@ -709,7 +709,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev) > return -ENOMEM; > } > > - msi_domain = ti_sci_inta_msi_create_irq_domain(of_node_to_fwnode(node), > + msi_domain = ti_sci_inta_msi_create_irq_domain(of_fwnode_handle(node), > &ti_sci_inta_msi_domain_info, > domain); > if (!msi_domain) { > diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c > index b49a73106c69..686a8f69fd9c 100644 > --- a/drivers/irqchip/irq-ti-sci-intr.c > +++ b/drivers/irqchip/irq-ti-sci-intr.c > @@ -149,7 +149,7 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain, > goto err_irqs; > > parent_node = of_irq_find_parent(dev_of_node(intr->dev)); > - fwspec.fwnode = of_node_to_fwnode(parent_node); > + fwspec.fwnode = of_fwnode_handle(parent_node); > > if (of_device_is_compatible(parent_node, "arm,gic-v3")) { > /* Parent is GIC */ > diff --git a/drivers/irqchip/irq-uniphier-aidet.c b/drivers/irqchip/irq-uniphier-aidet.c > index 601f9343d5b3..6005c2d28dd9 100644 > --- a/drivers/irqchip/irq-uniphier-aidet.c > +++ b/drivers/irqchip/irq-uniphier-aidet.c > @@ -188,7 +188,7 @@ static int uniphier_aidet_probe(struct platform_device *pdev) > priv->domain = irq_domain_create_hierarchy( > parent_domain, 0, > UNIPHIER_AIDET_NR_IRQS, > - of_node_to_fwnode(dev->of_node), > + of_fwnode_handle(dev->of_node), > &uniphier_aidet_domain_ops, priv); > if (!priv->domain) > return -ENOMEM; > -- > 2.49.0 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() 2025-03-19 9:28 ` [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() Jiri Slaby (SUSE) 2025-03-19 10:29 ` [Linux-stm32] " Antonio Borneo 2025-03-20 5:26 ` Anup Patel @ 2025-03-20 17:15 ` Herve Codina 2 siblings, 0 replies; 12+ messages in thread From: Herve Codina @ 2025-03-20 17:15 UTC (permalink / raw) To: Jiri Slaby (SUSE) Cc: tglx, maz, linux-kernel, Antoine Tenart, Sven Peter, Janne Grunau, Alyssa Rosenzweig, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Linus Walleij, Imre Kaloz, Huacai Chen, WANG Xuerui, Jiaxun Yang, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Anup Patel, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Maxime Coquelin, Alexandre Torgue, Nishanth Menon, Tero Kristo, Santosh Shilimkar, Kunihiko Hayashi, Masami Hiramatsu, linux-arm-kernel, asahi, loongarch, linux-mips, linux-amlogic, linux-riscv, linux-stm32 Hi Jiri, On Wed, 19 Mar 2025 10:28:59 +0100 "Jiri Slaby (SUSE)" <jirislaby@kernel.org> wrote: > of_node_to_fwnode() is irqdomain's reimplementation of the "officially" > defined of_fwnode_handle(). The former is in the process of being > removed, so use the latter instead. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Reviewed-by: Herve Codina <herve.codina@bootlin.com> Acked-by: Herve Codina <herve.codina@bootlin.com> # irq-lan966x-oic Best regards, Hervé ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 07/57] irqdomain: pci: Switch to of_fwnode_handle() [not found] <20250319092951.37667-1-jirislaby@kernel.org> 2025-03-19 9:28 ` [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() Jiri Slaby (SUSE) @ 2025-03-19 9:29 ` Jiri Slaby (SUSE) 2025-03-21 16:32 ` Bjorn Helgaas 2025-04-07 18:03 ` Bjorn Helgaas 2025-03-19 9:29 ` [PATCH v2 14/57] irqdomain: arm: Switch to irq_domain_create_*() Jiri Slaby (SUSE) ` (2 subsequent siblings) 4 siblings, 2 replies; 12+ messages in thread From: Jiri Slaby (SUSE) @ 2025-03-19 9:29 UTC (permalink / raw) To: tglx Cc: maz, linux-kernel, Jiri Slaby (SUSE), Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Karthikeyan Mitran, Hou Zhiqiang, Toan Le, Joyce Ooi, Jim Quinlan, Nicolas Saenz Julienne, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Ryder Lee, Jianjun Wang, Michal Simek, Daire McNamara, linux-pci, linux-arm-kernel, linux-rpi-kernel, linux-mediatek of_node_to_fwnode() is irqdomain's reimplementation of the "officially" defined of_fwnode_handle(). The former is in the process of being removed, so use the latter instead. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> Cc: "Krzysztof Wilczyński" <kw@linux.com> Cc: Rob Herring <robh@kernel.org> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> Cc: Toan Le <toan@os.amperecomputing.com> Cc: Joyce Ooi <joyce.ooi@intel.com> Cc: Jim Quinlan <jim2101024@gmail.com> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> Cc: Florian Fainelli <florian.fainelli@broadcom.com> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: Ryder Lee <ryder.lee@mediatek.com> Cc: Jianjun Wang <jianjun.wang@mediatek.com> Cc: Michal Simek <michal.simek@amd.com> Cc: Daire McNamara <daire.mcnamara@microchip.com> Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org --- drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 2 +- drivers/pci/controller/pci-xgene-msi.c | 2 +- drivers/pci/controller/pcie-altera-msi.c | 2 +- drivers/pci/controller/pcie-brcmstb.c | 2 +- drivers/pci/controller/pcie-iproc-msi.c | 2 +- drivers/pci/controller/pcie-mediatek.c | 2 +- drivers/pci/controller/pcie-xilinx-dma-pl.c | 2 +- drivers/pci/controller/pcie-xilinx-nwl.c | 2 +- drivers/pci/controller/plda/pcie-plda-host.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index ecc33f6789e3..d1cd48efad43 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -227,7 +227,7 @@ static const struct irq_domain_ops dw_pcie_msi_domain_ops = { int dw_pcie_allocate_domains(struct dw_pcie_rp *pp) { struct dw_pcie *pci = to_dw_pcie_from_pp(pp); - struct fwnode_handle *fwnode = of_node_to_fwnode(pci->dev->of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(pci->dev->of_node); pp->irq_domain = irq_domain_create_linear(fwnode, pp->num_vectors, &dw_pcie_msi_domain_ops, pp); diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c index 0e088e74155d..6628eed9d26e 100644 --- a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c @@ -435,7 +435,7 @@ static const struct irq_domain_ops msi_domain_ops = { static int mobiveil_allocate_msi_domains(struct mobiveil_pcie *pcie) { struct device *dev = &pcie->pdev->dev; - struct fwnode_handle *fwnode = of_node_to_fwnode(dev->of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(dev->of_node); struct mobiveil_msi *msi = &pcie->rp.msi; mutex_init(&msi->lock); diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c index 7bce327897c9..69a9c0a87639 100644 --- a/drivers/pci/controller/pci-xgene-msi.c +++ b/drivers/pci/controller/pci-xgene-msi.c @@ -247,7 +247,7 @@ static int xgene_allocate_domains(struct xgene_msi *msi) if (!msi->inner_domain) return -ENOMEM; - msi->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(msi->node), + msi->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(msi->node), &xgene_msi_domain_info, msi->inner_domain); diff --git a/drivers/pci/controller/pcie-altera-msi.c b/drivers/pci/controller/pcie-altera-msi.c index e1cee3c0575f..5fb3a2e0017e 100644 --- a/drivers/pci/controller/pcie-altera-msi.c +++ b/drivers/pci/controller/pcie-altera-msi.c @@ -164,7 +164,7 @@ static const struct irq_domain_ops msi_domain_ops = { static int altera_allocate_domains(struct altera_msi *msi) { - struct fwnode_handle *fwnode = of_node_to_fwnode(msi->pdev->dev.of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(msi->pdev->dev.of_node); msi->inner_domain = irq_domain_add_linear(NULL, msi->num_of_vectors, &msi_domain_ops, msi); diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 8b2b099e81eb..1f356fca07a2 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -581,7 +581,7 @@ static const struct irq_domain_ops msi_domain_ops = { static int brcm_allocate_domains(struct brcm_msi *msi) { - struct fwnode_handle *fwnode = of_node_to_fwnode(msi->np); + struct fwnode_handle *fwnode = of_fwnode_handle(msi->np); struct device *dev = msi->dev; msi->inner_domain = irq_domain_add_linear(NULL, msi->nr, &msi_domain_ops, msi); diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c index 649fcb449f34..804b3a5787c5 100644 --- a/drivers/pci/controller/pcie-iproc-msi.c +++ b/drivers/pci/controller/pcie-iproc-msi.c @@ -451,7 +451,7 @@ static int iproc_msi_alloc_domains(struct device_node *node, if (!msi->inner_domain) return -ENOMEM; - msi->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), + msi->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(node), &iproc_msi_domain_info, msi->inner_domain); if (!msi->msi_domain) { diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c index 811a8b4acd50..efcc4a7c17be 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -485,7 +485,7 @@ static struct msi_domain_info mtk_msi_domain_info = { static int mtk_pcie_allocate_msi_domains(struct mtk_pcie_port *port) { - struct fwnode_handle *fwnode = of_node_to_fwnode(port->pcie->dev->of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(port->pcie->dev->of_node); mutex_init(&port->lock); diff --git a/drivers/pci/controller/pcie-xilinx-dma-pl.c b/drivers/pci/controller/pcie-xilinx-dma-pl.c index dd117f07fc95..71cf13ae51c7 100644 --- a/drivers/pci/controller/pcie-xilinx-dma-pl.c +++ b/drivers/pci/controller/pcie-xilinx-dma-pl.c @@ -470,7 +470,7 @@ static int xilinx_pl_dma_pcie_init_msi_irq_domain(struct pl_dma_pcie *port) struct device *dev = port->dev; struct xilinx_msi *msi = &port->msi; int size = BITS_TO_LONGS(XILINX_NUM_MSI_IRQS) * sizeof(long); - struct fwnode_handle *fwnode = of_node_to_fwnode(port->dev->of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(port->dev->of_node); msi->dev_domain = irq_domain_add_linear(NULL, XILINX_NUM_MSI_IRQS, &dev_msi_domain_ops, port); diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c index 8d6e2a89b067..9cf8a96f7bc4 100644 --- a/drivers/pci/controller/pcie-xilinx-nwl.c +++ b/drivers/pci/controller/pcie-xilinx-nwl.c @@ -495,7 +495,7 @@ static int nwl_pcie_init_msi_irq_domain(struct nwl_pcie *pcie) { #ifdef CONFIG_PCI_MSI struct device *dev = pcie->dev; - struct fwnode_handle *fwnode = of_node_to_fwnode(dev->of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(dev->of_node); struct nwl_msi *msi = &pcie->msi; msi->dev_domain = irq_domain_add_linear(NULL, INT_PCI_MSI_NR, diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/controller/plda/pcie-plda-host.c index 4153214ca410..4c7a9fa311e3 100644 --- a/drivers/pci/controller/plda/pcie-plda-host.c +++ b/drivers/pci/controller/plda/pcie-plda-host.c @@ -150,7 +150,7 @@ static struct msi_domain_info plda_msi_domain_info = { static int plda_allocate_msi_domains(struct plda_pcie_rp *port) { struct device *dev = port->dev; - struct fwnode_handle *fwnode = of_node_to_fwnode(dev->of_node); + struct fwnode_handle *fwnode = of_fwnode_handle(dev->of_node); struct plda_msi *msi = &port->msi; mutex_init(&port->msi.lock); -- 2.49.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 07/57] irqdomain: pci: Switch to of_fwnode_handle() 2025-03-19 9:29 ` [PATCH v2 07/57] irqdomain: pci: " Jiri Slaby (SUSE) @ 2025-03-21 16:32 ` Bjorn Helgaas 2025-04-07 7:17 ` Jiri Slaby 2025-04-07 18:03 ` Bjorn Helgaas 1 sibling, 1 reply; 12+ messages in thread From: Bjorn Helgaas @ 2025-03-21 16:32 UTC (permalink / raw) To: Jiri Slaby (SUSE) Cc: tglx, maz, linux-kernel, Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Karthikeyan Mitran, Hou Zhiqiang, Toan Le, Joyce Ooi, Jim Quinlan, Nicolas Saenz Julienne, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Ryder Lee, Jianjun Wang, Michal Simek, Daire McNamara, linux-pci, linux-arm-kernel, linux-rpi-kernel, linux-mediatek On Wed, Mar 19, 2025 at 10:29:00AM +0100, Jiri Slaby (SUSE) wrote: > of_node_to_fwnode() is irqdomain's reimplementation of the "officially" > defined of_fwnode_handle(). The former is in the process of being > removed, so use the latter instead. I'm fine with these and happy to apply via the PCI tree, but it sounds like you're planning a v3 with a few updates, so I'll hold off for now: https://lore.kernel.org/r/4bc0e1ca-a523-424a-8759-59e353317fba@kernel.org ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 07/57] irqdomain: pci: Switch to of_fwnode_handle() 2025-03-21 16:32 ` Bjorn Helgaas @ 2025-04-07 7:17 ` Jiri Slaby 2025-04-07 7:18 ` Jiri Slaby 0 siblings, 1 reply; 12+ messages in thread From: Jiri Slaby @ 2025-04-07 7:17 UTC (permalink / raw) To: Bjorn Helgaas Cc: tglx, maz, linux-kernel, Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Karthikeyan Mitran, Hou Zhiqiang, Toan Le, Joyce Ooi, Jim Quinlan, Nicolas Saenz Julienne, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Ryder Lee, Jianjun Wang, Michal Simek, Daire McNamara, linux-pci, linux-arm-kernel, linux-rpi-kernel, linux-mediatek On 21. 03. 25, 17:32, Bjorn Helgaas wrote: > On Wed, Mar 19, 2025 at 10:29:00AM +0100, Jiri Slaby (SUSE) wrote: >> of_node_to_fwnode() is irqdomain's reimplementation of the "officially" >> defined of_fwnode_handle(). The former is in the process of being >> removed, so use the latter instead. > > I'm fine with these and happy to apply via the PCI tree, but it sounds > like you're planning a v3 with a few updates, so I'll hold off for > now: > > https://lore.kernel.org/r/4bc0e1ca-a523-424a-8759-59e353317fba@kernel.org Right, there will be a v3 to deal better with irq_domain_create_*()'s first parameter (patches 13-39/57 later in this series). But this very patch (of_fwnode_handle() cleanup sub-series) won't be affected, so please take it through your tree, if you can. I will fix up the _create_ subseries and resend non-merged patches from this series in v3 later. So it's also fine to wait for v3. (But less I have to resend (unmodified), the better ;).) thanks, -- js suse labs ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 07/57] irqdomain: pci: Switch to of_fwnode_handle() 2025-04-07 7:17 ` Jiri Slaby @ 2025-04-07 7:18 ` Jiri Slaby 0 siblings, 0 replies; 12+ messages in thread From: Jiri Slaby @ 2025-04-07 7:18 UTC (permalink / raw) To: Bjorn Helgaas Cc: tglx, maz, linux-kernel, Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Karthikeyan Mitran, Hou Zhiqiang, Toan Le, Joyce Ooi, Jim Quinlan, Nicolas Saenz Julienne, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Ryder Lee, Jianjun Wang, Michal Simek, Daire McNamara, linux-pci, linux-arm-kernel, linux-rpi-kernel, linux-mediatek On 07. 04. 25, 9:17, Jiri Slaby wrote: > On 21. 03. 25, 17:32, Bjorn Helgaas wrote: >> On Wed, Mar 19, 2025 at 10:29:00AM +0100, Jiri Slaby (SUSE) wrote: >>> of_node_to_fwnode() is irqdomain's reimplementation of the "officially" >>> defined of_fwnode_handle(). The former is in the process of being >>> removed, so use the latter instead. >> >> I'm fine with these and happy to apply via the PCI tree, but it sounds >> like you're planning a v3 with a few updates, so I'll hold off for >> now: >> >> https://lore.kernel.org/r/4bc0e1ca-a523-424a-8759-59e353317fba@kernel.org > > Right, there will be a v3 to deal better with irq_domain_create_*()'s > first parameter (patches 13-39/57 later in this series). > > But this very patch (of_fwnode_handle() cleanup sub-series) won't be > affected, so please take it through your tree, if you can. FWIW, the patch was 20250319092951.37667-8-jirislaby@kernel.org if you already dropped it. > I will fix up the _create_ subseries and resend non-merged patches from > this series in v3 later. So it's also fine to wait for v3. (But less I > have to resend (unmodified), the better ;).) > > thanks, -- js suse labs ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 07/57] irqdomain: pci: Switch to of_fwnode_handle() 2025-03-19 9:29 ` [PATCH v2 07/57] irqdomain: pci: " Jiri Slaby (SUSE) 2025-03-21 16:32 ` Bjorn Helgaas @ 2025-04-07 18:03 ` Bjorn Helgaas 1 sibling, 0 replies; 12+ messages in thread From: Bjorn Helgaas @ 2025-04-07 18:03 UTC (permalink / raw) To: Jiri Slaby (SUSE) Cc: tglx, maz, linux-kernel, Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Karthikeyan Mitran, Hou Zhiqiang, Toan Le, Joyce Ooi, Jim Quinlan, Nicolas Saenz Julienne, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Ryder Lee, Jianjun Wang, Michal Simek, Daire McNamara, linux-pci, linux-arm-kernel, linux-rpi-kernel, linux-mediatek On Wed, Mar 19, 2025 at 10:29:00AM +0100, Jiri Slaby (SUSE) wrote: > of_node_to_fwnode() is irqdomain's reimplementation of the "officially" > defined of_fwnode_handle(). The former is in the process of being > removed, so use the latter instead. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> > Cc: "Krzysztof Wilczyński" <kw@linux.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in> > Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > Cc: Toan Le <toan@os.amperecomputing.com> > Cc: Joyce Ooi <joyce.ooi@intel.com> > Cc: Jim Quinlan <jim2101024@gmail.com> > Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> > Cc: Florian Fainelli <florian.fainelli@broadcom.com> > Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: Ryder Lee <ryder.lee@mediatek.com> > Cc: Jianjun Wang <jianjun.wang@mediatek.com> > Cc: Michal Simek <michal.simek@amd.com> > Cc: Daire McNamara <daire.mcnamara@microchip.com> > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org Applied to pci/irq for v6.16, thanks! > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- > drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 2 +- > drivers/pci/controller/pci-xgene-msi.c | 2 +- > drivers/pci/controller/pcie-altera-msi.c | 2 +- > drivers/pci/controller/pcie-brcmstb.c | 2 +- > drivers/pci/controller/pcie-iproc-msi.c | 2 +- > drivers/pci/controller/pcie-mediatek.c | 2 +- > drivers/pci/controller/pcie-xilinx-dma-pl.c | 2 +- > drivers/pci/controller/pcie-xilinx-nwl.c | 2 +- > drivers/pci/controller/plda/pcie-plda-host.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index ecc33f6789e3..d1cd48efad43 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -227,7 +227,7 @@ static const struct irq_domain_ops dw_pcie_msi_domain_ops = { > int dw_pcie_allocate_domains(struct dw_pcie_rp *pp) > { > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > - struct fwnode_handle *fwnode = of_node_to_fwnode(pci->dev->of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(pci->dev->of_node); > > pp->irq_domain = irq_domain_create_linear(fwnode, pp->num_vectors, > &dw_pcie_msi_domain_ops, pp); > diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c > index 0e088e74155d..6628eed9d26e 100644 > --- a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c > +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c > @@ -435,7 +435,7 @@ static const struct irq_domain_ops msi_domain_ops = { > static int mobiveil_allocate_msi_domains(struct mobiveil_pcie *pcie) > { > struct device *dev = &pcie->pdev->dev; > - struct fwnode_handle *fwnode = of_node_to_fwnode(dev->of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(dev->of_node); > struct mobiveil_msi *msi = &pcie->rp.msi; > > mutex_init(&msi->lock); > diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c > index 7bce327897c9..69a9c0a87639 100644 > --- a/drivers/pci/controller/pci-xgene-msi.c > +++ b/drivers/pci/controller/pci-xgene-msi.c > @@ -247,7 +247,7 @@ static int xgene_allocate_domains(struct xgene_msi *msi) > if (!msi->inner_domain) > return -ENOMEM; > > - msi->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(msi->node), > + msi->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(msi->node), > &xgene_msi_domain_info, > msi->inner_domain); > > diff --git a/drivers/pci/controller/pcie-altera-msi.c b/drivers/pci/controller/pcie-altera-msi.c > index e1cee3c0575f..5fb3a2e0017e 100644 > --- a/drivers/pci/controller/pcie-altera-msi.c > +++ b/drivers/pci/controller/pcie-altera-msi.c > @@ -164,7 +164,7 @@ static const struct irq_domain_ops msi_domain_ops = { > > static int altera_allocate_domains(struct altera_msi *msi) > { > - struct fwnode_handle *fwnode = of_node_to_fwnode(msi->pdev->dev.of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(msi->pdev->dev.of_node); > > msi->inner_domain = irq_domain_add_linear(NULL, msi->num_of_vectors, > &msi_domain_ops, msi); > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 8b2b099e81eb..1f356fca07a2 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -581,7 +581,7 @@ static const struct irq_domain_ops msi_domain_ops = { > > static int brcm_allocate_domains(struct brcm_msi *msi) > { > - struct fwnode_handle *fwnode = of_node_to_fwnode(msi->np); > + struct fwnode_handle *fwnode = of_fwnode_handle(msi->np); > struct device *dev = msi->dev; > > msi->inner_domain = irq_domain_add_linear(NULL, msi->nr, &msi_domain_ops, msi); > diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c > index 649fcb449f34..804b3a5787c5 100644 > --- a/drivers/pci/controller/pcie-iproc-msi.c > +++ b/drivers/pci/controller/pcie-iproc-msi.c > @@ -451,7 +451,7 @@ static int iproc_msi_alloc_domains(struct device_node *node, > if (!msi->inner_domain) > return -ENOMEM; > > - msi->msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), > + msi->msi_domain = pci_msi_create_irq_domain(of_fwnode_handle(node), > &iproc_msi_domain_info, > msi->inner_domain); > if (!msi->msi_domain) { > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c > index 811a8b4acd50..efcc4a7c17be 100644 > --- a/drivers/pci/controller/pcie-mediatek.c > +++ b/drivers/pci/controller/pcie-mediatek.c > @@ -485,7 +485,7 @@ static struct msi_domain_info mtk_msi_domain_info = { > > static int mtk_pcie_allocate_msi_domains(struct mtk_pcie_port *port) > { > - struct fwnode_handle *fwnode = of_node_to_fwnode(port->pcie->dev->of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(port->pcie->dev->of_node); > > mutex_init(&port->lock); > > diff --git a/drivers/pci/controller/pcie-xilinx-dma-pl.c b/drivers/pci/controller/pcie-xilinx-dma-pl.c > index dd117f07fc95..71cf13ae51c7 100644 > --- a/drivers/pci/controller/pcie-xilinx-dma-pl.c > +++ b/drivers/pci/controller/pcie-xilinx-dma-pl.c > @@ -470,7 +470,7 @@ static int xilinx_pl_dma_pcie_init_msi_irq_domain(struct pl_dma_pcie *port) > struct device *dev = port->dev; > struct xilinx_msi *msi = &port->msi; > int size = BITS_TO_LONGS(XILINX_NUM_MSI_IRQS) * sizeof(long); > - struct fwnode_handle *fwnode = of_node_to_fwnode(port->dev->of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(port->dev->of_node); > > msi->dev_domain = irq_domain_add_linear(NULL, XILINX_NUM_MSI_IRQS, > &dev_msi_domain_ops, port); > diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c > index 8d6e2a89b067..9cf8a96f7bc4 100644 > --- a/drivers/pci/controller/pcie-xilinx-nwl.c > +++ b/drivers/pci/controller/pcie-xilinx-nwl.c > @@ -495,7 +495,7 @@ static int nwl_pcie_init_msi_irq_domain(struct nwl_pcie *pcie) > { > #ifdef CONFIG_PCI_MSI > struct device *dev = pcie->dev; > - struct fwnode_handle *fwnode = of_node_to_fwnode(dev->of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(dev->of_node); > struct nwl_msi *msi = &pcie->msi; > > msi->dev_domain = irq_domain_add_linear(NULL, INT_PCI_MSI_NR, > diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/controller/plda/pcie-plda-host.c > index 4153214ca410..4c7a9fa311e3 100644 > --- a/drivers/pci/controller/plda/pcie-plda-host.c > +++ b/drivers/pci/controller/plda/pcie-plda-host.c > @@ -150,7 +150,7 @@ static struct msi_domain_info plda_msi_domain_info = { > static int plda_allocate_msi_domains(struct plda_pcie_rp *port) > { > struct device *dev = port->dev; > - struct fwnode_handle *fwnode = of_node_to_fwnode(dev->of_node); > + struct fwnode_handle *fwnode = of_fwnode_handle(dev->of_node); > struct plda_msi *msi = &port->msi; > > mutex_init(&port->msi.lock); > -- > 2.49.0 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 14/57] irqdomain: arm: Switch to irq_domain_create_*() [not found] <20250319092951.37667-1-jirislaby@kernel.org> 2025-03-19 9:28 ` [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() Jiri Slaby (SUSE) 2025-03-19 9:29 ` [PATCH v2 07/57] irqdomain: pci: " Jiri Slaby (SUSE) @ 2025-03-19 9:29 ` Jiri Slaby (SUSE) 2025-03-19 9:29 ` [PATCH v2 46/57] irqdomain: irqchip: Switch to irq_find_mapping() Jiri Slaby (SUSE) 2025-03-19 9:29 ` [PATCH v2 48/57] irqdomain: soc: " Jiri Slaby (SUSE) 4 siblings, 0 replies; 12+ messages in thread From: Jiri Slaby (SUSE) @ 2025-03-19 9:29 UTC (permalink / raw) To: tglx Cc: maz, linux-kernel, Jiri Slaby (SUSE), Russell King, Krzysztof Kozlowski, Alim Akhtar, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Aaro Koskinen, Janusz Krzysztofik, Tony Lindgren, Andreas Kemnade, Kevin Hilman, Roger Quadros, Daniel Mack, Haojian Zhuang, Robert Jarzmik, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, linux-arm-kernel irq_domain_add_*() interfaces are going away as being obsolete now. Switch to the preferred irq_domain_create_*() ones. Those differ in the node parameter: They take more generic struct fwnode_handle instead of struct device_node. Therefore, of_fwnode_handle() is added around the original parameter. Note some of the users can likely use dev->fwnode directly instead of indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not guaranteed to be set for all, so this has to be investigated on case to case basis (by people who can actually test with the HW). Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Russell King <linux@armlinux.org.uk> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Alim Akhtar <alim.akhtar@samsung.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: Aaro Koskinen <aaro.koskinen@iki.fi> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Andreas Kemnade <andreas@kemnade.info> Cc: Kevin Hilman <khilman@baylibre.com> Cc: Roger Quadros <rogerq@kernel.org> Cc: Daniel Mack <daniel@zonque.org> Cc: Haojian Zhuang <haojian.zhuang@gmail.com> Cc: Robert Jarzmik <robert.jarzmik@free.fr> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Gregory Clement <gregory.clement@bootlin.com> Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/common/sa1111.c | 6 +++--- arch/arm/mach-exynos/suspend.c | 5 ++--- arch/arm/mach-imx/avic.c | 4 ++-- arch/arm/mach-imx/gpc.c | 5 ++--- arch/arm/mach-imx/tzic.c | 4 ++-- arch/arm/mach-omap1/irq.c | 3 +-- arch/arm/mach-omap2/omap-wakeupgen.c | 5 ++--- arch/arm/mach-pxa/irq.c | 5 ++--- arch/arm/plat-orion/gpio.c | 12 ++++++------ 9 files changed, 22 insertions(+), 27 deletions(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 9846f30990f7..02eda44a6faa 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -416,9 +416,9 @@ static int sa1111_setup_irq(struct sa1111 *sachip, unsigned irq_base) writel_relaxed(~0, irqbase + SA1111_INTSTATCLR0); writel_relaxed(~0, irqbase + SA1111_INTSTATCLR1); - sachip->irqdomain = irq_domain_add_linear(NULL, SA1111_IRQ_NR, - &sa1111_irqdomain_ops, - sachip); + sachip->irqdomain = irq_domain_create_linear(NULL, SA1111_IRQ_NR, + &sa1111_irqdomain_ops, + sachip); if (!sachip->irqdomain) { irq_free_descs(sachip->irq_base, SA1111_IRQ_NR); return -ENOMEM; diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index cac4e82f6c82..150a1e56dcae 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -209,9 +209,8 @@ static int __init exynos_pmu_irq_init(struct device_node *node, return -ENOMEM; } - domain = irq_domain_add_hierarchy(parent_domain, 0, 0, - node, &exynos_pmu_domain_ops, - NULL); + domain = irq_domain_create_hierarchy(parent_domain, 0, 0, of_fwnode_handle(node), + &exynos_pmu_domain_ops, NULL); if (!domain) { iounmap(pmu_base_addr); pmu_base_addr = NULL; diff --git a/arch/arm/mach-imx/avic.c b/arch/arm/mach-imx/avic.c index cf6546ddc7a3..3067c06b4b8e 100644 --- a/arch/arm/mach-imx/avic.c +++ b/arch/arm/mach-imx/avic.c @@ -201,8 +201,8 @@ static void __init mxc_init_irq(void __iomem *irqbase) WARN_ON(irq_base < 0); np = of_find_compatible_node(NULL, NULL, "fsl,avic"); - domain = irq_domain_add_legacy(np, AVIC_NUM_IRQS, irq_base, 0, - &irq_domain_simple_ops, NULL); + domain = irq_domain_create_legacy(of_fwnode_handle(np), AVIC_NUM_IRQS, irq_base, 0, + &irq_domain_simple_ops, NULL); WARN_ON(!domain); for (i = 0; i < AVIC_NUM_IRQS / 32; i++, irq_base += 32) diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index 5909088d5482..2e633569d2f8 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -245,9 +245,8 @@ static int __init imx_gpc_init(struct device_node *node, if (WARN_ON(!gpc_base)) return -ENOMEM; - domain = irq_domain_add_hierarchy(parent_domain, 0, GPC_MAX_IRQS, - node, &imx_gpc_domain_ops, - NULL); + domain = irq_domain_create_hierarchy(parent_domain, 0, GPC_MAX_IRQS, of_fwnode_handle(node), + &imx_gpc_domain_ops, NULL); if (!domain) { iounmap(gpc_base); return -ENOMEM; diff --git a/arch/arm/mach-imx/tzic.c b/arch/arm/mach-imx/tzic.c index 8b3d98d288d9..50a5668e65d2 100644 --- a/arch/arm/mach-imx/tzic.c +++ b/arch/arm/mach-imx/tzic.c @@ -175,8 +175,8 @@ static int __init tzic_init_dt(struct device_node *np, struct device_node *p) irq_base = irq_alloc_descs(-1, 0, TZIC_NUM_IRQS, numa_node_id()); WARN_ON(irq_base < 0); - domain = irq_domain_add_legacy(np, TZIC_NUM_IRQS, irq_base, 0, - &irq_domain_simple_ops, NULL); + domain = irq_domain_create_legacy(of_fwnode_handle(np), TZIC_NUM_IRQS, irq_base, 0, + &irq_domain_simple_ops, NULL); WARN_ON(!domain); for (i = 0; i < 4; i++, irq_base += 32) diff --git a/arch/arm/mach-omap1/irq.c b/arch/arm/mach-omap1/irq.c index 9b587ecebb1c..bb1bc060ecd8 100644 --- a/arch/arm/mach-omap1/irq.c +++ b/arch/arm/mach-omap1/irq.c @@ -220,8 +220,7 @@ void __init omap1_init_irq(void) omap_l2_irq = irq_base; omap_l2_irq -= NR_IRQS_LEGACY; - domain = irq_domain_add_legacy(NULL, nr_irqs, irq_base, 0, - &irq_domain_simple_ops, NULL); + domain = irq_domain_create_legacy(NULL, nr_irqs, irq_base, 0, &irq_domain_simple_ops, NULL); pr_info("Total of %lu interrupts in %i interrupt banks\n", nr_irqs, irq_bank_count); diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c index 6f0d6120c174..a66b1dc61571 100644 --- a/arch/arm/mach-omap2/omap-wakeupgen.c +++ b/arch/arm/mach-omap2/omap-wakeupgen.c @@ -585,9 +585,8 @@ static int __init wakeupgen_init(struct device_node *node, wakeupgen_ops = &am43xx_wakeupgen_ops; } - domain = irq_domain_add_hierarchy(parent_domain, 0, max_irqs, - node, &wakeupgen_domain_ops, - NULL); + domain = irq_domain_create_hierarchy(parent_domain, 0, max_irqs, of_fwnode_handle(node), + &wakeupgen_domain_ops, NULL); if (!domain) { iounmap(wakeupgen_base); return -ENOMEM; diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c index d9cadd97748a..5bfce8aa4102 100644 --- a/arch/arm/mach-pxa/irq.c +++ b/arch/arm/mach-pxa/irq.c @@ -147,9 +147,8 @@ pxa_init_irq_common(struct device_node *node, int irq_nr, int n; pxa_internal_irq_nr = irq_nr; - pxa_irq_domain = irq_domain_add_legacy(node, irq_nr, - PXA_IRQ(0), 0, - &pxa_irq_ops, NULL); + pxa_irq_domain = irq_domain_create_legacy(of_fwnode_handle(node), irq_nr, PXA_IRQ(0), 0, + &pxa_irq_ops, NULL); if (!pxa_irq_domain) panic("Unable to add PXA IRQ domain\n"); irq_set_default_domain(pxa_irq_domain); diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c index 595e9cb33c1d..a15f47450084 100644 --- a/arch/arm/plat-orion/gpio.c +++ b/arch/arm/plat-orion/gpio.c @@ -602,12 +602,12 @@ void __init orion_gpio_init(int gpio_base, int ngpio, IRQ_NOREQUEST, IRQ_LEVEL | IRQ_NOPROBE); /* Setup irq domain on top of the generic chip. */ - ochip->domain = irq_domain_add_legacy(NULL, - ochip->chip.ngpio, - ochip->secondary_irq_base, - ochip->secondary_irq_base, - &irq_domain_simple_ops, - ochip); + ochip->domain = irq_domain_create_legacy(NULL, + ochip->chip.ngpio, + ochip->secondary_irq_base, + ochip->secondary_irq_base, + &irq_domain_simple_ops, + ochip); if (!ochip->domain) panic("%s: couldn't allocate irq domain (DT).\n", ochip->chip.label); -- 2.49.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 46/57] irqdomain: irqchip: Switch to irq_find_mapping() [not found] <20250319092951.37667-1-jirislaby@kernel.org> ` (2 preceding siblings ...) 2025-03-19 9:29 ` [PATCH v2 14/57] irqdomain: arm: Switch to irq_domain_create_*() Jiri Slaby (SUSE) @ 2025-03-19 9:29 ` Jiri Slaby (SUSE) 2025-03-19 9:29 ` [PATCH v2 48/57] irqdomain: soc: " Jiri Slaby (SUSE) 4 siblings, 0 replies; 12+ messages in thread From: Jiri Slaby (SUSE) @ 2025-03-19 9:29 UTC (permalink / raw) To: tglx Cc: maz, linux-kernel, Jiri Slaby (SUSE), Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, linux-arm-kernel irq_linear_revmap() is deprecated, so remove all its uses and supersede them by an identical call to irq_find_mapping(). Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@bootlin.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-arm-kernel@lists.infradead.org --- drivers/irqchip/irq-armada-370-xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index e51612992735..67b672a78862 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -546,7 +546,7 @@ static void mpic_reenable_percpu(struct mpic *mpic) { /* Re-enable per-CPU interrupts that were enabled before suspend */ for (irq_hw_number_t i = 0; i < MPIC_PER_CPU_IRQS_NR; i++) { - unsigned int virq = irq_linear_revmap(mpic->domain, i); + unsigned int virq = irq_find_mapping(mpic->domain, i); struct irq_data *d; if (!virq || !irq_percpu_is_enabled(virq)) @@ -740,7 +740,7 @@ static void mpic_resume(void) /* Re-enable interrupts */ for (irq_hw_number_t i = 0; i < mpic->domain->hwirq_max; i++) { - unsigned int virq = irq_linear_revmap(mpic->domain, i); + unsigned int virq = irq_find_mapping(mpic->domain, i); struct irq_data *d; if (!virq) -- 2.49.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 48/57] irqdomain: soc: Switch to irq_find_mapping() [not found] <20250319092951.37667-1-jirislaby@kernel.org> ` (3 preceding siblings ...) 2025-03-19 9:29 ` [PATCH v2 46/57] irqdomain: irqchip: Switch to irq_find_mapping() Jiri Slaby (SUSE) @ 2025-03-19 9:29 ` Jiri Slaby (SUSE) 4 siblings, 0 replies; 12+ messages in thread From: Jiri Slaby (SUSE) @ 2025-03-19 9:29 UTC (permalink / raw) To: tglx Cc: maz, linux-kernel, Jiri Slaby (SUSE), Qiang Zhao, Christophe Leroy, linuxppc-dev, linux-arm-kernel irq_linear_revmap() is deprecated, so remove all its uses and supersede them by an identical call to irq_find_mapping(). Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Qiang Zhao <qiang.zhao@nxp.com> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/soc/fsl/qe/qe_ic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c index e5831c298ad6..e4b6ff2cc76b 100644 --- a/drivers/soc/fsl/qe/qe_ic.c +++ b/drivers/soc/fsl/qe/qe_ic.c @@ -344,7 +344,7 @@ static unsigned int qe_ic_get_low_irq(struct qe_ic *qe_ic) if (irq == 0) return 0; - return irq_linear_revmap(qe_ic->irqhost, irq); + return irq_find_mapping(qe_ic->irqhost, irq); } /* Return an interrupt vector or 0 if no interrupt is pending. */ @@ -360,7 +360,7 @@ static unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic) if (irq == 0) return 0; - return irq_linear_revmap(qe_ic->irqhost, irq); + return irq_find_mapping(qe_ic->irqhost, irq); } static void qe_ic_cascade_low(struct irq_desc *desc) -- 2.49.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-04-07 18:52 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250319092951.37667-1-jirislaby@kernel.org>
2025-03-19 9:28 ` [PATCH v2 06/57] irqdomain: irqchip: Switch to of_fwnode_handle() Jiri Slaby (SUSE)
2025-03-19 10:29 ` [Linux-stm32] " Antonio Borneo
2025-03-20 5:26 ` Anup Patel
2025-03-20 17:15 ` Herve Codina
2025-03-19 9:29 ` [PATCH v2 07/57] irqdomain: pci: " Jiri Slaby (SUSE)
2025-03-21 16:32 ` Bjorn Helgaas
2025-04-07 7:17 ` Jiri Slaby
2025-04-07 7:18 ` Jiri Slaby
2025-04-07 18:03 ` Bjorn Helgaas
2025-03-19 9:29 ` [PATCH v2 14/57] irqdomain: arm: Switch to irq_domain_create_*() Jiri Slaby (SUSE)
2025-03-19 9:29 ` [PATCH v2 46/57] irqdomain: irqchip: Switch to irq_find_mapping() Jiri Slaby (SUSE)
2025-03-19 9:29 ` [PATCH v2 48/57] irqdomain: soc: " Jiri Slaby (SUSE)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox