[PATCH v3 0/2] Imagination BXS-4-64 MC1 GPU support (DTS changes)

[PATCH v3 0/2] Imagination BXS-4-64 MC1 GPU support (DTS changes)

[Matt Coster]

Now that the binding and driver changes to support the Imagination
BXS-4-64 [1] have landed in a DRM tree, here are the corresponding DTS
changes without the [DO NOT MERGE] tag.

This GPU is found in the TI AM68 family of SoCs, with initial support
added to the k3-j721s2 devicetree and tested on a TI SK-AM68 board.

[1]: https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-0-eda620c5865f@imgtec.com

Reviewed-by: Randolph Sapp <rs@ti.com>
Signed-off-by: Matt Coster <matt.coster@imgtec.com>

---
Changes in v3:
- Use assigned-clocks to pre-load the frequency of the core clock (P2)
- Link to v2: https://lore.kernel.org/r/20250417-bxs-4-64-dts-v2-0-9f8c09233114@imgtec.com

Changes in v2:
- Add details of the source of the interrupt index (P2)
- Add Randolph's Rb
- Link to v1: https://lore.kernel.org/r/20250415-bxs-4-64-dts-v1-0-f7d3fa06625d@imgtec.com

---
Matt Coster (2):
      arm64: dts: ti: k3-am62: New GPU binding details
      arm64: dts: ti: k3-j721s2: Add GPU node

 arch/arm64/boot/dts/ti/k3-am62-main.dtsi   |  4 +++-
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 14 ++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
---
base-commit: dcbd5dcc956e2331414fd7020b4655df08deeb87
change-id: 20250415-bxs-4-64-dts-c984d0876556

[PATCH v3 1/2] arm64: dts: ti: k3-am62: New GPU binding details

[Matt Coster]

Use the new compatible string and power domain name as introduced in
commit 2c01d9099859 ("dt-bindings: gpu: img: Future-proofing
enhancements")[1].

[1]: https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-1-eda620c5865f@imgtec.com

Reviewed-by: Randolph Sapp <rs@ti.com>
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
---
Changes in v3:
- None
- Link to v2: https://lore.kernel.org/r/20250417-bxs-4-64-dts-v2-1-9f8c09233114@imgtec.com
Changes in v2:
- Add Randolph's Rb
- Link to v1: https://lore.kernel.org/r/20250415-bxs-4-64-dts-v1-1-f7d3fa06625d@imgtec.com

This patch was previously sent as [DO NOT MERGE]:
https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-17-eda620c5865f@imgtec.com
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 7d355aa73ea2116723735f70b9351cefcd8bc118..d17b25cae196b08d24adbe7c913ccaba7eed37eb 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -691,12 +691,14 @@ ospi0: spi@fc40000 {
 	};
 
 	gpu: gpu@fd00000 {
-		compatible = "ti,am62-gpu", "img,img-axe";
+		compatible = "ti,am62-gpu", "img,img-axe-1-16m", "img,img-axe",
+			     "img,img-rogue";
 		reg = <0x00 0x0fd00000 0x00 0x20000>;
 		clocks = <&k3_clks 187 0>;
 		clock-names = "core";
 		interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
 		power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
+		power-domain-names = "a";
 	};
 
 	cpsw3g: ethernet@8000000 {

-- 
2.49.0

[PATCH v3 2/2] arm64: dts: ti: k3-j721s2: Add GPU node

[Matt Coster]

The J721S2 binding is based on the TI downstream binding in commit
54b0f2a00d92 ("arm64: dts: ti: k3-j721s2-main: add gpu node") from [1]
but with updated compatible strings.

The clock[2] and power[3] indices were verified from HTML docs, while
the intterupt index comes from the TRM[4] (appendix
"J721S2_Appendix_20241106_Public.xlsx", "Interrupts (inputs)",
"GPU_BXS464_WRAP0_GPU_SS_0_OS_IRQ_OUT_0").

[1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel
[2]: https://downloads.ti.com/tisci/esd/latest/5_soc_doc/j721s2/clocks.html
[3]: https://downloads.ti.com/tisci/esd/latest/5_soc_doc/j721s2/devices.html
[4]: https://www.ti.com/lit/zip/spruj28 (revision E)

Reviewed-by: Randolph Sapp <rs@ti.com>
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
---
Changes in v3:
- Use assigned-clocks to pre-load the frequency of the core clock
- Link to v2: https://lore.kernel.org/r/20250417-bxs-4-64-dts-v2-2-9f8c09233114@imgtec.com
Changes in v2:
- Add interrupt reference details
- Add Randolph's Rb
- Link to v1: https://lore.kernel.org/r/20250415-bxs-4-64-dts-v1-2-f7d3fa06625d@imgtec.com

This patch was previously sent as [DO NOT MERGE]:
https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-18-eda620c5865f@imgtec.com
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index 92bf48fdbeba45ecca8c854db5f72fd3666239c5..9e36cbbe0ea2fefceedcc95b78068ded7ef395f0 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -2048,4 +2048,18 @@ watchdog8: watchdog@23f0000 {
 		/* reserved for MAIN_R5F1_1 */
 		status = "reserved";
 	};
+
+	gpu: gpu@4e20000000 {
+		compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
+		reg = <0x4e 0x20000000 0x00 0x80000>;
+		clocks = <&k3_clks 130 1>;
+		clock-names = "core";
+		assigned-clocks = <&k3_clks 130 1>;
+		assigned-clock-rates = <800000000>;
+		interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
+		power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>,
+				<&k3_pds 373 TI_SCI_PD_EXCLUSIVE>;
+		power-domain-names = "a", "b";
+		dma-coherent;
+	};
 };

-- 
2.49.0

Re: [PATCH v3 0/2] Imagination BXS-4-64 MC1 GPU support (DTS changes)

[Rob Herring (Arm)]

On Tue, 22 Apr 2025 16:26:40 +0100, Matt Coster wrote:
> Now that the binding and driver changes to support the Imagination
> BXS-4-64 [1] have landed in a DRM tree, here are the corresponding DTS
> changes without the [DO NOT MERGE] tag.
> 
> This GPU is found in the TI AM68 family of SoCs, with initial support
> added to the k3-j721s2 devicetree and tested on a TI SK-AM68 board.
> 
> [1]: https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-0-eda620c5865f@imgtec.com
> 
> Reviewed-by: Randolph Sapp <rs@ti.com>
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> 
> ---
> Changes in v3:
> - Use assigned-clocks to pre-load the frequency of the core clock (P2)
> - Link to v2: https://lore.kernel.org/r/20250417-bxs-4-64-dts-v2-0-9f8c09233114@imgtec.com
> 
> Changes in v2:
> - Add details of the source of the interrupt index (P2)
> - Add Randolph's Rb
> - Link to v1: https://lore.kernel.org/r/20250415-bxs-4-64-dts-v1-0-f7d3fa06625d@imgtec.com
> 
> ---
> Matt Coster (2):
>       arm64: dts: ti: k3-am62: New GPU binding details
>       arm64: dts: ti: k3-j721s2: Add GPU node
> 
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi   |  4 +++-
>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 14 ++++++++++++++
>  2 files changed, 17 insertions(+), 1 deletion(-)
> ---
> base-commit: dcbd5dcc956e2331414fd7020b4655df08deeb87
> change-id: 20250415-bxs-4-64-dts-c984d0876556
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: base-commit dcbd5dcc956e2331414fd7020b4655df08deeb87 not known, ignoring
 Base: attempting to guess base-commit...
 Base: tags/v6.15-rc1-15-g1f326fb84a60 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/ti/' for 20250422-bxs-4-64-dts-v3-0-ec6657bde135@imgtec.com:

arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: /bus@100000/gpu@4e20000000: failed to match any schema with compatible: ['ti,j721s2-gpu', 'img,img-bxs-4-64', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: /bus@100000/gpu@4e20000000: failed to match any schema with compatible: ['ti,j721s2-gpu', 'img,img-bxs-4-64', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: /bus@100000/gpu@4e20000000: failed to match any schema with compatible: ['ti,j721s2-gpu', 'img,img-bxs-4-64', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: gpu@fd00000 (ti,am62-gpu): 'power-domain-names' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: gpu@fd00000 (ti,am62-gpu): compatible:1: 'img,img-axe' was expected
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: gpu@fd00000 (ti,am62-gpu): compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue'] is too long
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: /bus@f0000/gpu@fd00000: failed to match any schema with compatible: ['ti,am62-gpu', 'img,img-axe-1-16m', 'img,img-axe', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: /bus@100000/gpu@4e20000000: failed to match any schema with compatible: ['ti,j721s2-gpu', 'img,img-bxs-4-64', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: /bus@100000/gpu@4e20000000: failed to match any schema with compatible: ['ti,j721s2-gpu', 'img,img-bxs-4-64', 'img,img-rogue']
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: /bus@100000/gpu@4e20000000: failed to match any schema with compatible: ['ti,j721s2-gpu', 'img,img-bxs-4-64', 'img,img-rogue']

Re: [PATCH v3 1/2] arm64: dts: ti: k3-am62: New GPU binding details

[Nishanth Menon]

On 16:26-20250422, Matt Coster wrote:
> Use the new compatible string and power domain name as introduced in
> commit 2c01d9099859 ("dt-bindings: gpu: img: Future-proofing
> enhancements")[1].
> 
> [1]: https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-1-eda620c5865f@imgtec.com

Please remove the lore link in the commit message, commit sha
reference is sufficient, url could be used in the diffstat section to
provide reference.

> 
> Reviewed-by: Randolph Sapp <rs@ti.com>
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> ---
> Changes in v3:
> - None
> - Link to v2: https://lore.kernel.org/r/20250417-bxs-4-64-dts-v2-1-9f8c09233114@imgtec.com
> Changes in v2:
> - Add Randolph's Rb
> - Link to v1: https://lore.kernel.org/r/20250415-bxs-4-64-dts-v1-1-f7d3fa06625d@imgtec.com
> 
> This patch was previously sent as [DO NOT MERGE]:
> https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-17-eda620c5865f@imgtec.com
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 7d355aa73ea2116723735f70b9351cefcd8bc118..d17b25cae196b08d24adbe7c913ccaba7eed37eb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -691,12 +691,14 @@ ospi0: spi@fc40000 {
>  	};
>  
>  	gpu: gpu@fd00000 {
> -		compatible = "ti,am62-gpu", "img,img-axe";
> +		compatible = "ti,am62-gpu", "img,img-axe-1-16m", "img,img-axe",
> +			     "img,img-rogue";
>  		reg = <0x00 0x0fd00000 0x00 0x20000>;
>  		clocks = <&k3_clks 187 0>;
>  		clock-names = "core";
>  		interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>  		power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> +		power-domain-names = "a";
>  	};
>  
>  	cpsw3g: ethernet@8000000 {
> 
> -- 
> 2.49.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 2/2] arm64: dts: ti: k3-j721s2: Add GPU node

[Nishanth Menon]

On 16:26-20250422, Matt Coster wrote:
> The J721S2 binding is based on the TI downstream binding in commit
> 54b0f2a00d92 ("arm64: dts: ti: k3-j721s2-main: add gpu node") from [1]
> but with updated compatible strings.
> 
> The clock[2] and power[3] indices were verified from HTML docs, while
> the intterupt index comes from the TRM[4] (appendix
       ^^ spell check interrupt (please use checkpatch.pl --strict --codespell
to catch these minor nuisance bugs)

> "J721S2_Appendix_20241106_Public.xlsx", "Interrupts (inputs)",
> "GPU_BXS464_WRAP0_GPU_SS_0_OS_IRQ_OUT_0").
> 
> [1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel
> [2]: https://downloads.ti.com/tisci/esd/latest/5_soc_doc/j721s2/clocks.html
> [3]: https://downloads.ti.com/tisci/esd/latest/5_soc_doc/j721s2/devices.html
> [4]: https://www.ti.com/lit/zip/spruj28 (revision E)
> 
> Reviewed-by: Randolph Sapp <rs@ti.com>
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> ---
> Changes in v3:
> - Use assigned-clocks to pre-load the frequency of the core clock
> - Link to v2: https://lore.kernel.org/r/20250417-bxs-4-64-dts-v2-2-9f8c09233114@imgtec.com
> Changes in v2:
> - Add interrupt reference details
> - Add Randolph's Rb
> - Link to v1: https://lore.kernel.org/r/20250415-bxs-4-64-dts-v1-2-f7d3fa06625d@imgtec.com
> 
> This patch was previously sent as [DO NOT MERGE]:
> https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-18-eda620c5865f@imgtec.com
> ---
>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 92bf48fdbeba45ecca8c854db5f72fd3666239c5..9e36cbbe0ea2fefceedcc95b78068ded7ef395f0 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -2048,4 +2048,18 @@ watchdog8: watchdog@23f0000 {
>  		/* reserved for MAIN_R5F1_1 */
>  		status = "reserved";
>  	};
> +
> +	gpu: gpu@4e20000000 {
> +		compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
> +		reg = <0x4e 0x20000000 0x00 0x80000>;
> +		clocks = <&k3_clks 130 1>;
> +		clock-names = "core";
> +		assigned-clocks = <&k3_clks 130 1>;
> +		assigned-clock-rates = <800000000>;
> +		interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> +		power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>,
> +				<&k3_pds 373 TI_SCI_PD_EXCLUSIVE>;
> +		power-domain-names = "a", "b";
> +		dma-coherent;
> +	};
>  };
> 
> -- 
> 2.49.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D