[PATCH 0/2] firmware: arm_scmi: Minor cleanups and documentation fixes

[PATCH 0/2] firmware: arm_scmi: Minor cleanups and documentation fixes

[Artem Shimko]

Hello maintainers,

This small patch series addresses some minor issues found in the SCMI driver:

Patch 1 fixes alignment and indentation inconsistencies in two files:

Adjusts function parameter alignment in protocol_id_show()

Fixes debugfs call alignment in raw_mode.c for better readability

Patch 2 adds missing documentation for the xfer_lock spinlock that protects
access to xfer buffers and transfer allocation mechanism, making the code
more maintainable and easier to understand.

These are straightforward cleanups that don't change any functionality but
improve code quality and documentation.

Best regards,
Artem Shimko

Artem Shimko (2):
  firmware: arm_scmi: fix alignment in protocol_id_show and debugfs calls
  firmware: arm_scmi: add missing spinlock documentation

 drivers/firmware/arm_scmi/bus.c      | 2 +-
 drivers/firmware/arm_scmi/driver.c   | 1 +
 drivers/firmware/arm_scmi/raw_mode.c | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.43.0

[PATCH 1/2] firmware: arm_scmi: fix alignment in protocol_id_show and debugfs calls

[Artem Shimko]

This patch fixes minor alignment/indentation issues in the SCMI driver:
Adjusts indentation in protocol_id_show function to maintain consistency
Fixes alignment in debugfs_create_file_aux_num calls in raw_mode.c

Signed-off-by: Artem Shimko <artyom.shimko@gmail.com>
---
 drivers/firmware/arm_scmi/bus.c      | 2 +-
 drivers/firmware/arm_scmi/raw_mode.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
index 24e59ddf85e7..e1e82139997c 100644
--- a/drivers/firmware/arm_scmi/bus.c
+++ b/drivers/firmware/arm_scmi/bus.c
@@ -298,7 +298,7 @@ static ssize_t modalias_show(struct device *dev,
 static DEVICE_ATTR_RO(modalias);
 
 static ssize_t protocol_id_show(struct device *dev,
-				 struct device_attribute *attr, char *buf)
+				struct device_attribute *attr, char *buf)
 {
 	struct scmi_device *scmi_dev = to_scmi_dev(dev);
 
diff --git a/drivers/firmware/arm_scmi/raw_mode.c b/drivers/firmware/arm_scmi/raw_mode.c
index 73db5492ab44..c85647562ba3 100644
--- a/drivers/firmware/arm_scmi/raw_mode.c
+++ b/drivers/firmware/arm_scmi/raw_mode.c
@@ -1280,8 +1280,8 @@ void *scmi_raw_mode_init(const struct scmi_handle *handle,
 			chd = debugfs_create_dir(cdir, top_chans);
 
 			debugfs_create_file_aux_num("message", 0600, chd,
-					    raw, channels[i],
-					    &scmi_dbg_raw_mode_message_fops);
+						    raw, channels[i],
+						    &scmi_dbg_raw_mode_message_fops);
 
 			debugfs_create_file_aux_num("message_async", 0600, chd,
 					    raw, channels[i],
-- 
2.43.0

[PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation

[Artem Shimko]

Adds a missing comment for xfer_lock spinlock in struct scmi_xfers_info.
The spinlock protects access to the xfer buffers and transfer allocation
mechanism, preventing race conditions in concurrent access scenarios.

Signed-off-by: Artem Shimko <artyom.shimko@gmail.com>
---
 drivers/firmware/arm_scmi/driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index bd56a877fdfc..6828392152f4 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -76,6 +76,7 @@ static struct dentry *scmi_top_dentry;
  */
 struct scmi_xfers_info {
 	unsigned long *xfer_alloc_table;
+	/* Protects access to the xfer buffers */
 	spinlock_t xfer_lock;
 	int max_msg;
 	struct hlist_head free_xfers;
-- 
2.43.0

Re: [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation

[Sudeep Holla]

On Mon, Sep 01, 2025 at 07:12:04PM +0300, Artem Shimko wrote:
> Adds a missing comment for xfer_lock spinlock in struct scmi_xfers_info.
> The spinlock protects access to the xfer buffers and transfer allocation
> mechanism, preventing race conditions in concurrent access scenarios.
> 
> Signed-off-by: Artem Shimko <artyom.shimko@gmail.com>
> ---
>  drivers/firmware/arm_scmi/driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index bd56a877fdfc..6828392152f4 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -76,6 +76,7 @@ static struct dentry *scmi_top_dentry;
>   */
>  struct scmi_xfers_info {
>  	unsigned long *xfer_alloc_table;
> +	/* Protects access to the xfer buffers */

Thanks for your patch but this is quite obvious and I see no point in
just adding this comment.

-- 
Regards,
Sudeep

Re: [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation

[Artem Shimko]

Hi Sudeep,

Thank you for the review and your feedback on my SCMI patch!
I really appreciate you taking the time to look at it.

Best regards,
Artem Shimko