[PATCH 1/2] dt-bindings: reset: microchip: Add LAN969x support

[PATCH 1/2] dt-bindings: reset: microchip: Add LAN969x support

[Robert Marko]

LAN969x also uses the Microchip reset driver, so document its compatible.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 Documentation/devicetree/bindings/reset/microchip,rst.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
index f2da0693b05a..4d4dd47f830e 100644
--- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
+++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
@@ -23,6 +23,7 @@ properties:
     enum:
       - microchip,sparx5-switch-reset
       - microchip,lan966x-switch-reset
+      - microchip,lan969x-switch-reset
 
   reg:
     items:
-- 
2.51.0

[PATCH 2/2] reset: sparx5: add LAN969x support

[Robert Marko]

LAN969x uses the same reset configuration as LAN966x so lets add support
for it as well.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 drivers/reset/Kconfig                  | 2 +-
 drivers/reset/reset-microchip-sparx5.c | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 78b7078478d4..35cb84d1de4e 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -170,7 +170,7 @@ config RESET_LPC18XX
 
 config RESET_MCHP_SPARX5
 	tristate "Microchip Sparx5 reset driver"
-	depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
+	depends on ARCH_SPARX5 || ARCH_LAN969X ||SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
 	default y if SPARX5_SWITCH
 	select MFD_SYSCON
 	help
diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
index 6d3e75b33260..28ad8f1298a0 100644
--- a/drivers/reset/reset-microchip-sparx5.c
+++ b/drivers/reset/reset-microchip-sparx5.c
@@ -198,6 +198,9 @@ static const struct of_device_id mchp_sparx5_reset_of_match[] = {
 	}, {
 		.compatible = "microchip,lan966x-switch-reset",
 		.data = &reset_props_lan966x,
+	}, {
+		.compatible = "microchip,lan969x-switch-reset",
+		.data = &reset_props_lan966x,
 	},
 	{ }
 };
-- 
2.51.0

Re: [PATCH 2/2] reset: sparx5: add LAN969x support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

On Wed, Sep 17, 2025 at 01:12:36PM +0200, Robert Marko wrote:
> LAN969x uses the same reset configuration as LAN966x so lets add support
> for it as well.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  drivers/reset/Kconfig                  | 2 +-
>  drivers/reset/reset-microchip-sparx5.c | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 78b7078478d4..35cb84d1de4e 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -170,7 +170,7 @@ config RESET_LPC18XX
>  
>  config RESET_MCHP_SPARX5
>  	tristate "Microchip Sparx5 reset driver"
> -	depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
> +	depends on ARCH_SPARX5 || ARCH_LAN969X ||SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
                                                 ^ missing space here.

>  	default y if SPARX5_SWITCH
>  	select MFD_SYSCON
>  	help
> diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
> index 6d3e75b33260..28ad8f1298a0 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -198,6 +198,9 @@ static const struct of_device_id mchp_sparx5_reset_of_match[] = {
>  	}, {
>  		.compatible = "microchip,lan966x-switch-reset",
>  		.data = &reset_props_lan966x,
> +	}, {
> +		.compatible = "microchip,lan969x-switch-reset",
> +		.data = &reset_props_lan966x,

These are identically handled, a fallback compatible will suffice.

>  	},
>  	{ }
>  };
> -- 
> 2.51.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] reset: sparx5: add LAN969x support

[Daniel Machon]

Hi Robert,

> LAN969x uses the same reset configuration as LAN966x so lets add support
> for it as well.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  drivers/reset/Kconfig                  | 2 +-
>  drivers/reset/reset-microchip-sparx5.c | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 78b7078478d4..35cb84d1de4e 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -170,7 +170,7 @@ config RESET_LPC18XX
> 
>  config RESET_MCHP_SPARX5
>         tristate "Microchip Sparx5 reset driver"
> -       depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
> +       depends on ARCH_SPARX5 || ARCH_LAN969X ||SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST

Missing space at ||SOC_LAN966.

>         default y if SPARX5_SWITCH
>         select MFD_SYSCON
>         help
> diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
> index 6d3e75b33260..28ad8f1298a0 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -198,6 +198,9 @@ static const struct of_device_id mchp_sparx5_reset_of_match[] = {
>         }, {
>                 .compatible = "microchip,lan966x-switch-reset",
>                 .data = &reset_props_lan966x,
> +       }, {
> +               .compatible = "microchip,lan969x-switch-reset",
> +               .data = &reset_props_lan966x,
>         },
>         { }
>  };
> --
> 2.51.0
> 

When upstreaming support for the other SoC peripherals [1] [2], I got some
push-back on the use of wildcards in the compatible string. Instead, we used a
fallback, which is the accepted ways of expressing the individual SKU's.

This boils down to: using the lan9691-switch-reset compatible string, and
documenting each individual SKU in the bindings, with a fallback to lan9691.
The linked patches should give you and idea.

[1] https://lore.kernel.org/linux-gpio/20240917-lan969x-pinctrl-v2-1-ea02cbc56831@microchip.com/
[2] https://lore.kernel.org/linux-clk/20240916-lan969x-clock-v1-1-0e150336074d@microchip.com/

/Daniel

Re: [PATCH 1/2] dt-bindings: reset: microchip: Add LAN969x support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

On Wed, Sep 17, 2025 at 01:12:35PM +0200, Robert Marko wrote:
> LAN969x also uses the Microchip reset driver, so document its compatible.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  Documentation/devicetree/bindings/reset/microchip,rst.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> index f2da0693b05a..4d4dd47f830e 100644
> --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> @@ -23,6 +23,7 @@ properties:
>      enum:
>        - microchip,sparx5-switch-reset
>        - microchip,lan966x-switch-reset
> +      - microchip,lan969x-switch-reset

Driver patch makes a fallback compatible seem usable.

>  
>    reg:
>      items:
> -- 
> 2.51.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: reset: microchip: Add LAN969x support

[Robert Marko]

On Wed, Sep 17, 2025 at 7:38 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Sep 17, 2025 at 01:12:35PM +0200, Robert Marko wrote:
> > LAN969x also uses the Microchip reset driver, so document its compatible.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> >  Documentation/devicetree/bindings/reset/microchip,rst.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > index f2da0693b05a..4d4dd47f830e 100644
> > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > @@ -23,6 +23,7 @@ properties:
> >      enum:
> >        - microchip,sparx5-switch-reset
> >        - microchip,lan966x-switch-reset
> > +      - microchip,lan969x-switch-reset
>
> Driver patch makes a fallback compatible seem usable.

Hi Conor,
Will respin to simply use the fallback compatible, that will avoid
adding more compatibles to the driver
for no reason.

But, can I ask what do you think about the
microchip,lan969x-switch-reset compatible?
Is lan969x fine or should I just make it lan9691 or like cause the
whole series uses the same
reset setup?

Regards,
Robert
>
> >
> >    reg:
> >      items:
> > --
> > 2.51.0
> >



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

Re: [PATCH 1/2] dt-bindings: reset: microchip: Add LAN969x support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

On Thu, Sep 18, 2025 at 01:45:32PM +0200, Robert Marko wrote:
> On Wed, Sep 17, 2025 at 7:38 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Sep 17, 2025 at 01:12:35PM +0200, Robert Marko wrote:
> > > LAN969x also uses the Microchip reset driver, so document its compatible.
> > >
> > > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > > ---
> > >  Documentation/devicetree/bindings/reset/microchip,rst.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > > index f2da0693b05a..4d4dd47f830e 100644
> > > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > > @@ -23,6 +23,7 @@ properties:
> > >      enum:
> > >        - microchip,sparx5-switch-reset
> > >        - microchip,lan966x-switch-reset
> > > +      - microchip,lan969x-switch-reset
> >
> > Driver patch makes a fallback compatible seem usable.
> 
> Hi Conor,
> Will respin to simply use the fallback compatible, that will avoid
> adding more compatibles to the driver
> for no reason.
> 
> But, can I ask what do you think about the
> microchip,lan969x-switch-reset compatible?
> Is lan969x fine or should I just make it lan9691 or like cause the
> whole series uses the same
> reset setup?

I'd rather the 1, I thought that the x was part of the name for some
reason.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]