From: Jason Gunthorpe <jgg@ziepe.ca>
To: Will Deacon <will@kernel.org>
Cc: Shyam Saini <shyamsaini@linux.microsoft.com>,
thierry.reding@gmail.com, robin.murphy@arm.com, robh@kernel.org,
joro@8bytes.org, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
virtualization@lists.linux.dev, jacob.pan@linux.microsoft.com,
eric.auger@redhat.com, code@tyhicks.com,
eahariha@linux.microsoft.com, vijayb@linux.microsoft.com,
bboscaccy@linux.microsoft.com, saravanak@google.com,
krzk+dt@kernel.org, conor+dt@kernel.org, lizhi.hou@amd.com,
clement.leger@bootlin.com
Subject: Re: [PATCH v4 3/4] arm-smmu: select suitable MSI IOVA
Date: Thu, 18 Sep 2025 19:43:22 -0300 [thread overview]
Message-ID: <20250918224322.GR1326709@ziepe.ca> (raw)
In-Reply-To: <aMw4I0AjKNPY6SOw@willie-the-truck>
On Thu, Sep 18, 2025 at 05:49:39PM +0100, Will Deacon wrote:
> Given that we're walking over the reserved regions to see if we have a
> collision with MSI_IOVA_BASE, why not allocate the base address
> dynamically if we detect a collision rather than having yet another
> hard-coded address which we can't guarantee won't be problematic in future?
I'm nervous about this. Right now the MSI_IOVA is actually UAPI and
things like VFIO/qmeu need to accomodate it's placement in their own
memory maps.
Nicolin has some patches on the iommufd side to let userspace select
the MSI address instead, but they are not done yet.
So, randomly picking an address sounds like a bad idea to me, it would
almost certainly unpredictably break qemu..
Hopefully by the time we need a 3rd one we have the userspace MSI
control and then we could make reasonably make the kernel
automatically select.
Jason
next prev parent reply other threads:[~2025-09-18 22:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 15:45 [PATCH v4 0/4] arm-smmu: select suitable MSI IOVA Shyam Saini
2025-09-09 15:45 ` [PATCH v4 1/4] arm-smmu: move MSI_IOVA macro definitions Shyam Saini
2025-09-09 15:45 ` [PATCH v4 2/4] iommu/of: fix device tree configuration for PCI devices Shyam Saini
2025-09-24 17:44 ` Robin Murphy
2025-09-09 15:45 ` [PATCH v4 3/4] arm-smmu: select suitable MSI IOVA Shyam Saini
2025-09-18 16:49 ` Will Deacon
2025-09-18 22:43 ` Jason Gunthorpe [this message]
2025-09-19 7:33 ` Will Deacon
2025-09-19 12:08 ` Jason Gunthorpe
2025-09-23 15:56 ` Shyam Saini
2025-09-23 16:19 ` Jason Gunthorpe
2025-09-24 18:59 ` Robin Murphy
2025-09-09 15:46 ` [PATCH v4 4/4] drivers: iommu: refactor arm_smmu_get_resv_regions Shyam Saini
2025-09-09 15:58 ` Jason Gunthorpe
2025-09-15 16:28 ` Shyam Saini
2025-09-15 22:59 ` Jason Gunthorpe
2025-09-13 0:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918224322.GR1326709@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bboscaccy@linux.microsoft.com \
--cc=clement.leger@bootlin.com \
--cc=code@tyhicks.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eahariha@linux.microsoft.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lizhi.hou@amd.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=shyamsaini@linux.microsoft.com \
--cc=thierry.reding@gmail.com \
--cc=vijayb@linux.microsoft.com \
--cc=virtualization@lists.linux.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox