[PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[Jack Hsu]

In this patch series, 
we add Mediatek MT8189 evaluation board dts, dtsi and Makefile,
and also related dt-binding documents.

based on tag: next-20251029

Note:
This patch series depends on following dt-binding headers and yamls
1.dt-binding headers
  1. mt8189-pinfunc.h
       https://patchwork.kernel.org/project/linux-mediatek/patch/20250919020525.7904-1-ot_cathy.xu@mediatek.com/
  2. mt8189_gce.h 
       https://patchwork.kernel.org/project/linux-mediatek/patch/20250820093831.23437-3-xiandong.wang@mediatek.com/ 
  
2.dt-binding yamls
  1. smi-common.yaml, smi-larb.yaml
        https://patchwork.kernel.org/project/linux-mediatek/patch/20251027121443.16783-2-zhengnan.chen@mediatek.com/
  2. mediatek,gce-mailbox.yaml
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250820093831.23437-2-xiandong.wang@mediatek.com/
  3. mediatek,ufs.yaml
        https://patchwork.kernel.org/project/linux-scsi/patch/20251016-mt8196-ufs-v2-1-c373834c4e7a@collabora.com/
  4. mediatek,iommu.yaml  
        https://lore.kernel.org/linux-mediatek/20251018132625.14428-2-zhengnan.chen@mediatek.com/
  5. gce-mailbox.yaml
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250820093831.23437-2-xiandong.wang@mediatek.com/
  6. disp_isp yamls
        https://lore.kernel.org/linux-mediatek/20251020074211.8942-1-xiandong.wang@mediatek.com/
  7. jpeg yaml
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250528095748.17485-2-jianhua.lin@mediatek.com/  
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250528095748.17485-3-jianhua.lin@mediatek.com/   
  8. vcodec yaml
        https://lore.kernel.org/linux-mediatek/20251016060747.20648-2-kyrie.wu@mediatek.com/      
        https://lore.kernel.org/linux-mediatek/20251016060747.20648-8-kyrie.wu@mediatek.com/ 
  9. mtk-sd.yaml
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250818114855.8637-1-mengqi.zhang@mediatek.com/   
  10. mtk,scp.yaml
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250924084422.4604-2-huayu.zong@mediatek.com/
  11. pwrap/spmi yaml  
        https://patchwork.kernel.org/project/linux-mediatek/patch/20250801070913.3109-2-niklaus.liu@mediatek.com/
  12. mt8189-nau8825.yaml
        https://lore.kernel.org/linux-mediatek/20250905071659.25805-10-Cyril.Chao@mediatek.com/
  13. mt8189-afe-pcm.yaml           
        https://lore.kernel.org/linux-mediatek/20250905071659.25805-8-Cyril.Chao@mediatek.com/
  14. mediatek,ufs.yaml
        https://patchwork.kernel.org/project/linux-scsi/patch/20251016-mt8196-ufs-v2-1-c373834c4e7a@collabora.com/


---
Changs in v6:
 - add/fix dt-bindings for mt8189 dts node
 - add pmic mt63xx dtsi for mt8189 evb board
 - add complete device node of mt8189 evb board
 - Fix previous version review comments
 - Link to v5: https://patchwork.kernel.org/project/linux-mediatek/cover/20250718075630.644870-1-sirius.wang@mediatek.com/

Changs in v5:
 - remove unused cpu-dile-state definition.
 - change memory size in "reg" property which if filled in by bootloader.

Changs in v4:
 - Correct cpu-idle-states.
 - Change the "reg" property name of the "memory" node in the
   device tree source (DTS) to lowercase.

Changs in v3:
 - Move ulposc and ulposc3 before cpu nodes.
 - Refactor cpu-map to a single cluster0.
 - Change cpu nodes name from medium core to big core.
 - Move psci before timer nodes.

Changs in v2:
 - Fix warning issues for make CHECK_DTBS=y.
 - Add mediatek,uart.yaml document.

---

Jack Hsu (11):
  dt-bindings: arm: Add compatible for MediaTek MT8189
  dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc
  dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse
  dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm
  dt-bindings: serial: Support MediaTek MT8189 evb board uart
  dt-bindings: timer: Support MediaTek MT8189 evb board timer
  dt-bindings: usb: Support MediaTek MT8189 evb board xhci
  dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt
  arm64: dts: mediatek: Add MT6319 PMIC Support
  arm64: dts: mediatek: add properties for MT6359
  arm64: dts: mediatek: Add mt8189 evaluation board dts

 .../devicetree/bindings/arm/mediatek.yaml     |    4 +
 .../iio/adc/mediatek,mt2701-auxadc.yaml       |    1 +
 .../bindings/nvmem/mediatek,efuse.yaml        |    1 +
 .../bindings/pwm/mediatek,pwm-disp.yaml       |    1 +
 .../bindings/serial/mediatek,uart.yaml        |    1 +
 .../bindings/timer/mediatek,timer.yaml        |    1 +
 .../bindings/usb/mediatek,mtk-xhci.yaml       |    7 +-
 .../bindings/watchdog/mediatek,mtk-wdt.yaml   |    1 +
 arch/arm64/boot/dts/mediatek/Makefile         |    1 +
 arch/arm64/boot/dts/mediatek/mt6319.dtsi      |   66 +
 arch/arm64/boot/dts/mediatek/mt6359.dtsi      |   20 +
 arch/arm64/boot/dts/mediatek/mt8189-evb.dts   | 1082 ++++++
 arch/arm64/boot/dts/mediatek/mt8189.dtsi      | 3014 +++++++++++++++++
 include/dt-bindings/iio/mt635x-auxadc.h       |   50 +
 14 files changed, 4249 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt6319.dtsi
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8189-evb.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8189.dtsi
 create mode 100644 include/dt-bindings/iio/mt635x-auxadc.h

-- 
2.45.2

[PATCH v6 01/11] dt-bindings: arm: Add compatible for MediaTek MT8189

[Jack Hsu]

This commit adds dt-binding documentation for the MediaTek MT8189
reference board.

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 7401c7cfd3ca..5fb30da8762e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -383,6 +383,10 @@ properties:
           - enum:
               - mediatek,mt8188-evb
           - const: mediatek,mt8188
+      - items:
+          - enum:
+              - mediatek,mt8189-evb
+          - const: mediatek,mt8189
       - description: Google Hayato
         items:
           - const: google,hayato-rev1
-- 
2.45.2

[PATCH v6 02/11] dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc

[Jack Hsu]

add compatible string for mt8189 evb board dts node of auxadc

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 .../devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml      | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
index 14363389f30a..d9e825e5054f 100644
--- a/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
@@ -42,6 +42,7 @@ properties:
               - mediatek,mt8183-auxadc
               - mediatek,mt8186-auxadc
               - mediatek,mt8188-auxadc
+              - mediatek,mt8189-auxadc
               - mediatek,mt8195-auxadc
               - mediatek,mt8516-auxadc
           - const: mediatek,mt8173-auxadc
-- 
2.45.2

[PATCH v6 03/11] dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse

[Jack Hsu]

add compatible string for mt8189 evb board dts node of efuse

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
index 4dc0d42df3e6..9d52caaf3e5c 100644
--- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
+++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
@@ -48,6 +48,7 @@ properties:
               - mediatek,mt7988-efuse
               - mediatek,mt8173-efuse
               - mediatek,mt8183-efuse
+              - mediatek,mt8189-efuse
               - mediatek,mt8192-efuse
               - mediatek,mt8195-efuse
               - mediatek,mt8516-efuse
-- 
2.45.2

[PATCH v6 04/11] dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm

[Jack Hsu]

add compatible string for mt8189 evb board dts node of disp-pwm

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 68ef30414325..22712769518b 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -30,6 +30,7 @@ properties:
               - mediatek,mt6893-disp-pwm
               - mediatek,mt8186-disp-pwm
               - mediatek,mt8188-disp-pwm
+              - mediatek,mt8189-disp-pwm
               - mediatek,mt8192-disp-pwm
               - mediatek,mt8195-disp-pwm
               - mediatek,mt8365-disp-pwm
-- 
2.45.2

[PATCH v6 05/11] dt-bindings: serial: Support MediaTek MT8189 evb board uart

[Jack Hsu]

add compatible string for mt8189 evb board dts node of uart

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/devicetree/bindings/serial/mediatek,uart.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/mediatek,uart.yaml b/Documentation/devicetree/bindings/serial/mediatek,uart.yaml
index 5bd8a8853ae0..3f0f4aea0a4c 100644
--- a/Documentation/devicetree/bindings/serial/mediatek,uart.yaml
+++ b/Documentation/devicetree/bindings/serial/mediatek,uart.yaml
@@ -47,6 +47,7 @@ properties:
               - mediatek,mt8183-uart
               - mediatek,mt8186-uart
               - mediatek,mt8188-uart
+              - mediatek,mt8189-uart
               - mediatek,mt8192-uart
               - mediatek,mt8195-uart
               - mediatek,mt8365-uart
-- 
2.45.2

[PATCH v6 06/11] dt-bindings: timer: Support MediaTek MT8189 evb board timer

[Jack Hsu]

add compatible string for mt8189 evb board dts node of timer

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 Documentation/devicetree/bindings/timer/mediatek,timer.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/mediatek,timer.yaml b/Documentation/devicetree/bindings/timer/mediatek,timer.yaml
index 337580dc77d8..8e705fe58dc5 100644
--- a/Documentation/devicetree/bindings/timer/mediatek,timer.yaml
+++ b/Documentation/devicetree/bindings/timer/mediatek,timer.yaml
@@ -44,6 +44,7 @@ properties:
               - mediatek,mt8183-timer
               - mediatek,mt8186-timer
               - mediatek,mt8188-timer
+              - mediatek,mt8189-timer
               - mediatek,mt8192-timer
               - mediatek,mt8195-timer
               - mediatek,mt8196-timer
-- 
2.45.2

[PATCH v6 07/11] dt-bindings: usb: Support MediaTek MT8189 evb board xhci

[Jack Hsu]

modify dt-binding for support mt8189 evb board dts node of xhci

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml         | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
index 004d3ebec091..05cb6a219e5c 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
@@ -34,6 +34,7 @@ properties:
           - mediatek,mt8183-xhci
           - mediatek,mt8186-xhci
           - mediatek,mt8188-xhci
+          - mediatek,mt8189-xhci
           - mediatek,mt8192-xhci
           - mediatek,mt8195-xhci
           - mediatek,mt8365-xhci
@@ -119,6 +120,9 @@ properties:
   resets:
     maxItems: 1
 
+  reset-names:
+    maxItems: 1
+
   usb3-lpm-capable: true
 
   usb2-lpm-disable: true
@@ -168,7 +172,8 @@ properties:
             104 - used by mt8195, IP1, specific 1.04;
             105 - used by mt8195, IP2, specific 1.05;
             106 - used by mt8195, IP3, specific 1.06;
-          enum: [1, 2, 101, 102, 103, 104, 105, 106]
+            110 - used by mt8189, IP4, specific 1.10;
+          enum: [1, 2, 101, 102, 103, 104, 105, 106, 110]
 
   mediatek,u3p-dis-msk:
     $ref: /schemas/types.yaml#/definitions/uint32
-- 
2.45.2

[PATCH v6 08/11] dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt

[Jack Hsu]

modify dt-binding for support mt8189 evb board dts node of wdt

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
index ba0bfd73ab62..a05f8155b738 100644
--- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
@@ -41,6 +41,7 @@ properties:
               - mediatek,mt7623-wdt
               - mediatek,mt7629-wdt
               - mediatek,mt8173-wdt
+              - mediatek,mt8188-wdt
               - mediatek,mt8365-wdt
               - mediatek,mt8516-wdt
           - const: mediatek,mt6589-wdt
-- 
2.45.2

[PATCH v6 09/11] arm64: dts: mediatek: Add MT6319 PMIC Support

[Jack Hsu]

Add support for MediaTek MT6319 PMIC IC

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt6319.dtsi | 66 ++++++++++++++++++++++++
 1 file changed, 66 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt6319.dtsi

diff --git a/arch/arm64/boot/dts/mediatek/mt6319.dtsi b/arch/arm64/boot/dts/mediatek/mt6319.dtsi
new file mode 100644
index 000000000000..8b2386547508
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt6319.dtsi
@@ -0,0 +1,66 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (c) 2025 MediaTek Inc.
+ */
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi {
+	mt6319_7: mt6319@7 {
+		compatible = "mediatek,mt6315-regulator";
+		buck1-modeset-mask = <0x3>;
+		reg = <0x7 SPMI_USID>;
+
+		regulators {
+			mt6319_7_vbuck1: vbuck1 {
+				regulator-name = "vbuck1";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+			mt6319_7_vbuck2: vbuck2 {
+				regulator-name = "vbuck2";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+			mt6319_7_vbuck3: vbuck3 {
+				regulator-name = "vbuck3";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+			mt6319_7_vbuck4: vbuck4 {
+				regulator-name = "vbuck4";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+		};
+	};
+
+	mt6319_8: mt6319@8 {
+		compatible = "mediatek,mt6315-regulator";
+		buck1-modeset-mask = <0xb>;
+		reg = <0x8 SPMI_USID>;
+
+		regulators {
+			mt6319_8_vbuck1: vbuck1 {
+				regulator-name = "vbuck1";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+			mt6319_8_vbuck2: vbuck2 {
+				regulator-name = "vbuck2";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+			mt6319_8_vbuck3: vbuck3 {
+				regulator-name = "vbuck3";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+			mt6319_8_vbuck4: vbuck4 {
+				regulator-name = "vbuck4";
+				regulator-allowed-modes = <0 1 2>;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
-- 
2.45.2

[PATCH v6 10/11] arm64: dts: mediatek: add properties for MT6359

[Jack Hsu]

Add properties of rtc fg (Fuel Gauge), external crystal
and auxadc definition for mt6359 pmic.

Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt6359.dtsi | 20 ++++++++++
 include/dt-bindings/iio/mt635x-auxadc.h  | 50 ++++++++++++++++++++++++
 2 files changed, 70 insertions(+)
 create mode 100644 include/dt-bindings/iio/mt635x-auxadc.h

diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 467d8a4c2aa7..cc7053bdd292 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -3,6 +3,8 @@
  * Copyright (C) 2022 MediaTek Inc.
  */
 
+#include <dt-bindings/iio/mt635x-auxadc.h>
+
 &pwrap {
 	pmic: pmic {
 		compatible = "mediatek,mt6359";
@@ -302,6 +304,24 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
 
 		mt6359rtc: rtc {
 			compatible = "mediatek,mt6358-rtc";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			status = "disabled";
+
+			fginit: fginit {
+				reg = <0 0x1>;
+				bits = <0 8>;
+			};
+
+			fgsoc: fgsoc {
+				reg = <1 0x1>;
+				bits = <0 8>;
+			};
+
+			ext32k: ext32k {
+				reg = <2 0x1>;
+				bits = <6 1>;
+			};
 		};
 	};
 };
diff --git a/include/dt-bindings/iio/mt635x-auxadc.h b/include/dt-bindings/iio/mt635x-auxadc.h
new file mode 100644
index 000000000000..69ba13a7b9ec
--- /dev/null
+++ b/include/dt-bindings/iio/mt635x-auxadc.h
@@ -0,0 +1,50 @@
+/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
+/*
+ * Copyright (c) 2020 MediaTek Inc.
+ */
+
+#ifndef _DT_BINDINGS_MT635X_AUXADC_H
+#define _DT_BINDINGS_MT635X_AUXADC_H
+
+/* PMIC MT635x AUXADC channels */
+#define AUXADC_BATADC				0x00
+#define AUXADC_ISENSE				0x01
+#define AUXADC_VCDT	    			0x02
+#define AUXADC_BAT_TEMP				0x03
+#define AUXADC_BATID				0x04
+#define AUXADC_CHIP_TEMP			0x05
+#define AUXADC_VCORE_TEMP			0x06
+#define AUXADC_VPROC_TEMP			0x07
+#define AUXADC_VGPU_TEMP			0x08
+#define AUXADC_ACCDET				0x09
+#define AUXADC_VDCXO				0x0a
+#define AUXADC_TSX_TEMP				0x0b
+#define AUXADC_HPOFS_CAL			0x0c
+#define AUXADC_DCXO_TEMP			0x0d
+#define AUXADC_VBIF		    		0x0e
+#define AUXADC_IMP			    	0x0f
+#define AUXADC_IMIX_R				0x10
+#define AUXADC_VTREF				0x11
+#define AUXADC_VSYSSNS				0x12
+#define AUXADC_VIN1				    0x13
+#define AUXADC_VIN2			    	0x14
+#define AUXADC_VIN3			    	0x15
+#define AUXADC_VIN4			    	0x16
+#define AUXADC_VIN5			    	0x17
+#define AUXADC_VIN6			    	0x18
+#define AUXADC_VIN7		            0x19
+
+#define AUXADC_CHAN_MIN				AUXADC_BATADC
+#define AUXADC_CHAN_MAX				AUXADC_VIN7
+
+#define ADC_PURES_100K				(0)
+#define ADC_PURES_30K				(1)
+#define ADC_PURES_400K				(2)
+#define ADC_PURES_OPEN				(3)
+
+#define ADC_PURES_100K_MASK			(ADC_PURES_100K << 8)
+#define ADC_PURES_30K_MASK			(ADC_PURES_30K << 8)
+#define ADC_PURES_400K_MASK			(ADC_PURES_400K << 8)
+#define ADC_PURES_OPEN_MASK			(ADC_PURES_OPEN << 8)
+
+#endif /* _DT_BINDINGS_MT635X_AUXADC_H */
-- 
2.45.2

Re: [PATCH v6 04/11] dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

On Thu, Oct 30, 2025 at 09:44:36PM +0800, Jack Hsu wrote:
> add compatible string for mt8189 evb board dts node of disp-pwm
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>

LGTM. Assuming this patch will go in together with the other patches
from this series via arm-soc:

Acked-by: Uwe Kleine-König <ukleinek@kernel.org>

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v6 01/11] dt-bindings: arm: Add compatible for MediaTek MT8189

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On Thu, Oct 30, 2025 at 09:44:33PM +0800, Jack Hsu wrote:
> This commit adds dt-binding documentation for the MediaTek MT8189
> reference board.
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 06/11] dt-bindings: timer: Support MediaTek MT8189 evb board timer

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

On Thu, Oct 30, 2025 at 09:44:38PM +0800, Jack Hsu wrote:
> add compatible string for mt8189 evb board dts node of timer
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 02/11] dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 03/11] dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 07/11] dt-bindings: usb: Support MediaTek MT8189 evb board xhci

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

On Thu, Oct 30, 2025 at 09:44:39PM +0800, Jack Hsu wrote:
> modify dt-binding for support mt8189 evb board dts node of xhci
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
>  .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml         | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index 004d3ebec091..05cb6a219e5c 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -34,6 +34,7 @@ properties:
>            - mediatek,mt8183-xhci
>            - mediatek,mt8186-xhci
>            - mediatek,mt8188-xhci
> +          - mediatek,mt8189-xhci
>            - mediatek,mt8192-xhci
>            - mediatek,mt8195-xhci
>            - mediatek,mt8365-xhci
> @@ -119,6 +120,9 @@ properties:
>    resets:
>      maxItems: 1
>  
> +  reset-names:
> +    maxItems: 1

Is this reset required on mt8189? Does it appear on other mediatek xhci
controllers?

> +
>    usb3-lpm-capable: true
>  
>    usb2-lpm-disable: true
> @@ -168,7 +172,8 @@ properties:
>              104 - used by mt8195, IP1, specific 1.04;
>              105 - used by mt8195, IP2, specific 1.05;
>              106 - used by mt8195, IP3, specific 1.06;
> -          enum: [1, 2, 101, 102, 103, 104, 105, 106]
> +            110 - used by mt8189, IP4, specific 1.10;
> +          enum: [1, 2, 101, 102, 103, 104, 105, 106, 110]
>  
>    mediatek,u3p-dis-msk:
>      $ref: /schemas/types.yaml#/definitions/uint32
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 08/11] dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

On Thu, Oct 30, 2025 at 09:44:40PM +0800, Jack Hsu wrote:
> modify dt-binding for support mt8189 evb board dts node of wdt
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 09/11] arm64: dts: mediatek: Add MT6319 PMIC Support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On Thu, Oct 30, 2025 at 09:44:41PM +0800, Jack Hsu wrote:
> Add support for MediaTek MT6319 PMIC IC
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt6319.dtsi | 66 ++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6319.dtsi
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6319.dtsi b/arch/arm64/boot/dts/mediatek/mt6319.dtsi
> new file mode 100644
> index 000000000000..8b2386547508
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt6319.dtsi
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2025 MediaTek Inc.
> + */
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi {
> +	mt6319_7: mt6319@7 {

Shouldn't this be something like "pmic@" or "regulator@"? mt6319 is not
a type of device. The binding example uses pmic.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 04/11] dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

On Thu, Oct 30, 2025 at 09:44:36PM +0800, Jack Hsu wrote:
> add compatible string for mt8189 evb board dts node of disp-pwm
> 

This commit message isn't accurate, and that makes me wonder if the
others are. This has nothing to do with the "evb board", this compatible
is for the mt8189, on whatever board it happens to be on. Please drop
all mention of the evb board from commit messages.
With it gone,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: changes-requested

> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> index 68ef30414325..22712769518b 100644
> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -30,6 +30,7 @@ properties:
>                - mediatek,mt6893-disp-pwm
>                - mediatek,mt8186-disp-pwm
>                - mediatek,mt8188-disp-pwm
> +              - mediatek,mt8189-disp-pwm
>                - mediatek,mt8192-disp-pwm
>                - mediatek,mt8195-disp-pwm
>                - mediatek,mt8365-disp-pwm
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 10/11] arm64: dts: mediatek: add properties for MT6359

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 3932 bytes --]

On Thu, Oct 30, 2025 at 09:44:42PM +0800, Jack Hsu wrote:
> Add properties of rtc fg (Fuel Gauge), external crystal
> and auxadc definition for mt6359 pmic.
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi | 20 ++++++++++
>  include/dt-bindings/iio/mt635x-auxadc.h  | 50 ++++++++++++++++++++++++
>  2 files changed, 70 insertions(+)
>  create mode 100644 include/dt-bindings/iio/mt635x-auxadc.h
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> index 467d8a4c2aa7..cc7053bdd292 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> @@ -3,6 +3,8 @@
>   * Copyright (C) 2022 MediaTek Inc.
>   */
>  
> +#include <dt-bindings/iio/mt635x-auxadc.h>
> +
>  &pwrap {
>  	pmic: pmic {
>  		compatible = "mediatek,mt6359";
> @@ -302,6 +304,24 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
>  
>  		mt6359rtc: rtc {
>  			compatible = "mediatek,mt6358-rtc";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			status = "disabled";
> +
> +			fginit: fginit {
> +				reg = <0 0x1>;
> +				bits = <0 8>;
> +			};

Uhhhh, what on earth is going on here? This is an RTC, what does
fuelgauge stuff have to do with it? Did you test this at all? What does
it even do? Very confused.

> +
> +			fgsoc: fgsoc {
> +				reg = <1 0x1>;
> +				bits = <0 8>;
> +			};
> +
> +			ext32k: ext32k {
> +				reg = <2 0x1>;
> +				bits = <6 1>;
> +			};
>  		};
>  	};
>  };
> diff --git a/include/dt-bindings/iio/mt635x-auxadc.h b/include/dt-bindings/iio/mt635x-auxadc.h
> new file mode 100644
> index 000000000000..69ba13a7b9ec
> --- /dev/null
> +++ b/include/dt-bindings/iio/mt635x-auxadc.h
> @@ -0,0 +1,50 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
> +/*
> + * Copyright (c) 2020 MediaTek Inc.
> + */
> +
> +#ifndef _DT_BINDINGS_MT635X_AUXADC_H
> +#define _DT_BINDINGS_MT635X_AUXADC_H
> +
> +/* PMIC MT635x AUXADC channels */
> +#define AUXADC_BATADC				0x00
> +#define AUXADC_ISENSE				0x01
> +#define AUXADC_VCDT	    			0x02
> +#define AUXADC_BAT_TEMP				0x03
> +#define AUXADC_BATID				0x04
> +#define AUXADC_CHIP_TEMP			0x05
> +#define AUXADC_VCORE_TEMP			0x06
> +#define AUXADC_VPROC_TEMP			0x07
> +#define AUXADC_VGPU_TEMP			0x08
> +#define AUXADC_ACCDET				0x09
> +#define AUXADC_VDCXO				0x0a
> +#define AUXADC_TSX_TEMP				0x0b
> +#define AUXADC_HPOFS_CAL			0x0c
> +#define AUXADC_DCXO_TEMP			0x0d
> +#define AUXADC_VBIF		    		0x0e
> +#define AUXADC_IMP			    	0x0f
> +#define AUXADC_IMIX_R				0x10
> +#define AUXADC_VTREF				0x11
> +#define AUXADC_VSYSSNS				0x12
> +#define AUXADC_VIN1				    0x13
> +#define AUXADC_VIN2			    	0x14
> +#define AUXADC_VIN3			    	0x15
> +#define AUXADC_VIN4			    	0x16
> +#define AUXADC_VIN5			    	0x17
> +#define AUXADC_VIN6			    	0x18
> +#define AUXADC_VIN7		            0x19

What has this fine got to do with the node you're adding above? I don't
understand why this is in this patch.
There's random whitespace problems in it, and half the defines look
bizarre. This seems like it should be in the same patch as some binding
changes for an iio device? The mt635x auxadc binding doesn't even permit
anything that would use any of the properties beyond this point.

NAK.

> +
> +#define AUXADC_CHAN_MIN				AUXADC_BATADC
> +#define AUXADC_CHAN_MAX				AUXADC_VIN7
> +
> +#define ADC_PURES_100K				(0)
> +#define ADC_PURES_30K				(1)
> +#define ADC_PURES_400K				(2)
> +#define ADC_PURES_OPEN				(3)
> +
> +#define ADC_PURES_100K_MASK			(ADC_PURES_100K << 8)
> +#define ADC_PURES_30K_MASK			(ADC_PURES_30K << 8)
> +#define ADC_PURES_400K_MASK			(ADC_PURES_400K << 8)
> +#define ADC_PURES_OPEN_MASK			(ADC_PURES_OPEN << 8)
> +
> +#endif /* _DT_BINDINGS_MT635X_AUXADC_H */
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

On Thu, Oct 30, 2025 at 09:44:32PM +0800, Jack Hsu wrote:
> In this patch series, 
> we add Mediatek MT8189 evaluation board dts, dtsi and Makefile,
> and also related dt-binding documents.
> Jack Hsu (11):
>   dt-bindings: arm: Add compatible for MediaTek MT8189
>   dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc
>   dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse
>   dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm
>   dt-bindings: serial: Support MediaTek MT8189 evb board uart
>   dt-bindings: timer: Support MediaTek MT8189 evb board timer
>   dt-bindings: usb: Support MediaTek MT8189 evb board xhci
>   dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt

Please drop mention of the evb from all of these commit messages. The
compatible has nothing to do with the evb board, it's going to be common
across all boards using an mt8189.

>   arm64: dts: mediatek: Add MT6319 PMIC Support
>   arm64: dts: mediatek: add properties for MT6359

Wait a minute, what are these two patches even doing in this series in
the first place, when it is otherwise about the mt8189?

>   arm64: dts: mediatek: Add mt8189 evaluation board dts


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 08/11] dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt

[Guenter Roeck]

On 10/30/25 06:44, Jack Hsu wrote:
> modify dt-binding for support mt8189 evb board dts node of wdt
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH v6 07/11] dt-bindings: usb: Support MediaTek MT8189 evb board xhci

[Krzysztof Kozlowski]

On Thu, Oct 30, 2025 at 09:44:39PM +0800, Jack Hsu wrote:
> modify dt-binding for support mt8189 evb board dts node of xhci
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
>  .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml         | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index 004d3ebec091..05cb6a219e5c 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -34,6 +34,7 @@ properties:
>            - mediatek,mt8183-xhci
>            - mediatek,mt8186-xhci
>            - mediatek,mt8188-xhci
> +          - mediatek,mt8189-xhci
>            - mediatek,mt8192-xhci
>            - mediatek,mt8195-xhci
>            - mediatek,mt8365-xhci
> @@ -119,6 +120,9 @@ properties:
>    resets:
>      maxItems: 1
>  
> +  reset-names:
> +    maxItems: 1

No, drop. Not needed, not related, not explained in the commit msg,

Best regards,
Krzysztof

Re: [PATCH v6 07/11] dt-bindings: usb: Support MediaTek MT8189 evb board xhci

[Krzysztof Kozlowski]

On Thu, Oct 30, 2025 at 07:32:26PM +0000, Conor Dooley wrote:
> On Thu, Oct 30, 2025 at 09:44:39PM +0800, Jack Hsu wrote:
> > modify dt-binding for support mt8189 evb board dts node of xhci
> > 
> > Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> > ---
> >  .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml         | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > index 004d3ebec091..05cb6a219e5c 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > @@ -34,6 +34,7 @@ properties:
> >            - mediatek,mt8183-xhci
> >            - mediatek,mt8186-xhci
> >            - mediatek,mt8188-xhci
> > +          - mediatek,mt8189-xhci
> >            - mediatek,mt8192-xhci
> >            - mediatek,mt8195-xhci
> >            - mediatek,mt8365-xhci
> > @@ -119,6 +120,9 @@ properties:
> >    resets:
> >      maxItems: 1
> >  
> > +  reset-names:
> > +    maxItems: 1
> 
> Is this reset required on mt8189? Does it appear on other mediatek xhci
> controllers?

reset was there, it is the name added for some unknown reason.

Best regards,
Krzysztof

Re: [PATCH v6 07/11] dt-bindings: usb: Support MediaTek MT8189 evb board xhci

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

On Fri, Oct 31, 2025 at 09:19:26AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Oct 30, 2025 at 07:32:26PM +0000, Conor Dooley wrote:
> > On Thu, Oct 30, 2025 at 09:44:39PM +0800, Jack Hsu wrote:
> > > modify dt-binding for support mt8189 evb board dts node of xhci
> > > 
> > > Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> > > ---
> > >  .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml         | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > > index 004d3ebec091..05cb6a219e5c 100644
> > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > > @@ -34,6 +34,7 @@ properties:
> > >            - mediatek,mt8183-xhci
> > >            - mediatek,mt8186-xhci
> > >            - mediatek,mt8188-xhci
> > > +          - mediatek,mt8189-xhci
> > >            - mediatek,mt8192-xhci
> > >            - mediatek,mt8195-xhci
> > >            - mediatek,mt8365-xhci
> > > @@ -119,6 +120,9 @@ properties:
> > >    resets:
> > >      maxItems: 1
> > >  
> > > +  reset-names:
> > > +    maxItems: 1
> > 
> > Is this reset required on mt8189? Does it appear on other mediatek xhci
> > controllers?
> 
> reset was there, it is the name added for some unknown reason.

Ah, so not helpful at all since no name is defined and therefore making
the property unusable :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 02/11] dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc

[Jonathan Cameron]

On Thu, 30 Oct 2025 19:30:39 +0000
Conor Dooley <conor@kernel.org> wrote:

> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable

Applied.

Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[Jh Hsu (許希孜)]

On Thu, 2025-10-30 at 19:49 +0000, Conor Dooley wrote:
> On Thu, Oct 30, 2025 at 09:44:32PM +0800, Jack Hsu wrote:
> > In this patch series, 
> > we add Mediatek MT8189 evaluation board dts, dtsi and Makefile,
> > and also related dt-binding documents.
> > Jack Hsu (11):
> >   dt-bindings: arm: Add compatible for MediaTek MT8189
> >   dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc
> >   dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse
> >   dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm
> >   dt-bindings: serial: Support MediaTek MT8189 evb board uart
> >   dt-bindings: timer: Support MediaTek MT8189 evb board timer
> >   dt-bindings: usb: Support MediaTek MT8189 evb board xhci
> >   dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt
> 
> Please drop mention of the evb from all of these commit messages. The
> compatible has nothing to do with the evb board, it's going to be
> common
> across all boards using an mt8189.
> 
> >   arm64: dts: mediatek: Add MT6319 PMIC Support
> >   arm64: dts: mediatek: add properties for MT6359
> 
> Wait a minute, what are these two patches even doing in this series
> in
> the first place, when it is otherwise about the mt8189?
mt8189 evb board include mt63xx.dtsi, 
and the dtsi files maybe for other boards in the future, 
ie. mt8189/81xx custom/OEM/ODM boards.
Should i separate those two patches as a new patch series ?

Re: (subset) [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[Srinivas Kandagatla]

On Thu, 30 Oct 2025 21:44:32 +0800, Jack Hsu wrote:
> In this patch series,
> we add Mediatek MT8189 evaluation board dts, dtsi and Makefile,
> and also related dt-binding documents.
> 
> based on tag: next-20251029
> 
> Note:
> This patch series depends on following dt-binding headers and yamls
> 1.dt-binding headers
>   1. mt8189-pinfunc.h
>        https://patchwork.kernel.org/project/linux-mediatek/patch/20250919020525.7904-1-ot_cathy.xu@mediatek.com/
>   2. mt8189_gce.h
>        https://patchwork.kernel.org/project/linux-mediatek/patch/20250820093831.23437-3-xiandong.wang@mediatek.com/
> 
> [...]

Applied, thanks!

[03/11] dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse
        commit: 2150cd7ffd14a39fb56c2b3cbfcc6dbf629b7643

Best regards,
-- 
Srinivas Kandagatla <srini@kernel.org>

Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]

On Wed, Nov 05, 2025 at 07:06:50AM +0000, Jh Hsu (許希孜) wrote:
> On Thu, 2025-10-30 at 19:49 +0000, Conor Dooley wrote:
> > On Thu, Oct 30, 2025 at 09:44:32PM +0800, Jack Hsu wrote:
> > > In this patch series, 
> > > we add Mediatek MT8189 evaluation board dts, dtsi and Makefile,
> > > and also related dt-binding documents.
> > > Jack Hsu (11):
> > >   dt-bindings: arm: Add compatible for MediaTek MT8189
> > >   dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc
> > >   dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse
> > >   dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm
> > >   dt-bindings: serial: Support MediaTek MT8189 evb board uart
> > >   dt-bindings: timer: Support MediaTek MT8189 evb board timer
> > >   dt-bindings: usb: Support MediaTek MT8189 evb board xhci
> > >   dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt
> > 
> > Please drop mention of the evb from all of these commit messages. The
> > compatible has nothing to do with the evb board, it's going to be
> > common
> > across all boards using an mt8189.
> > 
> > >   arm64: dts: mediatek: Add MT6319 PMIC Support
> > >   arm64: dts: mediatek: add properties for MT6359
> > 
> > Wait a minute, what are these two patches even doing in this series
> > in
> > the first place, when it is otherwise about the mt8189?
> 
> mt8189 evb board include mt63xx.dtsi, 
> and the dtsi files maybe for other boards in the future, 
> ie. mt8189/81xx custom/OEM/ODM boards.
> Should i separate those two patches as a new patch series ?

They seemed unrelated to your series and poor quality to the point that
they looked like an accidental inclusions, given there's no mention of
them in the cover letter. Since they do appear to be related, sure keep
them. That said, the "add properties for MT6359" patch is in need of
major rework, so you'll have to rework it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

[Jh Hsu (許希孜)]

On Wed, 2025-11-05 at 18:48 +0000, Conor Dooley wrote:
> > > Please drop mention of the evb from all of these commit messages.
> > > The
> > > compatible has nothing to do with the evb board, it's going to be
> > > common
> > > across all boards using an mt8189.
> > > 
> > > >   arm64: dts: mediatek: Add MT6319 PMIC Support
> > > >   arm64: dts: mediatek: add properties for MT6359
> > > 
> > > Wait a minute, what are these two patches even doing in this
> > > series
> > > in
> > > the first place, when it is otherwise about the mt8189?
> > 
> > mt8189 evb board include mt63xx.dtsi, 
> > and the dtsi files maybe for other boards in the future, 
> > ie. mt8189/81xx custom/OEM/ODM boards.
> > Should i separate those two patches as a new patch series ?
> 
> They seemed unrelated to your series and poor quality to the point
> that
> they looked like an accidental inclusions, given there's no mention
> of
> them in the cover letter. Since they do appear to be related, sure
> keep
> them. That said, the "add properties for MT6359" patch is in need of
> major rework, so you'll have to rework it.

Got it, will add mt63xx information and rework mt63xx dtsi in next
version