public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	 shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de,  festevam@gmail.com, abelvesa@kernel.org,
	peng.fan@nxp.com, mturquette@baylibre.com,  sboyd@kernel.org,
	Frank.Li@nxp.com, hongxing.zhu@nxp.com,
	 devicetree@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: imx95: fix hsio_blk_ctl reg map
Date: Wed, 19 Nov 2025 08:44:04 +0100	[thread overview]
Message-ID: <20251119-speedy-delectable-hawk-93fade@kuoka> (raw)
In-Reply-To: <20251118074055.2523766-4-xu.yang_2@nxp.com>

On Tue, Nov 18, 2025 at 03:40:55PM +0800, Xu Yang wrote:
> The HSIO block control register map should be 0x4c010000~0x4c01FFFF.
> Correct the start address and set length to 0x100 for available
> registers.
> 
> Fixes: 3c8d7b5d2bed ("arm64: dts: imx95: add ref clock for pcie nodes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx95.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 1292677cbe4e..21c9df445be0 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -1774,9 +1774,9 @@ usb3_dwc3: usb@4c100000 {
>  			};
>  		};
>  
> -		hsio_blk_ctl: syscon@4c0100c0 {
> +		hsio_blk_ctl: syscon@4c010000 {
>  			compatible = "nxp,imx95-hsio-blk-ctl", "syscon";
> -			reg = <0x0 0x4c0100c0 0x0 0x1>;
> +			reg = <0x0 0x4c010000 0x0 0x100>;
>  			#clock-cells = <1>;
>  			clocks = <&clk_sys100m>;
>  			power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
> @@ -1844,7 +1844,7 @@ pcie0: pcie@4c300000 {
>  				 <&scmi_clk IMX95_CLK_HSIOPLL>,
>  				 <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>  				 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>,
> -				 <&hsio_blk_ctl 0>;
> +				 <&hsio_blk_ctl IMX95_CLK_HSIOMIX_PCIE_CLK_GATE>;

This is unrelated change, nothing explained in commit msg. Please do not
combine independent changes into one commit. Non-fixes with
fixes either

Best regards,
Krzysztof



  reply	other threads:[~2025-11-19  7:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18  7:40 [PATCH 1/4] dt-bindings: clock: imx95: add PCIE and USB PHY clk Xu Yang
2025-11-18  7:40 ` [PATCH 2/4] clk: imx95-blk-ctl: fix hsio_blk_ctl_clk_dev_data reg offset Xu Yang
2025-11-18 15:45   ` Frank Li
2025-11-18  7:40 ` [PATCH 3/4] clk: imx95-blk-ctl: Add one clock mux for HSIO block Xu Yang
2025-11-18  7:40 ` [PATCH 4/4] arm64: dts: imx95: fix hsio_blk_ctl reg map Xu Yang
2025-11-19  7:44   ` Krzysztof Kozlowski [this message]
2025-11-25  7:08     ` Xu Yang
2025-11-19  7:44 ` [PATCH 1/4] dt-bindings: clock: imx95: add PCIE and USB PHY clk Krzysztof Kozlowski
2025-11-19 18:11 ` Stephen Boyd
2025-11-25  7:09   ` Xu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119-speedy-delectable-hawk-93fade@kuoka \
    --to=krzk@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=abelvesa@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox