Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 0/2] Add i.MX93 Wireless EVK board support
@ 2026-01-23  2:44 Sherry Sun
  2026-01-23  2:44 ` [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board Sherry Sun
  2026-01-23  2:44 ` [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support Sherry Sun
  0 siblings, 2 replies; 9+ messages in thread
From: Sherry Sun @ 2026-01-23  2:44 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, frank.li, s.hauer, festevam,
	daniel.baluta, dario.binacchi, alexander.stein, Markus.Niebel,
	matthias.schiffer, y.moog, josua, francesco.dolcini, primoz.fiser
  Cc: kernel, devicetree, imx, linux-arm-kernel, linux-kernel

i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
(Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the i.MX93
Wireless SiP basically reuse the i.MX93 11x11 EVK board, with some minor
functional and pin connection differences.

Add device tree and dt-binding for i.MX93 Wireless EVK.

---
Changes in V2:
1. Rename the compatible string to fsl,imx93-wireless-evk which is more
   clearer and better aligned with the naming convention used on previous
   NXP boards.
2. Impreove the patch#1 commit message to add more info. 
---
Sherry Sun (2):
  dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board
  arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support

 .../devicetree/bindings/arm/fsl.yaml          |  1 +
 arch/arm64/boot/dts/freescale/Makefile        |  1 +
 arch/arm64/boot/dts/freescale/imx93w-evk.dts  | 73 +++++++++++++++++++
 3 files changed, 75 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts

-- 
2.37.1



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board
  2026-01-23  2:44 [PATCH V2 0/2] Add i.MX93 Wireless EVK board support Sherry Sun
@ 2026-01-23  2:44 ` Sherry Sun
  2026-01-23  9:00   ` Krzysztof Kozlowski
  2026-01-23  2:44 ` [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support Sherry Sun
  1 sibling, 1 reply; 9+ messages in thread
From: Sherry Sun @ 2026-01-23  2:44 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, frank.li, s.hauer, festevam,
	daniel.baluta, dario.binacchi, alexander.stein, Markus.Niebel,
	matthias.schiffer, y.moog, josua, francesco.dolcini, primoz.fiser
  Cc: kernel, devicetree, imx, linux-arm-kernel, linux-kernel

Add DT compatible string for NXP i.MX93 Wireless EVK board.

i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
(Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the i.MX93
Wireless SiP basically reuse the i.MX93 11x11 EVK board, with some minor
functional and pin connection differences.

The detailed differences between i.MX93 Wireless EVK and i.MX93 11x11
EVK board can be found in i.MX93 Wireless EVK DTS patch commit message.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 5716d701292c..df01b928c6c5 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1441,6 +1441,7 @@ properties:
               - fsl,imx93-11x11-evk       # i.MX93 11x11 EVK Board
               - fsl,imx93-11x11-frdm      # i.MX93 11x11 FRDM Board
               - fsl,imx93-14x14-evk       # i.MX93 14x14 EVK Board
+              - fsl,imx93-wireless-evk    # i.MX93 and IW610G WLCSP (Wi-Fi + BLE + 802.15.4) SiP EVK Board
           - const: fsl,imx93
 
       - description: i.MX94 based Boards
-- 
2.37.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support
  2026-01-23  2:44 [PATCH V2 0/2] Add i.MX93 Wireless EVK board support Sherry Sun
  2026-01-23  2:44 ` [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board Sherry Sun
@ 2026-01-23  2:44 ` Sherry Sun
  2026-01-23  9:02   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 9+ messages in thread
From: Sherry Sun @ 2026-01-23  2:44 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, frank.li, s.hauer, festevam,
	daniel.baluta, dario.binacchi, alexander.stein, Markus.Niebel,
	matthias.schiffer, y.moog, josua, francesco.dolcini, primoz.fiser
  Cc: kernel, devicetree, imx, linux-arm-kernel, linux-kernel

i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
(Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the i.MX93
Wireless SiP basically reuse the i.MX93 11x11 EVK board, with some minor
functional and pin connection differences.

Here are the detailed differences between i.MX93 Wireless EVK and i.MX93
11x11 EVK board.

Function differences:
Function	i.MX93W EVK			i.MX93 EVK
WIFI/BT		IW610 in i.MX93W		IW612 M.2 module
MQS		N				Y
PDM MIC		N				Y
M.2		N				Y
RPi 40-pin HDR	Limited support(pin conflict) 	Y

Pin connection differences:
Function  Signal name	i.MX93W EVK		i.MX93 EVK
WIFI/BT	  SPI_FRM	SAI1_TXFS (spi1.PCS0)	GPIO_IO08 (spi3.PCS0)
	  SPI_TXD	SAI1_TXC (spi1.SIN)	GPIO_IO09 (spi3.SIN)
	  SPI_RXD	SAI1_RXD0 (spi1.SOUT)	GPIO_IO10 (spi3.SOUT)
	  SPI_CLK	SAI1_TXD0 (spi1.SCK)	GPIO_IO11 (spi3.SCK)
	  SPI_INT	CCM_CLKO1		on-board IO expander
	  NB_WAKE_IN	PDM_CLK			on-module IO expander
	  WL_WAKE_IN	PDM_BIT_STREAM0		on-module IO expander
	  IND_RST_WL	PDM_BIT_STREAM1		on-module IO expander
	  IND_RST_NB	GPIO_IO28		on-module IO expander
	  PDn		GPIO_IO29		on-module IO expander
	  NB_WAKE_OUT	GPIO_IO14		on-board IO expander
	  WL_WAKE_OUT	GPIO_IO15		CCM_CLKO1
I2C3	  I2C3_SDA	GPIO_IO00		GPIO_IO28
	  I2C3_SCL	GPIO_IO01		GPIO_IO29

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/Makefile       |  1 +
 arch/arm64/boot/dts/freescale/imx93w-evk.dts | 73 ++++++++++++++++++++
 2 files changed, 74 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 700bab4d3e60..d0ea746c59b8 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -418,6 +418,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-i3c.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-frdm.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx93w-evk.dts b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
new file mode 100644
index 000000000000..f09587dc74f6
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2026 NXP
+ */
+
+#include "imx93-11x11-evk.dts"
+
+/ {
+	model = "NXP i.MX93W EVK board";
+	compatible = "fsl,imx93-wireless-evk", "fsl,imx93";
+
+	/delete-node/ regulator-m2-pwr;
+
+	sound-bt-sco {
+		status = "disabled";
+	};
+
+	sound-micfil {
+		status = "disabled";
+	};
+};
+
+&pcal6524 {
+	/delete-node/ m2-pcm-level-shifter-hog;
+};
+
+&reg_usdhc3_vmmc {
+	/delete-property/ vin-supply;
+	pinctrl-0 = <&pinctrl_reg_usdhc3_vmmc>;
+	pinctrl-names = "default";
+	gpio = <&gpio2 29 GPIO_ACTIVE_HIGH>;
+};
+
+&usdhc3_pwrseq {
+	pinctrl-0 = <&pinctrl_usdhc3_pwrseq>;
+	pinctrl-names = "default";
+	reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
+};
+
+&micfil {
+	status = "disabled";
+};
+
+&sai1 {
+	status = "disabled";
+};
+
+&iomuxc {
+	pinctrl_lpi2c3: lpi2c3grp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO00__LPI2C3_SDA			0x40000b9e
+			MX93_PAD_GPIO_IO01__LPI2C3_SCL			0x40000b9e
+		>;
+	};
+
+	pinctrl_reg_usdhc3_vmmc: regusdhc3vmmcgrp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO29__GPIO2_IO29			0x31e
+		>;
+	};
+
+	pinctrl_usdhc3_pwrseq: usdhc3pwrseqgrp {
+		fsl,pins = <
+			MX93_PAD_PDM_BIT_STREAM1__GPIO1_IO10		0x31e
+		>;
+	};
+
+	pinctrl_usdhc3_wlan: usdhc3wlangrp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO15__GPIO2_IO15			0x31e
+		>;
+	};
+};
-- 
2.37.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board
  2026-01-23  2:44 ` [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board Sherry Sun
@ 2026-01-23  9:00   ` Krzysztof Kozlowski
  2026-01-26  2:03     ` Sherry Sun
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-23  9:00 UTC (permalink / raw)
  To: Sherry Sun
  Cc: robh, krzk+dt, conor+dt, shawnguo, frank.li, s.hauer, festevam,
	daniel.baluta, dario.binacchi, alexander.stein, Markus.Niebel,
	matthias.schiffer, y.moog, josua, francesco.dolcini, primoz.fiser,
	kernel, devicetree, imx, linux-arm-kernel, linux-kernel

On Fri, Jan 23, 2026 at 10:44:47AM +0800, Sherry Sun wrote:
> Add DT compatible string for NXP i.MX93 Wireless EVK board.
> 
> i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
> (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the i.MX93
> Wireless SiP basically reuse the i.MX93 11x11 EVK board, with some minor
> functional and pin connection differences.
> 

I will leave it to the platform maintainer whether SiP deserves its own
compatible. I imagine that yes, but don't insist so:


> The detailed differences between i.MX93 Wireless EVK and i.MX93 11x11
> EVK board can be found in i.MX93 Wireless EVK DTS patch commit message.

Drop. Do not reference other patches in terms what do they provide - it
serves little purpose in git history.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support
  2026-01-23  2:44 ` [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support Sherry Sun
@ 2026-01-23  9:02   ` Krzysztof Kozlowski
  2026-01-23 15:06     ` Frank Li
  2026-01-26  2:52     ` Sherry Sun
  0 siblings, 2 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-23  9:02 UTC (permalink / raw)
  To: Sherry Sun
  Cc: robh, krzk+dt, conor+dt, shawnguo, frank.li, s.hauer, festevam,
	daniel.baluta, dario.binacchi, alexander.stein, Markus.Niebel,
	matthias.schiffer, y.moog, josua, francesco.dolcini, primoz.fiser,
	kernel, devicetree, imx, linux-arm-kernel, linux-kernel

On Fri, Jan 23, 2026 at 10:44:48AM +0800, Sherry Sun wrote:
> i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
> (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the i.MX93
> Wireless SiP basically reuse the i.MX93 11x11 EVK board, with some minor
> functional and pin connection differences.
> 
> Here are the detailed differences between i.MX93 Wireless EVK and i.MX93
> 11x11 EVK board.
> 
> Function differences:
> Function	i.MX93W EVK			i.MX93 EVK
> WIFI/BT		IW610 in i.MX93W		IW612 M.2 module
> MQS		N				Y
> PDM MIC		N				Y
> M.2		N				Y
> RPi 40-pin HDR	Limited support(pin conflict) 	Y
> 
> Pin connection differences:
> Function  Signal name	i.MX93W EVK		i.MX93 EVK
> WIFI/BT	  SPI_FRM	SAI1_TXFS (spi1.PCS0)	GPIO_IO08 (spi3.PCS0)
> 	  SPI_TXD	SAI1_TXC (spi1.SIN)	GPIO_IO09 (spi3.SIN)
> 	  SPI_RXD	SAI1_RXD0 (spi1.SOUT)	GPIO_IO10 (spi3.SOUT)
> 	  SPI_CLK	SAI1_TXD0 (spi1.SCK)	GPIO_IO11 (spi3.SCK)
> 	  SPI_INT	CCM_CLKO1		on-board IO expander
> 	  NB_WAKE_IN	PDM_CLK			on-module IO expander
> 	  WL_WAKE_IN	PDM_BIT_STREAM0		on-module IO expander
> 	  IND_RST_WL	PDM_BIT_STREAM1		on-module IO expander
> 	  IND_RST_NB	GPIO_IO28		on-module IO expander
> 	  PDn		GPIO_IO29		on-module IO expander
> 	  NB_WAKE_OUT	GPIO_IO14		on-board IO expander
> 	  WL_WAKE_OUT	GPIO_IO15		CCM_CLKO1
> I2C3	  I2C3_SDA	GPIO_IO00		GPIO_IO28
> 	  I2C3_SCL	GPIO_IO01		GPIO_IO29
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/Makefile       |  1 +
>  arch/arm64/boot/dts/freescale/imx93w-evk.dts | 73 ++++++++++++++++++++
>  2 files changed, 74 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 700bab4d3e60..d0ea746c59b8 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -418,6 +418,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-i3c.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-frdm.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx93w-evk.dts b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> new file mode 100644
> index 000000000000..f09587dc74f6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> @@ -0,0 +1,73 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2026 NXP
> + */
> +
> +#include "imx93-11x11-evk.dts"
> +
> +/ {
> +	model = "NXP i.MX93W EVK board";
> +	compatible = "fsl,imx93-wireless-evk", "fsl,imx93";
> +
> +	/delete-node/ regulator-m2-pwr;

If you remove nodes then clearly you do not share a common design, thus
you should not include other DTSI... and definitely even more confusing
to include other DTS.

> +
> +	sound-bt-sco {
> +		status = "disabled";
> +	};
> +
> +	sound-micfil {
> +		status = "disabled";

Kind of same here.

It's poor practice to include DTS inside DTS, some platforms disallow
this. Is it acceptable pattern in NXP/iMX?

> +	};
> +};
> +
> +&pcal6524 {
> +	/delete-node/ m2-pcm-level-shifter-hog;

Why do you remove so much?

> +};
> +
> +&reg_usdhc3_vmmc {
> +	/delete-property/ vin-supply;

Do you understand how inclusion works? You claim here you have common
parts. Removing them means they are not common.

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support
  2026-01-23  9:02   ` Krzysztof Kozlowski
@ 2026-01-23 15:06     ` Frank Li
  2026-01-26  2:52     ` Sherry Sun
  1 sibling, 0 replies; 9+ messages in thread
From: Frank Li @ 2026-01-23 15:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Sherry Sun, robh, krzk+dt, conor+dt, shawnguo, s.hauer, festevam,
	daniel.baluta, dario.binacchi, alexander.stein, Markus.Niebel,
	matthias.schiffer, y.moog, josua, francesco.dolcini, primoz.fiser,
	kernel, devicetree, imx, linux-arm-kernel, linux-kernel

On Fri, Jan 23, 2026 at 10:02:34AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Jan 23, 2026 at 10:44:48AM +0800, Sherry Sun wrote:
> > i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
> > (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the i.MX93
> > Wireless SiP basically reuse the i.MX93 11x11 EVK board, with some minor
> > functional and pin connection differences.
> >
> > Here are the detailed differences between i.MX93 Wireless EVK and i.MX93
> > 11x11 EVK board.
> >
> > Function differences:
> > Function	i.MX93W EVK			i.MX93 EVK
> > WIFI/BT		IW610 in i.MX93W		IW612 M.2 module
> > MQS		N				Y
> > PDM MIC		N				Y
> > M.2		N				Y
> > RPi 40-pin HDR	Limited support(pin conflict) 	Y
> >
> > Pin connection differences:
> > Function  Signal name	i.MX93W EVK		i.MX93 EVK
> > WIFI/BT	  SPI_FRM	SAI1_TXFS (spi1.PCS0)	GPIO_IO08 (spi3.PCS0)
> > 	  SPI_TXD	SAI1_TXC (spi1.SIN)	GPIO_IO09 (spi3.SIN)
> > 	  SPI_RXD	SAI1_RXD0 (spi1.SOUT)	GPIO_IO10 (spi3.SOUT)
> > 	  SPI_CLK	SAI1_TXD0 (spi1.SCK)	GPIO_IO11 (spi3.SCK)
> > 	  SPI_INT	CCM_CLKO1		on-board IO expander
> > 	  NB_WAKE_IN	PDM_CLK			on-module IO expander
> > 	  WL_WAKE_IN	PDM_BIT_STREAM0		on-module IO expander
> > 	  IND_RST_WL	PDM_BIT_STREAM1		on-module IO expander
> > 	  IND_RST_NB	GPIO_IO28		on-module IO expander
> > 	  PDn		GPIO_IO29		on-module IO expander
> > 	  NB_WAKE_OUT	GPIO_IO14		on-board IO expander
> > 	  WL_WAKE_OUT	GPIO_IO15		CCM_CLKO1
> > I2C3	  I2C3_SDA	GPIO_IO00		GPIO_IO28
> > 	  I2C3_SCL	GPIO_IO01		GPIO_IO29
> >
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/Makefile       |  1 +
> >  arch/arm64/boot/dts/freescale/imx93w-evk.dts | 73 ++++++++++++++++++++
> >  2 files changed, 74 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 700bab4d3e60..d0ea746c59b8 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -418,6 +418,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-i3c.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-frdm.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
> > diff --git a/arch/arm64/boot/dts/freescale/imx93w-evk.dts b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> > new file mode 100644
> > index 000000000000..f09587dc74f6
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> > @@ -0,0 +1,73 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright 2026 NXP
> > + */
> > +
> > +#include "imx93-11x11-evk.dts"
> > +
> > +/ {
> > +	model = "NXP i.MX93W EVK board";
> > +	compatible = "fsl,imx93-wireless-evk", "fsl,imx93";
> > +
> > +	/delete-node/ regulator-m2-pwr;
>
> If you remove nodes then clearly you do not share a common design, thus
> you should not include other DTSI... and definitely even more confusing
> to include other DTS.
>
> > +
> > +	sound-bt-sco {
> > +		status = "disabled";
> > +	};
> > +
> > +	sound-micfil {
> > +		status = "disabled";
>
> Kind of same here.
>
> It's poor practice to include DTS inside DTS, some platforms disallow
> this. Is it acceptable pattern in NXP/iMX?

Some old platform used it. It is discouraged for new platform.

Frank

>
> > +	};
> > +};
> > +
> > +&pcal6524 {
> > +	/delete-node/ m2-pcm-level-shifter-hog;
>
> Why do you remove so much?
>
> > +};
> > +
> > +&reg_usdhc3_vmmc {
> > +	/delete-property/ vin-supply;
>
> Do you understand how inclusion works? You claim here you have common
> parts. Removing them means they are not common.
>
> Best regards,
> Krzysztof
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board
  2026-01-23  9:00   ` Krzysztof Kozlowski
@ 2026-01-26  2:03     ` Sherry Sun
  0 siblings, 0 replies; 9+ messages in thread
From: Sherry Sun @ 2026-01-26  2:03 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	shawnguo@kernel.org, Frank Li, s.hauer@pengutronix.de,
	festevam@gmail.com, Daniel Baluta,
	dario.binacchi@amarulasolutions.com,
	alexander.stein@ew.tq-group.com, Markus.Niebel@tq-group.com,
	matthias.schiffer@tq-group.com, y.moog@phytec.de,
	josua@solid-run.com, Francesco Dolcini, primoz.fiser@norik.com,
	kernel@pengutronix.de, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK
> board
> 
> On Fri, Jan 23, 2026 at 10:44:47AM +0800, Sherry Sun wrote:
> > Add DT compatible string for NXP i.MX93 Wireless EVK board.
> >
> > i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
> > (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the
> > i.MX93 Wireless SiP basically reuse the i.MX93 11x11 EVK board, with
> > some minor functional and pin connection differences.
> >
> 
> I will leave it to the platform maintainer whether SiP deserves its own
> compatible. I imagine that yes, but don't insist so:
> 
> 
> > The detailed differences between i.MX93 Wireless EVK and i.MX93 11x11
> > EVK board can be found in i.MX93 Wireless EVK DTS patch commit message.
> 
> Drop. Do not reference other patches in terms what do they provide - it
> serves little purpose in git history.

Ok, will drop it in V3, thanks!

Best Regards
Sherry
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support
  2026-01-23  9:02   ` Krzysztof Kozlowski
  2026-01-23 15:06     ` Frank Li
@ 2026-01-26  2:52     ` Sherry Sun
  2026-01-28 10:16       ` Krzysztof Kozlowski
  1 sibling, 1 reply; 9+ messages in thread
From: Sherry Sun @ 2026-01-26  2:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	shawnguo@kernel.org, Frank Li, s.hauer@pengutronix.de,
	festevam@gmail.com, Daniel Baluta,
	dario.binacchi@amarulasolutions.com,
	alexander.stein@ew.tq-group.com, Markus.Niebel@tq-group.com,
	matthias.schiffer@tq-group.com, y.moog@phytec.de,
	josua@solid-run.com, Francesco Dolcini, primoz.fiser@norik.com,
	kernel@pengutronix.de, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless
> EVK board support
> 
> On Fri, Jan 23, 2026 at 10:44:48AM +0800, Sherry Sun wrote:
> > i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
> > (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the
> > i.MX93 Wireless SiP basically reuse the i.MX93 11x11 EVK board, with
> > some minor functional and pin connection differences.
> >
> > Here are the detailed differences between i.MX93 Wireless EVK and
> > i.MX93
> > 11x11 EVK board.
> >
> > Function differences:
> > Function	i.MX93W EVK			i.MX93 EVK
> > WIFI/BT		IW610 in i.MX93W		IW612 M.2 module
> > MQS		N				Y
> > PDM MIC		N				Y
> > M.2		N				Y
> > RPi 40-pin HDR	Limited support(pin conflict) 	Y
> >
> > Pin connection differences:
> > Function  Signal name	i.MX93W EVK		i.MX93 EVK
> > WIFI/BT	  SPI_FRM	SAI1_TXFS (spi1.PCS0)	GPIO_IO08
> (spi3.PCS0)
> > 	  SPI_TXD	SAI1_TXC (spi1.SIN)	GPIO_IO09 (spi3.SIN)
> > 	  SPI_RXD	SAI1_RXD0 (spi1.SOUT)	GPIO_IO10 (spi3.SOUT)
> > 	  SPI_CLK	SAI1_TXD0 (spi1.SCK)	GPIO_IO11 (spi3.SCK)
> > 	  SPI_INT	CCM_CLKO1		on-board IO expander
> > 	  NB_WAKE_IN	PDM_CLK			on-module IO
> expander
> > 	  WL_WAKE_IN	PDM_BIT_STREAM0		on-module IO
> expander
> > 	  IND_RST_WL	PDM_BIT_STREAM1		on-module IO
> expander
> > 	  IND_RST_NB	GPIO_IO28		on-module IO expander
> > 	  PDn		GPIO_IO29		on-module IO expander
> > 	  NB_WAKE_OUT	GPIO_IO14		on-board IO
> expander
> > 	  WL_WAKE_OUT	GPIO_IO15		CCM_CLKO1
> > I2C3	  I2C3_SDA	GPIO_IO00		GPIO_IO28
> > 	  I2C3_SCL	GPIO_IO01		GPIO_IO29
> >
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/Makefile       |  1 +
> >  arch/arm64/boot/dts/freescale/imx93w-evk.dts | 73
> > ++++++++++++++++++++
> >  2 files changed, 74 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index 700bab4d3e60..d0ea746c59b8 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -418,6 +418,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-
> i3c.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-frdm.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb diff --git
> > a/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> > new file mode 100644
> > index 000000000000..f09587dc74f6
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
> > @@ -0,0 +1,73 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright 2026 NXP
> > + */
> > +
> > +#include "imx93-11x11-evk.dts"
> > +
> > +/ {
> > +	model = "NXP i.MX93W EVK board";
> > +	compatible = "fsl,imx93-wireless-evk", "fsl,imx93";
> > +
> > +	/delete-node/ regulator-m2-pwr;
> 
> If you remove nodes then clearly you do not share a common design, thus
> you should not include other DTSI... and definitely even more confusing to
> include other DTS.

Hi Krzysztof,
Ok, it seems I should mark these nodes as disabled instead of delete them, will fix, thanks!

> 
> > +
> > +	sound-bt-sco {
> > +		status = "disabled";
> > +	};
> > +
> > +	sound-micfil {
> > +		status = "disabled";
> 
> Kind of same here.

Will fix in V3.

> 
> It's poor practice to include DTS inside DTS, some platforms disallow this. Is it
> acceptable pattern in NXP/iMX?

Perhaps I should simply use the DTS overlay for i.MX93 Wireless EVK, or
extract their common parts, such as imx93-11x11-evk-common.dtsi, not sure
which is better?

> 
> > +	};
> > +};
> > +
> > +&pcal6524 {
> > +	/delete-node/ m2-pcm-level-shifter-hog;
> 
> Why do you remove so much?

Will avoid such changes.

> 
> > +};
> > +
> > +&reg_usdhc3_vmmc {
> > +	/delete-property/ vin-supply;
> 
> Do you understand how inclusion works? You claim here you have common
> parts. Removing them means they are not common.
> 
Ok, will fix. Thanks!

Best Regards
Sherry

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support
  2026-01-26  2:52     ` Sherry Sun
@ 2026-01-28 10:16       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-28 10:16 UTC (permalink / raw)
  To: Sherry Sun
  Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	shawnguo@kernel.org, Frank Li, s.hauer@pengutronix.de,
	festevam@gmail.com, Daniel Baluta,
	dario.binacchi@amarulasolutions.com,
	alexander.stein@ew.tq-group.com, Markus.Niebel@tq-group.com,
	matthias.schiffer@tq-group.com, y.moog@phytec.de,
	josua@solid-run.com, Francesco Dolcini, primoz.fiser@norik.com,
	kernel@pengutronix.de, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org

On 26/01/2026 03:52, Sherry Sun wrote:
>> Subject: Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless
>> EVK board support
>>
>> On Fri, Jan 23, 2026 at 10:44:48AM +0800, Sherry Sun wrote:
>>> i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
>>> (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the
>>> i.MX93 Wireless SiP basically reuse the i.MX93 11x11 EVK board, with
>>> some minor functional and pin connection differences.
>>>
>>> Here are the detailed differences between i.MX93 Wireless EVK and
>>> i.MX93
>>> 11x11 EVK board.
>>>
>>> Function differences:
>>> Function	i.MX93W EVK			i.MX93 EVK
>>> WIFI/BT		IW610 in i.MX93W		IW612 M.2 module
>>> MQS		N				Y
>>> PDM MIC		N				Y
>>> M.2		N				Y
>>> RPi 40-pin HDR	Limited support(pin conflict) 	Y
>>>
>>> Pin connection differences:
>>> Function  Signal name	i.MX93W EVK		i.MX93 EVK
>>> WIFI/BT	  SPI_FRM	SAI1_TXFS (spi1.PCS0)	GPIO_IO08
>> (spi3.PCS0)
>>> 	  SPI_TXD	SAI1_TXC (spi1.SIN)	GPIO_IO09 (spi3.SIN)
>>> 	  SPI_RXD	SAI1_RXD0 (spi1.SOUT)	GPIO_IO10 (spi3.SOUT)
>>> 	  SPI_CLK	SAI1_TXD0 (spi1.SCK)	GPIO_IO11 (spi3.SCK)
>>> 	  SPI_INT	CCM_CLKO1		on-board IO expander
>>> 	  NB_WAKE_IN	PDM_CLK			on-module IO
>> expander
>>> 	  WL_WAKE_IN	PDM_BIT_STREAM0		on-module IO
>> expander
>>> 	  IND_RST_WL	PDM_BIT_STREAM1		on-module IO
>> expander
>>> 	  IND_RST_NB	GPIO_IO28		on-module IO expander
>>> 	  PDn		GPIO_IO29		on-module IO expander
>>> 	  NB_WAKE_OUT	GPIO_IO14		on-board IO
>> expander
>>> 	  WL_WAKE_OUT	GPIO_IO15		CCM_CLKO1
>>> I2C3	  I2C3_SDA	GPIO_IO00		GPIO_IO28
>>> 	  I2C3_SCL	GPIO_IO01		GPIO_IO29
>>>
>>> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
>>> ---
>>>  arch/arm64/boot/dts/freescale/Makefile       |  1 +
>>>  arch/arm64/boot/dts/freescale/imx93w-evk.dts | 73
>>> ++++++++++++++++++++
>>>  2 files changed, 74 insertions(+)
>>>  create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/Makefile
>>> b/arch/arm64/boot/dts/freescale/Makefile
>>> index 700bab4d3e60..d0ea746c59b8 100644
>>> --- a/arch/arm64/boot/dts/freescale/Makefile
>>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>>> @@ -418,6 +418,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-
>> i3c.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-frdm.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb
>>> +dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb diff --git
>>> a/arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>> b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>> new file mode 100644
>>> index 000000000000..f09587dc74f6
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>> @@ -0,0 +1,73 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright 2026 NXP
>>> + */
>>> +
>>> +#include "imx93-11x11-evk.dts"
>>> +
>>> +/ {
>>> +	model = "NXP i.MX93W EVK board";
>>> +	compatible = "fsl,imx93-wireless-evk", "fsl,imx93";
>>> +
>>> +	/delete-node/ regulator-m2-pwr;
>>
>> If you remove nodes then clearly you do not share a common design, thus
>> you should not include other DTSI... and definitely even more confusing to
>> include other DTS.
> 
> Hi Krzysztof,
> Ok, it seems I should mark these nodes as disabled instead of delete them, will fix, thanks!

Still wrong. How component present in the board can be missing in the
same time? You included other DTS for a reason which means this board
grows on the previous design.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-01-28 10:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-23  2:44 [PATCH V2 0/2] Add i.MX93 Wireless EVK board support Sherry Sun
2026-01-23  2:44 ` [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board Sherry Sun
2026-01-23  9:00   ` Krzysztof Kozlowski
2026-01-26  2:03     ` Sherry Sun
2026-01-23  2:44 ` [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support Sherry Sun
2026-01-23  9:02   ` Krzysztof Kozlowski
2026-01-23 15:06     ` Frank Li
2026-01-26  2:52     ` Sherry Sun
2026-01-28 10:16       ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox