* [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 3:38 ` Frank Li
2026-07-09 2:30 ` [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe() Pan Chuang
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:THERMAL,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: Pan Chuang
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/imx_thermal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 5aaacbc53478..416d89c6287a 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -732,10 +732,8 @@ static int imx_thermal_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, data->irq,
imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread,
0, "imx_thermal", data);
- if (ret < 0) {
- dev_err(dev, "failed to request alarm irq: %d\n", ret);
+ if (ret < 0)
goto thermal_zone_unregister;
- }
pm_runtime_put(data->dev);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err()
2026-07-09 2:30 ` [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err() Pan Chuang
@ 2026-07-09 3:38 ` Frank Li
0 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2026-07-09 3:38 UTC (permalink / raw)
To: Pan Chuang
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:THERMAL,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Thu, Jul 09, 2026 at 10:30:08AM +0800, Pan Chuang wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/thermal/imx_thermal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index 5aaacbc53478..416d89c6287a 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -732,10 +732,8 @@ static int imx_thermal_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(dev, data->irq,
> imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread,
> 0, "imx_thermal", data);
> - if (ret < 0) {
> - dev_err(dev, "failed to request alarm irq: %d\n", ret);
> + if (ret < 0)
> goto thermal_zone_unregister;
> - }
>
> pm_runtime_put(data->dev);
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
2026-07-09 2:30 ` [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err() Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 2:30 ` [PATCH 09/18] thermal/drivers/brcmstb_thermal: " Pan Chuang
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Heiko Stuebner, open list:THERMAL,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Cc: Pan Chuang
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err_probe() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/rockchip_thermal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index c49ddf70f86e..08891608baa6 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1773,8 +1773,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
IRQF_ONESHOT,
"rockchip_thermal", thermal);
if (error)
- return dev_err_probe(&pdev->dev, error,
- "failed to request tsadc irq.\n");
+ return error;
thermal->chip->control(thermal->regs, true);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 09/18] thermal/drivers/brcmstb_thermal: Remove redundant dev_err_probe()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
2026-07-09 2:30 ` [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 2:30 ` [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: Remove redundant dev_err() Pan Chuang
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Markus Mayer, Broadcom internal kernel review list,
Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Florian Fainelli, open list:BROADCOM STB AVS TMON DRIVER,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE, open list
Cc: Pan Chuang
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err_probe() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/broadcom/brcmstb_thermal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index a9ffa596f7c0..5e23f9e00847 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -356,8 +356,7 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
IRQF_ONESHOT,
DRV_NAME, priv);
if (ret < 0)
- return dev_err_probe(&pdev->dev, ret,
- "could not request IRQ\n");
+ return ret;
}
dev_info(&pdev->dev, "registered AVS TMON of-sensor driver\n");
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: Remove redundant dev_err()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
` (2 preceding siblings ...)
2026-07-09 2:30 ` [PATCH 09/18] thermal/drivers/brcmstb_thermal: " Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 2:30 ` [PATCH 15/18] thermal/drivers/exynos: " Pan Chuang
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, Laura Nao,
Mason Chang, Fei Shao, Frank Wunderlich, Christophe JAILLET,
Jiapeng Chong, open list:THERMAL, open list,
moderated list:ARM/Mediatek SoC support:Keyword:mediatek,
moderated list:ARM/Mediatek SoC support:Keyword:mediatek
Cc: Pan Chuang
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/mediatek/lvts_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index a9617d5e0077..d357968f362b 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -1491,7 +1491,7 @@ static int lvts_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, NULL, lvts_irq_handler,
IRQF_ONESHOT, dev_name(dev), lvts_td);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request interrupt\n");
+ return ret;
platform_set_drvdata(pdev, lvts_td);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 15/18] thermal/drivers/exynos: Remove redundant dev_err()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
` (3 preceding siblings ...)
2026-07-09 2:30 ` [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: Remove redundant dev_err() Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 2:30 ` [PATCH 16/18] thermal/drivers/st: " Pan Chuang
2026-07-09 2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
6 siblings, 0 replies; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski, Rafael J. Wysocki,
Daniel Lezcano, Zhang Rui, Lukasz Luba, Peter Griffin,
Alim Akhtar, open list:SAMSUNG THERMAL DRIVER,
open list:SAMSUNG THERMAL DRIVER,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
Cc: Pan Chuang
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/samsung/exynos_tmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 47a99b3c5395..56717bb50d60 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1102,10 +1102,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
IRQF_TRIGGER_RISING
| IRQF_SHARED | IRQF_ONESHOT,
dev_name(dev), data);
- if (ret) {
- dev_err(dev, "Failed to request irq: %d\n", data->irq);
+ if (ret)
goto err_sclk;
- }
exynos_tmu_control(pdev, true);
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 16/18] thermal/drivers/st: Remove redundant dev_err()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
` (4 preceding siblings ...)
2026-07-09 2:30 ` [PATCH 15/18] thermal/drivers/exynos: " Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 7:33 ` Andy Shevchenko
2026-07-09 2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
6 siblings, 1 reply; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Maxime Coquelin, Alexandre Torgue, Pan Chuang, Andy Shevchenko,
open list:THERMAL, open list,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/st/st_thermal_memmap.c | 4 +---
drivers/thermal/st/stm_thermal.c | 5 +----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/thermal/st/st_thermal_memmap.c b/drivers/thermal/st/st_thermal_memmap.c
index 8f76e50ea567..e3dbe4df80cb 100644
--- a/drivers/thermal/st/st_thermal_memmap.c
+++ b/drivers/thermal/st/st_thermal_memmap.c
@@ -101,10 +101,8 @@ static int st_mmap_register_enable_irq(struct st_thermal_sensor *sensor)
NULL, st_mmap_thermal_trip_handler,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
dev->driver->name, sensor);
- if (ret) {
- dev_err(dev, "failed to register IRQ %d\n", sensor->irq);
+ if (ret)
return ret;
- }
return st_mmap_enable_irq(sensor);
}
diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
index 5d8170bfb382..3290da7ab607 100644
--- a/drivers/thermal/st/stm_thermal.c
+++ b/drivers/thermal/st/stm_thermal.c
@@ -390,11 +390,8 @@ static int stm_register_irq(struct stm_thermal_sensor *sensor)
stm_thermal_irq_handler,
IRQF_ONESHOT,
dev->driver->name, sensor);
- if (ret) {
- dev_err(dev, "%s: Failed to register IRQ %d\n", __func__,
- sensor->irq);
+ if (ret)
return ret;
- }
dev_dbg(dev, "%s: thermal IRQ registered", __func__);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 16/18] thermal/drivers/st: Remove redundant dev_err()
2026-07-09 2:30 ` [PATCH 16/18] thermal/drivers/st: " Pan Chuang
@ 2026-07-09 7:33 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2026-07-09 7:33 UTC (permalink / raw)
To: Pan Chuang
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Maxime Coquelin, Alexandre Torgue, open list:THERMAL, open list,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
On Thu, Jul 09, 2026 at 10:30:19AM +0800, Pan Chuang wrote:
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
Correct.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe()
[not found] <20260709023048.599150-1-panchuang@vivo.com>
` (5 preceding siblings ...)
2026-07-09 2:30 ` [PATCH 16/18] thermal/drivers/st: " Pan Chuang
@ 2026-07-09 2:30 ` Pan Chuang
2026-07-09 3:38 ` Frank Li
6 siblings, 1 reply; 10+ messages in thread
From: Pan Chuang @ 2026-07-09 2:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:THERMAL,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: Pan Chuang
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err_probe() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/imx91_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/imx91_thermal.c b/drivers/thermal/imx91_thermal.c
index 25915bb702be..274eee303142 100644
--- a/drivers/thermal/imx91_thermal.c
+++ b/drivers/thermal/imx91_thermal.c
@@ -331,7 +331,7 @@ static int imx91_tmu_probe(struct platform_device *pdev)
IRQF_ONESHOT, "imx91_thermal", tmu);
if (ret < 0)
- return dev_err_probe(dev, ret, "failed to request alarm irq\n");
+ return ret;
pm_runtime_put(dev);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe()
2026-07-09 2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-09 3:38 ` Frank Li
0 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2026-07-09 3:38 UTC (permalink / raw)
To: Pan Chuang
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:THERMAL,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Thu, Jul 09, 2026 at 10:30:21AM +0800, Pan Chuang wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err_probe() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/thermal/imx91_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx91_thermal.c b/drivers/thermal/imx91_thermal.c
> index 25915bb702be..274eee303142 100644
> --- a/drivers/thermal/imx91_thermal.c
> +++ b/drivers/thermal/imx91_thermal.c
> @@ -331,7 +331,7 @@ static int imx91_tmu_probe(struct platform_device *pdev)
> IRQF_ONESHOT, "imx91_thermal", tmu);
>
> if (ret < 0)
> - return dev_err_probe(dev, ret, "failed to request alarm irq\n");
> + return ret;
>
> pm_runtime_put(dev);
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread