Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: "Peter Chen" <peter.chen@kernel.org>,
	"Pawel Laszczak" <pawell@cadence.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Minas Harutyunyan" <hminas@synopsys.com>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Neal Liu" <neal_liu@aspeedtech.com>,
	"Cristian Birsan" <cristian.birsan@microchip.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Thierry Reding" <thierry.reding@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Mathias Nyman" <mathias.nyman@intel.com>,
	"Al Cooper" <alcooperx@gmail.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Souradeep Chowdhury" <quic_schowdhu@quicinc.com>,
	"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	linux-usb@vger.kernel.org (open list:CADENCE USB3 DRD IP DRIVER),
	linux-kernel@vger.kernel.org (open list),
	linux-arm-kernel@lists.infradead.org (moderated list:GOOGLE
	TENSOR SoC SUPPORT),
	linux-samsung-soc@vger.kernel.org (open list:GOOGLE TENSOR SoC
	SUPPORT),
	imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
	ARCHITECTURE),
	linux-omap@vger.kernel.org (open list:OMAP USB SUPPORT),
	linux-aspeed@lists.ozlabs.org (moderated list:ARM/ASPEED MACHINE
	SUPPORT),
	linux-renesas-soc@vger.kernel.org (open list:RENESAS RZ/N1 USBF
	CONTROLLER DRIVER),
	linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE
	SUPPORT),
	linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING
	LIST),
	linux-mediatek@lists.infradead.org (moderated list:MEDIATEK USB3
	DRD IP DRIVER)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure
Date: Fri, 31 Jul 2026 11:54:34 +0800	[thread overview]
Message-ID: <20260731035448.252289-1-panchuang@vivo.com> (raw)

devm_request_threaded_irq() and devm_request_any_context_irq()
automatically log detailed error messages on failure via
the devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in usb drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (11):
  usb: cdns3: Remove redundant dev_err()
  usb: common: usb-conn-gpio: Remove redundant dev_err()
  usb: dwc2: gadget: Remove redundant dev_err()
  usb: dwc3: Remove redundant dev_err()/dev_err_probe()
  usb: gadget: Remove redundant dev_err()
  usb: host: xhci-tegra: Remove redundant dev_err()
  usb: misc: Remove redundant dev_err()/dev_err_probe()
  usb: mtu3: Remove redundant dev_err()
  usb: phy: Remove redundant dev_err()/dev_err_probe()
  usb: renesas_usbhs: Remove redundant dev_err()
  usb: typec: Remove redundant dev_err()/dev_err_probe()

 drivers/usb/cdns3/core.c                  |  4 +---
 drivers/usb/cdns3/drd.c                   |  4 +---
 drivers/usb/common/usb-conn-gpio.c        |  8 ++------
 drivers/usb/dwc2/gadget.c                 |  4 +---
 drivers/usb/dwc3/dwc3-google.c            |  4 +---
 drivers/usb/dwc3/dwc3-imx.c               |  2 +-
 drivers/usb/dwc3/dwc3-imx8mp.c            |  4 +---
 drivers/usb/dwc3/dwc3-keystone.c          |  5 +----
 drivers/usb/dwc3/dwc3-omap.c              |  5 +----
 drivers/usb/gadget/udc/aspeed-vhub/core.c |  4 +---
 drivers/usb/gadget/udc/aspeed_udc.c       |  4 +---
 drivers/usb/gadget/udc/atmel_usba_udc.c   |  5 +----
 drivers/usb/gadget/udc/r8a66597-udc.c     |  4 +---
 drivers/usb/gadget/udc/renesas_usbf.c     |  8 ++------
 drivers/usb/gadget/udc/snps_udc_plat.c    |  4 +---
 drivers/usb/gadget/udc/tegra-xudc.c       |  5 +----
 drivers/usb/host/xhci-tegra.c             |  8 ++------
 drivers/usb/misc/brcmstb-usb-pinmap.c     |  9 ++-------
 drivers/usb/misc/qcom_eud.c               |  2 +-
 drivers/usb/mtu3/mtu3_core.c              |  4 +---
 drivers/usb/phy/phy-ab8500-usb.c          | 12 +++---------
 drivers/usb/phy/phy-generic.c             |  3 +--
 drivers/usb/phy/phy-gpio-vbus-usb.c       |  5 +----
 drivers/usb/renesas_usbhs/mod.c           |  4 +---
 drivers/usb/typec/anx7411.c               |  4 +---
 drivers/usb/typec/hd3ss3220.c             |  4 +---
 drivers/usb/typec/mux/it5205.c            |  2 +-
 drivers/usb/typec/tcpm/tcpci_maxim_core.c |  3 +--
 drivers/usb/typec/tcpm/tcpci_mt6360.c     |  1 -
 drivers/usb/typec/tcpm/tcpci_mt6370.c     |  2 +-
 30 files changed, 35 insertions(+), 102 deletions(-)

-- 
2.34.1



             reply	other threads:[~2026-07-31  3:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  3:54 Pan Chuang [this message]
2026-07-31  3:54 ` [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-31 14:45   ` Frank Li
2026-08-05  1:00   ` Thinh Nguyen
2026-07-31  3:54 ` [PATCH 05/11] usb: gadget: Remove redundant dev_err() Pan Chuang
2026-07-31 22:41   ` Herve Codina
2026-07-31  3:54 ` [PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-31  3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
2026-07-31  3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-08-05 12:12   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260731035448.252289-1-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=Frank.Li@nxp.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alcooperx@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andre.draszik@linaro.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=cristian.birsan@microchip.com \
    --cc=festevam@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=herve.codina@bootlin.com \
    --cc=hminas@synopsys.com \
    --cc=imx@lists.linux.dev \
    --cc=joel@jms.id.au \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=neal_liu@aspeedtech.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=pawell@cadence.com \
    --cc=peter.chen@kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=quic_schowdhu@quicinc.com \
    --cc=rogerq@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=thierry.reding@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox