From: Herve Codina <herve.codina@bootlin.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Neal Liu <neal_liu@aspeedtech.com>,
Cristian Birsan <cristian.birsan@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-usb@vger.kernel.org (open list:USB SUBSYSTEM),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/ASPEED
MACHINE SUPPORT),
linux-aspeed@lists.ozlabs.org (moderated list:ARM/ASPEED MACHINE
SUPPORT), linux-kernel@vger.kernel.org (open list),
linux-renesas-soc@vger.kernel.org (open list:RENESAS RZ/N1 USBF
CONTROLLER DRIVER),
linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE
SUPPORT)
Subject: Re: [PATCH 05/11] usb: gadget: Remove redundant dev_err()
Date: Sat, 1 Aug 2026 00:41:43 +0200 [thread overview]
Message-ID: <20260801004143.1b0d864d@bootlin.com> (raw)
In-Reply-To: <20260731035448.252289-6-panchuang@vivo.com>
Hi Pan,
On Fri, 31 Jul 2026 11:54:39 +0800
Pan Chuang <panchuang@vivo.com> wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
> devm_request_irq() and devm_request_threaded_irq() automatically log
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/usb/gadget/udc/aspeed-vhub/core.c | 4 +---
> drivers/usb/gadget/udc/aspeed_udc.c | 4 +---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 5 +----
> drivers/usb/gadget/udc/r8a66597-udc.c | 4 +---
> drivers/usb/gadget/udc/renesas_usbf.c | 8 ++------
> drivers/usb/gadget/udc/snps_udc_plat.c | 4 +---
> drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
> 7 files changed, 8 insertions(+), 26 deletions(-)
>
LGTM for renesas_usbf.c.
Reviewed-by: Herve Codina <herve.codina@bootlin.com> # renesas_usbf.c
Best regards,
Hervé
next prev parent reply other threads:[~2026-07-31 22:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-31 14:45 ` Frank Li
2026-07-31 3:54 ` [PATCH 05/11] usb: gadget: Remove redundant dev_err() Pan Chuang
2026-07-31 22:41 ` Herve Codina [this message]
2026-07-31 3:54 ` [PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801004143.1b0d864d@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@codeconstruct.com.au \
--cc=claudiu.beznea@tuxon.dev \
--cc=cristian.birsan@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=nicolas.ferre@microchip.com \
--cc=panchuang@vivo.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox