From: Pan Chuang <panchuang@vivo.com>
To: "Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org (moderated list:GOOGLE
TENSOR SoC SUPPORT),
linux-samsung-soc@vger.kernel.org (open list:GOOGLE TENSOR SoC
SUPPORT),
linux-usb@vger.kernel.org (open list:DESIGNWARE USB3 DRD IP
DRIVER), linux-kernel@vger.kernel.org (open list),
imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
ARCHITECTURE),
linux-omap@vger.kernel.org (open list:OMAP USB SUPPORT)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe()
Date: Fri, 31 Jul 2026 11:54:38 +0800 [thread overview]
Message-ID: <20260731035448.252289-5-panchuang@vivo.com> (raw)
In-Reply-To: <20260731035448.252289-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/dwc3/dwc3-google.c | 4 +---
drivers/usb/dwc3/dwc3-imx.c | 2 +-
drivers/usb/dwc3/dwc3-imx8mp.c | 4 +---
drivers/usb/dwc3/dwc3-keystone.c | 5 +----
drivers/usb/dwc3/dwc3-omap.c | 5 +----
5 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
index 60ee4cc99b28..e581d407b872 100644
--- a/drivers/usb/dwc3/dwc3-google.c
+++ b/drivers/usb/dwc3/dwc3-google.c
@@ -235,10 +235,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
dwc3_google_resume_irq,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
req_name, google);
- if (ret < 0) {
- dev_err(google->dev, "failed to request irq %s\n", req_name);
+ if (ret < 0)
return ret;
- }
return irq;
}
diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c
index 973a486b544d..d967acd43d44 100644
--- a/drivers/usb/dwc3/dwc3-imx.c
+++ b/drivers/usb/dwc3/dwc3-imx.c
@@ -250,7 +250,7 @@ static int dwc3_imx_probe(struct platform_device *pdev)
IRQF_ONESHOT | IRQF_NO_AUTOEN,
irq_name, dwc_imx);
if (ret)
- return dev_err_probe(dev, ret, "failed to request IRQ #%d\n", irq);
+ return ret;
ret = device_add_software_node(dev, &dwc3_imx_swnode);
if (ret)
diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index 1cf96540b66e..ee92a5efaa6e 100644
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -273,10 +273,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt,
IRQF_ONESHOT, dev_name(dev), dwc3_imx);
- if (err) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
+ if (err)
goto put_dwc3;
- }
device_set_wakeup_capable(dev, true);
pm_runtime_put(dev);
diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
index 7ee1610162b9..8ad302abe883 100644
--- a/drivers/usb/dwc3/dwc3-keystone.c
+++ b/drivers/usb/dwc3/dwc3-keystone.c
@@ -144,11 +144,8 @@ static int kdwc3_probe(struct platform_device *pdev)
error = devm_request_irq(dev, irq, dwc3_keystone_interrupt, IRQF_SHARED,
dev_name(dev), kdwc);
- if (error) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n",
- irq, error);
+ if (error)
goto err_irq;
- }
kdwc3_enable_irqs(kdwc);
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index fe74d11bb629..3bff775fbe4e 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -518,11 +518,8 @@ static int dwc3_omap_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt,
dwc3_omap_interrupt_thread, IRQF_SHARED,
"dwc3-omap", omap);
- if (ret) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n",
- omap->irq, ret);
+ if (ret)
goto err2;
- }
dwc3_omap_enable_irqs(omap);
return 0;
--
2.34.1
next prev parent reply other threads:[~2026-07-31 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` Pan Chuang [this message]
2026-07-31 14:45 ` [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Frank Li
2026-08-05 1:00 ` Thinh Nguyen
2026-07-31 3:54 ` [PATCH 05/11] usb: gadget: Remove redundant dev_err() Pan Chuang
2026-07-31 22:41 ` Herve Codina
2026-07-31 3:54 ` [PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-08-05 12:12 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731035448.252289-5-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Frank.Li@nxp.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andre.draszik@linaro.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox