Re:Re: [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA

[huanglei <huanglei814@163.com>]

    Even if MAX_SMA_CANNELS is not defined, as long as GENETIC-SIA_DMA is enabled， request_rma/free_rma  function will also be exported, and other modules using these two interfaces will not encounter link errors.

    I don't know why others haven't noticed, but I discovered it when debugging pcie parallel port drivers.  And the arm/Kconfig  has been around for a long time.


Best regards!

At 2024-10-28 22:05:45, "Will Deacon" <will@kernel.org> wrote:
>On Fri, Oct 25, 2024 at 09:16:41AM +0800, huanglei814 wrote:
>> From: huanglei <huanglei@kylinos.cn>
>> 
>> Enable GENERIC_ISA_DMA feature on arm64 platform,
>> thus, request_dma and free_dma interface can be export.
>> and driver modules can use the this interfaces on arm64
>> platform.
>> 
>> Currently, many pcie parallel port drivers still use these
>> interfaces when ported to arm64 platform.
>
>Why has it taken so long for anybody to notice?
>
>> Signed-off-by: huanglei <huanglei@kylinos.cn>
>> ---
>>  arch/arm64/Kconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index fd9df6dcc593..986eb251f68f 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -367,6 +367,9 @@ config GENERIC_CSUM
>>  config GENERIC_CALIBRATE_DELAY
>>  	def_bool y
>>  
>> +config GENERIC_ISA_DMA
>> +	def_bool y
>> +
>
>Does this actually do anything without MAX_DMA_CHANNELS defined?
>
>Will