From: huanglei <huanglei814@163.com>
To: "Will Deacon" <will@kernel.org>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, huanglei <huanglei@kylinos.cn>
Subject: Re:Re:Re: [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA
Date: Tue, 29 Oct 2024 09:57:51 +0800 (CST) [thread overview]
Message-ID: <7f60ff1f.1d51.192d5fe6248.Coremail.huanglei814@163.com> (raw)
In-Reply-To: <26ed8fbb.1809.192d5ef13e5.Coremail.huanglei814@163.com>
There was a slight word spelling error in the previous reply, Now correct it.
Even if MAX_DMA_CHANNELS is not defined, as long as GENERIC_ISA_DMA is enabled, request_dma/free_dma function will also be exported, and other modules using these two interfaces will not encounter link errors.
I don't know why others haven't noticed, but I discovered it when debugging pcie parallel port drivers. And the arm/Kconfig has been around for a long time.
Best regards!
>At 2024-10-28 22:05:45, "Will Deacon" <will@kernel.org> wrote:
>>On Fri, Oct 25, 2024 at 09:16:41AM +0800, huanglei814 wrote:
>>> From: huanglei <huanglei@kylinos.cn>
>>>
>>> Enable GENERIC_ISA_DMA feature on arm64 platform,
>>> thus, request_dma and free_dma interface can be export.
>>> and driver modules can use the this interfaces on arm64
>>> platform.
>>>
>>> Currently, many pcie parallel port drivers still use these
>>> interfaces when ported to arm64 platform.
>>
>>Why has it taken so long for anybody to notice?
>>
>>> Signed-off-by: huanglei <huanglei@kylinos.cn>
>>> ---
>>> arch/arm64/Kconfig | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index fd9df6dcc593..986eb251f68f 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -367,6 +367,9 @@ config GENERIC_CSUM
>>> config GENERIC_CALIBRATE_DELAY
>>> def_bool y
>>>
>>> +config GENERIC_ISA_DMA
>>> + def_bool y
>>> +
>>
>>Does this actually do anything without MAX_DMA_CHANNELS defined?
>>
>>Will
next prev parent reply other threads:[~2024-10-29 1:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 1:16 [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA huanglei814
2024-10-28 15:05 ` Will Deacon
2024-10-29 1:41 ` huanglei
2024-10-29 1:57 ` huanglei [this message]
2024-10-29 13:20 ` Will Deacon
2024-10-29 20:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f60ff1f.1d51.192d5fe6248.Coremail.huanglei814@163.com \
--to=huanglei814@163.com \
--cc=catalin.marinas@arm.com \
--cc=huanglei@kylinos.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox