public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Will Deacon" <will@kernel.org>, huanglei <huanglei814@163.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, huanglei <huanglei@kylinos.cn>
Subject: Re: [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA
Date: Tue, 29 Oct 2024 20:35:39 +0000	[thread overview]
Message-ID: <5f93d7a3-082d-455c-b458-a9c2113eb512@app.fastmail.com> (raw)
In-Reply-To: <20241029132042.GA4416@willie-the-truck>

On Tue, Oct 29, 2024, at 13:20, Will Deacon wrote:
> On Tue, Oct 29, 2024 at 09:41:08AM +0800, huanglei wrote:
>>
>>     Even if MAX_SMA_CANNELS is not defined, as long as GENETIC-SIA_DMA is
>>     enabled, request_rma/free_rma  function will also be exported, and
>>     other modules using these two interfaces will not encounter link
>>     errors.
>
> Do the drivers do anything useful after they've linked? Can you please
> provide some in-tree examples of drivers that can be used on arm64 only
> once GENERIC_ISA_DMA is selected? If they just need some stubs for
> request_dma() and free_dma(), then it feels to me like that should be
> the default implementation, rather than having to select something to
> get them.

GENERIC_ISA_DMA does nothing by iself, there also needs to
be an iplementation of CONFIG_ISA_DMA_API in order to use
DMA mode on floppy/parport/soundblaster.

I think this should not be enabled by the architecture
itself, but by the LPC host driver that provides the ISA
style DMA. Most LPC implementations don't have this, and
most arm64 machines have no LPC or PC104 at all.

Note that PCI-ISA bridges can sometimes provide ISA devices,
but ISA DMA won't work behind a PCIe bridge.

The patch also needs a better changelog text to explain
specifically which arm64 platform has PC style DMA support,
and what devices are connected to it. 

     Arnd


      reply	other threads:[~2024-10-29 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25  1:16 [PATCH] arm64/Kconfig: introduce GENERIC_ISA_DMA huanglei814
2024-10-28 15:05 ` Will Deacon
2024-10-29  1:41   ` huanglei
2024-10-29  1:57     ` huanglei
2024-10-29 13:20     ` Will Deacon
2024-10-29 20:35       ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f93d7a3-082d-455c-b458-a9c2113eb512@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=huanglei814@163.com \
    --cc=huanglei@kylinos.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox