From: "Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>
To: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Bibby Hsieh (謝濟遠)" <Bibby.Hsieh@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"djkurtz@chromium.org" <djkurtz@chromium.org>,
"Markus.Elfring@web.de" <Markus.Elfring@web.de>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"littlecvr@chromium.org" <littlecvr@chromium.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Cc: "YT Shen (沈岳霆)" <Yt.Shen@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 04/14] drm/mediatek: Fix XRGB setting error in Mixer
Date: Wed, 9 Oct 2024 06:27:59 +0000 [thread overview]
Message-ID: <2f1aef50c4a72f0d901191e18aa537e62cbc1fd1.camel@mediatek.com> (raw)
In-Reply-To: <81ce44fa-a972-44bd-ae80-6144a8ac4c2f@web.de>
On Mon, 2024-10-07 at 13:36 +0200, Markus Elfring wrote:
> > Although the alpha channel in XRGB formats can be ignored,
> > ALPHA_CON
> > must be configured accordingly when using XRGB formats or it will
> > still
> > affects CRC generation.
>
> affect?
Yes, didn't notice that.
This is a typo, but the series has been merged.
>
>
> Can such a change description become a bit nicer with an additional
> imperative wording?
>
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94
Honestly, I wasn't familiar with the term "imerative mood" before this.
After studying it, I now understand. Thank you for pointing this out; I
will keep this in mind for the future.
As a result, I asked AI to refine the description using imperative
wording as a reference example:
"Ensure that ALPHA_CON is configured appropriately when using XRGB
formats, even though the alpha channel can be ignored. Failing to do so
will affect CRC generation."
Regards,
Shawn
>
> Regards,
> Markus
next prev parent reply other threads:[~2024-10-09 6:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 16:38 [PATCH v3 00/14] This series fixes the errors of MediaTek display driver found by IGT Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 01/14] drm/mediatek: Add missing plane settings when async update Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 02/14] drm/mediatek: Use 8-bit alpha in ETHDR Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 03/14] drm/mediatek: Fix XRGB setting error in OVL Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 04/14] drm/mediatek: Fix XRGB setting error in Mixer Hsiao Chien Sung via B4 Relay
2024-10-07 11:36 ` Markus Elfring
2024-10-09 6:27 ` Shawn Sung (宋孝謙) [this message]
2024-06-19 16:38 ` [PATCH v3 05/14] drm/mediatek: Fix destination alpha error in OVL Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 06/14] drm/mediatek: Turn off the layers with zero width or height Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 07/14] drm/mediatek: Add OVL compatible name for MT8195 Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 08/14] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property Hsiao Chien Sung via B4 Relay
2024-10-24 20:47 ` Doug Anderson
2024-10-25 1:32 ` Shawn Sung (宋孝謙)
2024-10-25 16:35 ` Doug Anderson
2024-10-26 4:10 ` Shawn Sung (宋孝謙)
2024-06-19 16:38 ` [PATCH v3 09/14] drm/mediatek: Add new color format MACROs in OVL Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 10/14] drm/mediatek: Set DRM mode configs accordingly Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 11/14] drm/mediatek: Support more 10bit formats in OVL Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 12/14] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195 Hsiao Chien Sung via B4 Relay
2024-06-19 16:38 ` [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL Hsiao Chien Sung via B4 Relay
2024-09-30 17:48 ` Adam Thiede
2024-10-01 8:55 ` CK Hu (胡俊光)
2024-10-01 18:02 ` Jason-JH Lin (林睿祥)
2024-10-01 19:51 ` Adam Thiede
2024-10-02 7:50 ` Jason-JH Lin (林睿祥)
2024-10-02 15:28 ` Adam Thiede
2024-10-03 5:17 ` Jason-JH Lin (林睿祥)
2024-10-03 15:29 ` Adam Thiede
2024-10-05 5:54 ` Yassine Oudjana
2024-10-05 6:33 ` Yassine Oudjana
2024-10-05 10:02 ` Jason-JH Lin (林睿祥)
2024-10-05 17:32 ` Adam Thiede
2024-10-07 7:22 ` Jason-JH Lin (林睿祥)
2024-10-07 10:54 ` Adam Thiede
2024-10-07 14:38 ` Jason-JH Lin (林睿祥)
2024-06-19 16:38 ` [PATCH v3 14/14] drm/mediatek: Support DRM plane alpha in Mixer Hsiao Chien Sung via B4 Relay
2024-06-20 14:16 ` [PATCH v3 00/14] This series fixes the errors of MediaTek display driver found by IGT Chun-Kuang Hu
2024-06-21 1:52 ` Shawn Sung (宋孝謙)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1aef50c4a72f0d901191e18aa537e62cbc1fd1.camel@mediatek.com \
--to=shawn.sung@mediatek.com \
--cc=Bibby.Hsieh@mediatek.com \
--cc=Markus.Elfring@web.de \
--cc=Nancy.Lin@mediatek.com \
--cc=Yt.Shen@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=littlecvr@chromium.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox