* [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC
@ 2024-03-29 13:01 Renze Nicolai
2024-03-29 13:01 ` [PATCH 1/3] ARM: dts: Modify GPIO table for " Renze Nicolai
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Renze Nicolai @ 2024-03-29 13:01 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd,
olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew, renze
Hello,
These patches change the GPIO table, ADC channel configuration and
I2C bus configuration of the devicetree for the X570D4U BMC as part of
ongoing efforts to support OpenBMC on this platform.
Best regards,
Renze Nicolai
Renze Nicolai (3):
ARM: dts: Modify GPIO table for Asrock X570D4U BMC
ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC
ARM: dts: Modify I2C bus configuration
.../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 152 +++++++++---------
1 file changed, 78 insertions(+), 74 deletions(-)
--
2.44.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/3] ARM: dts: Modify GPIO table for Asrock X570D4U BMC 2024-03-29 13:01 [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC Renze Nicolai @ 2024-03-29 13:01 ` Renze Nicolai 2024-04-03 3:21 ` Andrew Jeffery 2024-03-29 13:01 ` [PATCH 2/3] ARM: dts: Disable unused ADC channels " Renze Nicolai 2024-03-29 13:01 ` [PATCH 3/3] ARM: dts: Modify I2C bus configuration Renze Nicolai 2 siblings, 1 reply; 7+ messages in thread From: Renze Nicolai @ 2024-03-29 13:01 UTC (permalink / raw) To: linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd, olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew, renze This commit removes button-nmi-n, this board does not have support for an NMI button. Input status-locatorled-n has been renamed to input-locatorled-n to better indicate the signal type. The suffix -n has been appended to the name of control-locatorbutton, button-power, control-power, button-reset, control-reset, input-id0, input-id1, input-id2, output-bmc-ready to reflect the inverted signal polarity. GPIO output-rtc-battery-voltage-read-enable has been renamed to output-hwm-vbat-enable, input-alert1-n to input-aux-smb-alert-n, input-alert3-n to input-psu-smb-alert-n, input-mfg to input-mfg-mode-n and input-caseopen to input-case-open-n. And GPIOs input-bmc-smb-present-n, input-pcie-wake-n, input-sleep-s3-n, input-sleep-s5-n and input-power-good have been added. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 116 +++++++++--------- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts index 3c975bc41ae7..34bc382bf492 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts @@ -79,64 +79,64 @@ iio-hwmon { &gpio { status = "okay"; gpio-line-names = - /*A0-A3*/ "status-locatorled-n", "", "button-nmi-n", "", - /*A4-A7*/ "", "", "", "", - /*B0-B3*/ "input-bios-post-cmplt-n", "", "", "", - /*B4-B7*/ "", "", "", "", - /*C0-C3*/ "", "", "", "", - /*C4-C7*/ "", "", "control-locatorbutton", "", - /*D0-D3*/ "button-power", "control-power", "button-reset", "control-reset", - /*D4-D7*/ "", "", "", "", - /*E0-E3*/ "", "", "", "", - /*E4-E7*/ "", "", "", "", - /*F0-F3*/ "", "", "", "", - /*F4-F7*/ "", "", "", "", - /*G0-G3*/ "output-rtc-battery-voltage-read-enable", "input-id0", "input-id1", "input-id2", - /*G4-G7*/ "input-alert1-n", "input-alert2-n", "input-alert3-n", "", - /*H0-H3*/ "", "", "", "", - /*H4-H7*/ "input-mfg", "", "led-heartbeat-n", "input-caseopen", - /*I0-I3*/ "", "", "", "", - /*I4-I7*/ "", "", "", "", - /*J0-J3*/ "output-bmc-ready", "", "", "", - /*J4-J7*/ "", "", "", "", - /*K0-K3*/ "", "", "", "", - /*K4-K7*/ "", "", "", "", - /*L0-L3*/ "", "", "", "", - /*L4-L7*/ "", "", "", "", - /*M0-M3*/ "", "", "", "", - /*M4-M7*/ "", "", "", "", - /*N0-N3*/ "", "", "", "", - /*N4-N7*/ "", "", "", "", - /*O0-O3*/ "", "", "", "", - /*O4-O7*/ "", "", "", "", - /*P0-P3*/ "", "", "", "", - /*P4-P7*/ "", "", "", "", - /*Q0-Q3*/ "", "", "", "", - /*Q4-Q7*/ "", "", "", "", - /*R0-R3*/ "", "", "", "", - /*R4-R7*/ "", "", "", "", - /*S0-S3*/ "input-bmc-pchhot-n", "", "", "", - /*S4-S7*/ "", "", "", "", - /*T0-T3*/ "", "", "", "", - /*T4-T7*/ "", "", "", "", - /*U0-U3*/ "", "", "", "", - /*U4-U7*/ "", "", "", "", - /*V0-V3*/ "", "", "", "", - /*V4-V7*/ "", "", "", "", - /*W0-W3*/ "", "", "", "", - /*W4-W7*/ "", "", "", "", - /*X0-X3*/ "", "", "", "", - /*X4-X7*/ "", "", "", "", - /*Y0-Y3*/ "", "", "", "", - /*Y4-Y7*/ "", "", "", "", - /*Z0-Z3*/ "", "", "led-fault-n", "output-bmc-throttle-n", - /*Z4-Z7*/ "", "", "", "", - /*AA0-AA3*/ "input-cpu1-thermtrip-latch-n", "", "input-cpu1-prochot-n", "", - /*AA4-AC7*/ "", "", "", "", - /*AB0-AB3*/ "", "", "", "", - /*AB4-AC7*/ "", "", "", "", - /*AC0-AC3*/ "", "", "", "", - /*AC4-AC7*/ "", "", "", ""; + /*A0-A3*/ "input-locatorled-n", "", "", "", + /*A4-A7*/ "", "", "", "", + /*B0-B3*/ "input-bios-post-cmplt-n", "", "", "", + /*B4-B7*/ "", "", "", "", + /*C0-C3*/ "", "", "", "", + /*C4-C7*/ "", "", "control-locatorbutton-n", "", + /*D0-D3*/ "button-power-n", "control-power-n", "button-reset-n", "control-reset-n", + /*D4-D7*/ "", "", "", "", + /*E0-E3*/ "", "", "", "", + /*E4-E7*/ "", "", "", "", + /*F0-F3*/ "", "", "", "", + /*F4-F7*/ "", "", "", "", + /*G0-G3*/ "output-hwm-vbat-enable", "input-id0-n", "input-id1-n", "input-id2-n", + /*G4-G7*/ "input-aux-smb-alert-n", "", "input-psu-smb-alert-n", "", + /*H0-H3*/ "", "", "", "", + /*H4-H7*/ "input-mfg-mode-n", "", "led-heartbeat-n", "input-case-open-n", + /*I0-I3*/ "", "", "", "", + /*I4-I7*/ "", "", "", "", + /*J0-J3*/ "output-bmc-ready-n", "", "", "", + /*J4-J7*/ "", "", "", "", + /*K0-K3*/ "", "", "", "", + /*K4-K7*/ "", "", "", "", + /*L0-L3*/ "", "", "", "", + /*L4-L7*/ "", "", "", "", + /*M0-M3*/ "", "", "", "", + /*M4-M7*/ "", "", "", "", + /*N0-N3*/ "", "", "", "", + /*N4-N7*/ "", "", "", "", + /*O0-O3*/ "", "", "", "", + /*O4-O7*/ "", "", "", "", + /*P0-P3*/ "", "", "", "", + /*P4-P7*/ "", "", "", "", + /*Q0-Q3*/ "", "", "", "", + /*Q4-Q7*/ "input-bmc-smb-present-n", "", "", "input-pcie-wake-n", + /*R0-R3*/ "", "", "", "", + /*R4-R7*/ "", "", "", "", + /*S0-S3*/ "input-bmc-pchhot-n", "", "", "", + /*S4-S7*/ "", "", "", "", + /*T0-T3*/ "", "", "", "", + /*T4-T7*/ "", "", "", "", + /*U0-U3*/ "", "", "", "", + /*U4-U7*/ "", "", "", "", + /*V0-V3*/ "", "", "", "", + /*V4-V7*/ "", "", "", "", + /*W0-W3*/ "", "", "", "", + /*W4-W7*/ "", "", "", "", + /*X0-X3*/ "", "", "", "", + /*X4-X7*/ "", "", "", "", + /*Y0-Y3*/ "input-sleep-s3-n", "input-sleep-s5-n", "", "", + /*Y4-Y7*/ "", "", "", "", + /*Z0-Z3*/ "", "", "led-fault-n", "output-bmc-throttle-n", + /*Z4-Z7*/ "", "", "", "", + /*AA0-AA3*/ "input-cpu1-thermtrip-latch-n", "", "input-cpu1-prochot-n", "", + /*AA4-AC7*/ "", "", "", "", + /*AB0-AB3*/ "", "input-power-good", "", "", + /*AB4-AC7*/ "", "", "", "", + /*AC0-AC3*/ "", "", "", "", + /*AC4-AC7*/ "", "", "", ""; }; &fmc { -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] ARM: dts: Modify GPIO table for Asrock X570D4U BMC 2024-03-29 13:01 ` [PATCH 1/3] ARM: dts: Modify GPIO table for " Renze Nicolai @ 2024-04-03 3:21 ` Andrew Jeffery 0 siblings, 0 replies; 7+ messages in thread From: Andrew Jeffery @ 2024-04-03 3:21 UTC (permalink / raw) To: Renze Nicolai, linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd, olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew Hi Renze, Do you mind running this patch and the others in the series through ./scripts/checkpatch.pl? Generally patches sent to the list should not generate warnings. It looks like these patches are generated against Joel's bmc/for-next branch. He's applied your original X570D4U devicetree patch there, (though that also causes checkpatch warnings). On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote: > This commit removes button-nmi-n, this board does not have support for an NMI button. > Input status-locatorled-n has been renamed to input-locatorled-n to better indicate the signal type. > The suffix -n has been appended to the name of control-locatorbutton, button-power, control-power, button-reset, control-reset, input-id0, input-id1, input-id2, output-bmc-ready to reflect the inverted signal polarity. > GPIO output-rtc-battery-voltage-read-enable has been renamed to output-hwm-vbat-enable, input-alert1-n to input-aux-smb-alert-n, input-alert3-n to input-psu-smb-alert-n, input-mfg to input-mfg-mode-n and input-caseopen to input-case-open-n. > And GPIOs input-bmc-smb-present-n, input-pcie-wake-n, input-sleep-s3-n, input-sleep-s5-n and input-power-good have been added. > For instance, checkpatch warns about these lines in the commit message being too long. They should be wrapped at 72 characters. Additionally, the description forms a bit of a list of things the patch is doing. Patches are easier to review when they only do one thing, as it removes the need to assess whether there are subtle interactions between the several things, and if so, whether they're expected and correct. I'd prefer this change be split up so there's no need for such concerns. > Signed-off-by: Renze Nicolai <renze@rnplus.nl> > --- > .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 116 +++++++++--------- > 1 file changed, 58 insertions(+), 58 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts > index 3c975bc41ae7..34bc382bf492 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts > @@ -79,64 +79,64 @@ iio-hwmon { > &gpio { > status = "okay"; > gpio-line-names = > - /*A0-A3*/ "status-locatorled-n", "", "button-nmi-n", "", > - /*A4-A7*/ "", "", "", "", > - /*B0-B3*/ "input-bios-post-cmplt-n", "", "", "", > - /*B4-B7*/ "", "", "", "", > - /*C0-C3*/ "", "", "", "", > - /*C4-C7*/ "", "", "control-locatorbutton", "", > - /*D0-D3*/ "button-power", "control-power", "button-reset", "control-reset", > - /*D4-D7*/ "", "", "", "", > - /*E0-E3*/ "", "", "", "", > - /*E4-E7*/ "", "", "", "", > - /*F0-F3*/ "", "", "", "", > - /*F4-F7*/ "", "", "", "", > - /*G0-G3*/ "output-rtc-battery-voltage-read-enable", "input-id0", "input-id1", "input-id2", > - /*G4-G7*/ "input-alert1-n", "input-alert2-n", "input-alert3-n", "", > - /*H0-H3*/ "", "", "", "", > - /*H4-H7*/ "input-mfg", "", "led-heartbeat-n", "input-caseopen", > - /*I0-I3*/ "", "", "", "", > - /*I4-I7*/ "", "", "", "", > - /*J0-J3*/ "output-bmc-ready", "", "", "", > - /*J4-J7*/ "", "", "", "", > - /*K0-K3*/ "", "", "", "", > - /*K4-K7*/ "", "", "", "", > - /*L0-L3*/ "", "", "", "", > - /*L4-L7*/ "", "", "", "", > - /*M0-M3*/ "", "", "", "", > - /*M4-M7*/ "", "", "", "", > - /*N0-N3*/ "", "", "", "", > - /*N4-N7*/ "", "", "", "", > - /*O0-O3*/ "", "", "", "", > - /*O4-O7*/ "", "", "", "", > - /*P0-P3*/ "", "", "", "", > - /*P4-P7*/ "", "", "", "", > - /*Q0-Q3*/ "", "", "", "", > - /*Q4-Q7*/ "", "", "", "", > - /*R0-R3*/ "", "", "", "", > - /*R4-R7*/ "", "", "", "", > - /*S0-S3*/ "input-bmc-pchhot-n", "", "", "", > - /*S4-S7*/ "", "", "", "", > - /*T0-T3*/ "", "", "", "", > - /*T4-T7*/ "", "", "", "", > - /*U0-U3*/ "", "", "", "", > - /*U4-U7*/ "", "", "", "", > - /*V0-V3*/ "", "", "", "", > - /*V4-V7*/ "", "", "", "", > - /*W0-W3*/ "", "", "", "", > - /*W4-W7*/ "", "", "", "", > - /*X0-X3*/ "", "", "", "", > - /*X4-X7*/ "", "", "", "", > - /*Y0-Y3*/ "", "", "", "", > - /*Y4-Y7*/ "", "", "", "", > - /*Z0-Z3*/ "", "", "led-fault-n", "output-bmc-throttle-n", > - /*Z4-Z7*/ "", "", "", "", > - /*AA0-AA3*/ "input-cpu1-thermtrip-latch-n", "", "input-cpu1-prochot-n", "", > - /*AA4-AC7*/ "", "", "", "", > - /*AB0-AB3*/ "", "", "", "", > - /*AB4-AC7*/ "", "", "", "", > - /*AC0-AC3*/ "", "", "", "", > - /*AC4-AC7*/ "", "", "", ""; > + /*A0-A3*/ "input-locatorled-n", "", "", "", > + /*A4-A7*/ "", "", "", "", > + /*B0-B3*/ "input-bios-post-cmplt-n", "", "", "", > + /*B4-B7*/ "", "", "", "", > + /*C0-C3*/ "", "", "", "", > + /*C4-C7*/ "", "", "control-locatorbutton-n", "", > + /*D0-D3*/ "button-power-n", "control-power-n", "button-reset-n", "control-reset-n", > + /*D4-D7*/ "", "", "", "", > + /*E0-E3*/ "", "", "", "", > + /*E4-E7*/ "", "", "", "", > + /*F0-F3*/ "", "", "", "", > + /*F4-F7*/ "", "", "", "", > + /*G0-G3*/ "output-hwm-vbat-enable", "input-id0-n", "input-id1-n", "input-id2-n", > + /*G4-G7*/ "input-aux-smb-alert-n", "", "input-psu-smb-alert-n", "", > + /*H0-H3*/ "", "", "", "", > + /*H4-H7*/ "input-mfg-mode-n", "", "led-heartbeat-n", "input-case-open-n", > + /*I0-I3*/ "", "", "", "", > + /*I4-I7*/ "", "", "", "", > + /*J0-J3*/ "output-bmc-ready-n", "", "", "", > + /*J4-J7*/ "", "", "", "", > + /*K0-K3*/ "", "", "", "", > + /*K4-K7*/ "", "", "", "", > + /*L0-L3*/ "", "", "", "", > + /*L4-L7*/ "", "", "", "", > + /*M0-M3*/ "", "", "", "", > + /*M4-M7*/ "", "", "", "", > + /*N0-N3*/ "", "", "", "", > + /*N4-N7*/ "", "", "", "", > + /*O0-O3*/ "", "", "", "", > + /*O4-O7*/ "", "", "", "", > + /*P0-P3*/ "", "", "", "", > + /*P4-P7*/ "", "", "", "", > + /*Q0-Q3*/ "", "", "", "", > + /*Q4-Q7*/ "input-bmc-smb-present-n", "", "", "input-pcie-wake-n", > + /*R0-R3*/ "", "", "", "", > + /*R4-R7*/ "", "", "", "", > + /*S0-S3*/ "input-bmc-pchhot-n", "", "", "", > + /*S4-S7*/ "", "", "", "", > + /*T0-T3*/ "", "", "", "", > + /*T4-T7*/ "", "", "", "", > + /*U0-U3*/ "", "", "", "", > + /*U4-U7*/ "", "", "", "", > + /*V0-V3*/ "", "", "", "", > + /*V4-V7*/ "", "", "", "", > + /*W0-W3*/ "", "", "", "", > + /*W4-W7*/ "", "", "", "", > + /*X0-X3*/ "", "", "", "", > + /*X4-X7*/ "", "", "", "", > + /*Y0-Y3*/ "input-sleep-s3-n", "input-sleep-s5-n", "", "", > + /*Y4-Y7*/ "", "", "", "", > + /*Z0-Z3*/ "", "", "led-fault-n", "output-bmc-throttle-n", > + /*Z4-Z7*/ "", "", "", "", > + /*AA0-AA3*/ "input-cpu1-thermtrip-latch-n", "", "input-cpu1-prochot-n", "", > + /*AA4-AC7*/ "", "", "", "", > + /*AB0-AB3*/ "", "input-power-good", "", "", > + /*AB4-AC7*/ "", "", "", "", > + /*AC0-AC3*/ "", "", "", "", > + /*AC4-AC7*/ "", "", "", ""; > }; > I'd like some discussion in the commit message of whether these names align with net names in the schematic, follow the OpenBMC GPIO naming guidelines, or use some other strategy entirely. Also, the columnisation of the names leads to more warnings from checkpatch (due to line length). Other Aspeed-based devicetrees tend not to make the whitespace so significant, and generally group the GPIOs by complete banks. I prefer that the X570D4U devicetree is consistent with the others. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC 2024-03-29 13:01 [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC Renze Nicolai 2024-03-29 13:01 ` [PATCH 1/3] ARM: dts: Modify GPIO table for " Renze Nicolai @ 2024-03-29 13:01 ` Renze Nicolai 2024-04-03 3:29 ` Andrew Jeffery 2024-03-29 13:01 ` [PATCH 3/3] ARM: dts: Modify I2C bus configuration Renze Nicolai 2 siblings, 1 reply; 7+ messages in thread From: Renze Nicolai @ 2024-03-29 13:01 UTC (permalink / raw) To: linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd, olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew, renze This commit disables unused ADC channels and labels the ADC channels used with their function. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 29 +++++++++---------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts index 34bc382bf492..e93c2f0b8414 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts @@ -358,20 +358,17 @@ fan@5 { &adc { status = "okay"; pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_adc0_default - &pinctrl_adc1_default - &pinctrl_adc2_default - &pinctrl_adc3_default - &pinctrl_adc4_default - &pinctrl_adc5_default - &pinctrl_adc6_default - &pinctrl_adc7_default - &pinctrl_adc8_default - &pinctrl_adc9_default - &pinctrl_adc10_default - &pinctrl_adc11_default - &pinctrl_adc12_default - &pinctrl_adc13_default - &pinctrl_adc14_default - &pinctrl_adc15_default>; + pinctrl-0 = <&pinctrl_adc0_default /* 3VSB */ + &pinctrl_adc1_default /* 5VSB */ + &pinctrl_adc2_default /* VCPU */ + &pinctrl_adc3_default /* VSOC */ + &pinctrl_adc4_default /* VCCM */ + &pinctrl_adc5_default /* APU-VDDP */ + &pinctrl_adc6_default /* PM-VDD-CLDO */ + &pinctrl_adc7_default /* PM-VDDCR-S5 */ + &pinctrl_adc8_default /* PM-VDDCR */ + &pinctrl_adc9_default /* VBAT */ + &pinctrl_adc10_default /* 3V */ + &pinctrl_adc11_default /* 5V */ + &pinctrl_adc12_default>; /* 12V */ }; -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC 2024-03-29 13:01 ` [PATCH 2/3] ARM: dts: Disable unused ADC channels " Renze Nicolai @ 2024-04-03 3:29 ` Andrew Jeffery 0 siblings, 0 replies; 7+ messages in thread From: Andrew Jeffery @ 2024-04-03 3:29 UTC (permalink / raw) To: Renze Nicolai, linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd, olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew Hi Renze, On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote: > This commit disables unused ADC channels and labels the ADC channels used with their function. Please run this through checkpatch and address the warnings. Also, the submitting patches documentation[1] suggests using the imperative mood - instead of "This commit disables ...", use "Disable ...". The change subject is phrased the expected way. [1]: https://docs.kernel.org/process/submitting-patches.html Taking the subject and the description together, the description feels a little redundant. Maybe it could be trimmed back to > Also, label the ADC channels used with their function. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: dts: Modify I2C bus configuration 2024-03-29 13:01 [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC Renze Nicolai 2024-03-29 13:01 ` [PATCH 1/3] ARM: dts: Modify GPIO table for " Renze Nicolai 2024-03-29 13:01 ` [PATCH 2/3] ARM: dts: Disable unused ADC channels " Renze Nicolai @ 2024-03-29 13:01 ` Renze Nicolai 2024-04-03 3:30 ` Andrew Jeffery 2 siblings, 1 reply; 7+ messages in thread From: Renze Nicolai @ 2024-03-29 13:01 UTC (permalink / raw) To: linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd, olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew, renze This commit enables I2C bus 8 which is exposed on the IPMB_1 connector on the X570D4U mainboard. Additionally it adds a descriptive comment to I2C busses 1 and 5. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts index e93c2f0b8414..3b1c77a12605 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts @@ -183,6 +183,7 @@ &i2c0 { }; &i2c1 { + /* Hardware monitoring SMBus */ status = "okay"; w83773g@4c { @@ -240,6 +241,7 @@ i2c4mux0ch3: i2c@3 { }; &i2c5 { + /* SMBus on BMC connector (BMC_SMB_1) */ status = "okay"; }; @@ -264,6 +266,11 @@ eth1_macaddress: macaddress@3f88 { }; }; +&i2c8 { + /* SMBus on intelligent platform management bus header (IPMB_1) */ + status = "okay"; +}; + &gfx { status = "okay"; }; -- 2.44.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] ARM: dts: Modify I2C bus configuration 2024-03-29 13:01 ` [PATCH 3/3] ARM: dts: Modify I2C bus configuration Renze Nicolai @ 2024-04-03 3:30 ` Andrew Jeffery 0 siblings, 0 replies; 7+ messages in thread From: Andrew Jeffery @ 2024-04-03 3:30 UTC (permalink / raw) To: Renze Nicolai, linux-arm-kernel, devicetree, linux-kernel, linux-aspeed, arnd, olof, soc, robh+dt, krzysztof.kozlowski+dt, joel, andrew Hi Renze, On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote: > This commit enables I2C bus 8 which is exposed on the IPMB_1 connector on the X570D4U mainboard. > Additionally it adds a descriptive comment to I2C busses 1 and 5. checkpatch on this one too :) Cheers, Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-04-03 3:30 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-29 13:01 [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC Renze Nicolai 2024-03-29 13:01 ` [PATCH 1/3] ARM: dts: Modify GPIO table for " Renze Nicolai 2024-04-03 3:21 ` Andrew Jeffery 2024-03-29 13:01 ` [PATCH 2/3] ARM: dts: Disable unused ADC channels " Renze Nicolai 2024-04-03 3:29 ` Andrew Jeffery 2024-03-29 13:01 ` [PATCH 3/3] ARM: dts: Modify I2C bus configuration Renze Nicolai 2024-04-03 3:30 ` Andrew Jeffery
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox