[PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

[PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

[Peter Ujfalusi]

The original commit mixed up the forward and completion ring IDs for the
rx flow configuration.

Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Santosh, Vinod,

the offending patch was queued via ti SoC tree.
Santosh, can you pick up this fix also?

Regards,
Peter

 drivers/dma/ti/k3-udma-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
index 3a5d33ea5ebe..12da38a92218 100644
--- a/drivers/dma/ti/k3-udma-glue.c
+++ b/drivers/dma/ti/k3-udma-glue.c
@@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
 
 	/* request and cfg rings */
 	ret =  k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
-					     flow_cfg->ring_rxq_id,
 					     flow_cfg->ring_rxfdq0_id,
+					     flow_cfg->ring_rxq_id,
 					     &flow->ringrxfdq,
 					     &flow->ringrx);
 	if (ret) {
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

[Vinod Koul]

On 05-08-20, 14:27, Peter Ujfalusi wrote:
> The original commit mixed up the forward and completion ring IDs for the
> rx flow configuration.

Acked-By: Vinod Koul <vkoul@kernel.org>

> 
> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Santosh, Vinod,
> 
> the offending patch was queued via ti SoC tree.
> Santosh, can you pick up this fix also?
> 
> Regards,
> Peter
> 
>  drivers/dma/ti/k3-udma-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 3a5d33ea5ebe..12da38a92218 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
>  
>  	/* request and cfg rings */
>  	ret =  k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
> -					     flow_cfg->ring_rxq_id,
>  					     flow_cfg->ring_rxfdq0_id,
> +					     flow_cfg->ring_rxq_id,
>  					     &flow->ringrxfdq,
>  					     &flow->ringrx);
>  	if (ret) {
> -- 
> Peter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

[Grygorii Strashko]

On 05/08/2020 14:32, Vinod Koul wrote:
> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>> The original commit mixed up the forward and completion ring IDs for the
>> rx flow configuration.
> 
> Acked-By: Vinod Koul <vkoul@kernel.org>
> 
>>
>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Hi Santosh, Vinod,
>>
>> the offending patch was queued via ti SoC tree.
>> Santosh, can you pick up this fix also?

Thank you Peter for catching this - it's valid issue.
but I'd like to note that issue was discovered with private code and
nothing is broken in Master.

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

[santosh.shilimkar]

On 8/5/20 6:17 AM, Grygorii Strashko wrote:
> 
> 
> On 05/08/2020 14:32, Vinod Koul wrote:
>> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>>> The original commit mixed up the forward and completion ring IDs for the
>>> rx flow configuration.
>>
>> Acked-By: Vinod Koul <vkoul@kernel.org>
>>
>>>
>>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to 
>>> k3_ringacc_request_rings_pair")
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>>> Hi Santosh, Vinod,
>>>
>>> the offending patch was queued via ti SoC tree.
>>> Santosh, can you pick up this fix also?
> 
> Thank you Peter for catching this - it's valid issue.
> but I'd like to note that issue was discovered with private code and
> nothing is broken in Master.
> 
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> 
Will queue this up for next merge window.

regards,
Santosh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel