* [PATCH] arm: s3c: use string choices helper
@ 2025-06-17 0:06 Kuninori Morimoto
2025-06-17 5:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Kuninori Morimoto @ 2025-06-17 0:06 UTC (permalink / raw)
To: Alim Akhtar, Krzysztof Kozlowski, Russell King
Cc: Andy Shevchenko, Kees Cook, linux-arm-kernel
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-s3c/pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-s3c/pm.c b/arch/arm/mach-s3c/pm.c
index 5698cbceaf7a..6ef037dcb641 100644
--- a/arch/arm/mach-s3c/pm.c
+++ b/arch/arm/mach-s3c/pm.c
@@ -47,7 +47,7 @@ int s3c_irqext_wake(struct irq_data *data, unsigned int state)
return -ENOENT;
printk(KERN_INFO "wake %s for irq %d\n",
- state ? "enabled" : "disabled", data->irq);
+ str_enabled_disabled(state), data->irq);
if (!state)
s3c_irqwake_eintmask |= bit;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: s3c: use string choices helper
2025-06-17 0:06 [PATCH] arm: s3c: use string choices helper Kuninori Morimoto
@ 2025-06-17 5:54 ` Krzysztof Kozlowski
2025-06-17 6:11 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-17 5:54 UTC (permalink / raw)
To: Kuninori Morimoto, Alim Akhtar, Russell King
Cc: Andy Shevchenko, Kees Cook, linux-arm-kernel
On 17/06/2025 02:06, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Missing commit msg (especially considering this is legacy code which
soon might be completely removed).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: s3c: use string choices helper
2025-06-17 5:54 ` Krzysztof Kozlowski
@ 2025-06-17 6:11 ` Andy Shevchenko
2025-06-17 6:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-06-17 6:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kuninori Morimoto, Alim Akhtar, Russell King, Andy Shevchenko,
Kees Cook, linux-arm-kernel
On Tue, Jun 17, 2025 at 8:54 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 17/06/2025 02:06, Kuninori Morimoto wrote:
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Missing commit msg (especially considering this is legacy code which
> soon might be completely removed).
Besides the fact that this most likely would need to be changed to
pr_info() to begin with :-)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: s3c: use string choices helper
2025-06-17 6:11 ` Andy Shevchenko
@ 2025-06-17 6:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-17 6:34 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Kuninori Morimoto, Alim Akhtar, Russell King, Andy Shevchenko,
Kees Cook, linux-arm-kernel
On 17/06/2025 08:11, Andy Shevchenko wrote:
> On Tue, Jun 17, 2025 at 8:54 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 17/06/2025 02:06, Kuninori Morimoto wrote:
>>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> Missing commit msg (especially considering this is legacy code which
>> soon might be completely removed).
>
> Besides the fact that this most likely would need to be changed to
> pr_info() to begin with :-)
Yeah, indeed. I don't want patches converting it to pr_xxx or dev_xxx,
either, unless you come with really good explanation. This all will be
removed this or next year.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-17 6:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 0:06 [PATCH] arm: s3c: use string choices helper Kuninori Morimoto
2025-06-17 5:54 ` Krzysztof Kozlowski
2025-06-17 6:11 ` Andy Shevchenko
2025-06-17 6:34 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox