* [PATCH] serial: xuartps: add __init to earlycon write method
@ 2015-05-07 9:02 Masahiro Yamada
2015-05-07 9:08 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2015-05-07 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/tty/serial/xilinx_uartps.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 3ddbac7..009e0db 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1075,7 +1075,8 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
writel(ch, port->membase + CDNS_UART_FIFO_OFFSET);
}
-static void cdns_early_write(struct console *con, const char *s, unsigned n)
+static void __init cdns_early_write(struct console *con, const char *s,
+ unsigned n)
{
struct earlycon_device *dev = con->data;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] serial: xuartps: add __init to earlycon write method
2015-05-07 9:02 [PATCH] serial: xuartps: add __init to earlycon write method Masahiro Yamada
@ 2015-05-07 9:08 ` Arnd Bergmann
2015-05-07 9:14 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2015-05-07 9:08 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 07 May 2015 18:02:39 Masahiro Yamada wrote:
> @@ -1075,7 +1075,8 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
> writel(ch, port->membase + CDNS_UART_FIFO_OFFSET);
> }
>
> -static void cdns_early_write(struct console *con, const char *s, unsigned n)
> +static void __init cdns_early_write(struct console *con, const char *s,
> + unsigned n)
> {
> struct earlycon_device *dev = con->data;
>
>
Why?
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] serial: xuartps: add __init to earlycon write method
2015-05-07 9:08 ` Arnd Bergmann
@ 2015-05-07 9:14 ` Masahiro Yamada
2015-05-07 9:27 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2015-05-07 9:14 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
2015-05-07 18:08 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Thursday 07 May 2015 18:02:39 Masahiro Yamada wrote:
>> @@ -1075,7 +1075,8 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
>> writel(ch, port->membase + CDNS_UART_FIFO_OFFSET);
>> }
>>
>> -static void cdns_early_write(struct console *con, const char *s, unsigned n)
>> +static void __init cdns_early_write(struct console *con, const char *s,
>> + unsigned n)
>> {
>> struct earlycon_device *dev = con->data;
>>
>>
>
> Why?
>
I thought this function is used during the early boot stage.
I am seeing drivers/tty/serial/8250/8250_early.c
for reference.
All the functions in this file are marked as __init.
Perhaps, am I misunderstanding?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] serial: xuartps: add __init to earlycon write method
2015-05-07 9:14 ` Masahiro Yamada
@ 2015-05-07 9:27 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-05-07 9:27 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 07 May 2015 18:14:43 you wrote:
> 2015-05-07 18:08 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > On Thursday 07 May 2015 18:02:39 Masahiro Yamada wrote:
> >> @@ -1075,7 +1075,8 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
> >> writel(ch, port->membase + CDNS_UART_FIFO_OFFSET);
> >> }
> >>
> >> -static void cdns_early_write(struct console *con, const char *s, unsigned n)
> >> +static void __init cdns_early_write(struct console *con, const char *s,
> >> + unsigned n)
> >> {
> >> struct earlycon_device *dev = con->data;
> >>
> >>
> >
> > Why?
> >
>
> I thought this function is used during the early boot stage.
>
> I am seeing drivers/tty/serial/8250/8250_early.c
> for reference.
>
> All the functions in this file are marked as __init.
>
> Perhaps, am I misunderstanding?
>
Makes sense, please explain that in the commit message and send the
patch again.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-07 9:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 9:02 [PATCH] serial: xuartps: add __init to earlycon write method Masahiro Yamada
2015-05-07 9:08 ` Arnd Bergmann
2015-05-07 9:14 ` Masahiro Yamada
2015-05-07 9:27 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox