Re: [PATCH v5 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS

[Akashdeep Kaur <a-kaur@ti.com>]

Hi Kendall,

On 09/09/25 02:51, Kendall Willis wrote:
> On 9/5/25 00:14, Akashdeep Kaur wrote:
>> After the SoC has entered the DeepSleep low power mode, USB1 can be used
>> to wakeup the SoC based on USB events triggered by USB devices. This
>> requires that the pin corresponding to the Type-A connector remains 
>> pulled
>> up even after the SoC has entered the DeepSleep low power mode.
>> For that, either DeepSleep pullup configuration can be selected or the 
>> pin
>> can have the same configuration that it had when SoC was in active mode.
>> But, in order for DeepSleep configuration to take effect, the DeepSleep
>> control bit has to be enabled.
> 
> The last sentence wording is confusing because it sounds like a 
> DeepSleep control bit still needs to be enabled which is not seen in the 
> patch. If possible, drop this sentence and do the same for the other 
> similar patch in this series.

Sounds good! Removed.

Regards,
Akashdeep Kaur
> 
>> Remove the unnecessary DeepSleep state configuration from USB1_DRVBUS 
>> pin,
>> as the DeepSleep control bit is not set and the active configuration is
>> sufficient to keep the pin pulled up. This simplifies the setup and 
>> removes
>> redundant configuration.
>>
>> This reverts commit 115290c112952db27009668aa7ae2f29920704f0.
>>
>> Reviewed-by: Dhruva Gole <d-gole@ti.com>
>> Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
> 
> Verified USB disconnect, USB connect, and USB remote wakeup on AM62P SKEVM.
> 
> Tested-by: Kendall Willis <k-willis@ti.com>
> 
>> ---
>>   arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/ 
>> boot/dts/ti/k3-am62p5-sk.dts
>> index 899da7896563..e8f0ac2c55e2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> @@ -360,7 +360,7 @@ AM62PX_IOPAD(0x01b0, PIN_OUTPUT, 2) /* (G20) 
>> MCASP0_ACLKR.UART1_TXD */
>>       main_usb1_pins_default: main-usb1-default-pins {
>>           pinctrl-single,pins = <
>> -            AM62PX_IOPAD(0x0258, PIN_INPUT | PIN_DS_PULLUD_ENABLE | 
>> PIN_DS_PULL_UP, 0) /* (G21) USB1_DRVVBUS */
>> +            AM62PX_IOPAD(0x0258, PIN_INPUT, 0) /* (G21) USB1_DRVVBUS */
>>           >;
>>       };
>