From: Kendall Willis <k-willis@ti.com>
To: Akashdeep Kaur <a-kaur@ti.com>, <praneeth@ti.com>, <nm@ti.com>,
<afd@ti.com>, <vigneshr@ti.com>, <d-gole@ti.com>,
<u-kumar1@ti.com>, <sebin.francis@ti.com>, <kristo@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <vishalm@ti.com>
Subject: Re: [PATCH v5 4/4] arm64: dts: ti: k3-pinctrl: Fix the bug in existing macros
Date: Mon, 8 Sep 2025 18:35:53 -0500 [thread overview]
Message-ID: <fbbaf67a-8e59-44fa-8741-49cf53f4a31c@ti.com> (raw)
In-Reply-To: <20250905051448.2836237-5-a-kaur@ti.com>
On 9/5/25 00:14, Akashdeep Kaur wrote:
> Currently, DS_IO_OVERRIDE_EN_SHIFT macro is not defined anywhere but
> used for defining other macro.
> Replace this undefined macro with valid macro. Rename the existing macro
> to reflect the actual behavior.
>
> Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-pinctrl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> index 8ce37ace94c9..e46f7bf52701 100644
> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> @@ -88,8 +88,8 @@
>
> #define PIN_DS_FORCE_DISABLE (0 << FORCE_DS_EN_SHIFT)
> #define PIN_DS_FORCE_ENABLE (1 << FORCE_DS_EN_SHIFT)
> -#define PIN_DS_IO_OVERRIDE_DISABLE (0 << DS_IO_OVERRIDE_EN_SHIFT)
> -#define PIN_DS_IO_OVERRIDE_ENABLE (1 << DS_IO_OVERRIDE_EN_SHIFT)
> +#define PIN_DS_ISO_OVERRIDE_DISABLE (0 << ISO_OVERRIDE_EN_SHIFT)
> +#define PIN_DS_ISO_OVERRIDE_ENABLE (1 << ISO_OVERRIDE_EN_SHIFT)
> #define PIN_DS_OUT_ENABLE (0 << DS_OUT_DIS_SHIFT)
> #define PIN_DS_OUT_DISABLE (1 << DS_OUT_DIS_SHIFT)
> #define PIN_DS_OUT_VALUE_ZERO (0 << DS_OUT_VAL_SHIFT)
Reviewed-by: Kendall Willis <k-willis@ti.com>
prev parent reply other threads:[~2025-09-09 6:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 5:14 [PATCH v5 0/4] Remove unused bits from dts and add support for remaining pinctrl macros Akashdeep Kaur
2025-09-05 5:14 ` [PATCH v5 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS Akashdeep Kaur
2025-09-08 21:21 ` Kendall Willis
2025-09-09 2:24 ` Akashdeep Kaur
2025-09-05 5:14 ` [PATCH v5 2/4] arm64: dts: ti: k3-am62x-sk-common: " Akashdeep Kaur
2025-09-08 21:40 ` Kendall Willis
2025-09-05 5:14 ` [PATCH v5 3/4] arm64: dts: ti: k3-pinctrl: Add the remaining macros Akashdeep Kaur
2025-09-05 6:16 ` Dhruva Gole
2025-09-08 23:34 ` Kendall Willis
2025-09-09 2:36 ` Akashdeep Kaur
2025-09-05 5:14 ` [PATCH v5 4/4] arm64: dts: ti: k3-pinctrl: Fix the bug in existing macros Akashdeep Kaur
2025-09-05 6:21 ` Dhruva Gole
2025-09-08 23:35 ` Kendall Willis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbbaf67a-8e59-44fa-8741-49cf53f4a31c@ti.com \
--to=k-willis@ti.com \
--cc=a-kaur@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=sebin.francis@ti.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox