From: Wei Xu <xuwei5@hisilicon.com>
To: Linus Walleij <linusw@kernel.org>, <longzhao@ambarella.com>,
Chanho Min <chanho.min@lge.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Long Zhao <zl020895@163.com>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v8 10/18] gpio: pl061: convert register access to regmap
Date: Thu, 8 Oct 2026 17:04:18 +0800 [thread overview]
Message-ID: <6AC75C92.9090409@hisilicon.com> (raw)
In-Reply-To: <CAD++jLm8fWyAFY=Uv-O3-9joU+HiKjMAzmd0s6Hc=QEu51wCGA@mail.gmail.com>
Hi Linus and Andy,
On 2026/9/22 15:23, Linus Walleij wrote:
> On Mon, Sep 21, 2026 at 6:23 AM Long Zhao via B4 Relay
> <devnull+longzhao.ambarella.com@kernel.org> wrote:
>
>> From: Long Zhao <longzhao@ambarella.com>
>>
>> Replace readb()/writeb() with a MMIO regmap while keeping the existing
>> gpio_chip and girq irqchip. Use a raw spinlock so irq_ack() can run
>> under the irq descriptor lock.
>>
>> Signed-off-by: Long Zhao <longzhao@ambarella.com>
>
> It would be good if some critical users of the PL061 could
> test this patch.
>
> Wei, can you test this on HiSilicon?
Sorry for the late reply!
I did not get the HiKey boards these past days.
But I test the v9 patchset on the qemu sbsa-ref machine to verify the
gpio powerdown and it works after resolved some trivial merge conflicts.
The detail could be found at below link:
https://github.com/hisilicon/kernel-dev/commits/topic-test-pl061/
Best Regards,
Wei
>
> Chanho, can you test on LGE hardware?
>
> but it looks good!
> Reviewed-by: Linus Walleij <linusw@kernel.org>
>
> Yours,
> Linus Walleij
> .
>
next prev parent reply other threads:[~2026-10-08 9:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 4:23 [PATCH v8 00/18] Ambarella CV75 SoC minimal bring-up Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 01/18] dt-bindings: arm: add Ambarella CV75 platforms Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 02/18] dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 03/18] dt-bindings: clock: add Ambarella CV75 RCT Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 04/18] dt-bindings: pinctrl: add Ambarella CV75 pinctrl Long Zhao via B4 Relay
2026-09-22 7:11 ` Linus Walleij
2026-09-22 8:28 ` zl020895
2026-10-01 7:03 ` Linus Walleij
2026-09-21 4:23 ` [PATCH v8 05/18] dt-bindings: gpio: pl061: add Ambarella CV75 variant Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 06/18] dt-bindings: serial: snps-dw-apb-uart: add ambarella,cv75-uart Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 07/18] clk: ambarella: add CV75 RCT clock controller Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 08/18] gpiolib: regmap: add write_data_after_dir quirk Long Zhao via B4 Relay
2026-09-22 7:17 ` Linus Walleij
2026-09-22 8:45 ` zl020895
2026-09-21 4:23 ` [PATCH v8 09/18] gpiolib: regmap: add gpio_regmap_get_chip() Long Zhao via B4 Relay
2026-09-21 10:35 ` Bartosz Golaszewski
2026-09-21 12:19 ` zl020895
2026-09-21 13:05 ` Bartosz Golaszewski
2026-09-21 4:23 ` [PATCH v8 10/18] gpio: pl061: convert register access to regmap Long Zhao via B4 Relay
2026-09-22 7:23 ` Linus Walleij
2026-10-02 7:48 ` Chanho Min
2026-10-02 8:03 ` Andy Shevchenko
2026-10-08 9:04 ` Wei Xu [this message]
2026-09-21 4:23 ` [PATCH v8 11/18] gpio: pl061: use IRQ_TYPE_LEVEL_MASK and IRQ_TYPE_EDGE_BOTH Long Zhao via B4 Relay
2026-09-22 7:24 ` Linus Walleij
2026-09-21 4:23 ` [PATCH v8 12/18] gpio: pl061: use cleanup helpers for locks Long Zhao via B4 Relay
2026-09-22 7:24 ` Linus Walleij
2026-09-21 4:23 ` [PATCH v8 13/18] gpio: pl061: switch data path to gpio-regmap Long Zhao via B4 Relay
2026-09-22 7:25 ` Linus Walleij
2026-09-21 4:23 ` [PATCH v8 14/18] gpio: pl061: add Ambarella register-layout variant Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 15/18] pinctrl: ambarella: add CV75 pin controller Long Zhao via B4 Relay
2026-09-22 7:28 ` Linus Walleij
2026-10-01 7:05 ` Linus Walleij
2026-09-21 4:23 ` [PATCH v8 16/18] serial: 8250_dw: add Ambarella CV75 quirks Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 17/18] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT Long Zhao via B4 Relay
2026-09-21 4:23 ` [PATCH v8 18/18] MAINTAINERS: add ARM/AMBARELLA SoC support Long Zhao via B4 Relay
2026-09-21 10:31 ` [PATCH v8 00/18] Ambarella CV75 SoC minimal bring-up Bartosz Golaszewski
2026-09-21 11:08 ` zl020895
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6AC75C92.9090409@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chanho.min@lge.com \
--cc=conor+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=longzhao@ambarella.com \
--cc=mturquette@baylibre.com \
--cc=zl020895@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox