[PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[Marek Vasut]

The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
using output-low DT property leads to the GPIO being set high instead.

Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
index 25528a1c096f..757707766fa0 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
@@ -49,7 +49,7 @@ &gpioa {
 	 */
 	usb-port-power-hog {
 		gpio-hog;
-		gpios = <13 GPIO_ACTIVE_LOW>;
+		gpios = <13 0>;
 		output-low;
 		line-name = "usb-port-power";
 	};
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02

[Marek Vasut]

The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
correctness of the DT.

Fixes: fde180f06d7b ("ARM: dts: stm32: Add DHSOM based DRC02 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
index 6a2b546f6f72..8d1fea332665 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
@@ -35,7 +35,7 @@ &gpiob {
 	 */
 	rs485-rx-en-hog {
 		gpio-hog;
-		gpios = <8 GPIO_ACTIVE_HIGH>;
+		gpios = <8 0>;
 		output-low;
 		line-name = "rs485-rx-en";
 	};
@@ -63,7 +63,7 @@ &gpioi {
 	 */
 	usb-hub-hog {
 		gpio-hog;
-		gpios = <2 GPIO_ACTIVE_HIGH>;
+		gpios = <2 0>;
 		output-high;
 		line-name = "usb-hub-reset";
 	};
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[Alexandre TORGUE]

Hi Marek

On 12/29/20 6:55 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
> 
> Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> index 25528a1c096f..757707766fa0 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -49,7 +49,7 @@ &gpioa {
>   	 */
>   	usb-port-power-hog {

On my tree this node is "usb-port-power". Do you want to update the node 
name too ? I can do it directly during the merge if you want.
(Note, it is the case for DRC02 hog update).

regards
alex

>   		gpio-hog;
> -		gpios = <13 GPIO_ACTIVE_LOW>;
> +		gpios = <13 0>;
>   		output-low;
>   		line-name = "usb-port-power";
>   	};
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[Marek Vasut]

On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
> Hi Marek

Hi,

[...]

>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi 
>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> index 25528a1c096f..757707766fa0 100644
>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> @@ -49,7 +49,7 @@ &gpioa {
>>        */
>>       usb-port-power-hog {
> 
> On my tree this node is "usb-port-power". Do you want to update the node 
> name too ? I can do it directly during the merge if you want.
> (Note, it is the case for DRC02 hog update).

Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" 
first, then this patch should apply cleanly.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[Alexandre TORGUE]

On 1/14/21 6:08 PM, Marek Vasut wrote:
> On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
>> Hi Marek
> 
> Hi,
> 
> [...]
> 
>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi 
>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> index 25528a1c096f..757707766fa0 100644
>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> @@ -49,7 +49,7 @@ &gpioa {
>>>        */
>>>       usb-port-power-hog {
>>
>> On my tree this node is "usb-port-power". Do you want to update the 
>> node name too ? I can do it directly during the merge if you want.
>> (Note, it is the case for DRC02 hog update).
> 
> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" 
> first, then this patch should apply cleanly.

Yes I just saw this one. It doesn't contain a fixes tag, I can add the 
same than for other hog patches ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[Marek Vasut]

On 1/14/21 6:11 PM, Alexandre TORGUE wrote:
> 
> 
> On 1/14/21 6:08 PM, Marek Vasut wrote:
>> On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
>>> Hi Marek
>>
>> Hi,
>>
>> [...]
>>
>>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi 
>>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> index 25528a1c096f..757707766fa0 100644
>>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> @@ -49,7 +49,7 @@ &gpioa {
>>>>        */
>>>>       usb-port-power-hog {
>>>
>>> On my tree this node is "usb-port-power". Do you want to update the 
>>> node name too ? I can do it directly during the merge if you want.
>>> (Note, it is the case for DRC02 hog update).
>>
>> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" 
>> first, then this patch should apply cleanly.
> 
> Yes I just saw this one. It doesn't contain a fixes tag, I can add the 
> same than for other hog patches ?

If that is OK with you, please do. Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

[Alexandre TORGUE]

On 1/14/21 6:13 PM, Marek Vasut wrote:
> On 1/14/21 6:11 PM, Alexandre TORGUE wrote:
>>
>>
>> On 1/14/21 6:08 PM, Marek Vasut wrote:
>>> On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
>>>> Hi Marek
>>>
>>> Hi,
>>>
>>> [...]
>>>
>>>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi 
>>>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> index 25528a1c096f..757707766fa0 100644
>>>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> @@ -49,7 +49,7 @@ &gpioa {
>>>>>        */
>>>>>       usb-port-power-hog {
>>>>
>>>> On my tree this node is "usb-port-power". Do you want to update the 
>>>> node name too ? I can do it directly during the merge if you want.
>>>> (Note, it is the case for DRC02 hog update).
>>>
>>> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM" 
>>> first, then this patch should apply cleanly.
>>
>> Yes I just saw this one. It doesn't contain a fixes tag, I can add the 
>> same than for other hog patches ?
> 
> If that is OK with you, please do. Thanks

Done. Series applied on stm32-fixes.

Regards
Alex

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel