* [PATCH] soc: mediatek: cmdq: delete not used define
@ 2019-12-11 18:59 matthias.bgg
2019-12-12 1:36 ` Bibby Hsieh
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: matthias.bgg @ 2019-12-11 18:59 UTC (permalink / raw)
To: bibby.hsieh, matthias.bgg
Cc: Matthias Brugger, Matthias Brugger, linux-mediatek, linux-kernel,
linux-arm-kernel
From: Matthias Brugger <mbrugger@suse.com>
Define CMDQ_EOC_CMD was actually never used. Delete it.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 3c82de5f9417..1127c19c4e91 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -12,8 +12,6 @@
#define CMDQ_ARG_A_WRITE_MASK 0xffff
#define CMDQ_WRITE_ENABLE_MASK BIT(0)
#define CMDQ_EOC_IRQ_EN BIT(0)
-#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
- << 32 | CMDQ_EOC_IRQ_EN)
static void cmdq_client_timeout(struct timer_list *t)
{
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: cmdq: delete not used define
2019-12-11 18:59 [PATCH] soc: mediatek: cmdq: delete not used define matthias.bgg
@ 2019-12-12 1:36 ` Bibby Hsieh
2019-12-12 5:11 ` CK Hu
2019-12-14 22:07 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Bibby Hsieh @ 2019-12-12 1:36 UTC (permalink / raw)
To: matthias.bgg
Cc: Matthias Brugger, Matthias Brugger, linux-mediatek, linux-kernel,
linux-arm-kernel
On Wed, 2019-12-11 at 19:59 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Thanks. :D
Reviewed-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: cmdq: delete not used define
2019-12-11 18:59 [PATCH] soc: mediatek: cmdq: delete not used define matthias.bgg
2019-12-12 1:36 ` Bibby Hsieh
@ 2019-12-12 5:11 ` CK Hu
2019-12-14 22:07 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: CK Hu @ 2019-12-12 5:11 UTC (permalink / raw)
To: matthias.bgg
Cc: Matthias Brugger, linux-kernel, linux-mediatek, bibby.hsieh,
Matthias Brugger, linux-arm-kernel
Hi, Matthias:
On Wed, 2019-12-11 at 19:59 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: mediatek: cmdq: delete not used define
2019-12-11 18:59 [PATCH] soc: mediatek: cmdq: delete not used define matthias.bgg
2019-12-12 1:36 ` Bibby Hsieh
2019-12-12 5:11 ` CK Hu
@ 2019-12-14 22:07 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2019-12-14 22:07 UTC (permalink / raw)
To: matthias.bgg, bibby.hsieh
Cc: Matthias Brugger, linux-mediatek, linux-kernel, linux-arm-kernel
On 11/12/2019 19:59, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
Applied to v5.5-next/soc
Thanks for the reviews!
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-14 22:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 18:59 [PATCH] soc: mediatek: cmdq: delete not used define matthias.bgg
2019-12-12 1:36 ` Bibby Hsieh
2019-12-12 5:11 ` CK Hu
2019-12-14 22:07 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox