* [PATCH] arm64: pass ESR_ELx to die() of cfi_handler [not found] <CGME20230220073527epcas1p1e901bfa667b8c51551d26478013131e6@epcas1p1.samsung.com> @ 2023-02-20 7:34 ` Sangmoon Kim 2023-02-20 10:02 ` Mark Rutland ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Sangmoon Kim @ 2023-02-20 7:34 UTC (permalink / raw) To: Catalin Marinas, Will Deacon Cc: Mark Rutland, Mark Brown, linux-arm-kernel, linux-kernel, Sangmoon Kim Commit 0f2cb928a154 ("arm64: consistently pass ESR_ELx to die()") caused all callers to pass the ESR_ELx value to die(). For consistency, this patch also adds esr to die() call of cfi_handler. Also, when CFI error occurs, die handlers can use ESR_ELx value. Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com> --- arch/arm64/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index 0ccc063daccb..4a623e2e982b 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -990,7 +990,7 @@ static int cfi_handler(struct pt_regs *regs, unsigned long esr) switch (report_cfi_failure(regs, regs->pc, &target, type)) { case BUG_TRAP_TYPE_BUG: - die("Oops - CFI", regs, 0); + die("Oops - CFI", regs, esr); break; case BUG_TRAP_TYPE_WARN: -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: pass ESR_ELx to die() of cfi_handler 2023-02-20 7:34 ` [PATCH] arm64: pass ESR_ELx to die() of cfi_handler Sangmoon Kim @ 2023-02-20 10:02 ` Mark Rutland 2023-02-20 12:39 ` Mark Brown 2023-02-22 17:07 ` Catalin Marinas 2 siblings, 0 replies; 4+ messages in thread From: Mark Rutland @ 2023-02-20 10:02 UTC (permalink / raw) To: Sangmoon Kim Cc: Catalin Marinas, Will Deacon, Mark Brown, linux-arm-kernel, linux-kernel On Mon, Feb 20, 2023 at 04:34:41PM +0900, Sangmoon Kim wrote: > Commit 0f2cb928a154 ("arm64: consistently pass ESR_ELx to die()") caused > all callers to pass the ESR_ELx value to die(). > > For consistency, this patch also adds esr to die() call of cfi_handler. > Also, when CFI error occurs, die handlers can use ESR_ELx value. > > Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com> Consistently reporting the ESR value makes sense to me, so: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > arch/arm64/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index 0ccc063daccb..4a623e2e982b 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -990,7 +990,7 @@ static int cfi_handler(struct pt_regs *regs, unsigned long esr) > > switch (report_cfi_failure(regs, regs->pc, &target, type)) { > case BUG_TRAP_TYPE_BUG: > - die("Oops - CFI", regs, 0); > + die("Oops - CFI", regs, esr); > break; > > case BUG_TRAP_TYPE_WARN: > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: pass ESR_ELx to die() of cfi_handler 2023-02-20 7:34 ` [PATCH] arm64: pass ESR_ELx to die() of cfi_handler Sangmoon Kim 2023-02-20 10:02 ` Mark Rutland @ 2023-02-20 12:39 ` Mark Brown 2023-02-22 17:07 ` Catalin Marinas 2 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2023-02-20 12:39 UTC (permalink / raw) To: Sangmoon Kim Cc: Catalin Marinas, Will Deacon, Mark Rutland, linux-arm-kernel, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 385 bytes --] On Mon, Feb 20, 2023 at 04:34:41PM +0900, Sangmoon Kim wrote: > Commit 0f2cb928a154 ("arm64: consistently pass ESR_ELx to die()") caused > all callers to pass the ESR_ELx value to die(). > > For consistency, this patch also adds esr to die() call of cfi_handler. > Also, when CFI error occurs, die handlers can use ESR_ELx value. Reviewed-by: Mark Brown <broonie@kernel.org> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: pass ESR_ELx to die() of cfi_handler 2023-02-20 7:34 ` [PATCH] arm64: pass ESR_ELx to die() of cfi_handler Sangmoon Kim 2023-02-20 10:02 ` Mark Rutland 2023-02-20 12:39 ` Mark Brown @ 2023-02-22 17:07 ` Catalin Marinas 2 siblings, 0 replies; 4+ messages in thread From: Catalin Marinas @ 2023-02-22 17:07 UTC (permalink / raw) To: Will Deacon, Sangmoon Kim Cc: Mark Rutland, Mark Brown, linux-arm-kernel, linux-kernel On Mon, 20 Feb 2023 16:34:41 +0900, Sangmoon Kim wrote: > Commit 0f2cb928a154 ("arm64: consistently pass ESR_ELx to die()") caused > all callers to pass the ESR_ELx value to die(). > > For consistency, this patch also adds esr to die() call of cfi_handler. > Also, when CFI error occurs, die handlers can use ESR_ELx value. > > > [...] Applied to arm64 (for-next/core), thanks! [1/1] arm64: pass ESR_ELx to die() of cfi_handler https://git.kernel.org/arm64/c/b61b82f81e09 -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-22 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20230220073527epcas1p1e901bfa667b8c51551d26478013131e6@epcas1p1.samsung.com>
2023-02-20 7:34 ` [PATCH] arm64: pass ESR_ELx to die() of cfi_handler Sangmoon Kim
2023-02-20 10:02 ` Mark Rutland
2023-02-20 12:39 ` Mark Brown
2023-02-22 17:07 ` Catalin Marinas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox