* [PATCH] firmware: arm_scmi: return a literal instead of a variable
@ 2023-02-22 15:17 Dan Carpenter
2023-02-23 12:28 ` Cristian Marussi
2023-03-09 14:10 ` Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-02-22 15:17 UTC (permalink / raw)
To: Cristian Marussi; +Cc: Sudeep Holla, linux-arm-kernel, kernel-janitors
In this context "return scmi_dev;" and "return NULL;" are equivalent
but it is more readable to return a literal.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/firmware/arm_scmi/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
index 73140b854b31..ac306ca48b07 100644
--- a/drivers/firmware/arm_scmi/bus.c
+++ b/drivers/firmware/arm_scmi/bus.c
@@ -436,7 +436,7 @@ struct scmi_device *scmi_device_create(struct device_node *np,
/* Nothing to do. */
if (!phead) {
mutex_unlock(&scmi_requested_devices_mtx);
- return scmi_dev;
+ return NULL;
}
/* Walk the list of requested devices for protocol and create them */
--
2.39.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: arm_scmi: return a literal instead of a variable
2023-02-22 15:17 [PATCH] firmware: arm_scmi: return a literal instead of a variable Dan Carpenter
@ 2023-02-23 12:28 ` Cristian Marussi
2023-03-09 14:10 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Cristian Marussi @ 2023-02-23 12:28 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Sudeep Holla, linux-arm-kernel, kernel-janitors
On Wed, Feb 22, 2023 at 06:17:06PM +0300, Dan Carpenter wrote:
> In this context "return scmi_dev;" and "return NULL;" are equivalent
> but it is more readable to return a literal.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/firmware/arm_scmi/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
> index 73140b854b31..ac306ca48b07 100644
> --- a/drivers/firmware/arm_scmi/bus.c
> +++ b/drivers/firmware/arm_scmi/bus.c
> @@ -436,7 +436,7 @@ struct scmi_device *scmi_device_create(struct device_node *np,
> /* Nothing to do. */
> if (!phead) {
> mutex_unlock(&scmi_requested_devices_mtx);
> - return scmi_dev;
> + return NULL;
> }
>
> /* Walk the list of requested devices for protocol and create them */
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: arm_scmi: return a literal instead of a variable
2023-02-22 15:17 [PATCH] firmware: arm_scmi: return a literal instead of a variable Dan Carpenter
2023-02-23 12:28 ` Cristian Marussi
@ 2023-03-09 14:10 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2023-03-09 14:10 UTC (permalink / raw)
To: Cristian Marussi, Dan Carpenter
Cc: Sudeep Holla, linux-arm-kernel, kernel-janitors
On Wed, 22 Feb 2023 18:17:06 +0300, Dan Carpenter wrote:
> In this context "return scmi_dev;" and "return NULL;" are equivalent
> but it is more readable to return a literal.
>
Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!
[1/1] firmware: arm_scmi: return a literal instead of a variable
https://git.kernel.org/sudeep.holla/c/6bed395d7db2
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-09 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-22 15:17 [PATCH] firmware: arm_scmi: return a literal instead of a variable Dan Carpenter
2023-02-23 12:28 ` Cristian Marussi
2023-03-09 14:10 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox