* [PATCH] i2c: xiic: Remove some dead code
@ 2023-02-15 10:38 Christophe JAILLET
2023-02-16 9:12 ` Michal Simek
2023-02-17 21:46 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2023-02-15 10:38 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
linux-arm-kernel, linux-i2c
wait_for_completion_timeout() never returns negative value.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/i2c/busses/i2c-xiic.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 8503b5016aaf..5543f372ae60 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -1038,10 +1038,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
i2c->rx_msg = NULL;
i2c->nmsgs = 0;
err = -ETIMEDOUT;
- } else if (err < 0) { /* Completion error */
- i2c->tx_msg = NULL;
- i2c->rx_msg = NULL;
- i2c->nmsgs = 0;
} else {
err = (i2c->state == STATE_DONE) ? num : -EIO;
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: xiic: Remove some dead code
2023-02-15 10:38 [PATCH] i2c: xiic: Remove some dead code Christophe JAILLET
@ 2023-02-16 9:12 ` Michal Simek
2023-02-17 21:46 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2023-02-16 9:12 UTC (permalink / raw)
To: Christophe JAILLET, Michal Simek
Cc: linux-kernel, kernel-janitors, linux-arm-kernel, linux-i2c
On 2/15/23 11:38, Christophe JAILLET wrote:
>
> wait_for_completion_timeout() never returns negative value.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/i2c/busses/i2c-xiic.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 8503b5016aaf..5543f372ae60 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1038,10 +1038,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> i2c->rx_msg = NULL;
> i2c->nmsgs = 0;
> err = -ETIMEDOUT;
> - } else if (err < 0) { /* Completion error */
> - i2c->tx_msg = NULL;
> - i2c->rx_msg = NULL;
> - i2c->nmsgs = 0;
> } else {
> err = (i2c->state == STATE_DONE) ? num : -EIO;
> }
> --
> 2.34.1
>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: xiic: Remove some dead code
2023-02-15 10:38 [PATCH] i2c: xiic: Remove some dead code Christophe JAILLET
2023-02-16 9:12 ` Michal Simek
@ 2023-02-17 21:46 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-02-17 21:46 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Michal Simek, linux-kernel, kernel-janitors, linux-arm-kernel,
linux-i2c
[-- Attachment #1.1: Type: text/plain, Size: 239 bytes --]
On Wed, Feb 15, 2023 at 11:38:07AM +0100, Christophe JAILLET wrote:
> wait_for_completion_timeout() never returns negative value.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-17 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 10:38 [PATCH] i2c: xiic: Remove some dead code Christophe JAILLET
2023-02-16 9:12 ` Michal Simek
2023-02-17 21:46 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox