* [PATCH] staging: media: imx: remove unnecessary return variable
@ 2023-01-03 11:44 Deepak R Varma
2023-01-03 11:50 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Deepak R Varma @ 2023-01-03 11:44 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-media, linux-staging, linux-arm-kernel, linux-kernel
Cc: Saurabh Singh Sengar, Praveen Kumar, Deepak R Varma
The function imx_media_fim_set_stream() can directly return 0 instead of
using a ret variable which never changes its value. Issue identified
using the returnvar.cocci Coccinelle semantic patch.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/media/imx/imx-media-fim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
index fb6590dcfc36..e719227d4323 100644
--- a/drivers/staging/media/imx/imx-media-fim.c
+++ b/drivers/staging/media/imx/imx-media-fim.c
@@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,
bool on)
{
unsigned long flags;
- int ret = 0;
v4l2_ctrl_lock(fim->ctrl[FIM_CL_ENABLE]);
@@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,
fim->stream_on = on;
out:
v4l2_ctrl_unlock(fim->ctrl[FIM_CL_ENABLE]);
- return ret;
+ return 0;
}
int imx_media_fim_add_controls(struct imx_media_fim *fim)
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: imx: remove unnecessary return variable
2023-01-03 11:44 [PATCH] staging: media: imx: remove unnecessary return variable Deepak R Varma
@ 2023-01-03 11:50 ` Fabio Estevam
2023-01-03 11:57 ` Deepak R Varma
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2023-01-03 11:50 UTC (permalink / raw)
To: Deepak R Varma
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, linux-media,
linux-staging, linux-arm-kernel, linux-kernel,
Saurabh Singh Sengar, Praveen Kumar
On Tue, Jan 3, 2023 at 8:45 AM Deepak R Varma <drv@mailo.com> wrote:
>
> The function imx_media_fim_set_stream() can directly return 0 instead of
> using a ret variable which never changes its value. Issue identified
> using the returnvar.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> drivers/staging/media/imx/imx-media-fim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
> index fb6590dcfc36..e719227d4323 100644
> --- a/drivers/staging/media/imx/imx-media-fim.c
> +++ b/drivers/staging/media/imx/imx-media-fim.c
> @@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,
> bool on)
> {
> unsigned long flags;
> - int ret = 0;
>
> v4l2_ctrl_lock(fim->ctrl[FIM_CL_ENABLE]);
>
> @@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,
> fim->stream_on = on;
> out:
> v4l2_ctrl_unlock(fim->ctrl[FIM_CL_ENABLE]);
> - return ret;
> + return 0;
Maybe you could change imx_media_fim_set_stream() to a void function instead?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: imx: remove unnecessary return variable
2023-01-03 11:50 ` Fabio Estevam
@ 2023-01-03 11:57 ` Deepak R Varma
0 siblings, 0 replies; 3+ messages in thread
From: Deepak R Varma @ 2023-01-03 11:57 UTC (permalink / raw)
To: Fabio Estevam
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, linux-media,
linux-staging, linux-arm-kernel, linux-kernel,
Saurabh Singh Sengar, Praveen Kumar, Deepak R Varma
On Tue, Jan 03, 2023 at 08:50:51AM -0300, Fabio Estevam wrote:
> On Tue, Jan 3, 2023 at 8:45 AM Deepak R Varma <drv@mailo.com> wrote:
> >
> > The function imx_media_fim_set_stream() can directly return 0 instead of
> > using a ret variable which never changes its value. Issue identified
> > using the returnvar.cocci Coccinelle semantic patch.
> >
> > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > ---
> > drivers/staging/media/imx/imx-media-fim.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
> > index fb6590dcfc36..e719227d4323 100644
> > --- a/drivers/staging/media/imx/imx-media-fim.c
> > +++ b/drivers/staging/media/imx/imx-media-fim.c
> > @@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,
> > bool on)
> > {
> > unsigned long flags;
> > - int ret = 0;
> >
> > v4l2_ctrl_lock(fim->ctrl[FIM_CL_ENABLE]);
> >
> > @@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,
> > fim->stream_on = on;
> > out:
> > v4l2_ctrl_unlock(fim->ctrl[FIM_CL_ENABLE]);
> > - return ret;
> > + return 0;
>
> Maybe you could change imx_media_fim_set_stream() to a void function instead?
That sounds more accurate. I will send in the revision as v2. Thank you so much
for the feedback.
Regards,
./drv
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-03 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-03 11:44 [PATCH] staging: media: imx: remove unnecessary return variable Deepak R Varma
2023-01-03 11:50 ` Fabio Estevam
2023-01-03 11:57 ` Deepak R Varma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox