public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v5 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support
@ 2025-01-17  3:27 Kever Yang
  2025-01-17  3:27 ` [PATCH v5 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes Kever Yang
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Kever Yang @ 2025-01-17  3:27 UTC (permalink / raw)
  To: heiko
  Cc: linux-rockchip, Kever Yang, Simon Xue, Conor Dooley, Rob Herring,
	Bjorn Helgaas, linux-pci, Krzysztof Wilczyński, linux-kernel,
	Krzysztof Kozlowski, devicetree, Lorenzo Pieralisi, Shawn Lin,
	Manivannan Sadhasivam, linux-arm-kernel

rk3576 is using dwc controller, with msi interrupt directly to gic instead
of to gic its, so
- no its support is required and the 'msi-map' is not need anymore,
- a new 'msi' interrupt is needed.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v5:
- Add constraints per device for interrupt-names due to the interrupt is
different from rk3588.

Changes in v4:
- Fix wrong indentation in dt_binding_check report by Rob

Changes in v3:
- Fix dtb check broken on rk3588
- Update commit message

Changes in v2:
- remove required 'msi-map'
- add interrupt name 'msi'

 .../bindings/pci/rockchip-dw-pcie-common.yaml | 53 +++++++++++++++----
 .../bindings/pci/rockchip-dw-pcie.yaml        |  4 +-
 2 files changed, 44 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
index cc9adfc7611c..eef108037184 100644
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
@@ -40,6 +40,7 @@ properties:
 
   interrupts:
     minItems: 5
+    maxItems: 9
     items:
       - description:
           Combined system interrupt, which is used to signal the following
@@ -64,6 +65,10 @@ properties:
           interrupts - aer_rc_err, aer_rc_err_msi, rx_cpl_timeout,
           tx_cpl_timeout, cor_err_sent, nf_err_sent, f_err_sent, cor_err_rx,
           nf_err_rx, f_err_rx, radm_qoverflow
+      - description:
+          Combinded MSI line interrupt, which is to support MSI interrupts
+          output to GIC controller via GIC SPI interrupt instead of GIC its
+          interrupt.
       - description:
           eDMA write channel 0 interrupt
       - description:
@@ -75,16 +80,7 @@ properties:
 
   interrupt-names:
     minItems: 5
-    items:
-      - const: sys
-      - const: pmc
-      - const: msg
-      - const: legacy
-      - const: err
-      - const: dma0
-      - const: dma1
-      - const: dma2
-      - const: dma3
+    maxItems: 9
 
   num-lanes: true
 
@@ -123,4 +119,41 @@ required:
 
 additionalProperties: true
 
+allOf:
+  - if:
+      compatible:
+        contains:
+          enum:
+            - rockchip,rk3568-pcie
+            - rockchip,rk3588-pcie
+    then:
+      properties:
+        interrupts:
+          min-items: 5
+          max-Items: 9
+        interrupt-names:
+          items:
+            - const: sys
+            - const: pmc
+            - const: msg
+            - const: legacy
+            - const: err
+            - const: dma0
+            - const: dma1
+            - const: dma2
+            - const: dma3
+    else:
+      properties:
+        interrupts:
+          min-items: 6
+          max-Items: 6
+        interrupt-names:
+          items:
+            - const: sys
+            - const: pmc
+            - const: msg
+            - const: legacy
+            - const: err
+            - const: msi
+
 ...
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
index 550d8a684af3..9a464731fa4a 100644
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
@@ -26,6 +26,7 @@ properties:
       - const: rockchip,rk3568-pcie
       - items:
           - enum:
+              - rockchip,rk3576-pcie
               - rockchip,rk3588-pcie
           - const: rockchip,rk3568-pcie
 
@@ -71,9 +72,6 @@ properties:
 
   vpcie3v3-supply: true
 
-required:
-  - msi-map
-
 unevaluatedProperties: false
 
 examples:
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-01-17 14:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-17  3:27 [PATCH v5 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang
2025-01-17  3:27 ` [PATCH v5 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes Kever Yang
2025-01-17  5:20 ` [PATCH v5 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Rob Herring (Arm)
2025-01-17  7:36 ` Krzysztof Kozlowski
2025-01-17 11:00 ` Niklas Cassel
2025-01-17 14:32 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox