From: Alison Schofield <alison.schofield@intel.com>
To: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: imx: fix macro style error
Date: Mon, 10 Apr 2023 16:48:41 -0700 [thread overview]
Message-ID: <ZDSgWU5GXPFdJ99o@aschofie-mobl2> (raw)
In-Reply-To: <20230409200135.1033677-1-angelalbertoc.r@gmail.com>
On Sun, Apr 09, 2023 at 10:01:36PM +0200, Angel Alberto Carretero wrote:
> Wrap macro in parenthesis to fix checkpatch error.
>
> Tested it by compiling the driver successfully.
>
> Signed-off-by: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
> ---
Hi Angel,
The code change looks fine. Here are a few patch style suggestions:
- If you do 'git log --oneline imx-media-utils.c' you'll see that
changes in utils file only, seem to have utils in the patch subject
prefix. "media: imx: utils:"
- Commit message is vague. How about being explicit so anyone persuing
those one-liners knows exactly what change was made.
"Enclose IMX_BUS_FMTS macro in parentheses"
- The commit log 'why' is to conform to the kernel coding style, not
to fix a checkpatch error. It is good to say Issue found by
checkpatch, but that itself is not the 'why'.
Alison
> drivers/staging/media/imx/imx-media-utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index 411e907b68eb..eb44c09071de 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include "imx-media.h"
>
> -#define IMX_BUS_FMTS(fmt...) (const u32[]) {fmt, 0}
> +#define IMX_BUS_FMTS(fmt...) ((const u32[]) {fmt, 0})
>
> /*
> * List of supported pixel formats for the subdevs.
> --
> 2.40.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-10 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 20:01 [PATCH] media: imx: fix macro style error Angel Alberto Carretero
2023-04-10 23:48 ` Alison Schofield [this message]
2023-04-12 17:51 ` [PATCH v2] media: imx: utils: Enclose IMX_BUS_FMTS macro in parenthesis Angel Alberto Carretero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDSgWU5GXPFdJ99o@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=angelalbertoc.r@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox