* [PATCH] media: imx: fix macro style error
@ 2023-04-09 20:01 Angel Alberto Carretero
2023-04-10 23:48 ` Alison Schofield
0 siblings, 1 reply; 3+ messages in thread
From: Angel Alberto Carretero @ 2023-04-09 20:01 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
Cc: Angel Alberto Carretero, linux-media, linux-staging,
linux-arm-kernel, linux-kernel
Wrap macro in parenthesis to fix checkpatch error.
Tested it by compiling the driver successfully.
Signed-off-by: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
---
drivers/staging/media/imx/imx-media-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
index 411e907b68eb..eb44c09071de 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -7,7 +7,7 @@
#include <linux/module.h>
#include "imx-media.h"
-#define IMX_BUS_FMTS(fmt...) (const u32[]) {fmt, 0}
+#define IMX_BUS_FMTS(fmt...) ((const u32[]) {fmt, 0})
/*
* List of supported pixel formats for the subdevs.
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: imx: fix macro style error
2023-04-09 20:01 [PATCH] media: imx: fix macro style error Angel Alberto Carretero
@ 2023-04-10 23:48 ` Alison Schofield
2023-04-12 17:51 ` [PATCH v2] media: imx: utils: Enclose IMX_BUS_FMTS macro in parenthesis Angel Alberto Carretero
0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2023-04-10 23:48 UTC (permalink / raw)
To: Angel Alberto Carretero
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-media, linux-staging, linux-arm-kernel, linux-kernel
On Sun, Apr 09, 2023 at 10:01:36PM +0200, Angel Alberto Carretero wrote:
> Wrap macro in parenthesis to fix checkpatch error.
>
> Tested it by compiling the driver successfully.
>
> Signed-off-by: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
> ---
Hi Angel,
The code change looks fine. Here are a few patch style suggestions:
- If you do 'git log --oneline imx-media-utils.c' you'll see that
changes in utils file only, seem to have utils in the patch subject
prefix. "media: imx: utils:"
- Commit message is vague. How about being explicit so anyone persuing
those one-liners knows exactly what change was made.
"Enclose IMX_BUS_FMTS macro in parentheses"
- The commit log 'why' is to conform to the kernel coding style, not
to fix a checkpatch error. It is good to say Issue found by
checkpatch, but that itself is not the 'why'.
Alison
> drivers/staging/media/imx/imx-media-utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index 411e907b68eb..eb44c09071de 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include "imx-media.h"
>
> -#define IMX_BUS_FMTS(fmt...) (const u32[]) {fmt, 0}
> +#define IMX_BUS_FMTS(fmt...) ((const u32[]) {fmt, 0})
>
> /*
> * List of supported pixel formats for the subdevs.
> --
> 2.40.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] media: imx: utils: Enclose IMX_BUS_FMTS macro in parenthesis
2023-04-10 23:48 ` Alison Schofield
@ 2023-04-12 17:51 ` Angel Alberto Carretero
0 siblings, 0 replies; 3+ messages in thread
From: Angel Alberto Carretero @ 2023-04-12 17:51 UTC (permalink / raw)
To: Alison Schofield, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: Angel Alberto Carretero, linux-media, linux-staging,
linux-arm-kernel, linux-kernel
Conform to kernel coding style by wrapping macro in parenthesis. Issue
found by checkpatch.
Signed-off-by: Angel Alberto Carretero <angelalbertoc.r@gmail.com>
---
v2: changed commit message and description thanks to Alison suggestion
---
drivers/staging/media/imx/imx-media-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
index 411e907b68eb..eb44c09071de 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -7,7 +7,7 @@
#include <linux/module.h>
#include "imx-media.h"
-#define IMX_BUS_FMTS(fmt...) (const u32[]) {fmt, 0}
+#define IMX_BUS_FMTS(fmt...) ((const u32[]) {fmt, 0})
/*
* List of supported pixel formats for the subdevs.
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 17:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-09 20:01 [PATCH] media: imx: fix macro style error Angel Alberto Carretero
2023-04-10 23:48 ` Alison Schofield
2023-04-12 17:51 ` [PATCH v2] media: imx: utils: Enclose IMX_BUS_FMTS macro in parenthesis Angel Alberto Carretero
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox