* [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP
@ 2023-06-01 13:25 Uwe Kleine-König
2023-06-01 15:14 ` Andi Shyti
2023-06-09 15:27 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2023-06-01 13:25 UTC (permalink / raw)
To: Dong Aisheng, Shawn Guo
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-i2c,
linux-arm-kernel
There is no change in the generated code (tested on an ARCH=arm
allmodconfig build).
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index 1af0a637d7f1..ae6ce28d3330 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -217,7 +217,7 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
for (prescale = 0; prescale <= 7; prescale++) {
clk_cycle = clk_rate / ((1 << prescale) * lpi2c_imx->bitrate)
- 3 - (filt >> 1);
- clkhi = (clk_cycle + I2C_CLK_RATIO) / (I2C_CLK_RATIO + 1);
+ clkhi = DIV_ROUND_UP(clk_cycle, I2C_CLK_RATIO + 1);
clklo = clk_cycle - clkhi;
if (clklo < 64)
break;
base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP
2023-06-01 13:25 [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP Uwe Kleine-König
@ 2023-06-01 15:14 ` Andi Shyti
2023-06-09 15:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2023-06-01 15:14 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Dong Aisheng, Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-i2c, linux-arm-kernel
Hi Uwe,
On Thu, Jun 01, 2023 at 03:25:32PM +0200, Uwe Kleine-König wrote:
> There is no change in the generated code (tested on an ARCH=arm
> allmodconfig build).
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
> index 1af0a637d7f1..ae6ce28d3330 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -217,7 +217,7 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
> for (prescale = 0; prescale <= 7; prescale++) {
> clk_cycle = clk_rate / ((1 << prescale) * lpi2c_imx->bitrate)
> - 3 - (filt >> 1);
> - clkhi = (clk_cycle + I2C_CLK_RATIO) / (I2C_CLK_RATIO + 1);
> + clkhi = DIV_ROUND_UP(clk_cycle, I2C_CLK_RATIO + 1);
you updated this at the end... looks good :)
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
> clklo = clk_cycle - clkhi;
> if (clklo < 64)
> break;
>
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> --
> 2.39.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP
2023-06-01 13:25 [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP Uwe Kleine-König
2023-06-01 15:14 ` Andi Shyti
@ 2023-06-09 15:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-06-09 15:27 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Dong Aisheng, Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-i2c, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 266 bytes --]
On Thu, Jun 01, 2023 at 03:25:32PM +0200, Uwe Kleine-König wrote:
> There is no change in the generated code (tested on an ARCH=arm
> allmodconfig build).
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-09 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 13:25 [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP Uwe Kleine-König
2023-06-01 15:14 ` Andi Shyti
2023-06-09 15:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox