* [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION
@ 2024-08-28 1:47 Peng Fan (OSS)
2024-08-28 5:17 ` Peng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan (OSS) @ 2024-08-28 1:47 UTC (permalink / raw)
To: sudeep.holla, cristian.marussi, shawnguo, s.hauer
Cc: linux-arm-kernel, linux-kernel, festevam, imx, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add missing MODULE_LICENSE and MODULE_DESCRIPTION
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Hi Sudeep,
My bad for not build this as module. If you need me fix the previous patchset,
please let me know.
Thanks,
Peng.
drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c | 3 +++
drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
index 0df7ca135c34..ad8734d2aeab 100644
--- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
+++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
@@ -377,3 +377,6 @@ static const struct scmi_protocol scmi_imx_bbm = {
.sub_vendor_id = "IMX",
};
module_scmi_protocol(scmi_imx_bbm);
+
+MODULE_DESCRIPTION("i.MX SCMI BBM driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
index 9ee2d204d607..1d339cfa6ecf 100644
--- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
+++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
@@ -313,3 +313,6 @@ static const struct scmi_protocol scmi_imx_misc = {
.sub_vendor_id = "IMX",
};
module_scmi_protocol(scmi_imx_misc);
+
+MODULE_DESCRIPTION("i.MX SCMI BBM driver");
+MODULE_LICENSE("GPL");
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION
2024-08-28 1:47 [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION Peng Fan (OSS)
@ 2024-08-28 5:17 ` Peng Fan
2024-08-28 9:47 ` Sudeep Holla
0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan @ 2024-08-28 5:17 UTC (permalink / raw)
To: Peng Fan (OSS), sudeep.holla@arm.com, cristian.marussi@arm.com,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, festevam@gmail.com,
imx@lists.linux.dev
> Subject: [PATCH] firmware: arm_scmi: imx: add
> MODULE_LICENSE/DESCRIPTION
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Add missing MODULE_LICENSE and MODULE_DESCRIPTION
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> Hi Sudeep,
> My bad for not build this as module. If you need me fix the previous
> patchset, please let me know.
> Thanks,
> Peng.
>
> drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c | 3 +++
> drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> index 0df7ca135c34..ad8734d2aeab 100644
> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> @@ -377,3 +377,6 @@ static const struct scmi_protocol
> scmi_imx_bbm = {
> .sub_vendor_id = "IMX",
> };
> module_scmi_protocol(scmi_imx_bbm);
> +
> +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> index 9ee2d204d607..1d339cfa6ecf 100644
> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> @@ -313,3 +313,6 @@ static const struct scmi_protocol
> scmi_imx_misc = {
> .sub_vendor_id = "IMX",
> };
> module_scmi_protocol(scmi_imx_misc);
> +
> +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
Just find this Typo. BBM->MISC.
Thanks,
Peng.
> MODULE_LICENSE("GPL");
> --
> 2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION
2024-08-28 5:17 ` Peng Fan
@ 2024-08-28 9:47 ` Sudeep Holla
2024-08-28 12:43 ` Peng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Sudeep Holla @ 2024-08-28 9:47 UTC (permalink / raw)
To: Peng Fan
Cc: Peng Fan (OSS), cristian.marussi@arm.com, Sudeep Holla,
shawnguo@kernel.org, s.hauer@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, festevam@gmail.com,
imx@lists.linux.dev
On Wed, Aug 28, 2024 at 05:17:27AM +0000, Peng Fan wrote:
> > Subject: [PATCH] firmware: arm_scmi: imx: add
> > MODULE_LICENSE/DESCRIPTION
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add missing MODULE_LICENSE and MODULE_DESCRIPTION
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > Hi Sudeep,
> > My bad for not build this as module. If you need me fix the previous
> > patchset, please let me know.
> > Thanks,
> > Peng.
> >
> > drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c | 3 +++
> > drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > index 0df7ca135c34..ad8734d2aeab 100644
> > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > @@ -377,3 +377,6 @@ static const struct scmi_protocol
> > scmi_imx_bbm = {
> > .sub_vendor_id = "IMX",
> > };
> > module_scmi_protocol(scmi_imx_bbm);
> > +
> > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > index 9ee2d204d607..1d339cfa6ecf 100644
> > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > @@ -313,3 +313,6 @@ static const struct scmi_protocol
> > scmi_imx_misc = {
> > .sub_vendor_id = "IMX",
> > };
> > module_scmi_protocol(scmi_imx_misc);
> > +
> > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
>
> Just find this Typo. BBM->MISC.
>
I was about to ask the same. Please take time needed to push out any
patch, no point in rushing and churning unnecessarily like this.
Anyways, I did hit the issue last night and fixed it locally but
didn't push out as it was late for today's next. Please check if
https://git.kernel.org/sudeep.holla/c/for-next/scmi/updates
looks OK.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION
2024-08-28 9:47 ` Sudeep Holla
@ 2024-08-28 12:43 ` Peng Fan
0 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2024-08-28 12:43 UTC (permalink / raw)
To: Sudeep Holla
Cc: Peng Fan (OSS), cristian.marussi@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, festevam@gmail.com,
imx@lists.linux.dev
> Subject: Re: [PATCH] firmware: arm_scmi: imx: add
> MODULE_LICENSE/DESCRIPTION
>
> On Wed, Aug 28, 2024 at 05:17:27AM +0000, Peng Fan wrote:
> > > Subject: [PATCH] firmware: arm_scmi: imx: add
> > > MODULE_LICENSE/DESCRIPTION
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Add missing MODULE_LICENSE and MODULE_DESCRIPTION
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > Hi Sudeep,
> > > My bad for not build this as module. If you need me fix the
> > > previous patchset, please let me know.
> > > Thanks,
> > > Peng.
> > >
> > > drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c | 3 +++
> > > drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
> > > 2 files changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > index 0df7ca135c34..ad8734d2aeab 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > @@ -377,3 +377,6 @@ static const struct scmi_protocol
> scmi_imx_bbm =
> > > {
> > > .sub_vendor_id = "IMX",
> > > };
> > > module_scmi_protocol(scmi_imx_bbm);
> > > +
> > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> > > MODULE_LICENSE("GPL");
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > index 9ee2d204d607..1d339cfa6ecf 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > @@ -313,3 +313,6 @@ static const struct scmi_protocol
> scmi_imx_misc
> > > = {
> > > .sub_vendor_id = "IMX",
> > > };
> > > module_scmi_protocol(scmi_imx_misc);
> > > +
> > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> >
> > Just find this Typo. BBM->MISC.
> >
>
> I was about to ask the same. Please take time needed to push out any
> patch, no point in rushing and churning unnecessarily like this.
>
> Anyways, I did hit the issue last night and fixed it locally but didn't
> push out as it was late for today's next. Please check if
> https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/commit/?id=for-next/scmi/updates
Your fix is good. Thanks for helping on this issue. I will take care
next time.
Thanks,
Peng.
>
> --
> Regards,
> Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-28 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28 1:47 [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION Peng Fan (OSS)
2024-08-28 5:17 ` Peng Fan
2024-08-28 9:47 ` Sudeep Holla
2024-08-28 12:43 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox