* [PATCH v2 1/3] dt-bindings: clock: nxp,imx95-blk-ctl: Correct compatible entries by alphabetical order
2024-09-05 2:31 [PATCH v2 0/3] Add one clock gate for i.MX95 HSIO block Richard Zhu
@ 2024-09-05 2:31 ` Richard Zhu
2024-09-05 3:21 ` Frank Li
2024-09-05 2:31 ` [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL Richard Zhu
2024-09-05 2:31 ` [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block Richard Zhu
2 siblings, 1 reply; 10+ messages in thread
From: Richard Zhu @ 2024-09-05 2:31 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, abelvesa, peng.fan, mturquette, sboyd,
shawnguo, s.hauer, festevam
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-clk, imx,
kernel, Richard Zhu
No function chanegs, correct compatible entries by alphabetical order.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
.../devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
index 2dffc02dcd8b..6a928735e00d 100644
--- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
+++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
@@ -13,9 +13,9 @@ properties:
compatible:
items:
- enum:
- - nxp,imx95-lvds-csr
- - nxp,imx95-display-csr
- nxp,imx95-camera-csr
+ - nxp,imx95-display-csr
+ - nxp,imx95-lvds-csr
- nxp,imx95-vpu-csr
- const: syscon
--
2.37.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: clock: nxp,imx95-blk-ctl: Correct compatible entries by alphabetical order
2024-09-05 2:31 ` [PATCH v2 1/3] dt-bindings: clock: nxp,imx95-blk-ctl: Correct compatible entries by alphabetical order Richard Zhu
@ 2024-09-05 3:21 ` Frank Li
0 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2024-09-05 3:21 UTC (permalink / raw)
To: Richard Zhu
Cc: robh, krzk+dt, conor+dt, abelvesa, peng.fan, mturquette, sboyd,
shawnguo, s.hauer, festevam, devicetree, linux-kernel,
linux-arm-kernel, linux-clk, imx, kernel
On Thu, Sep 05, 2024 at 10:31:06AM +0800, Richard Zhu wrote:
> No function chanegs, correct compatible entries by alphabetical order.
nit:
Sort compatible entries by alphabetical order.
Frank
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> .../devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> index 2dffc02dcd8b..6a928735e00d 100644
> --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> @@ -13,9 +13,9 @@ properties:
> compatible:
> items:
> - enum:
> - - nxp,imx95-lvds-csr
> - - nxp,imx95-display-csr
> - nxp,imx95-camera-csr
> + - nxp,imx95-display-csr
> + - nxp,imx95-lvds-csr
> - nxp,imx95-vpu-csr
> - const: syscon
>
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL
2024-09-05 2:31 [PATCH v2 0/3] Add one clock gate for i.MX95 HSIO block Richard Zhu
2024-09-05 2:31 ` [PATCH v2 1/3] dt-bindings: clock: nxp,imx95-blk-ctl: Correct compatible entries by alphabetical order Richard Zhu
@ 2024-09-05 2:31 ` Richard Zhu
2024-09-05 6:44 ` Krzysztof Kozlowski
2024-09-05 2:31 ` [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block Richard Zhu
2 siblings, 1 reply; 10+ messages in thread
From: Richard Zhu @ 2024-09-05 2:31 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, abelvesa, peng.fan, mturquette, sboyd,
shawnguo, s.hauer, festevam
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-clk, imx,
kernel, Richard Zhu
Add compatible string "nxp,imx95-hsio-blk-ctl" for i.MX95.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
index 6a928735e00d..244fe7b95fd6 100644
--- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
+++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
@@ -15,6 +15,7 @@ properties:
- enum:
- nxp,imx95-camera-csr
- nxp,imx95-display-csr
+ - nxp,imx95-hsio-blk-ctl
- nxp,imx95-lvds-csr
- nxp,imx95-vpu-csr
- const: syscon
--
2.37.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL
2024-09-05 2:31 ` [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL Richard Zhu
@ 2024-09-05 6:44 ` Krzysztof Kozlowski
2024-09-05 7:14 ` Hongxing Zhu
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-05 6:44 UTC (permalink / raw)
To: Richard Zhu
Cc: robh, krzk+dt, conor+dt, abelvesa, peng.fan, mturquette, sboyd,
shawnguo, s.hauer, festevam, devicetree, linux-kernel,
linux-arm-kernel, linux-clk, imx, kernel
On Thu, Sep 05, 2024 at 10:31:07AM +0800, Richard Zhu wrote:
> Add compatible string "nxp,imx95-hsio-blk-ctl" for i.MX95.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
This one here is so trivial, you can squash both patches.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL
2024-09-05 6:44 ` Krzysztof Kozlowski
@ 2024-09-05 7:14 ` Hongxing Zhu
0 siblings, 0 replies; 10+ messages in thread
From: Hongxing Zhu @ 2024-09-05 7:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
abelvesa@kernel.org, Peng Fan, mturquette@baylibre.com,
sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
imx@lists.linux.dev, kernel@pengutronix.de
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 2024年9月5日 14:45
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> abelvesa@kernel.org; Peng Fan <peng.fan@nxp.com>;
> mturquette@baylibre.com; sboyd@kernel.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; festevam@gmail.com; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-clk@vger.kernel.org; imx@lists.linux.dev; kernel@pengutronix.de
> Subject: Re: [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible
> string for i.MX95 HSIO BLK CTRL
>
> On Thu, Sep 05, 2024 at 10:31:07AM +0800, Richard Zhu wrote:
> > Add compatible string "nxp,imx95-hsio-blk-ctl" for i.MX95.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
>
> This one here is so trivial, you can squash both patches.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Okay, If you don't mind, I will squash the first two patches into one.
Thanks a lot for your review.
Best Regards
Richard Zhu
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block
2024-09-05 2:31 [PATCH v2 0/3] Add one clock gate for i.MX95 HSIO block Richard Zhu
2024-09-05 2:31 ` [PATCH v2 1/3] dt-bindings: clock: nxp,imx95-blk-ctl: Correct compatible entries by alphabetical order Richard Zhu
2024-09-05 2:31 ` [PATCH v2 2/3] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL Richard Zhu
@ 2024-09-05 2:31 ` Richard Zhu
2024-09-05 3:34 ` Frank Li
2024-09-05 8:05 ` Peng Fan
2 siblings, 2 replies; 10+ messages in thread
From: Richard Zhu @ 2024-09-05 2:31 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, abelvesa, peng.fan, mturquette, sboyd,
shawnguo, s.hauer, festevam
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-clk, imx,
kernel, Richard Zhu
CREF_EN (Bit6) of LFAST_IO_REG control i.MX95 PCIe REF clock out
enable/disable.
Add compatible string "fsl,imx95-hsio-blk-ctl" to support PCIe REF clock
out gate.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
drivers/clk/imx/clk-imx95-blk-ctl.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/clk/imx/clk-imx95-blk-ctl.c b/drivers/clk/imx/clk-imx95-blk-ctl.c
index 74f595f9e5e3..596dfb2f3b75 100644
--- a/drivers/clk/imx/clk-imx95-blk-ctl.c
+++ b/drivers/clk/imx/clk-imx95-blk-ctl.c
@@ -248,6 +248,25 @@ static const struct imx95_blk_ctl_dev_data dispmix_csr_dev_data = {
.clk_reg_offset = 0,
};
+static const struct imx95_blk_ctl_clk_dev_data hsio_blk_ctl_clk_dev_data[] = {
+ [0] = {
+ .name = "hsio_blk_ctl_clk",
+ .parent_names = (const char *[]){ "hsio_pll", },
+ .num_parents = 1,
+ .reg = 0,
+ .bit_idx = 6,
+ .bit_width = 1,
+ .type = CLK_GATE,
+ .flags = CLK_SET_RATE_PARENT,
+ }
+};
+
+static const struct imx95_blk_ctl_dev_data hsio_blk_ctl_dev_data = {
+ .num_clks = 1,
+ .clk_dev_data = hsio_blk_ctl_clk_dev_data,
+ .clk_reg_offset = 0,
+};
+
static int imx95_bc_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -418,6 +437,7 @@ static const struct of_device_id imx95_bc_of_match[] = {
{ .compatible = "nxp,imx95-display-master-csr", },
{ .compatible = "nxp,imx95-lvds-csr", .data = &lvds_csr_dev_data },
{ .compatible = "nxp,imx95-display-csr", .data = &dispmix_csr_dev_data },
+ { .compatible = "nxp,imx95-hsio-blk-ctl", .data = &hsio_blk_ctl_dev_data },
{ .compatible = "nxp,imx95-vpu-csr", .data = &vpublk_dev_data },
{ /* Sentinel */ },
};
--
2.37.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block
2024-09-05 2:31 ` [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block Richard Zhu
@ 2024-09-05 3:34 ` Frank Li
2024-09-05 8:05 ` Peng Fan
1 sibling, 0 replies; 10+ messages in thread
From: Frank Li @ 2024-09-05 3:34 UTC (permalink / raw)
To: Richard Zhu
Cc: robh, krzk+dt, conor+dt, abelvesa, peng.fan, mturquette, sboyd,
shawnguo, s.hauer, festevam, devicetree, linux-kernel,
linux-arm-kernel, linux-clk, imx, kernel
On Thu, Sep 05, 2024 at 10:31:08AM +0800, Richard Zhu wrote:
> CREF_EN (Bit6) of LFAST_IO_REG control i.MX95 PCIe REF clock out
> enable/disable.
>
> Add compatible string "fsl,imx95-hsio-blk-ctl" to support PCIe REF clock
> out gate.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/clk/imx/clk-imx95-blk-ctl.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx95-blk-ctl.c b/drivers/clk/imx/clk-imx95-blk-ctl.c
> index 74f595f9e5e3..596dfb2f3b75 100644
> --- a/drivers/clk/imx/clk-imx95-blk-ctl.c
> +++ b/drivers/clk/imx/clk-imx95-blk-ctl.c
> @@ -248,6 +248,25 @@ static const struct imx95_blk_ctl_dev_data dispmix_csr_dev_data = {
> .clk_reg_offset = 0,
> };
>
> +static const struct imx95_blk_ctl_clk_dev_data hsio_blk_ctl_clk_dev_data[] = {
> + [0] = {
> + .name = "hsio_blk_ctl_clk",
> + .parent_names = (const char *[]){ "hsio_pll", },
> + .num_parents = 1,
> + .reg = 0,
> + .bit_idx = 6,
> + .bit_width = 1,
> + .type = CLK_GATE,
> + .flags = CLK_SET_RATE_PARENT,
> + }
> +};
> +
> +static const struct imx95_blk_ctl_dev_data hsio_blk_ctl_dev_data = {
> + .num_clks = 1,
> + .clk_dev_data = hsio_blk_ctl_clk_dev_data,
> + .clk_reg_offset = 0,
> +};
> +
> static int imx95_bc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -418,6 +437,7 @@ static const struct of_device_id imx95_bc_of_match[] = {
> { .compatible = "nxp,imx95-display-master-csr", },
> { .compatible = "nxp,imx95-lvds-csr", .data = &lvds_csr_dev_data },
> { .compatible = "nxp,imx95-display-csr", .data = &dispmix_csr_dev_data },
> + { .compatible = "nxp,imx95-hsio-blk-ctl", .data = &hsio_blk_ctl_dev_data },
> { .compatible = "nxp,imx95-vpu-csr", .data = &vpublk_dev_data },
> { /* Sentinel */ },
> };
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block
2024-09-05 2:31 ` [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block Richard Zhu
2024-09-05 3:34 ` Frank Li
@ 2024-09-05 8:05 ` Peng Fan
2024-09-05 8:57 ` Hongxing Zhu
1 sibling, 1 reply; 10+ messages in thread
From: Peng Fan @ 2024-09-05 8:05 UTC (permalink / raw)
To: Hongxing Zhu, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
imx@lists.linux.dev, kernel@pengutronix.de, Hongxing Zhu
> Subject: [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO
> block
>
> CREF_EN (Bit6) of LFAST_IO_REG control i.MX95 PCIe REF clock out
> enable/disable.
>
> Add compatible string "fsl,imx95-hsio-blk-ctl" to support PCIe REF clock
Typo: nxp,imx95-hsio-blk-ctl.
Except this, LGTM: Reviewed-by: Peng Fan <peng.fan@nxp.com>
Regards,
Peng.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO block
2024-09-05 8:05 ` Peng Fan
@ 2024-09-05 8:57 ` Hongxing Zhu
0 siblings, 0 replies; 10+ messages in thread
From: Hongxing Zhu @ 2024-09-05 8:57 UTC (permalink / raw)
To: Peng Fan, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
imx@lists.linux.dev, kernel@pengutronix.de
> -----Original Message-----
> From: Peng Fan <peng.fan@nxp.com>
> Sent: 2024年9月5日 16:06
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; abelvesa@kernel.org;
> mturquette@baylibre.com; sboyd@kernel.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; festevam@gmail.com
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-clk@vger.kernel.org;
> imx@lists.linux.dev; kernel@pengutronix.de; Hongxing Zhu
> <hongxing.zhu@nxp.com>
> Subject: RE: [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for HSIO
> block
>
> > Subject: [PATCH v2 3/3] clk: imx95-blk-ctl: Add one clock gate for
> > HSIO block
> >
> > CREF_EN (Bit6) of LFAST_IO_REG control i.MX95 PCIe REF clock out
> > enable/disable.
> >
> > Add compatible string "fsl,imx95-hsio-blk-ctl" to support PCIe REF
> > clock
>
> Typo: nxp,imx95-hsio-blk-ctl.
Nice catch, thanks.
Would be corrected later.
Best Regards
Richard Zhu
>
> Except this, LGTM: Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
> Regards,
> Peng.
^ permalink raw reply [flat|nested] 10+ messages in thread