[PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing

Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing
@ 2026-02-25  8:34 Nora Schiffer
  2026-02-25 15:41 ` Frank Li
  0 siblings, 1 reply; 4+ messages in thread
From: Nora Schiffer @ 2026-02-25  8:34 UTC (permalink / raw)
  To: Frank Li, Sascha Hauer
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel, imx,
	linux, devicetree, linux-kernel, Nora Schiffer

The pinmuxing for UART1 was mixing DCE and DTE modes, which cannot work.
Consistently use DCE mode.

This switches the RTS and CTS pins, which is fine for this board, as
UART1 is routed to a pin header.

Fixes: ddabb3ce3f90 ("arm64: dts: freescale: add TQMa8MPQL on MBa8MP-RAS314")
Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
---
 .../boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
index b7f69c92b7748..1665a5030b993 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
@@ -848,8 +848,8 @@ pinctrl_tlv320aic3x04: tlv320aic3x04grp {
 	pinctrl_uart1: uart1grp {
 		fsl,pins = <MX8MP_IOMUXC_SAI2_RXFS__UART1_DCE_TX	0x14>,
 			   <MX8MP_IOMUXC_SAI2_RXC__UART1_DCE_RX		0x14>,
-			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DTE_CTS	0x14>,
-			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DTE_RTS	0x14>;
+			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DCE_RTS	0x14>,
+			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DCE_CTS	0x14>;
 	};
 
 	pinctrl_uart1_gpio: uart1gpiogrp {
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing
  2026-02-25  8:34 [PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing Nora Schiffer
@ 2026-02-25 15:41 ` Frank Li
  2026-02-26  8:52   ` Nora Schiffer
  0 siblings, 1 reply; 4+ messages in thread
From: Frank Li @ 2026-02-25 15:41 UTC (permalink / raw)
  To: Nora Schiffer
  Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel, imx,
	linux, devicetree, linux-kernel

On Wed, Feb 25, 2026 at 09:34:18AM +0100, Nora Schiffer wrote:
> The pinmuxing for UART1 was mixing DCE and DTE modes, which cannot work.
> Consistently use DCE mode.
>
> This switches the RTS and CTS pins, which is fine for this board, as
> UART1 is routed to a pin header.

Is below commit better?

UART1 operates in DCE mode, but the RTS/CTS pins were incorrectly
configured using the DTE pinmux setting.

Correct the pinmux to match DCE mode, which does not affect existing
functionality because UART1 signals are routed to a pin header.

Frank
>
> Fixes: ddabb3ce3f90 ("arm64: dts: freescale: add TQMa8MPQL on MBa8MP-RAS314")
> Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
> ---
>  .../boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> index b7f69c92b7748..1665a5030b993 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> @@ -848,8 +848,8 @@ pinctrl_tlv320aic3x04: tlv320aic3x04grp {
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <MX8MP_IOMUXC_SAI2_RXFS__UART1_DCE_TX	0x14>,
>  			   <MX8MP_IOMUXC_SAI2_RXC__UART1_DCE_RX		0x14>,
> -			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DTE_CTS	0x14>,
> -			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DTE_RTS	0x14>;
> +			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DCE_RTS	0x14>,
> +			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DCE_CTS	0x14>;
>  	};
>
>  	pinctrl_uart1_gpio: uart1gpiogrp {
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> https://www.tq-group.com/
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing
  2026-02-25 15:41 ` Frank Li
@ 2026-02-26  8:52   ` Nora Schiffer
  2026-02-26 15:14     ` Frank Li
  0 siblings, 1 reply; 4+ messages in thread
From: Nora Schiffer @ 2026-02-26  8:52 UTC (permalink / raw)
  To: Frank Li
  Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel, imx,
	linux, devicetree, linux-kernel

On Wed, 2026-02-25 at 10:41 -0500, Frank Li wrote:
> On Wed, Feb 25, 2026 at 09:34:18AM +0100, Nora Schiffer wrote:
> > The pinmuxing for UART1 was mixing DCE and DTE modes, which cannot work.
> > Consistently use DCE mode.
> > 
> > This switches the RTS and CTS pins, which is fine for this board, as
> > UART1 is routed to a pin header.
> 
> Is below commit better?
> 
> UART1 operates in DCE mode, but the RTS/CTS pins were incorrectly
> configured using the DTE pinmux setting.
> 
> Correct the pinmux to match DCE mode, which does not affect existing
> functionality because UART1 signals are routed to a pin header.

Hi Frank,

your commit message sounds better, do you want me to send a v2?

Best,
Nora



> 
> Frank
> > 
> > Fixes: ddabb3ce3f90 ("arm64: dts: freescale: add TQMa8MPQL on MBa8MP-RAS314")
> > Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
> > ---
> >  .../boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts     | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> > index b7f69c92b7748..1665a5030b993 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> > @@ -848,8 +848,8 @@ pinctrl_tlv320aic3x04: tlv320aic3x04grp {
> >  	pinctrl_uart1: uart1grp {
> >  		fsl,pins = <MX8MP_IOMUXC_SAI2_RXFS__UART1_DCE_TX	0x14>,
> >  			   <MX8MP_IOMUXC_SAI2_RXC__UART1_DCE_RX		0x14>,
> > -			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DTE_CTS	0x14>,
> > -			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DTE_RTS	0x14>;
> > +			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DCE_RTS	0x14>,
> > +			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DCE_CTS	0x14>;
> >  	};
> > 
> >  	pinctrl_uart1_gpio: uart1gpiogrp {
> > --
> > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > Amtsgericht München, HRB 105018
> > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > https://www.tq-group.com/
> > 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing
  2026-02-26  8:52   ` Nora Schiffer
@ 2026-02-26 15:14     ` Frank Li
  0 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-02-26 15:14 UTC (permalink / raw)
  To: Nora Schiffer
  Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel, imx,
	linux, devicetree, linux-kernel

On Thu, Feb 26, 2026 at 09:52:22AM +0100, Nora Schiffer wrote:
> On Wed, 2026-02-25 at 10:41 -0500, Frank Li wrote:
> > On Wed, Feb 25, 2026 at 09:34:18AM +0100, Nora Schiffer wrote:
> > > The pinmuxing for UART1 was mixing DCE and DTE modes, which cannot work.
> > > Consistently use DCE mode.
> > >
> > > This switches the RTS and CTS pins, which is fine for this board, as
> > > UART1 is routed to a pin header.
> >
> > Is below commit better?
> >
> > UART1 operates in DCE mode, but the RTS/CTS pins were incorrectly
> > configured using the DTE pinmux setting.
> >
> > Correct the pinmux to match DCE mode, which does not affect existing
> > functionality because UART1 signals are routed to a pin header.
>
> Hi Frank,
>
> your commit message sounds better, do you want me to send a v2?

Yes, in case I miss change it when I apply it.

Frank
>
> Best,
> Nora
>
>
>
> >
> > Frank
> > >
> > > Fixes: ddabb3ce3f90 ("arm64: dts: freescale: add TQMa8MPQL on MBa8MP-RAS314")
> > > Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
> > > ---
> > >  .../boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts     | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> > > index b7f69c92b7748..1665a5030b993 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314.dts
> > > @@ -848,8 +848,8 @@ pinctrl_tlv320aic3x04: tlv320aic3x04grp {
> > >  	pinctrl_uart1: uart1grp {
> > >  		fsl,pins = <MX8MP_IOMUXC_SAI2_RXFS__UART1_DCE_TX	0x14>,
> > >  			   <MX8MP_IOMUXC_SAI2_RXC__UART1_DCE_RX		0x14>,
> > > -			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DTE_CTS	0x14>,
> > > -			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DTE_RTS	0x14>;
> > > +			   <MX8MP_IOMUXC_SAI2_RXD0__UART1_DCE_RTS	0x14>,
> > > +			   <MX8MP_IOMUXC_SAI2_TXFS__UART1_DCE_CTS	0x14>;
> > >  	};
> > >
> > >  	pinctrl_uart1_gpio: uart1gpiogrp {
> > > --
> > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > > Amtsgericht München, HRB 105018
> > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > > https://www.tq-group.com/
> > >
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> https://www.tq-group.com/


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-26 15:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-25  8:34 [PATCH] arm64: dts: freescale: imx8mp-tqma8mpql-mba8mp-ras314: fix UART1 RTS/CTS muxing Nora Schiffer
2026-02-25 15:41 ` Frank Li
2026-02-26  8:52   ` Nora Schiffer
2026-02-26 15:14     ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox