Re: [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186

From: xinlei.lee <xinlei.lee@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
	<lee.jones@linaro.org>, <matthias.bgg@gmail.com>,
	<jitao.shi@mediatek.com>, <allen-kh.cheng@mediatek.com>,
	<linux-pwm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 <Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
Subject: Re: [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186
Date: Fri, 25 Feb 2022 14:17:41 +0800	[thread overview]
Message-ID: <acc635f9e6d4f6f278ac334b13e96ce30c8c8b1d.camel@mediatek.com> (raw)
In-Reply-To: <Yhf2a/h6H1/9sN6b@robh.at.kernel.org>

On Thu, 2022-02-24 at 15:19 -0600, Rob Herring wrote:
> On Wed, Feb 16, 2022 at 05:32:51PM +0800, xinlei.lee@mediatek.com
> wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> > 
> > Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
> > 
> > Signed-off-by: Xinlei Lee <
> > xinlei.lee@mediatek.corp-partner.google.com>
> > ---
> >  Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml
> > index 768ab04d3764..1f45b1b8c3d4 100755
> > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > @@ -17,6 +17,7 @@ properties:
> >        - mediatek,mt6595-disp-pwm
> >        - mediatek,mt8173-disp-pwm
> >        - mediatek,mt8183-disp-pwm
> > +      - mediatek,mt8186-disp-pwm
> >        - mediatek,mt8192-disp-pwm
> >        - mediatek,mt8195-disp-pwm
> 
> It seems unlikely that every SoC has a different version of h/w for 
> something as simple as a PWM. There's not an appropriate fallback?
> The 
> first version from an SoC that has all the features and would work
> with 
> existing driver unchanged?
> 
> Rob

Hi Rob:

Thanks for your suggestion,I agree with your point of view.
If I want to show that different socs are using this disp_pwm, can I
use oneOf with items to achieve this, and reuse the compatiable that is
currently included in the pwm_mtk_disp.c file.
E.g:
- items:
       - enum:
           -mediatek,mt8186-disp-pwm
       - enum:
           -mediatek,mt8183-disp-pwm
What's your suggestion for this program?

Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel