Re: [v2,1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format

[xinlei.lee <xinlei.lee@mediatek.com>]

On Wed, 2022-02-16 at 11:22 +0100, Krzysztof Kozlowski wrote:
> On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> > 
> > Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as
> > suggested by maintainer
> > 
> > Signed-off-by: Xinlei Lee <
> > xinlei.lee@mediatek.corp-partner.google.com>
> > ---
> >  .../bindings/pwm/mediatek,pwm-disp.yaml       | 71
> > +++++++++++++++++++
> >  .../devicetree/bindings/pwm/pwm-mtk-disp.txt  | 44 ------------
> >  2 files changed, 71 insertions(+), 44 deletions(-)
> >  create mode 100755
> > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-
> > disp.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml
> > new file mode 100755
> > index 000000000000..edf2a2e9ea72
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > @@ -0,0 +1,71 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek PWM Controller Device Tree Bindings
> 
> This is a Display PWM, not a generic PWM.
> 
> > +
> > +maintainers:
> > +  - Jitao Shi <jitao.shi@mediatek.com>
> > +  - Xinlei Lee <xinlei.lee@mediatek.com>
> > +
> 
> My comment about pwm schema was ignored.
> 
> Please include pwm.yaml.
> 
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mediatek,mt2701-disp-pwm
> > +      - mediatek,mt6595-disp-pwm
> > +      - mediatek,mt8173-disp-pwm
> > +      - mediatek,mt8183-disp-pwm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +  "#pwm-cells":
> > +    description:
> > +      Number of cells in a PWM specifier.
> 
> Need a const. Description can be skipped, it's obvious.
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof:

Thanks for your review, I'm sorry for my previous misunderstanding.
I'll fix all the issues in the next version.

Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel