* [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE
@ 2026-04-14 10:02 Vincent Donnefort
2026-04-14 14:52 ` Marc Zyngier
2026-04-17 14:23 ` Marc Zyngier
0 siblings, 2 replies; 4+ messages in thread
From: Vincent Donnefort @ 2026-04-14 10:02 UTC (permalink / raw)
To: maz, oliver.upton, joey.gouly, suzuki.poulose, yuzenghui,
catalin.marinas, will
Cc: linux-arm-kernel, kvmarm, kernel-team, Vincent Donnefort
The introduction of __KVM_HOST_SMCCC_FUNC_MAX_NO_PKVM excluded hyp
tracing HVCs from the common [nh]VHE/pKVM list. Re-allow them.
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h
index 37414440cee7..11dcdf434971 100644
--- a/arch/arm64/include/asm/kvm_asm.h
+++ b/arch/arm64/include/asm/kvm_asm.h
@@ -72,6 +72,14 @@ enum __kvm_host_smccc_func {
__KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_range,
__KVM_HOST_SMCCC_FUNC___kvm_flush_cpu_context,
__KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff,
+ __KVM_HOST_SMCCC_FUNC___tracing_load,
+ __KVM_HOST_SMCCC_FUNC___tracing_unload,
+ __KVM_HOST_SMCCC_FUNC___tracing_enable,
+ __KVM_HOST_SMCCC_FUNC___tracing_swap_reader,
+ __KVM_HOST_SMCCC_FUNC___tracing_update_clock,
+ __KVM_HOST_SMCCC_FUNC___tracing_reset,
+ __KVM_HOST_SMCCC_FUNC___tracing_enable_event,
+ __KVM_HOST_SMCCC_FUNC___tracing_write_event,
__KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs,
__KVM_HOST_SMCCC_FUNC___vgic_v3_restore_vmcr_aprs,
__KVM_HOST_SMCCC_FUNC___vgic_v5_save_apr,
@@ -100,14 +108,6 @@ enum __kvm_host_smccc_func {
__KVM_HOST_SMCCC_FUNC___pkvm_vcpu_load,
__KVM_HOST_SMCCC_FUNC___pkvm_vcpu_put,
__KVM_HOST_SMCCC_FUNC___pkvm_tlb_flush_vmid,
- __KVM_HOST_SMCCC_FUNC___tracing_load,
- __KVM_HOST_SMCCC_FUNC___tracing_unload,
- __KVM_HOST_SMCCC_FUNC___tracing_enable,
- __KVM_HOST_SMCCC_FUNC___tracing_swap_reader,
- __KVM_HOST_SMCCC_FUNC___tracing_update_clock,
- __KVM_HOST_SMCCC_FUNC___tracing_reset,
- __KVM_HOST_SMCCC_FUNC___tracing_enable_event,
- __KVM_HOST_SMCCC_FUNC___tracing_write_event,
};
#define DECLARE_KVM_VHE_SYM(sym) extern char sym[]
diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c
index 73f2e0221e70..8f7582d57ab5 100644
--- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c
+++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c
@@ -709,6 +709,14 @@ static const hcall_t host_hcall[] = {
HANDLE_FUNC(__kvm_tlb_flush_vmid_range),
HANDLE_FUNC(__kvm_flush_cpu_context),
HANDLE_FUNC(__kvm_timer_set_cntvoff),
+ HANDLE_FUNC(__tracing_load),
+ HANDLE_FUNC(__tracing_unload),
+ HANDLE_FUNC(__tracing_enable),
+ HANDLE_FUNC(__tracing_swap_reader),
+ HANDLE_FUNC(__tracing_update_clock),
+ HANDLE_FUNC(__tracing_reset),
+ HANDLE_FUNC(__tracing_enable_event),
+ HANDLE_FUNC(__tracing_write_event),
HANDLE_FUNC(__vgic_v3_save_aprs),
HANDLE_FUNC(__vgic_v3_restore_vmcr_aprs),
HANDLE_FUNC(__vgic_v5_save_apr),
@@ -735,14 +743,6 @@ static const hcall_t host_hcall[] = {
HANDLE_FUNC(__pkvm_vcpu_load),
HANDLE_FUNC(__pkvm_vcpu_put),
HANDLE_FUNC(__pkvm_tlb_flush_vmid),
- HANDLE_FUNC(__tracing_load),
- HANDLE_FUNC(__tracing_unload),
- HANDLE_FUNC(__tracing_enable),
- HANDLE_FUNC(__tracing_swap_reader),
- HANDLE_FUNC(__tracing_update_clock),
- HANDLE_FUNC(__tracing_reset),
- HANDLE_FUNC(__tracing_enable_event),
- HANDLE_FUNC(__tracing_write_event),
};
static void handle_host_hcall(struct kvm_cpu_context *host_ctxt)
base-commit: 94b4ae79ebb42a8a6f2124b4d4b033b15a98e4f9
--
2.54.0.rc0.605.g598a273b03-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE
2026-04-14 10:02 [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE Vincent Donnefort
@ 2026-04-14 14:52 ` Marc Zyngier
2026-04-14 14:58 ` Vincent Donnefort
2026-04-17 14:23 ` Marc Zyngier
1 sibling, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2026-04-14 14:52 UTC (permalink / raw)
To: Vincent Donnefort
Cc: oliver.upton, joey.gouly, suzuki.poulose, yuzenghui,
catalin.marinas, will, linux-arm-kernel, kvmarm, kernel-team
On Tue, 14 Apr 2026 11:02:31 +0100,
Vincent Donnefort <vdonnefort@google.com> wrote:
>
> The introduction of __KVM_HOST_SMCCC_FUNC_MAX_NO_PKVM excluded hyp
> tracing HVCs from the common [nh]VHE/pKVM list. Re-allow them.
>
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
>
> diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h
> index 37414440cee7..11dcdf434971 100644
> --- a/arch/arm64/include/asm/kvm_asm.h
> +++ b/arch/arm64/include/asm/kvm_asm.h
> @@ -72,6 +72,14 @@ enum __kvm_host_smccc_func {
> __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_range,
> __KVM_HOST_SMCCC_FUNC___kvm_flush_cpu_context,
> __KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff,
> + __KVM_HOST_SMCCC_FUNC___tracing_load,
> + __KVM_HOST_SMCCC_FUNC___tracing_unload,
> + __KVM_HOST_SMCCC_FUNC___tracing_enable,
> + __KVM_HOST_SMCCC_FUNC___tracing_swap_reader,
> + __KVM_HOST_SMCCC_FUNC___tracing_update_clock,
> + __KVM_HOST_SMCCC_FUNC___tracing_reset,
> + __KVM_HOST_SMCCC_FUNC___tracing_enable_event,
> + __KVM_HOST_SMCCC_FUNC___tracing_write_event,
> __KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs,
> __KVM_HOST_SMCCC_FUNC___vgic_v3_restore_vmcr_aprs,
> __KVM_HOST_SMCCC_FUNC___vgic_v5_save_apr,
> @@ -100,14 +108,6 @@ enum __kvm_host_smccc_func {
> __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_load,
> __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_put,
> __KVM_HOST_SMCCC_FUNC___pkvm_tlb_flush_vmid,
> - __KVM_HOST_SMCCC_FUNC___tracing_load,
> - __KVM_HOST_SMCCC_FUNC___tracing_unload,
> - __KVM_HOST_SMCCC_FUNC___tracing_enable,
> - __KVM_HOST_SMCCC_FUNC___tracing_swap_reader,
> - __KVM_HOST_SMCCC_FUNC___tracing_update_clock,
> - __KVM_HOST_SMCCC_FUNC___tracing_reset,
> - __KVM_HOST_SMCCC_FUNC___tracing_enable_event,
> - __KVM_HOST_SMCCC_FUNC___tracing_write_event,
> };
>
> #define DECLARE_KVM_VHE_SYM(sym) extern char sym[]
> diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c
> index 73f2e0221e70..8f7582d57ab5 100644
> --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c
> +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c
> @@ -709,6 +709,14 @@ static const hcall_t host_hcall[] = {
> HANDLE_FUNC(__kvm_tlb_flush_vmid_range),
> HANDLE_FUNC(__kvm_flush_cpu_context),
> HANDLE_FUNC(__kvm_timer_set_cntvoff),
> + HANDLE_FUNC(__tracing_load),
> + HANDLE_FUNC(__tracing_unload),
> + HANDLE_FUNC(__tracing_enable),
> + HANDLE_FUNC(__tracing_swap_reader),
> + HANDLE_FUNC(__tracing_update_clock),
> + HANDLE_FUNC(__tracing_reset),
> + HANDLE_FUNC(__tracing_enable_event),
> + HANDLE_FUNC(__tracing_write_event),
> HANDLE_FUNC(__vgic_v3_save_aprs),
> HANDLE_FUNC(__vgic_v3_restore_vmcr_aprs),
> HANDLE_FUNC(__vgic_v5_save_apr),
> @@ -735,14 +743,6 @@ static const hcall_t host_hcall[] = {
> HANDLE_FUNC(__pkvm_vcpu_load),
> HANDLE_FUNC(__pkvm_vcpu_put),
> HANDLE_FUNC(__pkvm_tlb_flush_vmid),
> - HANDLE_FUNC(__tracing_load),
> - HANDLE_FUNC(__tracing_unload),
> - HANDLE_FUNC(__tracing_enable),
> - HANDLE_FUNC(__tracing_swap_reader),
> - HANDLE_FUNC(__tracing_update_clock),
> - HANDLE_FUNC(__tracing_reset),
> - HANDLE_FUNC(__tracing_enable_event),
> - HANDLE_FUNC(__tracing_write_event),
> };
Why isn't it sufficient to reorder the enum?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE
2026-04-14 14:52 ` Marc Zyngier
@ 2026-04-14 14:58 ` Vincent Donnefort
0 siblings, 0 replies; 4+ messages in thread
From: Vincent Donnefort @ 2026-04-14 14:58 UTC (permalink / raw)
To: Marc Zyngier
Cc: oliver.upton, joey.gouly, suzuki.poulose, yuzenghui,
catalin.marinas, will, linux-arm-kernel, kvmarm, kernel-team
On Tue, Apr 14, 2026 at 03:52:29PM +0100, Marc Zyngier wrote:
> On Tue, 14 Apr 2026 11:02:31 +0100,
> Vincent Donnefort <vdonnefort@google.com> wrote:
> >
> > The introduction of __KVM_HOST_SMCCC_FUNC_MAX_NO_PKVM excluded hyp
> > tracing HVCs from the common [nh]VHE/pKVM list. Re-allow them.
> >
> > Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
> >
> > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h
> > index 37414440cee7..11dcdf434971 100644
> > --- a/arch/arm64/include/asm/kvm_asm.h
> > +++ b/arch/arm64/include/asm/kvm_asm.h
> > @@ -72,6 +72,14 @@ enum __kvm_host_smccc_func {
> > __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_range,
> > __KVM_HOST_SMCCC_FUNC___kvm_flush_cpu_context,
> > __KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff,
> > + __KVM_HOST_SMCCC_FUNC___tracing_load,
> > + __KVM_HOST_SMCCC_FUNC___tracing_unload,
> > + __KVM_HOST_SMCCC_FUNC___tracing_enable,
> > + __KVM_HOST_SMCCC_FUNC___tracing_swap_reader,
> > + __KVM_HOST_SMCCC_FUNC___tracing_update_clock,
> > + __KVM_HOST_SMCCC_FUNC___tracing_reset,
> > + __KVM_HOST_SMCCC_FUNC___tracing_enable_event,
> > + __KVM_HOST_SMCCC_FUNC___tracing_write_event,
> > __KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs,
> > __KVM_HOST_SMCCC_FUNC___vgic_v3_restore_vmcr_aprs,
> > __KVM_HOST_SMCCC_FUNC___vgic_v5_save_apr,
> > @@ -100,14 +108,6 @@ enum __kvm_host_smccc_func {
> > __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_load,
> > __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_put,
> > __KVM_HOST_SMCCC_FUNC___pkvm_tlb_flush_vmid,
> > - __KVM_HOST_SMCCC_FUNC___tracing_load,
> > - __KVM_HOST_SMCCC_FUNC___tracing_unload,
> > - __KVM_HOST_SMCCC_FUNC___tracing_enable,
> > - __KVM_HOST_SMCCC_FUNC___tracing_swap_reader,
> > - __KVM_HOST_SMCCC_FUNC___tracing_update_clock,
> > - __KVM_HOST_SMCCC_FUNC___tracing_reset,
> > - __KVM_HOST_SMCCC_FUNC___tracing_enable_event,
> > - __KVM_HOST_SMCCC_FUNC___tracing_write_event,
> > };
> >
> > #define DECLARE_KVM_VHE_SYM(sym) extern char sym[]
> > diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c
> > index 73f2e0221e70..8f7582d57ab5 100644
> > --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c
> > +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c
> > @@ -709,6 +709,14 @@ static const hcall_t host_hcall[] = {
> > HANDLE_FUNC(__kvm_tlb_flush_vmid_range),
> > HANDLE_FUNC(__kvm_flush_cpu_context),
> > HANDLE_FUNC(__kvm_timer_set_cntvoff),
> > + HANDLE_FUNC(__tracing_load),
> > + HANDLE_FUNC(__tracing_unload),
> > + HANDLE_FUNC(__tracing_enable),
> > + HANDLE_FUNC(__tracing_swap_reader),
> > + HANDLE_FUNC(__tracing_update_clock),
> > + HANDLE_FUNC(__tracing_reset),
> > + HANDLE_FUNC(__tracing_enable_event),
> > + HANDLE_FUNC(__tracing_write_event),
> > HANDLE_FUNC(__vgic_v3_save_aprs),
> > HANDLE_FUNC(__vgic_v3_restore_vmcr_aprs),
> > HANDLE_FUNC(__vgic_v5_save_apr),
> > @@ -735,14 +743,6 @@ static const hcall_t host_hcall[] = {
> > HANDLE_FUNC(__pkvm_vcpu_load),
> > HANDLE_FUNC(__pkvm_vcpu_put),
> > HANDLE_FUNC(__pkvm_tlb_flush_vmid),
> > - HANDLE_FUNC(__tracing_load),
> > - HANDLE_FUNC(__tracing_unload),
> > - HANDLE_FUNC(__tracing_enable),
> > - HANDLE_FUNC(__tracing_swap_reader),
> > - HANDLE_FUNC(__tracing_update_clock),
> > - HANDLE_FUNC(__tracing_reset),
> > - HANDLE_FUNC(__tracing_enable_event),
> > - HANDLE_FUNC(__tracing_write_event),
> > };
>
> Why isn't it sufficient to reorder the enum?
>
> Thanks,
>
> M.
It is, I just thought we might want to keep both in the same order. WDYS?
>
> --
> Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE
2026-04-14 10:02 [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE Vincent Donnefort
2026-04-14 14:52 ` Marc Zyngier
@ 2026-04-17 14:23 ` Marc Zyngier
1 sibling, 0 replies; 4+ messages in thread
From: Marc Zyngier @ 2026-04-17 14:23 UTC (permalink / raw)
To: joey.gouly, suzuki.poulose, yuzenghui, catalin.marinas, will,
Oliver Upton, Vincent Donnefort
Cc: linux-arm-kernel, kvmarm, kernel-team
On Tue, 14 Apr 2026 11:02:31 +0100, Vincent Donnefort wrote:
> The introduction of __KVM_HOST_SMCCC_FUNC_MAX_NO_PKVM excluded hyp
> tracing HVCs from the common [nh]VHE/pKVM list. Re-allow them.
>
>
Applied to fixes, thanks!
[1/1] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE
commit: ccab51d69b1478b549ad0bbb38f556ab3bfb47ab
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-17 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-14 10:02 [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE Vincent Donnefort
2026-04-14 14:52 ` Marc Zyngier
2026-04-14 14:58 ` Vincent Donnefort
2026-04-17 14:23 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox