From: "Anwar, Md Danish" <a0501179@ti.com>
To: Meghana Malladi <m-malladi@ti.com>, <vigneshr@ti.com>,
<horms@kernel.org>, <jan.kiszka@siemens.com>,
<diogo.ivo@siemens.com>, <pabeni@redhat.com>, <kuba@kernel.org>,
<edumazet@google.com>, <davem@davemloft.net>,
<andrew+netdev@lunn.ch>
Cc: <linux-kernel@vger.kernel.org>, <vadim.fedorenko@linux.dev>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<srk@ti.com>, Roger Quadros <rogerq@kernel.org>,
<danishanwar@ti.com>
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix 1 PPS sync
Date: Thu, 24 Oct 2024 19:03:00 +0530 [thread overview]
Message-ID: <c735f62e-c9fc-4698-ae9f-305cd5519dbd@ti.com> (raw)
In-Reply-To: <20241024113140.973928-1-m-malladi@ti.com>
Hi Meghana,
On 10/24/2024 5:01 PM, Meghana Malladi wrote:
> The first PPS latch time needs to be calculated by the driver
> (in rounded off seconds) and configured as the start time
> offset for the cycle. After synchronizing two PTP clocks
> running as master/slave, missing this would cause master
> and slave to start immediately with some milliseconds
> drift which causes the PPS signal to never synchronize with
> the PTP master.
>
> Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Signed-off-by: Meghana Malladi <m-malladi@ti.com>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
--
Thanks and Regards,
Md Danish Anwar
next prev parent reply other threads:[~2024-10-24 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 11:31 [PATCH net v2] net: ti: icssg-prueth: Fix 1 PPS sync Meghana Malladi
2024-10-24 13:16 ` Vadim Fedorenko
2024-10-24 13:33 ` Anwar, Md Danish [this message]
2024-10-24 19:55 ` Andrew Lunn
2024-10-25 5:47 ` Meghana Malladi
2024-10-25 13:22 ` Andrew Lunn
2024-10-28 11:05 ` Meghana Malladi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c735f62e-c9fc-4698-ae9f-305cd5519dbd@ti.com \
--to=a0501179@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox