[PATCH 0/2] PCI: brcmstb: Trivial changes

[PATCH 0/2] PCI: brcmstb: Trivial changes

[Florian Fainelli]

The first patch removes Nicolas from the maintainers list since he has
not been active and the second patch uses an existing constant rather
than open code the value.

Florian Fainelli (2):
  MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
  PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS

 MAINTAINERS                           | 1 -
 drivers/pci/controller/pcie-brcmstb.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

-- 
2.43.0

[PATCH 1/2] MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb

[Florian Fainelli]

Nicolas indicated a long time back that he would not have the bandwidth
and indeed, has not provided any review or feedback since.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 41d95e7c60c6..439edc5babb3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5093,7 +5093,6 @@ F:	include/linux/platform_data/brcmnand.h
 
 BROADCOM STB PCIE DRIVER
 M:	Jim Quinlan <jim2101024@gmail.com>
-M:	Nicolas Saenz Julienne <nsaenz@kernel.org>
 M:	Florian Fainelli <florian.fainelli@broadcom.com>
 R:	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
 L:	linux-pci@vger.kernel.org
-- 
2.43.0

Re: [PATCH 1/2] MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb

[Manivannan Sadhasivam]

+ Nicolas (who was not CCed)

On Tue, Jun 24, 2025 at 04:19:22PM GMT, Florian Fainelli wrote:
> Nicolas indicated a long time back that he would not have the bandwidth
> and indeed, has not provided any review or feedback since.
> 

Nicolas, I hope you are fine with this change. So I'm going ahead and merging
it. If you don't feel so, please let me know.

- Mani

> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41d95e7c60c6..439edc5babb3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5093,7 +5093,6 @@ F:	include/linux/platform_data/brcmnand.h
>  
>  BROADCOM STB PCIE DRIVER
>  M:	Jim Quinlan <jim2101024@gmail.com>
> -M:	Nicolas Saenz Julienne <nsaenz@kernel.org>
>  M:	Florian Fainelli <florian.fainelli@broadcom.com>
>  R:	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
>  L:	linux-pci@vger.kernel.org
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH 1/2] MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb

[nicolas saenz julienne]

On Thu, 2025-07-17 at 18:12 +0530, Manivannan Sadhasivam wrote:
> + Nicolas (who was not CCed)
> 
> On Tue, Jun 24, 2025 at 04:19:22PM GMT, Florian Fainelli wrote:
> > Nicolas indicated a long time back that he would not have the bandwidth
> > and indeed, has not provided any review or feedback since.
> > 
> 
> Nicolas, I hope you are fine with this change. So I'm going ahead and merging
> it. If you don't feel so, please let me know.

I'm a bit late, but:

Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org>

Thanks,
Nicolas

[PATCH 2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS

[Florian Fainelli]

The delay that we are waiting on in brcm_pcie_start_link() is
PCIE_T_RRS_READY_MS, use it.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index 92887b394eb4..7fa2087e85db 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -1337,7 +1337,7 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
 	 * Wait for 100ms after PERST# deassertion; see PCIe CEM specification
 	 * sections 2.2, PCIe r5.0, 6.6.1.
 	 */
-	msleep(100);
+	msleep(PCIE_T_RRS_READY_MS);
 
 	/*
 	 * Give the RC/EP even more time to wake up, before trying to
-- 
2.43.0

Re: [PATCH 2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS

[Manivannan Sadhasivam]

On Tue, Jun 24, 2025 at 04:19:23PM GMT, Florian Fainelli wrote:
> The delay that we are waiting on in brcm_pcie_start_link() is
> PCIE_T_RRS_READY_MS, use it.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/pci/controller/pcie-brcmstb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 92887b394eb4..7fa2087e85db 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1337,7 +1337,7 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
>  	 * Wait for 100ms after PERST# deassertion; see PCIe CEM specification
>  	 * sections 2.2, PCIe r5.0, 6.6.1.
>  	 */

We don't need this comment also since it is part of RRS definition. I'll remove
it while applying.

- Mani

> -	msleep(100);
> +	msleep(PCIE_T_RRS_READY_MS);
>  
>  	/*
>  	 * Give the RC/EP even more time to wake up, before trying to
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH 0/2] PCI: brcmstb: Trivial changes

[Manivannan Sadhasivam]

On Tue, 24 Jun 2025 16:19:21 -0700, Florian Fainelli wrote:
> The first patch removes Nicolas from the maintainers list since he has
> not been active and the second patch uses an existing constant rather
> than open code the value.
> 
> Florian Fainelli (2):
>   MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
>   PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
> 
> [...]

Applied, thanks!

[1/2] MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
      commit: fde41f282590b46e96864ae88da2e2c20a967b3a
[2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
      commit: e8e7c1e95d6d4ccdc53654a5966d2183532ab115

Best regards,
-- 
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

Re: [PATCH 0/2] PCI: brcmstb: Trivial changes

[Bjorn Helgaas]

On Thu, Jul 17, 2025 at 06:17:28PM +0530, Manivannan Sadhasivam wrote:
> 
> On Tue, 24 Jun 2025 16:19:21 -0700, Florian Fainelli wrote:
> > The first patch removes Nicolas from the maintainers list since he has
> > not been active and the second patch uses an existing constant rather
> > than open code the value.
> > 
> > Florian Fainelli (2):
> >   MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
> >   PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
>       commit: fde41f282590b46e96864ae88da2e2c20a967b3a
> [2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
>       commit: e8e7c1e95d6d4ccdc53654a5966d2183532ab115

Thanks, I updated s/PCIE_T_RRS_READY_MS/PCIE_RESET_CONFIG_WAIT_MS/
when merging this branch to account for the removal of
PCIE_T_RRS_READY_MS by
https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/commit/?id=bbc6a829ad3f
("PCI: rockchip-host: Use macro PCIE_RESET_CONFIG_WAIT_MS")

Re: [PATCH 0/2] PCI: brcmstb: Trivial changes

[Florian Fainelli]

On 7/17/25 14:00, Bjorn Helgaas wrote:
> On Thu, Jul 17, 2025 at 06:17:28PM +0530, Manivannan Sadhasivam wrote:
>>
>> On Tue, 24 Jun 2025 16:19:21 -0700, Florian Fainelli wrote:
>>> The first patch removes Nicolas from the maintainers list since he has
>>> not been active and the second patch uses an existing constant rather
>>> than open code the value.
>>>
>>> Florian Fainelli (2):
>>>    MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
>>>    PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/2] MAINTAINERS: Drop Nicolas from maintaining pcie-brcmstb
>>        commit: fde41f282590b46e96864ae88da2e2c20a967b3a
>> [2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
>>        commit: e8e7c1e95d6d4ccdc53654a5966d2183532ab115
> 
> Thanks, I updated s/PCIE_T_RRS_READY_MS/PCIE_RESET_CONFIG_WAIT_MS/
> when merging this branch to account for the removal of
> PCIE_T_RRS_READY_MS by
> https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/commit/?id=bbc6a829ad3f
> ("PCI: rockchip-host: Use macro PCIE_RESET_CONFIG_WAIT_MS")
> 

OK, thank you both!
-- 
Florian