[PATCH 0/2] Baisc devicetree support for Amlogic T7

[PATCH 0/2] Baisc devicetree support for Amlogic T7

[Xianwei Zhao]

T7 is an advanced application processor designed for smart display.

Add the new T7 SoC/board device tree bindings.

Add basic support for the T7 based Amlogic AN400 board, which describes
the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
booting up into the serial console.

Xianwei Zhao (2):
  dt-bindings: arm: amlogic: add T7 based AN400 bindings
  arm64: dts: add support for T7 based Amlogic AN400

 .../devicetree/bindings/arm/amlogic.yaml      |   6 +
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
 4 files changed, 193 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
 create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi


base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

[Xianwei Zhao]

Document the new T7 SoC/board device tree bindings.

T7 is an advanced application processor designed for smart display.
It integrates a powerful CPU/GPU subsystem, a secured 8K video
CODEC engine with all major peripherals.

The main system CPU is based on Big.LITTLE architecture,
with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.

Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 08d59842655c..79a8b44ffd03 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -218,6 +218,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4
 
+      - description: Boards with the Amlogic T7 A311D2 SoC
+        items:
+          - enum:
+              - amlogic,an400
+          - const: amlogic,t7
+
 additionalProperties: true
 
 ...
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

[Krzysztof Kozlowski]

On 26/06/2023 11:52, Xianwei Zhao wrote:
> Document the new T7 SoC/board device tree bindings.
> 
> T7 is an advanced application processor designed for smart display.
> It integrates a powerful CPU/GPU subsystem, a secured 8K video
> CODEC engine with all major peripherals.
> 
> The main system CPU is based on Big.LITTLE architecture,
> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
> 


If there is going to be new version, subject: drop second/last,
redundant "bindings". The "dt-bindings" prefix is already stating that
these are bindings.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

[Xianwei Zhao]

Hi Krzysztof,
       Thank you for your reply.

On 2023/6/26 23:38, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 26/06/2023 11:52, Xianwei Zhao wrote:
>> Document the new T7 SoC/board device tree bindings.
>>
>> T7 is an advanced application processor designed for smart display.
>> It integrates a powerful CPU/GPU subsystem, a secured 8K video
>> CODEC engine with all major peripherals.
>>
>> The main system CPU is based on Big.LITTLE architecture,
>> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
>>
>
> If there is going to be new version, subject: drop second/last,
> redundant "bindings". The "dt-bindings" prefix is already stating that
> these are bindings.
will drop bindings in next version, thanks.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

[Xianwei Zhao]

Hi Krzysztof,
       Thank you for your reply.

On 2023/6/26 23:38, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 26/06/2023 11:52, Xianwei Zhao wrote:
>> Document the new T7 SoC/board device tree bindings.
>>
>> T7 is an advanced application processor designed for smart display.
>> It integrates a powerful CPU/GPU subsystem, a secured 8K video
>> CODEC engine with all major peripherals.
>>
>> The main system CPU is based on Big.LITTLE architecture,
>> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
>>
>
> If there is going to be new version, subject: drop second/last,
> redundant "bindings". The "dt-bindings" prefix is already stating that
> these are bindings.
Will drop "bindings" in next version, thanks.
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

[Christian Hewitt]

> On 26 Jun 2023, at 1:52 pm, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
> 
> Document the new T7 SoC/board device tree bindings.
> 
> T7 is an advanced application processor designed for smart display.
> It integrates a powerful CPU/GPU subsystem, a secured 8K video
> CODEC engine with all major peripherals.

^ please avoid marketing text in commit messages (and same for the
other commits in this series).

> The main system CPU is based on Big.LITTLE architecture,
> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.

“T7 is an Amlogic SoC for smart display applications. The main CPU is
based on a big.LITTLE architecture with a quad-core A73 cluster and
quad-core A53 cluster.”

Christian

> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 08d59842655c..79a8b44ffd03 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -218,6 +218,12 @@ properties:
>               - amlogic,aq222
>           - const: amlogic,s4
> 
> +      - description: Boards with the Amlogic T7 A311D2 SoC
> +        items:
> +          - enum:
> +              - amlogic,an400
> +          - const: amlogic,t7
> +
> additionalProperties: true
> 
> ...
> -- 
> 2.37.1
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: arm: amlogic: add T7 based AN400 bindings

[Xianwei Zhao]

Hi Christian,
       Thanks for your advice.

On 2023/6/27 16:56, Christian Hewitt wrote:
> [你通常不会收到来自 christianshewitt@gmail.com 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
> 
> [ EXTERNAL EMAIL ]
> 
>> On 26 Jun 2023, at 1:52 pm, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>>
>> Document the new T7 SoC/board device tree bindings.
>>
>> T7 is an advanced application processor designed for smart display.
>> It integrates a powerful CPU/GPU subsystem, a secured 8K video
>> CODEC engine with all major peripherals.
> 
> ^ please avoid marketing text in commit messages (and same for the
> other commits in this series).
> 
Will do
>> The main system CPU is based on Big.LITTLE architecture,
>> with quad core Cortex-A73 cluster and quad core Cortex-A53 cluster.
> 
> “T7 is an Amlogic SoC for smart display applications. The main CPU is
> based on a big.LITTLE architecture with a quad-core A73 cluster and
> quad-core A53 cluster.”
> 
Will do
> Christian
> 
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index 08d59842655c..79a8b44ffd03 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -218,6 +218,12 @@ properties:
>>                - amlogic,aq222
>>            - const: amlogic,s4
>>
>> +      - description: Boards with the Amlogic T7 A311D2 SoC
>> +        items:
>> +          - enum:
>> +              - amlogic,an400
>> +          - const: amlogic,t7
>> +
>> additionalProperties: true
>>
>> ...
>> --
>> 2.37.1
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

[Xianwei Zhao]

Amlogic T7 is an advanced application processor designed for smart display.

Add basic support for the T7 based Amlogic AN400 board, which describes
the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
booting up into the serial console.

Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
 3 files changed, 187 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
 create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 6f61798a109f..99299731f5d4 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
+dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j110-rev-2.dtb
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
new file mode 100644
index 000000000000..7ce1975b99e4
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "amlogic-t7.dtsi"
+
+/ {
+	model = "Amlogic A311D2 AN400 Development Board";
+	compatible = "amlogic,an400", "amlogic,t7";
+	interrupt-parent = <&gic>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	aliases {
+		serial0 = &uart_a;
+	};
+
+	memory@0 {
+		device_type = "memory";
+		linux,usable-memory = <0x00000000 0x00000000 0x00000000 0xE0000000
+					0x00000001 0x00000000 0x00000000 0x20000000>;
+	};
+};
+
+&uart_a {
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
new file mode 100644
index 000000000000..d3ee864f0d40
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
@@ -0,0 +1,156 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/gpio/gpio.h>
+/ {
+	cpus:cpus {
+		#address-cells = <2>;
+		#size-cells = <0>;
+
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+				core2 {
+					cpu = <&cpu2>;
+				};
+				core3 {
+					cpu = <&cpu3>;
+				};
+			};
+			cluster1 {
+				core0 {
+					cpu = <&cpu4>;
+				};
+				core1 {
+					cpu = <&cpu5>;
+				};
+				core2 {
+					cpu = <&cpu6>;
+				};
+				core3 {
+					cpu = <&cpu7>;
+				};
+			};
+		};
+
+		cpu0:cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a73";
+			reg = <0x0 0x0>;
+			enable-method = "psci";
+		};
+
+		cpu1:cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a73";
+			reg = <0x0 0x1>;
+			enable-method = "psci";
+		};
+
+		cpu2:cpu@2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a73";
+			reg = <0x0 0x2>;
+			enable-method = "psci";
+		};
+
+		cpu3:cpu@3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a73";
+			reg = <0x0 0x3>;
+			enable-method = "psci";
+		};
+
+		cpu4:cpu@100 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x0 0x100>;
+			enable-method = "psci";
+		};
+
+		cpu5:cpu@101{
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x0 0x101>;
+			enable-method = "psci";
+		};
+
+		cpu6:cpu@102 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x0 0x102>;
+			enable-method = "psci";
+		};
+
+		cpu7:cpu@103 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x0 0x103>;
+			enable-method = "psci";
+		};
+	};
+
+	timer {
+		compatible = "arm,armv8-timer";
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
+	};
+
+	psci {
+		compatible = "arm,psci-0.2";
+		method = "smc";
+	};
+
+	xtal: xtal-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <24000000>;
+		clock-output-names = "xtal";
+		#clock-cells = <0>;
+	};
+
+	soc {
+		compatible = "simple-bus";
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		gic: interrupt-controller@fff01000 {
+			compatible = "arm,gic-400";
+			#interrupt-cells = <3>;
+			#address-cells = <0>;
+			interrupt-controller;
+			reg = <0x0 0xfff01000 0 0x1000>,
+			    <0x0 0xfff02000 0 0x0100>;
+			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
+		     };
+
+		apb4: bus@fe000000 {
+			compatible = "simple-bus";
+			reg = <0x0 0xfe000000 0x0 0x480000>;
+			#address-cells = <2>;
+			#size-cells = <2>;
+			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
+
+			uart_a: serial@78000 {
+				compatible = "amlogic,meson-s4-uart",
+					     "amlogic,meson-ao-uart";
+				reg = <0x0 0x78000 0x0 0x18>;
+				interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
+				status = "disabled";
+				clocks = <&xtal>,<&xtal>,<&xtal>;
+				clock-names = "xtal", "pclk", "baud";
+			};
+		};
+	};
+};
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

[Krzysztof Kozlowski]

On 26/06/2023 11:52, Xianwei Zhao wrote:
> Amlogic T7 is an advanced application processor designed for smart display.
> 
> Add basic support for the T7 based Amlogic AN400 board, which describes
> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> booting up into the serial console.

Few nits.

...

> +				core3 {
> +					cpu = <&cpu7>;
> +				};
> +			};
> +		};
> +
> +		cpu0:cpu@0 {

You miss spaces after labels.

> +			device_type = "cpu";
> +			compatible = "arm,cortex-a73";
> +			reg = <0x0 0x0>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu1:cpu@1 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a73";
> +			reg = <0x0 0x1>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu2:cpu@2 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a73";
> +			reg = <0x0 0x2>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu3:cpu@3 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a73";
> +			reg = <0x0 0x3>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu4:cpu@100 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a53";
> +			reg = <0x0 0x100>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu5:cpu@101{
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a53";
> +			reg = <0x0 0x101>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu6:cpu@102 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a53";
> +			reg = <0x0 0x102>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu7:cpu@103 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a53";
> +			reg = <0x0 0x103>;
> +			enable-method = "psci";
> +		};
> +	};
> +
> +	timer {
> +		compatible = "arm,armv8-timer";
> +		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
> +	};
> +
> +	psci {
> +		compatible = "arm,psci-0.2";
> +		method = "smc";
> +	};
> +
> +	xtal: xtal-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <24000000>;
> +		clock-output-names = "xtal";
> +		#clock-cells = <0>;
> +	};
> +
> +	soc {
> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		gic: interrupt-controller@fff01000 {
> +			compatible = "arm,gic-400";
> +			#interrupt-cells = <3>;
> +			#address-cells = <0>;
> +			interrupt-controller;
> +			reg = <0x0 0xfff01000 0 0x1000>,
> +			    <0x0 0xfff02000 0 0x0100>;
> +			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> +		     };

Fix indentation.

> +
> +		apb4: bus@fe000000 {
> +			compatible = "simple-bus";
> +			reg = <0x0 0xfe000000 0x0 0x480000>;
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> +
> +			uart_a: serial@78000 {
> +				compatible = "amlogic,meson-s4-uart",
> +					     "amlogic,meson-ao-uart";
> +				reg = <0x0 0x78000 0x0 0x18>;
> +				interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> +				status = "disabled";

Please, don't put status in the middle of properties...



Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

[Xianwei Zhao]

Hi Krzysztof,
       Thank you for your review.

On 2023/6/26 23:41, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 26/06/2023 11:52, Xianwei Zhao wrote:
>> Amlogic T7 is an advanced application processor designed for smart display.
>>
>> Add basic support for the T7 based Amlogic AN400 board, which describes
>> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>> booting up into the serial console.
> Few nits.
Is it possible to be more specific about it?
> ...
>
>> +                             core3 {
>> +                                     cpu = <&cpu7>;
>> +                             };
>> +                     };
>> +             };
>> +
>> +             cpu0:cpu@0 {
> You miss spaces after labels.
Will do.
>
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a73";
>> +                     reg = <0x0 0x0>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu1:cpu@1 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a73";
>> +                     reg = <0x0 0x1>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu2:cpu@2 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a73";
>> +                     reg = <0x0 0x2>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu3:cpu@3 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a73";
>> +                     reg = <0x0 0x3>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu4:cpu@100 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x100>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu5:cpu@101{
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x101>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu6:cpu@102 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x102>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu7:cpu@103 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x103>;
>> +                     enable-method = "psci";
>> +             };
>> +     };
>> +
>> +     timer {
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
>> +     };
>> +
>> +     psci {
>> +             compatible = "arm,psci-0.2";
>> +             method = "smc";
>> +     };
>> +
>> +     xtal: xtal-clk {
>> +             compatible = "fixed-clock";
>> +             clock-frequency = <24000000>;
>> +             clock-output-names = "xtal";
>> +             #clock-cells = <0>;
>> +     };
>> +
>> +     soc {
>> +             compatible = "simple-bus";
>> +             #address-cells = <2>;
>> +             #size-cells = <2>;
>> +             ranges;
>> +
>> +             gic: interrupt-controller@fff01000 {
>> +                     compatible = "arm,gic-400";
>> +                     #interrupt-cells = <3>;
>> +                     #address-cells = <0>;
>> +                     interrupt-controller;
>> +                     reg = <0x0 0xfff01000 0 0x1000>,
>> +                         <0x0 0xfff02000 0 0x0100>;
>> +                     interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
>> +                  };
> Fix indentation.
Will do.
>> +
>> +             apb4: bus@fe000000 {
>> +                     compatible = "simple-bus";
>> +                     reg = <0x0 0xfe000000 0x0 0x480000>;
>> +                     #address-cells = <2>;
>> +                     #size-cells = <2>;
>> +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>> +
>> +                     uart_a: serial@78000 {
>> +                             compatible = "amlogic,meson-s4-uart",
>> +                                          "amlogic,meson-ao-uart";
>> +                             reg = <0x0 0x78000 0x0 0x18>;
>> +                             interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
>> +                             status = "disabled";
> Please, don't put status in the middle of properties...
Will put status in the end of properties in next version.
>
>
>
> Best regards,
> Krzysztof
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]

On Mon, Jun 26, 2023 at 05:41:05PM +0200, Krzysztof Kozlowski wrote:
> On 26/06/2023 11:52, Xianwei Zhao wrote:
> > +
> > +		apb4: bus@fe000000 {
> > +			compatible = "simple-bus";
> > +			reg = <0x0 0xfe000000 0x0 0x480000>;
> > +			#address-cells = <2>;
> > +			#size-cells = <2>;
> > +			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> > +
> > +			uart_a: serial@78000 {
> > +				compatible = "amlogic,meson-s4-uart",
> > +					     "amlogic,meson-ao-uart";
> > +				reg = <0x0 0x78000 0x0 0x18>;
> > +				interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> > +				status = "disabled";
> 
> Please, don't put status in the middle of properties...

The serial entry is also missing the soc specific compatible (and
removal of the always-on uart) that was discussed in Lucas Tanure's
series.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1423 bytes --]

Hey,

On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> T7 is an advanced application processor designed for smart display.
> 
> Add the new T7 SoC/board device tree bindings.
> 
> Add basic support for the T7 based Amlogic AN400 board, which describes
> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> booting up into the serial console.

Lucas has already sent patches for the T7 SoC & is at v5:
https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/

There's been a bit of discussion there, and there serial stuff in
particular is different in his series (it doesn't use always-on for
examples).
Could you please go and take a look at his series?

Cheers,
Conor.

> 
> Xianwei Zhao (2):
>   dt-bindings: arm: amlogic: add T7 based AN400 bindings
>   arm64: dts: add support for T7 based Amlogic AN400
> 
>  .../devicetree/bindings/arm/amlogic.yaml      |   6 +
>  arch/arm64/boot/dts/amlogic/Makefile          |   1 +
>  .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
>  arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
>  4 files changed, 193 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>  create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> 
> 
> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
> -- 
> 2.37.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Xianwei Zhao]

Hi Conor,
     Thanks for you reply.
On 2023/6/26 18:02, Conor Dooley wrote:


 > [ EXTERNAL EMAIL ]
 >
 > Hey,
 >
 > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
 >> T7 is an advanced application processor designed for smart display.
 >>
 >> Add the new T7 SoC/board device tree bindings.
 >>
 >> Add basic support for the T7 based Amlogic AN400 board, which describes
 >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
 >> booting up into the serial console.
 >
 > Lucas has already sent patches for the T7 SoC & is at v5:
 > 
https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
 >
 > There's been a bit of discussion there, and there serial stuff in
 > particular is different in his series (it doesn't use always-on for
 > examples).
 > Could you please go and take a look at his series?
 >
 > Cheers,
 > Conor.
 >
AN400 is the reference board designed by Amlogic, which is different 
from Khadas VIM4.
And T7 serial is the same as S4, so I follow S4 serial.

 >>
 >> Xianwei Zhao (2):
 >>    dt-bindings: arm: amlogic: add T7 based AN400 bindings
 >>    arm64: dts: add support for T7 based Amlogic AN400
 >>
 >>   .../devicetree/bindings/arm/amlogic.yaml      |   6 +
 >>   arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 >>   .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
 >>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
 >>   4 files changed, 193 insertions(+)
 >> create mode 100644 
arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
 >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
 >>
 >>
 >> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
 >> --
 >> 2.37.1
 >>
 >>
 >> _______________________________________________
 >> linux-amlogic mailing list
 >> linux-amlogic@lists.infradead.org
 >> http://lists.infradead.org/mailman/listinfo/linux-amlogic

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1315 bytes --]

On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
> Hi Conor,
>     Thanks for you reply.
> On 2023/6/26 18:02, Conor Dooley wrote:
> 
> 
> > [ EXTERNAL EMAIL ]
> >
> > Hey,
> >
> > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> >> T7 is an advanced application processor designed for smart display.
> >>
> >> Add the new T7 SoC/board device tree bindings.
> >>
> >> Add basic support for the T7 based Amlogic AN400 board, which describes
> >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> >> booting up into the serial console.
> >
> > Lucas has already sent patches for the T7 SoC & is at v5:
> > https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
> >
> > There's been a bit of discussion there, and there serial stuff in
> > particular is different in his series (it doesn't use always-on for
> > examples).
> > Could you please go and take a look at his series?
> >
> > Cheers,
> > Conor.
> >
> AN400 is the reference board designed by Amlogic, which is different from
> Khadas VIM4.

Yet you share the same dtsi, which he has got through several iterations
of before you arrived.

> And T7 serial is the same as S4, so I follow S4 serial.

Yeah, no. SoC specific compatible please.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Xianwei Zhao]

On 2023/6/27 15:23, Conor Dooley wrote:


 > [ EXTERNAL EMAIL ]
 >
 > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
 >> Hi Conor,
 >>      Thanks for you reply.
 >> On 2023/6/26 18:02, Conor Dooley wrote:
 >>
 >>
 >>> [ EXTERNAL EMAIL ]
 >>>
 >>> Hey,
 >>>
 >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
 >>>> T7 is an advanced application processor designed for smart display.
 >>>>
 >>>> Add the new T7 SoC/board device tree bindings.
 >>>>
 >>>> Add basic support for the T7 based Amlogic AN400 board, which
 >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
 >>>> capable of booting up into the serial console.
 >>>
 >>> Lucas has already sent patches for the T7 SoC & is at v5:
 >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
 >>> tanure@linux.com/
 >>> There's been a bit of discussion there, and there serial stuff in
 >>> particular is different in his series (it doesn't use always-on for
 >>> examples).
 >>> Could you please go and take a look at his series?
 >>>
 >>> Cheers,
 >>> Conor.
 >>>
 >> AN400 is the reference board designed by Amlogic, which is different
 >> from Khadas VIM4.
 >
 > Yet you share the same dtsi, which he has got through several
 > iterations of before you arrived.
 >
Hi Lucas,
Are you going to continue with the dtsi part?

 >> And T7 serial is the same as S4, so I follow S4 serial.
 >
 > Yeah, no. SoC specific compatible please.
 >
 >
 > _______________________________________________
 > linux-amlogic mailing list
 > linux-amlogic@lists.infradead.org
 > http://lists.infradead.org/mailman/listinfo/linux-amlogic

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Lucas Tanure]

On Tue, Jun 27, 2023 at 8:52 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
>
> On 2023/6/27 15:23, Conor Dooley wrote:
>
>
>  > [ EXTERNAL EMAIL ]
>  >
>  > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
>  >> Hi Conor,
>  >>      Thanks for you reply.
>  >> On 2023/6/26 18:02, Conor Dooley wrote:
>  >>
>  >>
>  >>> [ EXTERNAL EMAIL ]
>  >>>
>  >>> Hey,
>  >>>
>  >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>  >>>> T7 is an advanced application processor designed for smart display.
>  >>>>
>  >>>> Add the new T7 SoC/board device tree bindings.
>  >>>>
>  >>>> Add basic support for the T7 based Amlogic AN400 board, which
>  >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
>  >>>> capable of booting up into the serial console.
>  >>>
>  >>> Lucas has already sent patches for the T7 SoC & is at v5:
>  >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
>  >>> tanure@linux.com/
>  >>> There's been a bit of discussion there, and there serial stuff in
>  >>> particular is different in his series (it doesn't use always-on for
>  >>> examples).
>  >>> Could you please go and take a look at his series?
>  >>>
>  >>> Cheers,
>  >>> Conor.
>  >>>
>  >> AN400 is the reference board designed by Amlogic, which is different
>  >> from Khadas VIM4.
>  >
>  > Yet you share the same dtsi, which he has got through several
>  > iterations of before you arrived.
>  >
> Hi Lucas,
> Are you going to continue with the dtsi part?
>
>  >> And T7 serial is the same as S4, so I follow S4 serial.
>  >
>  > Yeah, no. SoC specific compatible please.
>  >
>  >
>  > _______________________________________________
>  > linux-amlogic mailing list
>  > linux-amlogic@lists.infradead.org
>  > http://lists.infradead.org/mailman/listinfo/linux-amlogic

Hi Xianwei,

I am doing the basics for Amlogic T7 A311D2, but the next step ( sd
card or emmc, something to boot on) would be more difficult for me
than you.
After the first series for Vim4 gets merged, I will start to work on
how to get sd cards working.
But if you already have that working for the AN400 board, please send
it. And I will look at that work and use it for Vim4.

Or, if you don't have it ready and want to share it with me, we can
work together on these A311D2 patches.
You test on AN400, and I test on Vim4.

Thanks
Lucas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Xianwei Zhao]

On 2023/6/30 00:33, Lucas Tanure wrote:
> [ EXTERNAL EMAIL ]
> 
> On Tue, Jun 27, 2023 at 8:52 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>>
>>
>> On 2023/6/27 15:23, Conor Dooley wrote:
>>
>>
>>   > [ EXTERNAL EMAIL ]
>>   >
>>   > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
>>   >> Hi Conor,
>>   >>      Thanks for you reply.
>>   >> On 2023/6/26 18:02, Conor Dooley wrote:
>>   >>
>>   >>
>>   >>> [ EXTERNAL EMAIL ]
>>   >>>
>>   >>> Hey,
>>   >>>
>>   >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>>   >>>> T7 is an advanced application processor designed for smart display.
>>   >>>>
>>   >>>> Add the new T7 SoC/board device tree bindings.
>>   >>>>
>>   >>>> Add basic support for the T7 based Amlogic AN400 board, which
>>   >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
>>   >>>> capable of booting up into the serial console.
>>   >>>
>>   >>> Lucas has already sent patches for the T7 SoC & is at v5:
>>   >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
>>   >>> tanure@linux.com/
>>   >>> There's been a bit of discussion there, and there serial stuff in
>>   >>> particular is different in his series (it doesn't use always-on for
>>   >>> examples).
>>   >>> Could you please go and take a look at his series?
>>   >>>
>>   >>> Cheers,
>>   >>> Conor.
>>   >>>
>>   >> AN400 is the reference board designed by Amlogic, which is different
>>   >> from Khadas VIM4.
>>   >
>>   > Yet you share the same dtsi, which he has got through several
>>   > iterations of before you arrived.
>>   >
>> Hi Lucas,
>> Are you going to continue with the dtsi part?
>>
>>   >> And T7 serial is the same as S4, so I follow S4 serial.
>>   >
>>   > Yeah, no. SoC specific compatible please.
>>   >
>>   >
>>   > _______________________________________________
>>   > linux-amlogic mailing list
>>   > linux-amlogic@lists.infradead.org
>>   > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 
> Hi Xianwei,
> 
> I am doing the basics for Amlogic T7 A311D2, but the next step ( sd
> card or emmc, something to boot on) would be more difficult for me
> than you.
> After the first series for Vim4 gets merged, I will start to work on
> how to get sd cards working.
> But if you already have that working for the AN400 board, please send
> it. And I will look at that work and use it for Vim4.
> 
> Or, if you don't have it ready and want to share it with me, we can
> work together on these A311D2 patches.
> You test on AN400, and I test on Vim4.
> 
> Thanks
> Lucas

We are preparing this part. However it depends on clock. So the clock 
must ready first.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Lucas Tanure]

On Fri, Jun 30, 2023 at 3:22 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
>
>
> On 2023/6/30 00:33, Lucas Tanure wrote:
> > [ EXTERNAL EMAIL ]
> >
> > On Tue, Jun 27, 2023 at 8:52 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
> >>
> >>
> >> On 2023/6/27 15:23, Conor Dooley wrote:
> >>
> >>
> >>   > [ EXTERNAL EMAIL ]
> >>   >
> >>   > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
> >>   >> Hi Conor,
> >>   >>      Thanks for you reply.
> >>   >> On 2023/6/26 18:02, Conor Dooley wrote:
> >>   >>
> >>   >>
> >>   >>> [ EXTERNAL EMAIL ]
> >>   >>>
> >>   >>> Hey,
> >>   >>>
> >>   >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> >>   >>>> T7 is an advanced application processor designed for smart display.
> >>   >>>>
> >>   >>>> Add the new T7 SoC/board device tree bindings.
> >>   >>>>
> >>   >>>> Add basic support for the T7 based Amlogic AN400 board, which
> >>   >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
> >>   >>>> capable of booting up into the serial console.
> >>   >>>
> >>   >>> Lucas has already sent patches for the T7 SoC & is at v5:
> >>   >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
> >>   >>> tanure@linux.com/
> >>   >>> There's been a bit of discussion there, and there serial stuff in
> >>   >>> particular is different in his series (it doesn't use always-on for
> >>   >>> examples).
> >>   >>> Could you please go and take a look at his series?
> >>   >>>
> >>   >>> Cheers,
> >>   >>> Conor.
> >>   >>>
> >>   >> AN400 is the reference board designed by Amlogic, which is different
> >>   >> from Khadas VIM4.
> >>   >
> >>   > Yet you share the same dtsi, which he has got through several
> >>   > iterations of before you arrived.
> >>   >
> >> Hi Lucas,
> >> Are you going to continue with the dtsi part?
> >>
> >>   >> And T7 serial is the same as S4, so I follow S4 serial.
> >>   >
> >>   > Yeah, no. SoC specific compatible please.
> >>   >
> >>   >
> >>   > _______________________________________________
> >>   > linux-amlogic mailing list
> >>   > linux-amlogic@lists.infradead.org
> >>   > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> >
> > Hi Xianwei,
> >
> > I am doing the basics for Amlogic T7 A311D2, but the next step ( sd
> > card or emmc, something to boot on) would be more difficult for me
> > than you.
> > After the first series for Vim4 gets merged, I will start to work on
> > how to get sd cards working.
> > But if you already have that working for the AN400 board, please send
> > it. And I will look at that work and use it for Vim4.
> >
> > Or, if you don't have it ready and want to share it with me, we can
> > work together on these A311D2 patches.
> > You test on AN400, and I test on Vim4.
> >
> > Thanks
> > Lucas
>
> We are preparing this part. However it depends on clock. So the clock
> must ready first.

Will you send clock for T7?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7

[Neil Armstrong]

On 27/06/2023 08:13, Xianwei Zhao wrote:
> Hi Conor,
>      Thanks for you reply.
> On 2023/6/26 18:02, Conor Dooley wrote:
> 
> 
>  > [ EXTERNAL EMAIL ]
>  >
>  > Hey,
>  >
>  > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>  >> T7 is an advanced application processor designed for smart display.
>  >>
>  >> Add the new T7 SoC/board device tree bindings.
>  >>
>  >> Add basic support for the T7 based Amlogic AN400 board, which describes
>  >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>  >> booting up into the serial console.
>  >
>  > Lucas has already sent patches for the T7 SoC & is at v5:
>  > https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
>  >
>  > There's been a bit of discussion there, and there serial stuff in
>  > particular is different in his series (it doesn't use always-on for
>  > examples).
>  > Could you please go and take a look at his series?
>  >
>  > Cheers,
>  > Conor.
>  >
> AN400 is the reference board designed by Amlogic, which is different from Khadas VIM4.

Please coordinate with Lucas so a single bindings & dtsi patches are submitted,
in any case only a single one will be reviewed and merged.
You can rebase your AN400 dts on top of his VIM4 initial patchset.

Thanks,
Neil

> And T7 serial is the same as S4, so I follow S4 serial.
> 
>  >>
>  >> Xianwei Zhao (2):
>  >>    dt-bindings: arm: amlogic: add T7 based AN400 bindings
>  >>    arm64: dts: add support for T7 based Amlogic AN400
>  >>
>  >>   .../devicetree/bindings/arm/amlogic.yaml      |   6 +
>  >>   arch/arm64/boot/dts/amlogic/Makefile          |   1 +
>  >>   .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
>  >>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
>  >>   4 files changed, 193 insertions(+)
>  >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>  >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>  >>
>  >>
>  >> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
>  >> --
>  >> 2.37.1
>  >>
>  >>
>  >> _______________________________________________
>  >> linux-amlogic mailing list
>  >> linux-amlogic@lists.infradead.org
>  >> http://lists.infradead.org/mailman/listinfo/linux-amlogic


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel