From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xu Yang <xu.yang_2@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, Jun Li <jun.li@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v2 3/5] dt-bindings: usb: ci-hdrc-usb2: add compatible and clock-names restriction for imx93
Date: Wed, 20 Dec 2023 08:24:33 +0100 [thread overview]
Message-ID: <e3ca4b8e-7e5b-4e0d-963d-e020729cab6c@linaro.org> (raw)
In-Reply-To: <DB7PR04MB5146154E6C62BCFCDA7879F38C96A@DB7PR04MB5146.eurprd04.prod.outlook.com>
On 20/12/2023 03:23, Xu Yang wrote:
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: fsl,imx93-usb
>>> + then:
>>> + properties:
>>> + clock-names:
>>> + items:
>>> + - const: usb_ctrl_root_clk
>>> + - const: usb_wakeup_clk
>>
>> What about all the reset? reg, interrupts? Maybe it is time to split the
>> schema into common part and device-specific.
>
> Why I need to consider reset, reg and interrupts? Should I add restrictions on
> these too? I may not really understand your meaning.
I looked at the binding and it seems that you allow different number of
items for them. Why aren't these constrained for your device?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-20 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 8:54 [PATCH v2 1/5] arm64: dts: imx8ulp: add usb nodes Xu Yang
2023-12-18 8:54 ` [PATCH v2 2/5] arm64: dts: imx8ulp-evk: enable usb nodes and add ptn5150 nodes Xu Yang
2023-12-18 10:16 ` Fabio Estevam
2023-12-19 7:35 ` [EXT] " Xu Yang
2023-12-18 8:54 ` [PATCH v2 3/5] dt-bindings: usb: ci-hdrc-usb2: add compatible and clock-names restriction for imx93 Xu Yang
2023-12-19 7:47 ` Krzysztof Kozlowski
2023-12-20 2:23 ` [EXT] " Xu Yang
2023-12-20 7:24 ` Krzysztof Kozlowski [this message]
2023-12-21 13:13 ` Xu Yang
2023-12-18 8:54 ` [PATCH v2 4/5] arm64: dts: imx93: add usb nodes Xu Yang
2024-01-08 15:49 ` Alexander Stein
2024-01-12 10:37 ` [EXT] " Xu Yang
2023-12-18 8:54 ` [PATCH v2 5/5] arm64: dts: imx93-11x11-evk: enable usb and typec nodes Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ca4b8e-7e5b-4e0d-963d-e020729cab6c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox