* Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function
From: Andrew Cooper @ 2019-09-06 15:55 UTC (permalink / raw)
To: Arnd Bergmann, Stefano Stabellini
Cc: Emil Velikov, Russell King, Denis Efremov, linux-kernel,
Masahiro Yamada, xen-devel, linux-arm-kernel
In-Reply-To: <20190906153948.2160342-1-arnd@arndb.de>
On 06/09/2019 16:39, Arnd Bergmann wrote:
> HYPERVISOR_platform_op() is an inline function and should not
> be exported. Since commit 15bfc2348d54 ("modpost: check for
> static EXPORT_SYMBOL* functions"), this causes a warning:
>
> WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Remove the extraneous export.
>
> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Something is wonky. That symbol is (/ really ought to be) in the
hypercall page and most definitely not inline.
Which tree is that changeset from? I can't find the SHA.
I hate to open a separate can of worms, but why are they tagged GPL?
The Xen hypercall ABI, like the Linux syscall ABI, are specifically not
GPL. Xen has as something very similar to (and probably derived from)
the Linux-syscall-note exception.
~Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v3 1/2] ASoC: dt-bindings: Convert Allwinner A10 codec to a schema
From: Rob Herring @ 2019-09-06 15:58 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, devicetree, Linux-ALSA, Liam Girdwood, Chen-Yu Tsai,
Mark Brown, Frank Rowand,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
In-Reply-To: <20190906151221.3148-1-mripard@kernel.org>
On Fri, Sep 6, 2019 at 4:12 PM Maxime Ripard <mripard@kernel.org> wrote:
>
> From: Maxime Ripard <maxime.ripard@bootlin.com>
>
> The Allwinner SoCs have an embedded audio codec that is supported in Linux,
> with a matching Device Tree binding.
>
> Now that we have the DT validation in place, let's convert the device tree
> bindings for that controller over to a YAML schemas.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> ---
>
> Changes from v2:
> - Change the audio-routing values to an enum, and enforce boundaries on
> the size
> - Add restrictions to the possible values of audio-routing
>
> Changes from v1:
> - Fix subject prefix
> ---
> .../sound/allwinner,sun4i-a10-codec.yaml | 262 ++++++++++++++++++
> .../devicetree/bindings/sound/sun4i-codec.txt | 94 -------
> 2 files changed, 262 insertions(+), 94 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/sun4i-codec.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> new file mode 100644
> index 000000000000..faa75b91c072
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> @@ -0,0 +1,262 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/allwinner,sun4i-a10-codec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner A10 Codec Device Tree Bindings
> +
> +maintainers:
> + - Chen-Yu Tsai <wens@csie.org>
> + - Maxime Ripard <maxime.ripard@bootlin.com>
> +
> +properties:
> + "#sound-dai-cells":
> + const: 0
> +
> + compatible:
> + enum:
> + - allwinner,sun4i-a10-codec
> + - allwinner,sun6i-a31-codec
> + - allwinner,sun7i-a20-codec
> + - allwinner,sun8i-a23-codec
> + - allwinner,sun8i-h3-codec
> + - allwinner,sun8i-v3s-codec
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Bus Clock
> + - description: Module Clock
> +
> + clock-names:
> + items:
> + - const: apb
> + - const: codec
> +
> + dmas:
> + items:
> + - description: RX DMA Channel
> + - description: TX DMA Channel
> +
> + dma-names:
> + items:
> + - const: rx
> + - const: tx
> +
> + resets:
> + maxItems: 1
> +
> + allwinner,audio-routing:
> + description: |-
> + A list of the connections between audio components. Each entry
> + is a pair of strings, the first being the connection's sink, the
> + second being the connection's source.
> + allOf:
> + - $ref: /schemas/types.yaml#definitions/non-unique-string-array
> + - minItems: 2
> + maxItems: 18
> + enum:
> + # Audio Pins on the SoC
> + - HP
> + - HPCOM
> + - LINEIN
> + - LINEOUT
> + - MIC1
> + - MIC2
> + - MIC3
> +
> + # Microphone Biases from the SoC
> + - HBIAS
> + - MBIAS
> +
> + # Board Connectors
> + - Headphone
> + - Headset Mic
> + - Line In
> + - Line Out
> + - Mic
> + - Speaker
> +
> + allwinner,codec-analog-controls:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the codec analog controls in the PRCM
> +
> + allwinner,pa-gpios:
> + description: GPIO to enable the external amplifier
> +
> +required:
> + - "#sound-dai-cells"
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - allwinner,sun6i-a31-codec
> + - allwinner,sun8i-a23-codec
> + - allwinner,sun8i-h3-codec
> + - allwinner,sun8i-v3s-codec
> +
> + then:
> + if:
> + properties:
> + compatible:
> + const: allwinner,sun6i-a31-codec
> +
> + then:
> + required:
> + - resets
> + - allwinner,audio-routing
> +
> + else:
> + required:
> + - resets
> + - allwinner,audio-routing
> + - allwinner,codec-analog-controls
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - allwinner,sun6i-a31-codec
> +
> + then:
> + properties:
> + allwinner,audio-routing:
> + enum:
> + - HP
> + - HPCOM
> + - LINEIN
> + - LINEOUT
> + - MIC1
> + - MIC2
> + - MIC3
> + - HBIAS
> + - MBIAS
> + - Headphone
> + - Headset Mic
> + - Line In
> + - Line Out
> + - Mic
> + - Speaker
This looks like the same list as the default...
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - allwinner,sun8i-a23-codec
> +
> + then:
> + properties:
> + allwinner,audio-routing:
> + enum:
> + - HP
> + - HPCOM
> + - LINEIN
> + - MIC1
> + - MIC2
> + - HBIAS
> + - MBIAS
> + - Headphone
> + - Headset Mic
> + - Line In
> + - Line Out
> + - Mic
> + - Speaker
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - allwinner,sun8i-h3-codec
> +
> + then:
> + properties:
> + allwinner,audio-routing:
> + enum:
> + - HP
> + - HPCOM
> + - LINEIN
> + - LINEOUT
> + - MIC1
> + - MIC2
> + - HBIAS
> + - MBIAS
> + - Headphone
> + - Headset Mic
> + - Line In
> + - Line Out
> + - Mic
> + - Speaker
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - allwinner,sun8i-v3s-codec
> +
> + then:
> + properties:
> + allwinner,audio-routing:
> + enum:
> + - HP
> + - HPCOM
> + - MIC1
> + - HBIAS
> + - Headphone
> + - Headset Mic
> + - Line In
> + - Line Out
> + - Mic
> + - Speaker
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + codec@1c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun7i-a20-codec";
> + reg = <0x01c22c00 0x40>;
> + interrupts = <0 30 4>;
> + clocks = <&apb0_gates 0>, <&codec_clk>;
> + clock-names = "apb", "codec";
> + dmas = <&dma 0 19>, <&dma 0 19>;
> + dma-names = "rx", "tx";
> + };
> +
> + - |
> + codec@1c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun6i-a31-codec";
> + reg = <0x01c22c00 0x98>;
> + interrupts = <0 29 4>;
> + clocks = <&ccu 61>, <&ccu 135>;
> + clock-names = "apb", "codec";
> + resets = <&ccu 42>;
> + dmas = <&dma 15>, <&dma 15>;
> + dma-names = "rx", "tx";
> + allwinner,audio-routing =
> + "Headphone", "HP",
> + "Speaker", "LINEOUT",
> + "LINEIN", "Line In",
> + "MIC1", "MBIAS",
> + "MIC1", "Mic",
> + "MIC2", "HBIAS",
> + "MIC2", "Headset Mic";
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/sound/sun4i-codec.txt b/Documentation/devicetree/bindings/sound/sun4i-codec.txt
> deleted file mode 100644
> index 66579bbd3294..000000000000
> --- a/Documentation/devicetree/bindings/sound/sun4i-codec.txt
> +++ /dev/null
> @@ -1,94 +0,0 @@
> -* Allwinner A10 Codec
> -
> -Required properties:
> -- compatible: must be one of the following compatibles:
> - - "allwinner,sun4i-a10-codec"
> - - "allwinner,sun6i-a31-codec"
> - - "allwinner,sun7i-a20-codec"
> - - "allwinner,sun8i-a23-codec"
> - - "allwinner,sun8i-h3-codec"
> - - "allwinner,sun8i-v3s-codec"
> -- reg: must contain the registers location and length
> -- interrupts: must contain the codec interrupt
> -- dmas: DMA channels for tx and rx dma. See the DMA client binding,
> - Documentation/devicetree/bindings/dma/dma.txt
> -- dma-names: should include "tx" and "rx".
> -- clocks: a list of phandle + clock-specifer pairs, one for each entry
> - in clock-names.
> -- clock-names: should contain the following:
> - - "apb": the parent APB clock for this controller
> - - "codec": the parent module clock
> -
> -Optional properties:
> -- allwinner,pa-gpios: gpio to enable external amplifier
> -
> -Required properties for the following compatibles:
> - - "allwinner,sun6i-a31-codec"
> - - "allwinner,sun8i-a23-codec"
> - - "allwinner,sun8i-h3-codec"
> - - "allwinner,sun8i-v3s-codec"
> -- resets: phandle to the reset control for this device
> -- allwinner,audio-routing: A list of the connections between audio components.
> - Each entry is a pair of strings, the first being the
> - connection's sink, the second being the connection's
> - source. Valid names include:
> -
> - Audio pins on the SoC:
> - "HP"
> - "HPCOM"
> - "LINEIN" (not on sun8i-v3s)
> - "LINEOUT" (not on sun8i-a23 or sun8i-v3s)
> - "MIC1"
> - "MIC2" (not on sun8i-v3s)
> - "MIC3" (sun6i-a31 only)
> -
> - Microphone biases from the SoC:
> - "HBIAS"
> - "MBIAS" (not on sun8i-v3s)
> -
> - Board connectors:
> - "Headphone"
> - "Headset Mic"
> - "Line In"
> - "Line Out"
> - "Mic"
> - "Speaker"
> -
> -Required properties for the following compatibles:
> - - "allwinner,sun8i-a23-codec"
> - - "allwinner,sun8i-h3-codec"
> - - "allwinner,sun8i-v3s-codec"
> -- allwinner,codec-analog-controls: A phandle to the codec analog controls
> - block in the PRCM.
> -
> -Example:
> -codec: codec@1c22c00 {
> - #sound-dai-cells = <0>;
> - compatible = "allwinner,sun7i-a20-codec";
> - reg = <0x01c22c00 0x40>;
> - interrupts = <0 30 4>;
> - clocks = <&apb0_gates 0>, <&codec_clk>;
> - clock-names = "apb", "codec";
> - dmas = <&dma 0 19>, <&dma 0 19>;
> - dma-names = "rx", "tx";
> -};
> -
> -codec: codec@1c22c00 {
> - #sound-dai-cells = <0>;
> - compatible = "allwinner,sun6i-a31-codec";
> - reg = <0x01c22c00 0x98>;
> - interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&ccu CLK_APB1_CODEC>, <&ccu CLK_CODEC>;
> - clock-names = "apb", "codec";
> - resets = <&ccu RST_APB1_CODEC>;
> - dmas = <&dma 15>, <&dma 15>;
> - dma-names = "rx", "tx";
> - allwinner,audio-routing =
> - "Headphone", "HP",
> - "Speaker", "LINEOUT",
> - "LINEIN", "Line In",
> - "MIC1", "MBIAS",
> - "MIC1", "Mic",
> - "MIC2", "HBIAS",
> - "MIC2", "Headset Mic";
> -};
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function
From: Jan Beulich @ 2019-09-06 15:59 UTC (permalink / raw)
To: Andrew Cooper
Cc: Stefano Stabellini, Arnd Bergmann, Emil Velikov, Russell King,
Denis Efremov, linux-kernel, Masahiro Yamada, xen-devel,
linux-arm-kernel
In-Reply-To: <7abad95e-ea47-c068-d91c-ba503f2530b9@citrix.com>
On 06.09.2019 17:55, Andrew Cooper wrote:
> On 06/09/2019 16:39, Arnd Bergmann wrote:
>> HYPERVISOR_platform_op() is an inline function and should not
>> be exported. Since commit 15bfc2348d54 ("modpost: check for
>> static EXPORT_SYMBOL* functions"), this causes a warning:
>>
>> WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL
>>
>> Remove the extraneous export.
>>
>> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Something is wonky. That symbol is (/ really ought to be) in the
> hypercall page and most definitely not inline.
It's HYPERVISOR_platform_op_raw that's in the hypercall page afaics.
Jan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v3 06/17] arm64, hibernate: add trans_pgd public functions
From: Pavel Tatashin @ 2019-09-06 16:00 UTC (permalink / raw)
To: James Morse
Cc: Sasha Levin, Mark Rutland, Vladimir Murzin, Jonathan Corbet,
Marc Zyngier, Catalin Marinas, Bhupesh Sharma, kexec mailing list,
LKML, James Morris, linux-mm, Eric W. Biederman, Matthias Brugger,
will, Linux ARM
In-Reply-To: <bcc3f71f-97d2-dff4-c55a-4798c6e2bede@arm.com>
On Fri, Sep 6, 2019 at 11:18 AM James Morse <james.morse@arm.com> wrote:
>
> Hi Pavel,
>
> On 21/08/2019 19:31, Pavel Tatashin wrote:
> > trans_pgd_create_copy() and trans_pgd_map_page() are going to be
> > the basis for public interface of new subsystem that handles page
>
> Please don't call this a subsystem. 'sound' and 'mm' are subsystems, this is just some
> shared code.
Sounds good: just could not find a better term to call trans_pgd_*. I
won't fix log commits.
>
> > tables for cases which are between kernels: kexec, and hibernate.
>
> Even though you've baked the get_safe_page() calls into trans_pgd_map_page()?
It is getting removed later. Just for a cleaner migration to new
place, get_safe_page() is included for now.
>
>
> > diff --git a/arch/arm64/kernel/hibernate.c b/arch/arm64/kernel/hibernate.c
> > index 750ecc7f2cbe..2e29d620b56c 100644
> > --- a/arch/arm64/kernel/hibernate.c
> > +++ b/arch/arm64/kernel/hibernate.c
> > @@ -182,39 +182,15 @@ int arch_hibernation_header_restore(void *addr)
>
> > +int trans_pgd_map_page(pgd_t *trans_pgd, void *page,
> > + unsigned long dst_addr,
> > + pgprot_t pgprot)
>
> If this thing is going to be exposed, its name should reflect that its creating a set of
> page tables, to map a single page.
>
> A function called 'map_page' with this prototype should 'obviously' map @page at @dst_addr
> in @trans_pgd using the provided @pgprot... but it doesn't.
Answered below...
>
> This is what 'create' was doing in the old name, if that wasn't obvious, its because
> naming things is hard!
> | trans_create_single_page_mapping()?
>
> (might be too verbose)
>
> I think this bites you in patch 8, where you 'generalise' this.
The new naming makes more sense to me. The old code had function named:
create_safe_exec_page()
It was doing four things: 1. creating the actual page via provided
allocator, 2. copying content from the provided page to new page, 3
creating a new page table. 4 mapping it to a new page table at
specified destination address
After, I generalize this the function the prototype looks like this:
int trans_pgd_map_page(struct trans_pgd_info *info, pgd_t *trans_pgd,
void *page, unsigned long
dst_addr, pgprot_t pgprot)
The function only does the "4" from the old code: map the specified
page at dst_addr. The trans_pgd is already created. Of course, and
mapping function will have to allocate missing tables in the page
tables when necessary.
> > + return 0;
> > +}
> > +
> > +/*
> > + * Copies length bytes, starting at src_start into an new page,
> > + * perform cache maintentance, then maps it at the specified address low
>
> Could you fix the spelling of maintenance as git thinks you've moved it?
I will.
Thank you,
Pasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function
From: Arnd Bergmann @ 2019-09-06 16:00 UTC (permalink / raw)
To: Andrew Cooper
Cc: Stefano Stabellini, Emil Velikov, Russell King, Denis Efremov,
linux-kernel@vger.kernel.org, Masahiro Yamada, xen-devel,
Linux ARM
In-Reply-To: <7abad95e-ea47-c068-d91c-ba503f2530b9@citrix.com>
On Fri, Sep 6, 2019 at 5:55 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> On 06/09/2019 16:39, Arnd Bergmann wrote:
> > HYPERVISOR_platform_op() is an inline function and should not
> > be exported. Since commit 15bfc2348d54 ("modpost: check for
> > static EXPORT_SYMBOL* functions"), this causes a warning:
> >
> > WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL
> >
> > Remove the extraneous export.
> >
> > Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Something is wonky. That symbol is (/ really ought to be) in the
> hypercall page and most definitely not inline.
>
> Which tree is that changeset from? I can't find the SHA.
This is from linux-next, I think from the kbuild tree.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH 1/3] ARM: omap2plus_defconfig: Fix missing video
From: Tony Lindgren @ 2019-09-06 16:17 UTC (permalink / raw)
To: Adam Ford
Cc: Mark Rutland, devicetree, Russell King, linux-kernel, Rob Herring,
Benoît Cousson, linux-omap, linux-arm-kernel
In-Reply-To: <20190828183351.822-1-aford173@gmail.com>
* Adam Ford <aford173@gmail.com> [190828 11:34]:
> When the panel-dpi driver was removed, the simple-panels driver
> was never enabled, so anyone who used the panel-dpi driver lost
> video, and those who used it inconjunction with simple-panels
> would have to manually enable CONFIG_DRM_PANEL_SIMPLE.
>
> This patch makes CONFIG_DRM_PANEL_SIMPLE a module in the same
> way the deprecated panel-dpi was.
>
> Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
Applying all three into fixes. Not going to send out a pull
request for the fixes until next week so it may not land
until after the merge window starts. But looks like these
have been broken since 2018, so not super urgent.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] rtc: meson: mark PM functions as __maybe_unused
From: Kevin Hilman @ 2019-09-06 16:56 UTC (permalink / raw)
To: Arnd Bergmann, Alessandro Zummo, Alexandre Belloni
Cc: linux-rtc, Arnd Bergmann, Neil Armstrong, linux-kernel,
linux-amlogic, linux-arm-kernel
In-Reply-To: <20190906152438.1533833-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> writes:
> The meson_vrtc_set_wakeup_time() function is only used by
> the PM functions and causes a warning when they are disabled:
>
> drivers/rtc/rtc-meson-vrtc.c:32:13: error: unused function 'meson_vrtc_set_wakeup_time' [-Werror,-Wunused-function]
>
> Remove the #ifdef around the callers and add a __maybe_unused
> annotation as a more reliable way to avoid these warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V4 01/11] dt-bindings: firmware: imx-scu: new binding to parse clocks from device tree
From: Stephen Boyd @ 2019-09-06 16:56 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, devicetree, mturquette, Rob Herring, linux-imx,
kernel, fabio.estevam, shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-2-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:15)
> There's a few limitations on the original one cell clock binding
> (#clock-cells = <1>) that we have to define some SW clock IDs for device
> tree to reference. This may cause troubles if we want to use common
> clock IDs for multi platforms support when the clock of those platforms
> are mostly the same.
> e.g. Current clock IDs name are defined with SS prefix.
>
> However the device may reside in different SS across CPUs, that means the
> SS prefix may not valid anymore for a new SoC. Furthermore, the device
> availability of those clocks may also vary a bit.
>
> For such situation, we want to eliminate the using of SW Clock IDs and
> change to use a more close to HW one instead.
> For SCU clocks usage, only two params required: Resource id + Clock Type.
> Both parameters are platform independent. So we could use two cells binding
> to pass those parameters,
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V4 02/11] dt-bindings: clock: imx-lpcg: add support to parse clocks from device tree
From: Stephen Boyd @ 2019-09-06 17:00 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, devicetree, mturquette, Rob Herring, linux-imx,
kernel, fabio.estevam, shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-3-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:16)
> MX8QM and MX8QXP LPCG Clocks are mostly the same except they may reside
> in different subsystems across CPUs and also vary a bit on the availability.
>
> Same as SCU clock, we want to move the clock definition into device tree
> which can fully decouple the dependency of Clock ID definition from device
> tree and make us be able to write a fully generic lpcg clock driver.
>
> And we can also use the existence of clock nodes in device tree to address
> the device and clock availability differences across different SoCs.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> ChangeLog:
> v3->v4:
> * change bit-offset property to clock-indices
> * use constant macro to define clock indinces
> * drop hw-autogate property which is still not used by drivers
> v2->v3:
> * no changes
> v1->v2:
> * Update example
> * Add power domain property
> ---
> .../devicetree/bindings/clock/imx8qxp-lpcg.txt | 36 ++++++++++++++++++----
> include/dt-bindings/clock/imx8-lpcg.h | 14 +++++++++
> 2 files changed, 44 insertions(+), 6 deletions(-)
> create mode 100644 include/dt-bindings/clock/imx8-lpcg.h
>
> diff --git a/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.txt b/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.txt
> index 965cfa4..cad8fc4 100644
> --- a/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.txt
> +++ b/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.txt
> @@ -11,6 +11,21 @@ enabled by these control bits, it might still not be running based
> on the base resource.
>
> Required properties:
> +- compatible: Should be one of:
> + "fsl,imx8qxp-lpcg"
> + "fsl,imx8qm-lpcg" followed by "fsl,imx8qxp-lpcg".
> +- reg: Address and length of the register set.
> +- #clock-cells: Should be 1. One LPCG supports multiple clocks.
> +- clocks: Input parent clocks phandle array for each clock.
> +- clock-indices: An integer array indicating the bit offset for each clock.
> + Refer to <include/dt-bindings/clock/imx8-lpcg.h> for the
> + supported LPCG clock indices.
This is an interesting solution.
> +- clock-output-names: Shall be the corresponding names of the outputs.
> + NOTE this property must be specified in the same order
> + as the clock-indices property.
> +- power-domains: Should contain the power domain used by this clock.
> +
> +Legacy binding (DEPRECATED):
> - compatible: Should be one of:
> "fsl,imx8qxp-lpcg-adma",
> "fsl,imx8qxp-lpcg-conn",
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* [PATCH] arm64: dts: zii-ultra: fix ARM regulator states
From: Lucas Stach @ 2019-09-06 17:06 UTC (permalink / raw)
To: Shawn Guo; +Cc: Fabio Estevam, kernel, linux-arm-kernel, patchwork-lst
The GPIO controlled regulator for the ARM power supply is supplying
the higher voltage when the GPIO is driven high. This is opposite to
the similar regulator setup on the EVK board and is impacting stability
of the board as the ARM domain has been supplied with a too low voltage
when to faster OPPs are in use.
Fixes: 4a13b3bec3b4 (arm64: dts: imx: add Zii Ultra board support)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 7a1706f969f0..3faa652fdf20 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -101,8 +101,8 @@
regulator-min-microvolt = <900000>;
regulator-max-microvolt = <1000000>;
gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
- states = <1000000 0x0
- 900000 0x1>;
+ states = <1000000 0x1
+ 900000 0x0>;
regulator-always-on;
};
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related
* Re: [PATCH V4 03/11] clk: imx: scu: add two cells binding support
From: Stephen Boyd @ 2019-09-06 17:06 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, mturquette, linux-imx, kernel, fabio.estevam,
shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-4-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:17)
> diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
> index 5e2903e..1ad3f2a 100644
> --- a/drivers/clk/imx/clk-imx8qxp.c
> +++ b/drivers/clk/imx/clk-imx8qxp.c
> @@ -134,7 +134,12 @@ static int imx8qxp_clk_probe(struct platform_device *pdev)
> i, PTR_ERR(clks[i]));
> }
>
> - return of_clk_add_hw_provider(ccm_node, of_clk_hw_onecell_get, clk_data);
> + if (clock_cells == 2)
Can you just read this from the DT node again instead of having a global
variable called "clock_cells" for this?
> + ret = of_clk_add_hw_provider(ccm_node, imx_scu_of_clk_src_get, imx_scu_clks);
> + else
> + ret = of_clk_add_hw_provider(ccm_node, of_clk_hw_onecell_get, clk_data);
> +
> + return ret;
> }
>
> static const struct of_device_id imx8qxp_match[] = {
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index fbef740..48bfb08 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -16,6 +19,21 @@
> #define IMX_SIP_SET_CPUFREQ 0x00
>
> static struct imx_sc_ipc *ccm_ipc_handle;
> +struct device_node *pd_np;
> +u32 clock_cells;
> +
> +struct imx_scu_clk_node {
> + const char *name;
> + u32 rsrc;
> + u8 clk_type;
> + const char * const *parents;
> + int num_parents;
> +
> + struct clk_hw *hw;
> + struct list_head node;
> +};
> +
> +struct list_head imx_scu_clks[IMX_SC_R_LAST];
>
> /*
> * struct clk_scu - Description of one SCU clock
> @@ -128,9 +146,29 @@ static inline struct clk_scu *to_clk_scu(struct clk_hw *hw)
> return container_of(hw, struct clk_scu, hw);
> }
>
> -int imx_clk_scu_init(void)
> +int imx_clk_scu_init(struct device_node *np)
> {
> - return imx_scu_get_handle(&ccm_ipc_handle);
> + struct platform_device *pd_dev;
> + int ret, i;
> +
> + ret = imx_scu_get_handle(&ccm_ipc_handle);
> + if (ret)
> + return ret;
> +
> + if (of_property_read_u32(np, "#clock-cells", &clock_cells))
> + return -EINVAL;
> +
> + if (clock_cells == 2) {
> + for (i = 0; i < IMX_SC_R_LAST; i++)
> + INIT_LIST_HEAD(&imx_scu_clks[i]);
> +
> + pd_np = of_find_compatible_node(NULL, NULL, "fsl,scu-pd");
> + pd_dev = of_find_device_by_node(pd_np);
> + if (!pd_dev || !device_is_bound(&pd_dev->dev))
> + return -EPROBE_DEFER;
Do you need to put some nodes here with of_node_put() one failure or
when they're done being used?
> + }
> +
> + return 0;
> }
>
> /*
> @@ -387,3 +425,99 @@ struct clk_hw *__imx_clk_scu(const char *name, const char * const *parents,
[...]
> +
> +struct clk_hw *imx_clk_scu_alloc_dev(const char *name,
> + const char * const *parents,
> + int num_parents, u32 rsrc_id, u8 clk_type)
> +{
> + struct imx_scu_clk_node clk = {
> + .name = name,
> + .rsrc = rsrc_id,
> + .clk_type = clk_type,
> + .parents = parents,
> + .num_parents = num_parents,
> + };
> + struct platform_device *pdev;
> + int ret;
> +
> + pdev = platform_device_alloc(name, PLATFORM_DEVID_NONE);
> + if (!pdev) {
> + pr_err("%s: failed to allocate scu clk dev rsrc %d type %d\n",
> + name, rsrc_id, clk_type);
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + ret = platform_device_add_data(pdev, &clk, sizeof(clk));
> + if (ret) {
> + platform_device_put(pdev);
> + return ERR_PTR(-ENOMEM);
Why not ERR_PTR(ret)?
> + }
> +
> + pdev->driver_override = "imx-scu-clk";
> +
> + ret = imx_clk_scu_attach_pd(&pdev->dev, rsrc_id);
> + if (ret)
> + pr_warn("%s: failed to attached the power domain %d\n",
> + name, ret);
> +
> + platform_device_add(pdev);
> +
> + /* For API backwards compatiblilty, simply return NULL for success */
> + return NULL;
> +}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V4 04/11] clk: imx: scu: bypass cpu power domains
From: Stephen Boyd @ 2019-09-06 17:07 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, mturquette, linux-imx, kernel, fabio.estevam,
shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-5-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:18)
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index 48bfb08..5f935b1 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -479,6 +479,10 @@ static int imx_clk_scu_attach_pd(struct device *dev, u32 rsrc_id)
> .args[0] = rsrc_id,
> };
>
> + if ((rsrc_id == IMX_SC_R_A35) || (rsrc_id == IMX_SC_R_A53) ||
> + (rsrc_id == IMX_SC_R_A72))
Please drop the extra parenthesis. It makes it hard to read.
> + return 0;
> +
> return of_genpd_add_device(&genpdspec, dev);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V4 07/11] clk: imx: scu: add suspend/resume support
From: Stephen Boyd @ 2019-09-06 17:09 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, mturquette, linux-imx, kernel, fabio.estevam,
shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-8-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:21)
> Clock state will be lost when its power domain is completely off
> during system suspend/resume. So we save and restore the state
> accordingly in suspend/resume callback.
And this doesn't need any coordination with other clks in the clk tree
right?
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index edc39d7..8d9cfa2 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -46,6 +46,10 @@ struct clk_scu {
> struct clk_hw hw;
> u16 rsrc_id;
> u8 clk_type;
> +
> + /* for state save&restore */
> + bool is_enabled;
> + u32 rate;
> };
>
> /*
> @@ -425,6 +429,9 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name,
> hw = ERR_PTR(ret);
> }
>
> + if (dev)
> + dev_set_drvdata(dev, clk);
> +
> return hw;
> }
>
> @@ -481,10 +488,52 @@ static int imx_clk_scu_probe(struct platform_device *pdev)
> return 0;
> }
>
> +int __maybe_unused imx_clk_scu_suspend(struct device *dev)
static?
> +{
> + struct clk_scu *clk = dev_get_drvdata(dev);
> +
> + clk->rate = clk_hw_get_rate(&clk->hw);
> + clk->is_enabled = clk_hw_is_enabled(&clk->hw);
> +
> + if (clk->rate)
> + dev_dbg(dev, "save rate %d\n", clk->rate);
> +
> + if (clk->is_enabled)
> + dev_dbg(dev, "save enabled state\n");
> +
> + return 0;
> +}
> +
> +int __maybe_unused imx_clk_scu_resume(struct device *dev)
static?
> +{
> + struct clk_scu *clk = dev_get_drvdata(dev);
> + int ret = 0;
> +
> + if (clk->rate) {
> + ret = clk_scu_set_rate(&clk->hw, clk->rate, 0);
> + dev_dbg(dev, "restore rate %d %s\n", clk->rate,
> + !ret ? "success" : "failed");
> + }
> +
> + if (clk->is_enabled) {
> + ret = clk_scu_prepare(&clk->hw);
> + dev_dbg(dev, "restore enabled state %s\n",
> + !ret ? "success" : "failed");
> + }
> +
> + return ret;
> +}
> +
> +const struct dev_pm_ops imx_clk_scu_pm_ops = {
static?
> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx_clk_scu_suspend,
> + imx_clk_scu_resume)
> +};
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V4 08/11] clk: imx: imx8qxp-lpcg: add parsing clocks from device tree
From: Stephen Boyd @ 2019-09-06 17:13 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, mturquette, linux-imx, kernel, fabio.estevam,
shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-9-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:22)
> Add parsing clocks from device tree.
Please describe some more here.
> diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> index c0aff7c..90326e5 100644
> --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> @@ -157,6 +158,101 @@ static const struct imx8qxp_ss_lpcg imx8qxp_ss_lsio = {
> .num_max = IMX_LSIO_LPCG_CLK_END,
> };
>
> +#define IMX_LPCG_MAX_CLKS 8
> +
> +static struct clk_hw *imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec,
> + void *data)
> +{
> + struct clk_hw_onecell_data *hw_data = data;
> + unsigned int idx = clkspec->args[0] / 4;
> +
> + if (idx >= hw_data->num) {
> + pr_err("%s: invalid index %u\n", __func__, idx);
> + return ERR_PTR(-EINVAL);
> + }
> +
> + return hw_data->hws[idx];
> +}
> +
> +static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
> + struct device_node *np)
> +{
> + const char *output_names[IMX_LPCG_MAX_CLKS];
> + const char *parent_names[IMX_LPCG_MAX_CLKS];
> + unsigned int bit_offset[IMX_LPCG_MAX_CLKS];
> + struct clk_hw_onecell_data *clk_data;
> + struct clk_hw **clk_hws;
> + struct resource *res;
> + void __iomem *base;
> + int count;
> + int idx;
> + int ret;
> + int i;
> +
> + if (!of_device_is_compatible(np, "fsl,imx8qxp-lpcg"))
> + return -EINVAL;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
> +
> + count = of_property_count_u32_elems(np, "clock-indices");
> + if (count < 0) {
> + dev_err(&pdev->dev, "failed to count clocks\n");
> + return -EINVAL;
> + }
Is 'count' expected to be equal to IMX_LPCG_MAX_CLKS? Because later on
in this function we set the num of clks to the MAX instead of the count
from clock-indices.
> +
> + clk_data = devm_kzalloc(&pdev->dev, struct_size(clk_data, hws, IMX_LPCG_MAX_CLKS),
This line is too long.
> + GFP_KERNEL);
> + if (!clk_data)
> + return -ENOMEM;
> +
> + clk_data->num = IMX_LPCG_MAX_CLKS;
> + clk_hws = clk_data->hws;
> +
> + ret = of_property_read_u32_array(np, "clock-indices", bit_offset,
> + count);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to read clocks bit-offset\n");
This isn't called bit-offset anymore.
> + return -EINVAL;
> + }
> +
> + ret = of_clk_parent_fill(np, parent_names, count);
> + if (ret != count) {
> + dev_err(&pdev->dev, "failed to get clock parent names\n");
> + return -EINVAL;
return count?
> + }
> +
> + ret = of_property_read_string_array(np, "clock-output-names",
> + output_names, count);
> + if (ret != count) {
> + dev_err(&pdev->dev, "failed to read clock-output-names\n");
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < count; i++) {
> + idx = bit_offset[i] / 4;
> + if (idx > IMX_LPCG_MAX_CLKS) {
> + dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
> + i);
> + return -EINVAL;
> + }
> +
> + clk_hws[idx] = imx_clk_lpcg_scu(output_names[i],
> + parent_names[i], 0, base,
> + bit_offset[i], false);
> + if (IS_ERR(clk_hws[idx])) {
> + dev_warn(&pdev->dev, "failed to register clock %d\n",
> + idx);
> + return -EINVAL;
> + }
> + }
> +
> + return devm_of_clk_add_hw_provider(&pdev->dev, imx_lpcg_of_clk_src_get,
> + clk_data);
If this fails does imx_clk_lpcg_scu() need to be unwound and unregister
clks?
> +}
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V4 11/11] clk: imx: lpcg: add suspend/resume support
From: Stephen Boyd @ 2019-09-06 17:14 UTC (permalink / raw)
To: Dong Aisheng, linux-clk
Cc: Dong Aisheng, mturquette, linux-imx, kernel, fabio.estevam,
shawnguo, linux-arm-kernel
In-Reply-To: <1566299605-15641-12-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:25)
> diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c
> index 3c092a0..4df0818 100644
> --- a/drivers/clk/imx/clk-lpcg-scu.c
> +++ b/drivers/clk/imx/clk-lpcg-scu.c
> @@ -33,6 +33,9 @@ struct clk_lpcg_scu {
> void __iomem *reg;
> u8 bit_idx;
> bool hw_gate;
> +
> + /* for state save&restore */
> + u32 state;
> };
>
> #define to_clk_lpcg_scu(_hw) container_of(_hw, struct clk_lpcg_scu, hw)
> @@ -112,5 +115,35 @@ struct clk_hw *__imx_clk_lpcg_scu(struct device *dev, const char *name,
> hw = ERR_PTR(ret);
> }
>
> + if (dev)
> + dev_set_drvdata(dev, clk);
> +
> return hw;
> }
> +
> +int __maybe_unused imx_clk_lpcg_scu_suspend(struct device *dev)
static?
> +{
> + struct clk_lpcg_scu *clk = dev_get_drvdata(dev);
> +
> + clk->state = readl_relaxed(clk->reg);
> + dev_dbg(dev, "save lpcg state 0x%x\n", clk->state);
> +
> + return 0;
> +}
> +
> +int __maybe_unused imx_clk_lpcg_scu_resume(struct device *dev)
static?
> +{
> + struct clk_lpcg_scu *clk = dev_get_drvdata(dev);
> +
> + /* FIXME: double write in case a failure */
What does this mean? Sometimes writes don't work unless the CPU issues
them twice?
> + writel(clk->state, clk->reg);
> + writel(clk->state, clk->reg);
> + dev_dbg(dev, "restore lpcg state 0x%x\n", clk->state);
> +
> + return 0;
> +}
> +
> +const struct dev_pm_ops imx_clk_lpcg_scu_pm_ops = {
> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx_clk_lpcg_scu_suspend,
> + imx_clk_lpcg_scu_resume)
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function
From: Andrew Cooper @ 2019-09-06 17:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Stefano Stabellini, Emil Velikov, Russell King, Denis Efremov,
linux-kernel@vger.kernel.org, Masahiro Yamada, Julien Grall,
xen-devel, Linux ARM
In-Reply-To: <CAK8P3a1qkMLW_Wnn-N0seUw4N5bPwTU7Dy7CwOWxzS6NTnTmiQ@mail.gmail.com>
On 06/09/2019 17:00, Arnd Bergmann wrote:
> On Fri, Sep 6, 2019 at 5:55 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> On 06/09/2019 16:39, Arnd Bergmann wrote:
>>> HYPERVISOR_platform_op() is an inline function and should not
>>> be exported. Since commit 15bfc2348d54 ("modpost: check for
>>> static EXPORT_SYMBOL* functions"), this causes a warning:
>>>
>>> WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL
>>>
>>> Remove the extraneous export.
>>>
>>> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Something is wonky. That symbol is (/ really ought to be) in the
>> hypercall page and most definitely not inline.
>>
>> Which tree is that changeset from? I can't find the SHA.
> This is from linux-next, I think from the kbuild tree.
Thanks.
Julien/Stefano: Why are any of these hypercalls out-of-line? ARM
doesn't use the hypercall page, and there is no argument translation
(not even in arm32 as there are no 5-argument hypercalls declared).
They'd surely be easier to implement with a few static inlines and some
common code, than to try and replicate the x86 side hypercall_page
interface ?
~Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] clk: imx: lpcg: write twice when writing lpcg regs
From: Stephen Boyd @ 2019-09-06 17:20 UTC (permalink / raw)
To: festevam@gmail.com, mturquette@baylibre.com,
s.hauer@pengutronix.de, shawnguo@kernel.org, Aisheng Dong,
Peng Fan
Cc: Peng Fan, Abel Vesa, Anson Huang, linux-kernel@vger.kernel.org,
dl-linux-imx, kernel@pengutronix.de, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jacky Bai
In-Reply-To: <1566936978-28519-1-git-send-email-peng.fan@nxp.com>
Quoting Peng Fan (2019-08-27 01:17:50)
> From: Peng Fan <peng.fan@nxp.com>
>
> There is hardware issue that:
> The output clock the LPCG cell will not turn back on as expected,
> even though a read of the IPG registers in the LPCG indicates that
> the clock should be enabled.
>
> The software workaround is to write twice to enable the LPCG clock
> output.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Does this need a Fixes tag?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V2 1/4] clk: imx: pll14xx: avoid glitch when set rate
From: Stephen Boyd @ 2019-09-06 17:21 UTC (permalink / raw)
To: festevam@gmail.com, mturquette@baylibre.com,
s.hauer@pengutronix.de, shawnguo@kernel.org, Peng Fan
Cc: Peng Fan, Abel Vesa, Anson Huang, linux-kernel@vger.kernel.org,
dl-linux-imx, kernel@pengutronix.de, Leonard Crestez,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jacky Bai
In-Reply-To: <1566855676-11510-1-git-send-email-peng.fan@nxp.com>
Quoting Peng Fan (2019-08-26 02:42:14)
> From: Peng Fan <peng.fan@nxp.com>
>
> According to PLL1443XA and PLL1416X spec,
> "When BYPASS is 0 and RESETB is changed from 0 to 1, FOUT starts to
> output unstable clock until lock time passes. PLL1416X/PLL1443XA may
> generate a glitch at FOUT."
>
> So set BYPASS when RESETB is changed from 0 to 1 to avoid glitch.
> In the end of set rate, BYPASS will be cleared.
>
> When prepare clock, also need to take care to avoid glitch. So
> we also follow Spec to set BYPASS before RESETB changed from 0 to 1.
> And add a check if the RESETB is already 0, directly return 0;
>
> Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc")
> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Please make cover letters for multi-patch series.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] clk: imx: pll14xx: Fix quick switch of S/K parameter
From: Stephen Boyd @ 2019-09-06 17:24 UTC (permalink / raw)
To: Leonard Crestez, Peng Fan, Shawn Guo
Cc: Dong Aisheng, Jacky Bai, Michael Turquette, linux-clk, linux-imx,
Viorel Suman, Fabio Estevam, Daniel Baluta, kernel,
linux-arm-kernel, Abel Vesa
In-Reply-To: <c3e86b5a832a14278e8ba670d51defc70ee78d84.1567590349.git.leonard.crestez@nxp.com>
Quoting Leonard Crestez (2019-09-04 02:49:18)
> The PLL14xx on imx8m can change the S and K parameter without requiring
> a reset and relock of the whole PLL.
>
> Fix clk_pll144xx_mp_change register reading and use it for pll1443 as
> well since no reset+relock is required on K changes either.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> drivers/clk/imx/clk-pll14xx.c | 40 +++++++----------------------------
> 1 file changed, 8 insertions(+), 32 deletions(-)
>
> The PLLs are currently table-based and none of the entries differ only
> in S/K so further work would be required to make use of this. The
> prospective user is audio doing tiny freq adjustments and there is no
> standard API for that.
sub-Hz adjustments?
>
> Lacking users is not a good reason to carry broken code around.
Maybe add a Fixes tag so if anyone wants to use it in LTS kernels there
might be a chance that they'll find this patch mention code they're
using.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] clk: spear: Make structure i2s_sclk_masks constant
From: Stephen Boyd @ 2019-09-06 17:27 UTC (permalink / raw)
To: Nishka Dasgupta, linux-arm-kernel, linux-clk, mturquette, vireshk
Cc: Nishka Dasgupta
In-Reply-To: <20190813085714.8079-1-nishkadg.linux@gmail.com>
Quoting Nishka Dasgupta (2019-08-13 01:57:14)
> Static structure i2s_sclk_masks, having type aux_clk_masks, is only used
> when it is passed as the sixth argument to function clk_register_aux().
> However, clk_register_aux() is defined with its sixth argument as const.
> Hence i2s_sclk_masks is not modified by clk_register_aux, which is also
> the only usage of the former. Therefore make i2s_sclk_masks constant as
> it is never modified.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings
From: Stephen Boyd @ 2019-09-06 17:30 UTC (permalink / raw)
To: Jonas Gorski, Julia Lawall
Cc: Florian Fainelli, Michael Turquette, Philippe Mathieu-Daud??,
linux-kernel, bcm-kernel-feedback-list, kbuild-all, linux-clk,
linux-arm-kernel
In-Reply-To: <alpine.DEB.2.21.1908081809160.2995@hadrien>
Quoting Julia Lawall (2019-08-08 09:10:53)
> From: kbuild test robot <lkp@intel.com>
>
> drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together.
>
> Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
>
> Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver")
> CC: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v3 07/17] arm64, hibernate: move page handling function to new trans_pgd.c
From: Pavel Tatashin @ 2019-09-06 17:41 UTC (permalink / raw)
To: James Morse
Cc: Sasha Levin, Mark Rutland, Vladimir Murzin, Jonathan Corbet,
Marc Zyngier, Catalin Marinas, Bhupesh Sharma, kexec mailing list,
LKML, James Morris, linux-mm, Eric W. Biederman, Matthias Brugger,
will, Linux ARM
In-Reply-To: <f1db863a-de57-2d1a-6bec-6020b2130964@arm.com>
On Fri, Sep 6, 2019 at 11:18 AM James Morse <james.morse@arm.com> wrote:
>
> Hi Pavel,
>
> On 21/08/2019 19:31, Pavel Tatashin wrote:
> > Now, that we abstracted the required functions move them to a new home.
> > Later, we will generalize these function in order to be useful outside
> > of hibernation.
>
> > diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c
> > new file mode 100644
> > index 000000000000..00b62d8640c2
> > --- /dev/null
> > +++ b/arch/arm64/mm/trans_pgd.c
> > @@ -0,0 +1,211 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +/*
> > + * Copyright (c) 2019, Microsoft Corporation.
> > + * Pavel Tatashin <patatash@linux.microsoft.com>
>
> Hmmm, while line-count isn't a useful metric: this file contains 41% of the code that was
> in hibernate.c, but has stripped the substantial copyright-pedigree that the hibernate
> code had built up over the years.
> (counting lines identified by 'cloc' as code, not comments or blank)
>
> If you are copying or moving a non trivial quantity of code, you need to preserve the
> copyright. Something like 'Derived from the arm64 hibernate support which has:'....
I will do that. The copyright thing was meant to appear in
"generalization" patch that comes later, where I unified most of the
code to be symmetric.
So, I will add it there, and also do the derived message that you suggested.
>
>
> > + */
> > +
> > +/*
> > + * Transitional tables are used during system transferring from one world to
> > + * another: such as during hibernate restore, and kexec reboots. During these
> > + * phases one cannot rely on page table not being overwritten.
>
> I think you need to mention that hibernate and kexec are rewriting memory, and may
> overwrite the live page tables, therefore ...
Will add, thank you.
Pasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings
From: Bjorn Andersson @ 2019-09-06 18:25 UTC (permalink / raw)
To: Stephen Boyd
Cc: mark.rutland, robh, Jack Pham, devicetree, gregkh, linux-usb,
khasim.mohammed, linux-kernel, kishon, linux-arm-msm, andy.gross,
Jorge Ramirez, shawn.guo, linux-arm-kernel
In-Reply-To: <5d71edf5.1c69fb81.1f307.fdd6@mx.google.com>
On Thu 05 Sep 22:26 PDT 2019, Stephen Boyd wrote:
> Quoting Jack Pham (2019-09-05 10:58:02)
> > Hi Jorge, Bjorn,
> >
> > On Thu, Sep 05, 2019 at 09:18:57AM +0200, Jorge Ramirez wrote:
> > > On 9/4/19 01:34, Bjorn Andersson wrote:
> > > > On Tue 03 Sep 14:45 PDT 2019, Stephen Boyd wrote:
> > > >> that would need an of_regulator_get() sort of API that can get the
> > > >> regulator out of there? Or to make the connector into a struct device
> > > >> that can get the regulator out per some generic connector driver and
> > > >> then pass it through to the USB controller when it asks for it. Maybe
> > > >> try to prototype that out?
> > > >>
> > > >
> > > > The examples given in the DT bindings describes the connector as a child
> > > > of a PMIC, with of_graph somehow tying it to the various inputs. But in
> > > > these examples vbus is handled by implicitly inside the MFD, where
> > > > extcon is informed about the plug event they toggle vbus as well.
> > > >
> > > > In our case we have a extcon-usb-gpio to detect mode, which per Jorge's
> > > > proposal will trickle down to the PHY and become a regulator calls on
> > > > either some external regulator or more typically one of the chargers in
> > > > the system.
> >
> > Interesting you mention extcon-usb-gpio. I thought extcon at least from
> > bindings perspective is passé now. Maybe this is what you need (just
> > landed in usb-next):
> >
> > usb: common: add USB GPIO based connection detection driver
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=4602f3bff2669012c1147eecfe74c121765f5c56
> >
> > dt-bindings: usb: add binding for USB GPIO based connection detection driver
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=f651c73e71f53f65e9846677d79d8e120452b59f
> >
> > Fortunately this new driver might check the right boxes for you:
> > - usb connector binding
> > - ID detect GPIO
> > - vbus-supply regulator
> >
> > With that, I think you can also keep the connector subnode out of the
> > SSPHY node well, and similarly get rid of the vbus toggle handling from
> > the PHY driver.
> >
> > The big thing missing now is that this driver replaces extcon
> > completely, so we'll need handling in dwc3/dwc3-qcom to retrieve the
> > role switch state to know when host mode is entered. I saw this a while
> > back but don't think it got picked up:
> >
> > https://patchwork.kernel.org/patch/10909981/
> >
>
> Yes this looks like the approach that should be taken. One question
> though, is this a micro-b connector or a type-c connector on the board?
> I thought it was a type-c, so then this USB gpio based connection driver
> isn't an exact fit?
>
For this particular case it's a type c connector, but the port
controller is operated completely passively (and there's no PD or DP
involved), so the GPIO based approach seems like a good fit.
Regards,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* [PATCH 0/9] crypto: add sun8i-ce driver for Allwinner crypto engine
From: Corentin Labbe @ 2019-09-06 18:45 UTC (permalink / raw)
To: davem, herbert, linux, mark.rutland, mripard, robh+dt, wens
Cc: devicetree, linux-kernel, linux-sunxi, Corentin Labbe,
linux-crypto, linux-arm-kernel
Hello
This patch serie adds support for the Allwinner crypto engine.
The Crypto Engine is the third generation of Allwinner cryptogaphic offloader.
The first generation is the Security System already handled by the
sun4i-ss driver.
The second is named also Security System and is present on A80 and A83T
SoCs, originaly this driver supported it also, but supporting both IP bringing
too much complexity and another driver (sun8i-ss) will came for it.
For the moment, the driver support only DES3/AES in ECB/CBC mode.
Patchs for CTR/CTS/XTS and RNGs will came later.
Regards
Corentin Labbe (9):
crypto: Add allwinner subdirectory
crypto: Add Allwinner sun8i-ce Crypto Engine
dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto
Engine
ARM: dts: sun8i: r40: add crypto engine node
ARM: dts: sun8i: h3: Add Crypto Engine node
ARM64: dts: allwinner: sun50i: Add Crypto Engine node on A64
ARM64: dts: allwinner: sun50i: Add crypto engine node on H5
ARM64: dts: allwinner: sun50i: Add Crypto Engine node on H6
sunxi_defconfig: add new crypto options
.../bindings/crypto/allwinner,sun8i-ce.yaml | 84 +++
MAINTAINERS | 6 +
arch/arm/boot/dts/sun8i-h3.dtsi | 11 +
arch/arm/boot/dts/sun8i-r40.dtsi | 11 +
arch/arm/configs/sunxi_defconfig | 2 +
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 11 +
arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 11 +
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 +
drivers/crypto/Kconfig | 2 +
drivers/crypto/Makefile | 1 +
drivers/crypto/allwinner/Kconfig | 32 +
drivers/crypto/allwinner/Makefile | 1 +
drivers/crypto/allwinner/sun8i-ce/Makefile | 2 +
.../allwinner/sun8i-ce/sun8i-ce-cipher.c | 390 +++++++++++
.../crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 630 ++++++++++++++++++
drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 256 +++++++
16 files changed, 1460 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml
create mode 100644 drivers/crypto/allwinner/Kconfig
create mode 100644 drivers/crypto/allwinner/Makefile
create mode 100644 drivers/crypto/allwinner/sun8i-ce/Makefile
create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* [PATCH 1/9] crypto: Add allwinner subdirectory
From: Corentin Labbe @ 2019-09-06 18:45 UTC (permalink / raw)
To: davem, herbert, linux, mark.rutland, mripard, robh+dt, wens
Cc: devicetree, linux-kernel, linux-sunxi, Corentin Labbe,
linux-crypto, linux-arm-kernel
In-Reply-To: <20190906184551.17858-1-clabbe.montjoie@gmail.com>
Since a second Allwinner crypto driver will be added, it is better to
create a dedicated subdirectory.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
MAINTAINERS | 6 ++++++
drivers/crypto/Kconfig | 2 ++
drivers/crypto/Makefile | 1 +
drivers/crypto/allwinner/Kconfig | 6 ++++++
4 files changed, 15 insertions(+)
create mode 100644 drivers/crypto/allwinner/Kconfig
diff --git a/MAINTAINERS b/MAINTAINERS
index ee4e873c0f9a..d62ddf8ff262 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -681,6 +681,12 @@ L: linux-crypto@vger.kernel.org
S: Maintained
F: drivers/crypto/sunxi-ss/
+ALLWINNER CRYPTO ENGINE
+M: Corentin Labbe <clabbe.montjoie@gmail.com>
+L: linux-crypto@vger.kernel.org
+S: Maintained
+F: drivers/crypto/allwinner/
+
ALLWINNER VPU DRIVER
M: Maxime Ripard <mripard@kernel.org>
M: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 83271d944a96..fe90dd74797c 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -11,6 +11,8 @@ menuconfig CRYPTO_HW
if CRYPTO_HW
+source "drivers/crypto/allwinner/Kconfig"
+
config CRYPTO_DEV_PADLOCK
tristate "Support for VIA PadLock ACE"
depends on X86 && !UML
diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
index afc4753b5d28..90d60eff5ecc 100644
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -1,4 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_CRYPTO_DEV_ALLWINNER) += allwinner/
obj-$(CONFIG_CRYPTO_DEV_ATMEL_AES) += atmel-aes.o
obj-$(CONFIG_CRYPTO_DEV_ATMEL_SHA) += atmel-sha.o
obj-$(CONFIG_CRYPTO_DEV_ATMEL_TDES) += atmel-tdes.o
diff --git a/drivers/crypto/allwinner/Kconfig b/drivers/crypto/allwinner/Kconfig
new file mode 100644
index 000000000000..0c8a99f7959d
--- /dev/null
+++ b/drivers/crypto/allwinner/Kconfig
@@ -0,0 +1,6 @@
+config CRYPTO_DEV_ALLWINNER
+ bool "Support for Allwinner cryptographic offloader"
+ depends on ARCH_SUNXI || COMPILE_TEST
+ default y if ARCH_SUNXI
+ help
+ Say Y here to get to see options for Allwinner hardware crypto devices
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox